On July 30, 2014, 3:34 p.m., Mark Michelson wrote:
trunk/channels/chan_sip.c, lines 30492-30498
https://reviewboard.asterisk.org/r/3867/diff/1/?file=65719#file65719line30492
Use ast_rtp_dtls_cfg_copy() here. The current change has two problems:
1) Many of the default
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3807/
---
(Updated July 31, 2014, 6:49 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3810/
---
(Updated July 31, 2014, 6:58 a.m.)
Status
--
This change has been
On July 30, 2014, 10:31 a.m., opticron wrote:
/branches/12/include/asterisk/manager.h, lines 97-106
https://reviewboard.asterisk.org/r/3726/diff/2/?file=65028#file65028line97
Unrelated change?
Kind of, but not really. The unit tests make heavy use of the manager hook
callback in
On July 30, 2014, 10:31 a.m., opticron wrote:
/branches/12/rest-api/api-docs/endpoints.json, line 23
https://reviewboard.asterisk.org/r/3726/diff/2/?file=65043#file65043line23
Doesn't this conflict with /endpoints/{tech} and
/endpoints/{tech}/{resource} below? There are currently
On June 27, 2014, 2:42 p.m., Matt Jordan wrote:
trunk/channels/chan_sip.c, line 2755
https://reviewboard.asterisk.org/r/3653/diff/2/?file=59976#file59976line2755
So, I had to go back and do some research to see if this solution was
correct - and I think it is a step in the right
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3866/#review12936
---
Ship it!
Ship It!
- Scott Griepentrog
On July 29, 2014,
To the community at large, a security vulnerability has been discovered
in Asterisk. Bug marshals and others with commit access are invited to
visit the JIRA issue [1] to provide feedback. Keep in mind that this
issue is not visible to the general community due to its sensitivity.
Thank you,
On June 27, 2014, 9:42 a.m., Matt Jordan wrote:
trunk/channels/chan_sip.c, line 2755
https://reviewboard.asterisk.org/r/3653/diff/2/?file=59976#file59976line2755
So, I had to go back and do some research to see if this solution was
correct - and I think it is a step in the right
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3780/
---
(Updated July 31, 2014, 3:28 p.m.)
Review request for Asterisk
On June 27, 2014, 2:42 p.m., Matt Jordan wrote:
trunk/channels/chan_sip.c, line 2755
https://reviewboard.asterisk.org/r/3653/diff/2/?file=59976#file59976line2755
So, I had to go back and do some research to see if this solution was
correct - and I think it is a step in the right
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3825/
---
(Updated July 31, 2014, 11:21 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3817/
---
(Updated July 31, 2014, 11:19 a.m.)
Status
--
This change has been
On June 27, 2014, 9:42 a.m., Matt Jordan wrote:
trunk/channels/chan_sip.c, line 2755
https://reviewboard.asterisk.org/r/3653/diff/2/?file=59976#file59976line2755
So, I had to go back and do some research to see if this solution was
correct - and I think it is a step in the right
On June 27, 2014, 10:42 a.m., Matt Jordan wrote:
trunk/channels/chan_sip.c, line 2755
https://reviewboard.asterisk.org/r/3653/diff/2/?file=59976#file59976line2755
So, I had to go back and do some research to see if this solution was
correct - and I think it is a step in the right
On June 27, 2014, 9:42 a.m., Matt Jordan wrote:
trunk/channels/chan_sip.c, line 2755
https://reviewboard.asterisk.org/r/3653/diff/2/?file=59976#file59976line2755
So, I had to go back and do some research to see if this solution was
correct - and I think it is a step in the right
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3881/
---
Review request for Asterisk Developers and Mark Michelson.
Bugs:
On June 27, 2014, 10:42 a.m., Matt Jordan wrote:
trunk/channels/chan_sip.c, line 2755
https://reviewboard.asterisk.org/r/3653/diff/2/?file=59976#file59976line2755
So, I had to go back and do some research to see if this solution was
correct - and I think it is a step in the right
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3883/
---
Review request for Asterisk Developers and Mark Michelson.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3882/
---
(Updated July 31, 2014, 2:14 p.m.)
Review request for Asterisk Developers
On July 31, 2014, 2:11 p.m., rmudgett wrote:
You need to add asterisk-dev to the Groups header for people to see the
review.
You need to use the full issue name ASTERISK-18345 in the Bugs header.
Thanks!
- ebroad
---
This is an
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3843/
---
(Updated July 31, 2014, 1:19 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3874/
---
(Updated July 31, 2014, 1:24 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3874/#review12946
---
Ship it!
Ship It!
- Matt Jordan
On July 30, 2014, 2:47
On July 30, 2014, 10:31 a.m., opticron wrote:
/branches/12/main/message.c, lines 883-884
https://reviewboard.asterisk.org/r/3726/diff/2/?file=65032#file65032line883
This can be changed to ao2_bump for clarity. It may actually need to be
ao2_replace depending on whether the value
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3862/
---
(Updated July 31, 2014, 3:25 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3884/
---
Review request for Asterisk Developers.
Repository: testsuite
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3884/#review12950
---
/asterisk/trunk/lib/python/asterisk/sipp.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3726/
---
(Updated July 31, 2014, 2:01 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3884/
---
(Updated July 31, 2014, 2:41 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3797/#review12948
---
Ship it!
Go ahead and commit this as the code looks good to
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3884/#review12951
---
Ship it!
Ship It!
- Corey Farrell
On July 31, 2014, 3:41
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3726/#review12949
---
Ship it!
Minor nitpicks below.
/branches/12/main/message.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3885/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-24107
On July 17, 2014, 4:41 p.m., Matt Jordan wrote:
/trunk/main/stasis_channels.c, lines 1071-1077
https://reviewboard.asterisk.org/r/3811/diff/1/?file=64565#file64565line1071
I'm not sure why these changes (removal of the .to_ami callback) were
necessary.
Generally, I
On July 17, 2014, 5:41 p.m., Matt Jordan wrote:
/trunk/main/stasis_channels.c, lines 1071-1077
https://reviewboard.asterisk.org/r/3811/diff/1/?file=64565#file64565line1071
I'm not sure why these changes (removal of the .to_ami callback) were
necessary.
Generally, I
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3887/
---
Review request for Asterisk Developers and Matt Jordan.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3887/
---
(Updated July 31, 2014, 9:45 p.m.)
Status
--
This change has been
38 matches
Mail list logo
