Re: [asterisk-dev] [Code Review] 3917: ARI: /channels/continue doesn't work on a channel originated to a Stasis application with no PBX

2014-08-18 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3917/#review13095 --- /branches/12/res/res_stasis.c

Re: [asterisk-dev] [Code Review] 3856: Fix Dynamic IAX2 Registrations From Failing Or Not Retrying After Temporary DNS Failure

2014-08-18 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3856/#review13096 --- Ship it! Ship It! /branches/11/channels/chan_iax2.c

Re: [asterisk-dev] [Code Review] 3893: fromdomainport used even if not set

2014-08-18 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3893/#review13097 --- Ship it! This applies to 1.8+ - Joshua Colp On Aug. 7,

Re: [asterisk-dev] [Code Review] 3907: ARI: Fix implicit answer of channel when playback is initiated on unanswered channels

2014-08-18 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3907/#review13098 --- Ship it! Ship It! - Joshua Colp On Aug. 13, 2014, 10:04

Re: [asterisk-dev] [Code Review] 3917: ARI: /channels/continue doesn't work on a channel originated to a Stasis application with no PBX

2014-08-18 Thread Jonathan Rose
On Aug. 18, 2014, 9:24 a.m., Joshua Colp wrote: /branches/12/res/res_stasis.c, lines 1330-1333 https://reviewboard.asterisk.org/r/3917/diff/1/?file=66549#file66549line1330 Add a comment explaining why this is being done. Honestly, I don't believe this is necessary and as far as I

Re: [asterisk-dev] [Code Review] 3917: ARI: /channels/continue doesn't work on a channel originated to a Stasis application with no PBX

2014-08-18 Thread Joshua Colp
On Aug. 18, 2014, 2:24 p.m., Joshua Colp wrote: /branches/12/res/res_stasis.c, lines 1330-1333 https://reviewboard.asterisk.org/r/3917/diff/1/?file=66549#file66549line1330 Add a comment explaining why this is being done. Jonathan Rose wrote: Honestly, I don't believe this is

Re: [asterisk-dev] [Code Review] 3917: ARI: /channels/continue doesn't work on a channel originated to a Stasis application with no PBX

2014-08-18 Thread Jonathan Rose
On Aug. 18, 2014, 9:24 a.m., Joshua Colp wrote: /branches/12/res/res_stasis.c, lines 1330-1333 https://reviewboard.asterisk.org/r/3917/diff/1/?file=66549#file66549line1330 Add a comment explaining why this is being done. Jonathan Rose wrote: Honestly, I don't believe this is

Re: [asterisk-dev] [Code Review] 3917: ARI: /channels/continue doesn't work on a channel originated to a Stasis application with no PBX

2014-08-18 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3917/ --- (Updated Aug. 18, 2014, 10:27 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3917: ARI: /channels/continue doesn't work on a channel originated to a Stasis application with no PBX

2014-08-18 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3917/#review13102 --- Ship it! Ship It! /branches/12/res/res_stasis.c

[asterisk-dev] [Code Review] 3919: func_config: Change 'Not Found' message from ERROR to DEBUG

2014-08-18 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3919/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3908: ARI: Fix bug where hanging up while in a bridge during playback causes a crash

2014-08-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3908/#review13103 --- /branches/12/res/res_stasis.c

Re: [asterisk-dev] [Code Review] 3913: chan_pjsip: Attended transfer does not update connected line name.

2014-08-18 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3913/#review13104 --- Ship it! Ship It! - Joshua Colp On Aug. 15, 2014, 1:55

Re: [asterisk-dev] [Code Review] 3919: func_config: Change 'Not Found' message from ERROR to DEBUG

2014-08-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3919/#review13105 --- Should be done for v1.8+. That message is kind of over

[asterisk-dev] [Code Review] 3920: Fix after bridge behavior when channel moves from a Stasis bridge to a non-Stasis bridge

2014-08-18 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3920/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3920: Fix after bridge behavior when channel moves from a Stasis bridge to a non-Stasis bridge

2014-08-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3920/#review13106 --- /branches/13/res/stasis/control.c

Re: [asterisk-dev] [Code Review] 3919: func_config: Change 'Not Found' message from ERROR to DEBUG

2014-08-18 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3919/ --- (Updated Aug. 18, 2014, 12:47 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 3921: Stasis: Add missing information to blind transfer events

2014-08-18 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3921/ --- Review request for Asterisk Developers, Matt Jordan and Mark Michelson.

[asterisk-dev] [Code Review] 3922: Testsuite: Update ARI blind transfer test for new information

2014-08-18 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3922/ --- Review request for Asterisk Developers and Mark Michelson. Repository:

Re: [asterisk-dev] [Code Review] 3919: func_config: Change 'Not Found' message from ERROR to DEBUG

2014-08-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3919/#review13107 --- Ship it! Ship It! - rmudgett On Aug. 18, 2014, 1:47 p.m.,

Re: [asterisk-dev] [Code Review] 3921: Stasis: Add missing information to blind transfer events

2014-08-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3921/#review13108 --- branches/12/main/bridge.c

Re: [asterisk-dev] [Code Review] 3919: func_config: Change 'Not Found' message from ERROR to DEBUG

2014-08-18 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3919/ --- (Updated Aug. 18, 2014, 3:14 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3915: AMI: Add AllVariables parameter to Status

2014-08-18 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3915/#review13109 --- trunk/main/manager.c

Re: [asterisk-dev] [Code Review] 3920: Fix after bridge behavior when channel moves from a Stasis bridge to a non-Stasis bridge

2014-08-18 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3920/#review13110 --- {quote} To be honest, I'm not a huge fan of this patch, but it

[asterisk-dev] [Code Review] 3923: CallerID: Fix parsing of malformed callerid strings

2014-08-18 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3923/ --- Review request for Asterisk Developers. Repository: Asterisk