[asterisk-dev] Does asterisk video frame contains video data only or there is RTP headers too ?

2014-08-25 Thread Shishir Pokharel
Hi list, I am developing an application to convert different video format to H.264 and transport it via RTMP protocol to FMS server. I am bit confused about asterisk Video Frame , my confusion is does the Video frame has the RTP headers on it or the just the video data? Going through the

Re: [asterisk-dev] [Code Review] 3931: runtests.py: -d (--dry-run)

2014-08-25 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3931/#review13162 --- /asterisk/trunk/runtests.py

Re: [asterisk-dev] [Code Review] 3931: runtests.py: -d (--dry-run)

2014-08-25 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3931/#review13163 --- /asterisk/trunk/runtests.py

Re: [asterisk-dev] Does asterisk video frame contains video data only or there is RTP headers too ?

2014-08-25 Thread Russell Bryant
On Mon, Aug 25, 2014 at 3:20 AM, Shishir Pokharel shishir.pokha...@on24.com wrote: Hi list, I am developing an application to convert different video format to H.264 and transport it via RTMP protocol to FMS server. I am bit confused about asterisk Video Frame , my confusion is does the

Re: [asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-08-25 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3930/#review13164 --- Review your doxygen because I think you are repeating

Re: [asterisk-dev] [Code Review] 3873: Testsuite: RLS tests - nominal presence lists

2014-08-25 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3873/#review13165 --- Ship it! Ship It! - opticron On Aug. 21, 2014, 1:38 p.m.,

Re: [asterisk-dev] [Code Review] 3923: CallerID: Fix parsing of malformed callerid strings

2014-08-25 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3923/ --- (Updated Aug. 25, 2014, 8:52 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-08-25 Thread Mark Michelson
On Aug. 25, 2014, 1:12 p.m., Joshua Colp wrote: Review your doxygen because I think you are repeating yourself, and also run through all the PJSIP tests. Do that and this is good to go. I don't see the doxygen problem. One states that on transaction state changes, it is called before SDP

Re: [asterisk-dev] [Code Review] 3930: PJSIP: Resolve race condition regarding media handling when receiving 200 OK

2014-08-25 Thread Joshua Colp
On Aug. 25, 2014, 1:12 p.m., Joshua Colp wrote: Review your doxygen because I think you are repeating yourself, and also run through all the PJSIP tests. Do that and this is good to go. Mark Michelson wrote: I don't see the doxygen problem. One states that on transaction state

Re: [asterisk-dev] [Code Review] 3928: res_musiconhold: Fix MOH restarting where it left off from the last hold.

2014-08-25 Thread rmudgett
On Aug. 24, 2014, 11:20 a.m., wdoekes wrote: /branches/1.8/res/res_musiconhold.c, line 421 https://reviewboard.asterisk.org/r/3928/diff/1/?file=66739#file66739line421 Something like this? /* If the class has the same name and amount of files, continue where we left

Re: [asterisk-dev] [Code Review] 3928: res_musiconhold: Fix MOH restarting where it left off from the last hold.

2014-08-25 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3928/ --- (Updated Aug. 25, 2014, 4 p.m.) Status -- This change has been

Re: [asterisk-dev] Does asterisk video frame contains video data only or there is RTP headers too ?

2014-08-25 Thread Shishir Pokharel
Thanks Russell. From: asterisk-dev-boun...@lists.digium.com [mailto:asterisk-dev-boun...@lists.digium.com] On Behalf Of Russell Bryant Sent: Monday, August 25, 2014 4:55 AM To: Asterisk Developers Mailing List Subject: Re: [asterisk-dev] Does asterisk video frame contains video data only or

Re: [asterisk-dev] [Code Review] 3931: runtests.py: -d (--dry-run)

2014-08-25 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3931/#review13170 --- How is this different than the -l option? - Matt Jordan On

[asterisk-dev] [Code Review] 3933: CallerID: Fix parsing of malformed callerid strings - Asterisk 12+

2014-08-25 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3933/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3929: ARI: Holding bridge issues with bridge Music on Hold, playback operations, and default channel roles

2014-08-25 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3929/#review13171 --- /branches/12/res/ari/resource_bridges.c

Re: [asterisk-dev] [Code Review] 3923: CallerID: Fix parsing of malformed callerid strings

2014-08-25 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3923/#review13173 --- branches/1.8/tests/test_callerid.c

Re: [asterisk-dev] [Code Review] 3923: CallerID: Fix parsing of malformed callerid strings

2014-08-25 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3923/ --- (Updated Aug. 25, 2014, 3:50 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3933: CallerID: Fix parsing of malformed callerid strings - Asterisk 12+

2014-08-25 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3933/ --- (Updated Aug. 25, 2014, 3:52 p.m.) Review request for Asterisk

Re: [asterisk-dev] Increasing DAHDI_CHUNKSIZE, what consequences?

2014-08-25 Thread Thomas Petazzoni
Hello all, Any suggestion about the below questions? Thanks, Thomas On Thu, 7 Aug 2014 09:57:33 +0200, Thomas Petazzoni wrote: Hello, I am currently writing a driver for the XHFC ISDN chip from Cologne Chip, which is interfaced over SPI with an ARM processor (i.e it's not the typical PCI

Re: [asterisk-dev] [Code Review] 3923: CallerID: Fix parsing of malformed callerid strings

2014-08-25 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3923/#review13174 --- branches/1.8/main/callerid.c

[asterisk-dev] [Code Review] 3944: app_confbridge: Add 'all' to channel target for mute and unmute.

2014-08-25 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3944/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3931: runtests.py: -d (--dry-run)

2014-08-25 Thread George Joseph
On Aug. 25, 2014, 11:53 a.m., Matt Jordan wrote: How is this different than the -l option? Just to chip in... The -l option lists everything even though the test might not actually get run because of some constraint. I use something like the proposed dry-run so I can know how many tests

[asterisk-dev] [Code Review] 3948: Asterisk does not respect outbound proxy when sending qualify requests

2014-08-25 Thread Damian Ivereigh
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3948/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24063

Re: [asterisk-dev] [Code Review] 3944: app_confbridge: Add 'all' to channel target for mute and unmute.

2014-08-25 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3944/#review13176 --- I don't think a mute/unmute all feature was intended when the

Re: [asterisk-dev] [Code Review] 3944: app_confbridge: Add 'all' to channel target for mute and unmute.

2014-08-25 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3944/ --- (Updated Aug. 25, 2014, 5:53 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3923: CallerID: Fix parsing of malformed callerid strings

2014-08-25 Thread opticron
On Aug. 25, 2014, 4:42 p.m., rmudgett wrote: branches/1.8/main/callerid.c, line 1013 https://reviewboard.asterisk.org/r/3923/diff/3/?file=66780#file66780line1013 Where did the requirement to allow a missing come from? The previous code required the to match. The prevous code

Re: [asterisk-dev] [Code Review] 3923: CallerID: Fix parsing of malformed callerid strings

2014-08-25 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3923/ --- (Updated Aug. 25, 2014, 8:08 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3933: CallerID: Fix parsing of malformed callerid strings - Asterisk 12+

2014-08-25 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3933/ --- (Updated Aug. 25, 2014, 8:59 p.m.) Review request for Asterisk