Ashley Sanders has posted comments on this change.
Change subject: rest_api/applications/stasisstatus: Make run-test executable
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/36
To unsubscribe,
Hello Mark Michelson, Matt Jordan,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/18
to look at the new patch set (#6).
Change subject: stasis: set a channel variable on websocket disconnect error
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 5:
(6 comments)
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 5:
(1 comment)
Gerrit ate this response in my previous draft. :/
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 6:
(1 comment)
Just one more finding.
Hello Mark Michelson, Matt Jordan,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/18
to look at the new patch set (#7).
Change subject: stasis: set a channel variable on websocket disconnect error
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 7:
(1 comment)
Done =)
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 5:
(3 comments)
Found more draft comments that gerrit obscured from me earlier =)
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 7:
(1 comment)
Ooops. I forgot to remove the chan_sip dependency from the
Hello Mark Michelson, Matt Jordan,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/18
to look at the new patch set (#8).
Change subject: stasis: set a channel variable on websocket disconnect error
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 6:
(1 comment)
Ashley Sanders has posted comments on this change.
Change subject: Enable support for directory containing custom tests.
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/27
To unsubscribe, visit
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 8:
(2 comments)
Addressed both of Matt Jordan's review feedback comments.
Hello Mark Michelson, Matt Jordan,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/18
to look at the new patch set (#10).
Change subject: stasis: set a channel variable on websocket disconnect error
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 9:
(1 comment)
Found one more tiny issue with the docstrings.
Hello Mark Michelson, Matt Jordan,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/18
to look at the new patch set (#9).
Change subject: stasis: set a channel variable on websocket disconnect error
Ashley Sanders has posted comments on this change.
Change subject: sip_attended_transfer now supports pre-12 Asterisk versions.
..
Patch Set 3: Code-Review+1
(2 comments)
Hello Mark Michelson,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/18
to look at the new patch set (#3).
Change subject: stasis: set a channel variable on websocket disconnect error
..
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 2:
(5 comments)
Addressed Matt Jordan's review feedback.
Hello Mark Michelson,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/18
to look at the new patch set (#5).
Change subject: stasis: set a channel variable on websocket disconnect error
..
Hello Mark Michelson,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/18
to look at the new patch set (#4).
Change subject: stasis: set a channel variable on websocket disconnect error
..
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 5:
(1 comment)
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 2:
(5 comments)
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 1:
(1 comment)
Addressed Mark Michelson's suggestion for refactoring the
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 5:
(5 comments)
I found some more minor issues with the review.
Ashley Sanders has posted comments on this change.
Change subject: Testsuite: New test for FAX via PJSIP T38 with authentication
..
Patch Set 3:
(4 comments)
I just found a few minor issues regarding docstrings, but
Ashley Sanders has posted comments on this change.
Change subject: sip_attended_transfer now supports pre-12 Asterisk versions.
..
Patch Set 2:
(4 comments)
A vast improvement over the previous approach. I think this version
Ashley Sanders has posted comments on this change.
Change subject: Testsuite: New test for FAX via PJSIP T38 with authentication
..
Patch Set 4: Code-Review+1
Looks good.
--
To view, visit https://gerrit.asterisk.org/28
To
Ashley Sanders has posted comments on this change.
Change subject: non_stasis_bridge_to_stasis_bridge: Update regex for ami events
..
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/25
To unsubscribe,
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 2:
(1 comment)
Ashley Sanders has posted comments on this change.
Change subject: Memory Debugging Improvements
..
Patch Set 4: Code-Review+1
From what I can tell, everything looks good to me.
--
To view, visit
Ashley Sanders has posted comments on this change.
Change subject: non_stasis_bridge_to_stasis_bridge: Update regex for ami events
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/25
To unsubscribe,
Ashley Sanders has posted comments on this change.
Change subject: Add a test for PJSIP t38 with authentication based on normal
t38 test
..
Patch Set 1: Code-Review-1
(5 comments)
Very close. I think just fix the pylint
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 1:
(3 comments)
Hello Mark Michelson,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/18
to look at the new patch set (#2).
Change subject: stasis: set a channel variable on websocket disconnect error
..
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 1:
(5 comments)
Ashley Sanders has posted comments on this change.
Change subject: Rewrite sip_attended_transfer test to stop failing.
..
Patch Set 2:
(1 comment)
Ashley Sanders has posted comments on this change.
Change subject: Rewrite sip_attended_transfer test to stop failing.
..
Patch Set 3: Code-Review+1
(2 comments)
Very nice!!! Thanks for taking my (more reasonable) suggestions
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 1:
(6 comments)
Responses to most of the review feedback from Mark Michelson.
Ashley Sanders has posted comments on this change.
Change subject: Rewrite sip_attended_transfer test to stop failing.
..
Patch Set 2: Code-Review-1
(6 comments)
Overall, this is pretty good. The flow was mostly easy to
Ashley Sanders has posted comments on this change.
Change subject: Add SIP attended transfer for Asterisk 11.
..
Patch Set 1: Code-Review-1
(1 comment)
I think that most of this could be collapsed into the logic for the test
Ashley Sanders has posted comments on this change.
Change subject: Memory Debugging Improvements
..
Patch Set 3:
Would it be possible for you to post a sample output file?
--
To view, visit https://gerrit.asterisk.org/15
To
Ashley Sanders has posted comments on this change.
Change subject: Memory Debugging Improvements
..
Patch Set 3: Code-Review-1
(1 comment)
I only have one finding - a misspelling.
Ashley Sanders has uploaded a new change for review.
https://gerrit.asterisk.org/18
Change subject: stasis: set a channel variable on websocket disconnect error
..
stasis: set a channel variable on websocket disconnect error
44 matches
Mail list logo
