---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4379/
---
(Updated Feb. 25, 2015, 5:48 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4379/#review14524
---
Ship it!
Ship It!
- Matt Jordan
On Feb. 24, 2015, 7:20
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4379/#review14526
---
Ship it!
Ship It!
- Joshua Colp
On Feb. 24, 2015, 1:20
On Feb. 20, 2015, 2:37 p.m., Matt Jordan wrote:
/branches/13/configs/examples/awesome/extensions.conf, lines 29-31
https://reviewboard.asterisk.org/r/4379/diff/2/?file=71364#file71364line29
Is this comment correct still with this pattern match?
Nope. Fixed. I also adjusted the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4379/
---
(Updated Feb. 24, 2015, 1:20 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4379/#review14511
---
/branches/13/configs/examples/awesome/extensions.conf
On Feb. 16, 2015, 10:59 p.m., Matt Jordan wrote:
/branches/13/configs/examples/awesome/logger.conf, line 5
https://reviewboard.asterisk.org/r/4379/diff/2/?file=71366#file71366line5
Go with least to greatest:
console = verbose,notice,warning,error
That works.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4379/#review14484
---
/branches/13/configs/examples/awesome/extensions.conf
On Feb. 16, 2015, 10:59 p.m., Matt Jordan wrote:
/branches/13/configs/examples/awesome/asterisk.conf, line 1
https://reviewboard.asterisk.org/r/4379/diff/2/?file=71363#file71363line1
This isn't a template
Yup. Oddly it is this way in the asterisk.conf.sample as well, and I'm not
On Feb. 16, 2015, 4:59 p.m., Matt Jordan wrote:
/branches/13/configs/examples/awesome/asterisk.conf, line 1
https://reviewboard.asterisk.org/r/4379/diff/2/?file=71363#file71363line1
This isn't a template
rnewton wrote:
Yup. Oddly it is this way in the asterisk.conf.sample as
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4379/#review14470
---
/branches/13/configs/examples/awesome/asterisk.conf
On Jan. 29, 2015, 10:23 p.m., Mark Michelson wrote:
/branches/13/configs/examples/super_awesome_company/pjsip.conf, line 41
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71114#file71114line41
I'm curious why you elected to use MAC addresses as the endpoint names.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4379/
---
(Updated Feb. 13, 2015, 12:46 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4379/#review14456
---
/branches/13/configs/examples/awesome/extensions.conf
On Jan. 27, 2015, 2:34 p.m., Matt Jordan wrote:
/branches/13/configs/examples/super_awesome_company/extensions.conf, line 42
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71109#file71109line42
I know '=' is the same as '=', but I (for some reason) still prefer
'=' in
On Jan. 27, 2015, 2:34 p.m., Matt Jordan wrote:
/branches/13/configs/examples/super_awesome_company/extensions.conf, line 42
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71109#file71109line42
I know '=' is the same as '=', but I (for some reason) still prefer
'=' in
On Jan. 29, 2015, 4:23 p.m., Mark Michelson wrote:
/branches/13/configs/examples/super_awesome_company/pjsip.conf, line 41
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71114#file71114line41
I'm curious why you elected to use MAC addresses as the endpoint names.
On Jan. 27, 2015, 1:34 p.m., Matt Jordan wrote:
/branches/13/configs/examples/super_awesome_company/extensions.conf, line 42
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71109#file71109line42
I know '=' is the same as '=', but I (for some reason) still prefer
'=' in
On Jan. 27, 2015, 8:34 p.m., Matt Jordan wrote:
/branches/13/configs/examples/super_awesome_company/extensions.conf, line 42
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71109#file71109line42
I know '=' is the same as '=', but I (for some reason) still prefer
'=' in
On Jan. 30, 2015, 7:51 p.m., Paul Belanger wrote:
/branches/13/configs/examples/super_awesome_company/extensions.conf, line 78
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71109#file71109line78
I prefer putting include statements at the top of the context.
On Fri, 6 Feb 2015, rnewton wrote:
I used MAC addresses as that is what we use as an example in our
security best practices document:
http://svnview.digium.com/svn/asterisk/trunk/README-SERIOUSLY.bestpractices.txt?view=markup
Perhaps this is a moot point. SAC's Asterisk system is behind NAT
On Fri, 30 Jan 2015, Paul Belanger wrote:
I'd also prefer to see the first time always a naked NoOp()
exten = 8000,1,NoOp()
same = n,Verbose(1, blah)
What value does noop() add?
I start my contexts with
exten = s,1,
verbose(1,[${EXTEN}@${CONTEXT}!application
On Jan. 30, 2015, 7:51 p.m., Paul Belanger wrote:
/branches/13/configs/examples/super_awesome_company/indications.conf, line 1
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71110#file71110line1
Again, this file seem to be the default. I'd rather see a symlink.
rnewton
On Jan. 27, 2015, 1:34 p.m., Matt Jordan wrote:
/branches/13/configs/examples/super_awesome_company/extensions.conf, line 42
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71109#file71109line42
I know '=' is the same as '=', but I (for some reason) still prefer
'=' in
On Jan. 29, 2015, 10:23 p.m., Mark Michelson wrote:
/branches/13/configs/examples/super_awesome_company/pjsip.conf, line 41
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71114#file71114line41
I'm curious why you elected to use MAC addresses as the endpoint names.
On Jan. 27, 2015, 8:34 p.m., Matt Jordan wrote:
/branches/13/configs/examples/super_awesome_company/pjsip.conf, lines 24-30
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71114#file71114line24
I'd rename these to:
auth-basic
aor-basic
On Jan. 30, 2015, 1:13 p.m., Joshua Colp wrote:
/branches/13/configs/examples/super_awesome_company/modules.conf, line 41
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71112#file71112line41
Add format_pcm. This covers ulaw and g722 as well. On installation it's
wise to
On Jan. 30, 2015, 7:51 p.m., Paul Belanger wrote:
/branches/13/configs/examples/super_awesome_company/README, line 2
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71107#file71107line2
maybe shorten directory name to awesome, or sae?
Or, another option would be to
On Jan. 27, 2015, 8:34 p.m., Matt Jordan wrote:
/branches/13/configs/examples/super_awesome_company/extensions.conf, line 42
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71109#file71109line42
I know '=' is the same as '=', but I (for some reason) still prefer
'=' in
On Jan. 29, 2015, 10:23 p.m., Mark Michelson wrote:
/branches/13/configs/examples/super_awesome_company/pjsip.conf, line 41
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71114#file71114line41
I'm curious why you elected to use MAC addresses as the endpoint names.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4379/#review14401
---
In general I like what you are doing. Some concerns on how
On Jan. 29, 2015, 10:23 p.m., Mark Michelson wrote:
/branches/13/configs/examples/super_awesome_company/pjsip.conf, line 41
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71114#file71114line41
I'm curious why you elected to use MAC addresses as the endpoint names.
On Jan. 27, 2015, 8:34 p.m., Matt Jordan wrote:
/branches/13/configs/examples/super_awesome_company/extensions.conf, line 42
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71109#file71109line42
I know '=' is the same as '=', but I (for some reason) still prefer
'=' in
On Jan. 29, 2015, 10:29 p.m., Mark Michelson wrote:
/branches/13/configs/examples/super_awesome_company/extensions.conf, lines
72-75
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71109#file71109line72
Heh, I have one more comment and it's a real nitpicky thing.
On Jan. 29, 2015, 10:23 p.m., Mark Michelson wrote:
/branches/13/configs/examples/super_awesome_company/pjsip.conf, line 41
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71114#file71114line41
I'm curious why you elected to use MAC addresses as the endpoint names.
On Jan. 29, 2015, 10:29 p.m., Mark Michelson wrote:
/branches/13/configs/examples/super_awesome_company/extensions.conf, lines
72-75
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71109#file71109line72
Heh, I have one more comment and it's a real nitpicky thing.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4379/#review14391
---
On Jan. 27, 2015, 8:34 p.m., Matt Jordan wrote:
/branches/13/configs/examples/super_awesome_company/pjsip.conf, lines 14-22
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71114#file71114line14
For the endpoint, I would also set:
rtp_symmetric=yes
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4379/#review14377
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4379/#review14378
---
On Jan. 29, 2015, 3:29 p.m., Mark Michelson wrote:
/branches/13/configs/examples/super_awesome_company/extensions.conf, lines
72-75
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71109#file71109line72
Heh, I have one more comment and it's a real nitpicky thing.
On Jan. 29, 2015, 4:23 p.m., Mark Michelson wrote:
/branches/13/configs/examples/super_awesome_company/pjsip.conf, line 41
https://reviewboard.asterisk.org/r/4379/diff/1/?file=71114#file71114line41
I'm curious why you elected to use MAC addresses as the endpoint names.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4379/
---
Review request for Asterisk Developers.
Repository: Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4379/#review14320
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4379/#review14318
---
45 matches
Mail list logo
