---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4437/
---
(Updated March 6, 2015, 6:45 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4437/#review14572
---
I've incorporated feedback! Continue.
- Joshua Colp
On Feb.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4437/#review14580
---
I think you hit on just about everything I asked about, so yay
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4437/#review14582
---
Ship it!
You have my approval!
- Mark Michelson
On Feb.
Olle E. Johansson wrote:
On 03 Mar 2015, at 21:10, Mark Michelson reviewbo...@asterisk.org
mailto:reviewbo...@asterisk.org wrote:
for (i = 0; i ast_query_set_num_queries(query_set); ++i) {
struct ast_dns_query *query = ast_dns_query_set_get(query_set, i);
...do stuff...
}
Why not
On 03 Mar 2015, at 22:30, Joshua Colp jc...@digium.com wrote:
Olle E. Johansson wrote:
On 03 Mar 2015, at 21:10, Mark Michelson reviewbo...@asterisk.org
mailto:reviewbo...@asterisk.org wrote:
for (i = 0; i ast_query_set_num_queries(query_set); ++i) {
struct ast_dns_query *query =
On March 3, 2015, 8:10 p.m., Mark Michelson wrote:
I think you hit on just about everything I asked about, so yay for that.
...that is, except for one thing. I had mentioned about how
ast_query_set_get() was a leaky abstraction. After thinking about this a
bit more, I've figured
Olle E. Johansson wrote:
On 03 Mar 2015, at 22:30, Joshua Colpjc...@digium.com wrote:
Olle E. Johansson wrote:
On 03 Mar 2015, at 21:10, Mark
Michelsonreviewbo...@asterisk.org
mailto:reviewbo...@asterisk.org wrote:
for (i = 0; i ast_query_set_num_queries(query_set); ++i) {
struct
On 03 Mar 2015, at 21:10, Mark Michelson reviewbo...@asterisk.org wrote:
for (i = 0; i ast_query_set_num_queries(query_set); ++i) {
struct ast_dns_query *query = ast_dns_query_set_get(query_set, i);
...do stuff...
}
Why not use DNS terminology?
/O--
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4437/#review14558
---
mjordan file: for the proposed DNS API, are you envisioning
On Feb. 26, 2015, 10:46 a.m., Joshua Colp wrote:
mjordan file: for the proposed DNS API, are you envisioning having it act
as a facade over a particular library? Or having a separate file/module
register to the core?
file register
file the end result will be the same but it keeps
James Cloos wrote:
J == Joshua Colpreviewbo...@asterisk.org writes:
J 2. Are there any higher level APIs that would be useful to have?
In addition to the dns_naptr.h and dns_srv.h apis, there should be a
similar dns_tlsa.h api.
Even if tlsa is not yet widespread, Asterisk's dns code should
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4437/#review14545
---
From James Cloos on the mailing list:
In addition to the
On Feb. 24, 2015, 11:48 p.m., Mark Michelson wrote:
First off, good page! It's pretty easy to follow the expected flow for DNS
queries based on the API you've provided. From a low-level, there isn't
much that's missing: you have ways of performing synchronous and
asynchronous DNS
On Feb. 26, 2015, 1:53 a.m., Ashley Sanders wrote:
These are my findings regarding the first few sections of the document. On
the technical-side, I have only made one small observation. All other
observations are related to phrasing or a request for more information. At
this time, I
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4437/#review14556
---
These are my findings regarding the first few sections of the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4437/#review14539
---
First off, good page! It's pretty easy to follow the expected
J == Joshua Colp reviewbo...@asterisk.org writes:
J 2. Are there any higher level APIs that would be useful to have?
In addition to the dns_naptr.h and dns_srv.h apis, there should be a
similar dns_tlsa.h api.
Even if tlsa is not yet widespread, Asterisk's dns code should offer
quality support
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4437/
---
Review request for Asterisk Developers.
Repository: Asterisk
19 matches
Mail list logo
