Re: [asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

2015-04-08 Thread Olle E Johansson
On April 7, 2015, 9:55 p.m., Olle E Johansson wrote: global is used for global variabels. Other CLI commands have show settings - can't we reuse the same with some extra options for system? rmudgett wrote: Where are you getting global variables from the command? pjsip

Re: [asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

2015-04-08 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4597/#review15130 --- Ship it! branches/13/CHANGES

Re: [asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

2015-04-07 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4597/#review15087 --- Please update the CHANGES file :-) - Matt Jordan On April

Re: [asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

2015-04-07 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4597/ --- (Updated April 7, 2015, 11:05 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

2015-04-07 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4597/#review15095 --- branches/13/res/res_pjsip/config_global.c

Re: [asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

2015-04-07 Thread rmudgett
On April 7, 2015, 1:04 p.m., Mark Michelson wrote: branches/13/res/res_pjsip/config_global.c, lines 234-240 https://reviewboard.asterisk.org/r/4597/diff/2/?file=73682#file73682line234 I think for now this is fine, but there actually is the possibility to misrepresent to the user

Re: [asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

2015-04-07 Thread Olle E Johansson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4597/#review15109 --- global is used for global variabels. Other CLI commands have

Re: [asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

2015-04-07 Thread rmudgett
On April 7, 2015, 2:55 p.m., Olle E Johansson wrote: global is used for global variabels. Other CLI commands have show settings - can't we reuse the same with some extra options for system? Where are you getting global variables from the command? pjsip show global gives the settings for

Re: [asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

2015-04-07 Thread Olle E Johansson
On April 7, 2015, 9:55 p.m., Olle E Johansson wrote: global is used for global variabels. Other CLI commands have show settings - can't we reuse the same with some extra options for system? rmudgett wrote: Where are you getting global variables from the command? pjsip

Re: [asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

2015-04-07 Thread Kevin Harwell
On April 7, 2015, 1:04 p.m., Mark Michelson wrote: branches/13/res/res_pjsip/config_system.c, lines 149-155 https://reviewboard.asterisk.org/r/4597/diff/2/?file=73683#file73683line149 This should be impossible to happen since default system configuration should automatically get

Re: [asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

2015-04-07 Thread Kevin Harwell
On April 7, 2015, 2:55 p.m., Olle E Johansson wrote: global is used for global variabels. Other CLI commands have show settings - can't we reuse the same with some extra options for system? rmudgett wrote: Where are you getting global variables from the command? pjsip

Re: [asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

2015-04-07 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4597/ --- (Updated April 7, 2015, 5:35 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 4597: res_pjsip: add CLI commands for global and system configuration

2015-04-06 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4597/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24918