Matt Jordan has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/18
To unsubscribe, visit
Mark Michelson has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 5: Verified+1
--
To view, visit https://gerrit.asterisk.org/18
To unsubscribe, visit
Mark Michelson has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.asterisk.org/18
To unsubscribe,
Mark Michelson has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 5: -Verified
Removing the Verified since there are still outstanding findings.
--
Hello Mark Michelson, Matt Jordan,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/18
to look at the new patch set (#6).
Change subject: stasis: set a channel variable on websocket disconnect error
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 5:
(6 comments)
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 5:
(1 comment)
Gerrit ate this response in my previous draft. :/
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 6:
(1 comment)
Just one more finding.
Hello Mark Michelson, Matt Jordan,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/18
to look at the new patch set (#7).
Change subject: stasis: set a channel variable on websocket disconnect error
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 7:
(1 comment)
Done =)
Mark Michelson has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 5: Code-Review+1
(2 comments)
It's looking good by me!
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 5:
(3 comments)
Found more draft comments that gerrit obscured from me earlier =)
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 7:
(1 comment)
Ooops. I forgot to remove the chan_sip dependency from the
Hello Mark Michelson, Matt Jordan,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/18
to look at the new patch set (#8).
Change subject: stasis: set a channel variable on websocket disconnect error
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 6:
(1 comment)
Matt Jordan has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 8:
(3 comments)
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 8:
(2 comments)
Addressed both of Matt Jordan's review feedback comments.
Hello Mark Michelson, Matt Jordan,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/18
to look at the new patch set (#10).
Change subject: stasis: set a channel variable on websocket disconnect error
Matt Jordan has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 10: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/18
To unsubscribe,
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 9:
(1 comment)
Found one more tiny issue with the docstrings.
Hello Mark Michelson, Matt Jordan,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/18
to look at the new patch set (#9).
Change subject: stasis: set a channel variable on websocket disconnect error
Mark Michelson has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 10: Code-Review+2 Verified+1
--
To view, visit https://gerrit.asterisk.org/18
To
Mark Michelson has submitted this change and it was merged.
Change subject: stasis: set a channel variable on websocket disconnect error
..
stasis: set a channel variable on websocket disconnect error
This test is to ensure
Hello Mark Michelson,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/18
to look at the new patch set (#3).
Change subject: stasis: set a channel variable on websocket disconnect error
..
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 2:
(5 comments)
Addressed Matt Jordan's review feedback.
Hello Mark Michelson,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/18
to look at the new patch set (#5).
Change subject: stasis: set a channel variable on websocket disconnect error
..
Hello Mark Michelson,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/18
to look at the new patch set (#4).
Change subject: stasis: set a channel variable on websocket disconnect error
..
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 5:
(1 comment)
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 2:
(5 comments)
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 1:
(1 comment)
Addressed Mark Michelson's suggestion for refactoring the
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 5:
(5 comments)
I found some more minor issues with the review.
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 2:
(1 comment)
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 1:
(3 comments)
Hello Mark Michelson,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/18
to look at the new patch set (#2).
Change subject: stasis: set a channel variable on websocket disconnect error
..
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 1:
(5 comments)
Mark Michelson has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 1: Code-Review+1
(4 comments)
I noticed that I gave the Code-Review a 0 last time. I
Ashley Sanders has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 1:
(6 comments)
Responses to most of the review feedback from Mark Michelson.
Mark Michelson has posted comments on this change.
Change subject: stasis: set a channel variable on websocket disconnect error
..
Patch Set 1:
(10 comments)
Ashley Sanders has uploaded a new change for review.
https://gerrit.asterisk.org/18
Change subject: stasis: set a channel variable on websocket disconnect error
..
stasis: set a channel variable on websocket disconnect error
39 matches
Mail list logo
