Re: [asterisk-dev] [Code Review] 3797: PJSIP: Add ContactStatusDetail to PJSIPShowEndpoint AMI command output

2014-08-01 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3797/#review12954 --- /trunk/res/res_pjsip/pjsip_options.c

Re: [asterisk-dev] [Code Review] 3797: PJSIP: Add ContactStatusDetail to PJSIPShowEndpoint AMI command output

2014-08-01 Thread opticron
On July 31, 2014, 2:09 p.m., opticron wrote: Go ahead and commit this as the code looks good to go. I'll take care of the documentation for it since PJSIPShowEndpoint is lacking enough in reponse documentation so as to be out of the scope of this review. The documentation for this

Re: [asterisk-dev] [Code Review] 3797: PJSIP: Add ContactStatusDetail to PJSIPShowEndpoint AMI command output

2014-08-01 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3797/ --- (Updated Aug. 1, 2014, 9:48 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3797: PJSIP: Add ContactStatusDetail to PJSIPShowEndpoint AMI command output

2014-07-31 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3797/#review12948 --- Ship it! Go ahead and commit this as the code looks good to

Re: [asterisk-dev] [Code Review] 3797: PJSIP: Add ContactStatusDetail to PJSIPShowEndpoint AMI command output

2014-07-29 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3797/#review12900 --- /trunk/res/res_pjsip/pjsip_options.c

Re: [asterisk-dev] [Code Review] 3797: PJSIP: Add ContactStatusDetail to PJSIPShowEndpoint AMI command output

2014-07-29 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3797/ --- (Updated July 29, 2014, 8:05 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3797: PJSIP: Add ContactStatusDetail to PJSIPShowEndpoint AMI command output

2014-07-15 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3797/#review12666 --- /trunk/res/res_pjsip/pjsip_options.c