Re: [asterisk-dev] Final Preview: docs.asterisk.org

Hi George! Something I noticed (e.g. on this page: https://docs.asterisk.org/Asterisk_20_Documentation/API_Documentation/Module_Configuration/res_pjsip/) The available space in the browser is used badly with the current layout template. There is a lot of blank space to the left and right,

Re: [asterisk-dev] Final Preview: docs.asterisk.org

On 8/4/2023 3:20 PM, George Joseph wrote: On Fri, Aug 4, 2023 at 11:50 AM > wrote: Only thing I noticed when building this time around was warnings like these: INFO    -  Doc file

Re: [asterisk-dev] Final Preview: docs.asterisk.org

On Fri, Aug 4, 2023 at 11:50 AM wrote: > On 8/4/2023 9:42 AM, George Joseph wrote: > > Well, I've made a few more changes and pushed them up. I think this > > is as good as it's going to get for now. > > I think it's perfect. Down from 230 MB to 140 MB for the same build. 40% > size reduction

Re: [asterisk-dev] Final Preview: docs.asterisk.org

On 8/4/2023 9:42 AM, George Joseph wrote: Well, I've made a few more changes and pushed them up.  I think this is as good as it's going to get for now. I think it's perfect. Down from 230 MB to 140 MB for the same build. 40% size reduction just by removing whitespace I guess! Looking at a few

Re: [asterisk-dev] Final Preview: docs.asterisk.org

Well, I've made a few more changes and pushed them up. I think this is as good as it's going to get for now. On Fri, Jul 28, 2023 at 6:56 PM wrote: > On 7/28/2023 8:48 PM, George Joseph wrote: > > On Fri, Jul 28, 2023 at 1:52 PM > > wrote: > > > > > > It's

Re: [asterisk-dev] Final Preview: docs.asterisk.org

On 7/28/2023 8:48 PM, George Joseph wrote: On Fri, Jul 28, 2023 at 1:52 PM > wrote: It's at the very bottom of the README: > If you're always going to build just 1 branch's dynamic documentation, > you can skip the Makefile..inc file and just

Re: [asterisk-dev] Final Preview: docs.asterisk.org

On Fri, Jul 28, 2023 at 6:48 PM George Joseph wrote: > > > On Fri, Jul 28, 2023 at 1:52 PM wrote: > >> >> It's at the very bottom of the README: >> > If you're always going to build just 1 branch's dynamic documentation, >> > you can skip the Makefile..inc file and just place everything in the

Re: [asterisk-dev] Final Preview: docs.asterisk.org

On Fri, Jul 28, 2023 at 1:52 PM wrote: > > It's at the very bottom of the README: > > If you're always going to build just 1 branch's dynamic documentation, > > you can skip the Makefile..inc file and just place everything in the > > main Makefile.inc: > > The first Makefile..inc has an extra

Re: [asterisk-dev] Final Preview: docs.asterisk.org

On 7/24/2023 8:27 AM, George Joseph wrote: Only one at the time... I just found an extra period in Makefile..inc in the latest README, but haven't noticed anything else. Not seeing it.  Probably fixed already. It's at the very bottom of the README: If you're always going to

Re: [asterisk-dev] Final Preview: docs.asterisk.org

> > > > > > TBH, I haven't looked at that stuff in years. It could probably be > > simplified quite a bit. > > Thanks, I'll play with these further and see if I can solve the include > omission I had before. Simplification aside, I think this type of stuff > has been historically underdocumented,

Re: [asterisk-dev] Final Preview: docs.asterisk.org

On 7/12/2023 8:27 AM, George Joseph wrote: On Tue, Jul 11, 2023 at 3:28 PM > wrote: How are the includes *supposed* to be handled, by the way i.e. what's supposed to dereference the xincludes? Is it one of the Asterisk build scripts for the docs

Re: [asterisk-dev] Final Preview: docs.asterisk.org

On Tue, Jul 11, 2023 at 3:28 PM wrote: > On 7/11/2023 4:34 PM, George Joseph wrote: > > On Sat, Jul 8, 2023 at 4:24 PM > > wrote: > > > > Hi, Geroge, > > Just had a chance to look at this this afternoon. The > > instructions > > for the

Re: [asterisk-dev] Final Preview: docs.asterisk.org

On 7/11/2023 4:34 PM, George Joseph wrote: On Sat, Jul 8, 2023 at 4:24 PM > wrote: Hi, Geroge, Just had a chance to look at this this afternoon. The instructions for the dynamic doc generation definitely made my head hurt a little bit, but

Re: [asterisk-dev] Final Preview: docs.asterisk.org

Comments in line ... On Sat, Jul 8, 2023 at 4:24 PM wrote: > Hi, Geroge, > Just had a chance to look at this this afternoon. The instructions > for the dynamic doc generation definitely made my head hurt a little > bit, but I have a few thoughts after putzing around a little bit. > Your

Re: [asterisk-dev] Final Preview: docs.asterisk.org

On Mon, Jul 10, 2023 at 1:06 PM wrote: > On 7/10/2023 10:09 AM, George Joseph wrote: > > I'm digesting this. It may be a while. :) > > Sorry, didn't mean to dump a novel on you there. Let me know if there's > anything I should clarify. > No worries. I've managed to eliminate 'mike' completely

Re: [asterisk-dev] Final Preview: docs.asterisk.org

On 7/10/2023 10:09 AM, George Joseph wrote: I'm digesting this.  It may be a while. :) Sorry, didn't mean to dump a novel on you there. Let me know if there's anything I should clarify. On another note, after a couple months of being in the GitHub workflow, here's another suggestion for

Re: [asterisk-dev] Final Preview: docs.asterisk.org

I'm digesting this. It may be a while. :) On Sat, Jul 8, 2023 at 4:24 PM wrote: > On 6/29/2023 3:14 PM, George Joseph wrote: > > I think we're at a point where the new documentation site can go > > live. The dynamic documentation is integrated and the README file has > > been expanded

Re: [asterisk-dev] Final Preview: docs.asterisk.org

On 6/29/2023 3:14 PM, George Joseph wrote: I think we're at a point where the new documentation site can go live.  The dynamic documentation is integrated and the README file has been expanded greatly with information on how the site is built and how you can build it yourself. Hi, Geroge,    

Re: [asterisk-dev] Final Preview: docs.asterisk.org

Thanks George, That is what was really needed (I face palmed at how obvious that was) On Fri, Jun 30, 2023 at 10:26 AM George Joseph wrote: > > > On Fri, Jun 30, 2023 at 9:36 AM Andrew Latham wrote: > >> George >> >> I just had an idea. We could disable the github plugin by not setting a >>

Re: [asterisk-dev] Final Preview: docs.asterisk.org

On Fri, Jun 30, 2023 at 9:36 AM Andrew Latham wrote: > George > > I just had an idea. We could disable the github plugin by not setting a > repo and then just add the links to a custom footer or `About` page. Just a > thought > Actually, changing that plugin to point to the actual asterisk repo

Re: [asterisk-dev] Final Preview: docs.asterisk.org

George I just had an idea. We could disable the github plugin by not setting a repo and then just add the links to a custom footer or `About` page. Just a thought On Fri, Jun 30, 2023 at 9:33 AM Andrew Latham wrote: > Ack, thanks George > > * As best I can tell in the JS [1] it needs a release

Re: [asterisk-dev] Final Preview: docs.asterisk.org

Ack, thanks George * As best I can tell in the JS [1] it needs a release to generate the version. I do agree with you that there is no real need for releases. However to enable the JS to work a release may be required. * I can see how the double Asterisk logos at the bottom would be confusing. I

Re: [asterisk-dev] Final Preview: docs.asterisk.org

[image: image.png] On Fri, Jun 30, 2023 at 10:37 AM George Joseph wrote: > > > On Fri, Jun 30, 2023 at 8:30 AM Shloime Rosenblum < > shloimerosenb...@gmail.com> wrote: > >> Is the double bullets on purpose? >> > > Nope. I thought I fixed those. Added to the list. > > >> >> [image: image.png]

Re: [asterisk-dev] Final Preview: docs.asterisk.org

On Fri, Jun 30, 2023 at 8:30 AM Shloime Rosenblum < shloimerosenb...@gmail.com> wrote: > Is the double bullets on purpose? > Nope. I thought I fixed those. Added to the list. > > [image: image.png] > > On Fri, Jun 30, 2023 at 10:03 AM Niklas Larsson wrote: > >> Hi, >> >> On >>

Re: [asterisk-dev] Final Preview: docs.asterisk.org

On Fri, Jun 30, 2023 at 8:03 AM Niklas Larsson wrote: > Hi, > > On > https://docs.asterisk.org/20/Configuration/Channel-Drivers/SIP/Configuring-res_pjsip/ > the link to "Core res_pjsip configuration options" points to > https://docs.asterisk.org/latest/Asterisk-12-Configuration_res_pjsip - > and

Re: [asterisk-dev] Final Preview: docs.asterisk.org

Is the double bullets on purpose? [image: image.png] On Fri, Jun 30, 2023 at 10:03 AM Niklas Larsson wrote: > Hi, > > On > https://docs.asterisk.org/20/Configuration/Channel-Drivers/SIP/Configuring-res_pjsip/ > the link to "Core res_pjsip configuration options" points to >

Re: [asterisk-dev] Final Preview: docs.asterisk.org

Hi, On https://docs.asterisk.org/20/Configuration/Channel-Drivers/SIP/Configuring-res_pjsip/ the link to "Core res_pjsip configuration options" points to https://docs.asterisk.org/latest/Asterisk-12-Configuration_res_pjsip - and that is a 404 /niklas On 2023-06-29 21:14, George Joseph

Re: [asterisk-dev] Final Preview: docs.asterisk.org

On Fri, Jun 30, 2023 at 8:52 AM Olivier wrote: > IMHO, having per-Asterisk-version doc is very useful feature of > current wiki for those maintening an heterogeneous set of Asterisk > instances or wanting to study differences between versions. > The Asterisk Latest (20) at the top of the docs

Re: [asterisk-dev] Final Preview: docs.asterisk.org

On Thu, Jun 29, 2023 at 2:07 PM Andrew Latham wrote: > More testing, I notice the logo is missing on the versions in the top left > corner eg https://docs.asterisk.org/19/ > Oh yeah. I probably need to copy it somewhere. I'll do that later today. > > On Thu, Jun 29, 2023 at 2:05 PM Andrew

Re: [asterisk-dev] Final Preview: docs.asterisk.org

On Thu, Jun 29, 2023 at 2:06 PM Andrew Latham wrote: > Good Work George and crew. It looks really good, it is snappy, looks nice > on mobile. > Thanks! > > All boxes checked!!! > > Nits > > 1. I get a 404 on > https://api.github.com/repos/asterisk/documentation/releases/latest > because

Re: [asterisk-dev] Final Preview: docs.asterisk.org

More testing, I notice the logo is missing on the versions in the top left corner eg https://docs.asterisk.org/19/ On Thu, Jun 29, 2023 at 2:05 PM Andrew Latham wrote: > Good Work George and crew. It looks really good, it is snappy, looks nice > on mobile. > > All boxes checked!!! > > Nits

Re: [asterisk-dev] Final Preview: docs.asterisk.org

Good Work George and crew. It looks really good, it is snappy, looks nice on mobile. All boxes checked!!! Nits 1. I get a 404 on https://api.github.com/repos/asterisk/documentation/releases/latest because there is no release yet I guess 2. I am thinking the Asterisk Logo would be good at