Re: [asterisk-dev] [Code Review] 3051: TestSuite: Add chan_pjsip path support tests

2013-12-09 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3051/ --- (Updated Dec. 9, 2013, 8:49 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] [Code Review] 3051: TestSuite: Add chan_pjsip path support tests

2013-12-09 Thread opticron
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3051/ --- (Updated Dec. 9, 2013, 8:52 a.m.) Review request for Asterisk Developers.

Re: [asterisk-dev] Asterisk Test Suite: Proposed Logging Change

2013-12-09 Thread Scott Griepentrog
So you're saying put the logs/full.txt and logs/messages.txt files in the /tmp/asterisk-testsuite path, and only copy them down to the logs/test/path/*.txt on a failure? On Sun, Dec 8, 2013 at 9:09 AM, Matthew Jordan mjor...@digium.com wrote: Back when we first added python logging to the

Re: [asterisk-dev] Asterisk Test Suite: Proposed Logging Change

2013-12-09 Thread Mark Michelson
Matthew Jordan Sunday, December 08, 2013 9:09 AM Back when we first added python logging to the Asterisk Test Suite, there were considerably fewer tests and the log files - while large - were slightly more manageable. Today, it feels like things have gotten a bit more

Re: [asterisk-dev] [Code Review] 3055: pbx.c: add lock around ast_exten use to prevent memory corruption

2013-12-09 Thread Scott Griepentrog
On Dec. 7, 2013, 9:48 a.m., Matt Jordan wrote: /branches/1.8/main/pbx.c, lines 4477-4491 https://reviewboard.asterisk.org/r/3055/diff/4/?file=49180#file49180line4477 I don't think we need the extra lock here. The purpose of the contexts lock is to prevent changes to the

Re: [asterisk-dev] PJSIP CLI and AMI organization thoughts

2013-12-09 Thread Kevin Harwell
On Sat, 2013-12-07 at 09:20 -0700, George Joseph wrote: snip It would be nice if endpoint stored all its object relationships the same way but it doesn't. It stores its related aors as a comma separated string, its auths in 2 different auth arrays, channels you have to get through a

Re: [asterisk-dev] Asterisk Test Suite: Proposed Logging Change

2013-12-09 Thread Kevin Harwell
On Sun, 2013-12-08 at 09:09 -0600, Matthew Jordan wrote: Back when we first added python logging to the Asterisk Test Suite, there were considerably fewer tests and the log files - while large - were slightly more manageable. Today, it feels like things have gotten a bit more cumbersome. On

[asterisk-dev] CDR bug in 1.8, 10 and 11 - Comments on patch please

2013-12-09 Thread Steve Davies
I believe there is a regression in the CDR code since 1.8.11. It also affects versions 10 and 11, but probably not version 12. https://issues.asterisk.org/jira/browse/ASTERISK-22954 After a SIP attended transfer, the code that was added in ASTERISK-16990 tries to copy userfield etc CDR data onto

Re: [asterisk-dev] [Code Review] 3044: Switch PJSIP auth to use a vector

2013-12-09 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3044/ --- (Updated Dec. 9, 2013, 10:10 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 2944: PJSIP messaging: send message to URI.

2013-12-09 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2944/ --- (Updated Dec. 9, 2013, 10:17 a.m.) Review request for Asterisk

Re: [asterisk-dev] PJSIP CLI and AMI organization thoughts

2013-12-09 Thread George Joseph
On Mon, Dec 9, 2013 at 8:49 AM, Kevin Harwell kharw...@digium.com wrote: On Sat, 2013-12-07 at 09:20 -0700, George Joseph wrote: snip It would be nice if endpoint stored all its object relationships the same way but it doesn't. It stores its related aors as a comma separated string,

Re: [asterisk-dev] [Code Review] 3024: Testsuite: Test the MixMonitor 'f' option

2013-12-09 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3024/#review10336 --- Ship it! Ship It! - Joshua Colp On Nov. 26, 2013, 5:07

Re: [asterisk-dev] [Code Review] 3023: Add MixMonitor() option to specify channel variable into which to store the recording filename

2013-12-09 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3023/ --- (Updated Dec. 9, 2013, 10:43 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3024: Testsuite: Test the MixMonitor 'f' option

2013-12-09 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3024/ --- (Updated Dec. 9, 2013, 10:49 a.m.) Status -- This change has been

Re: [asterisk-dev] PJSIP CLI and AMI organization thoughts

2013-12-09 Thread Kevin Harwell
On Mon, 2013-12-09 at 09:17 -0700, George Joseph wrote: On Mon, Dec 9, 2013 at 8:49 AM, Kevin Harwell kharw...@digium.com wrote: On Sat, 2013-12-07 at 09:20 -0700, George Joseph wrote: snip It would be nice if endpoint stored all its object

Re: [asterisk-dev] [Code Review] 3009: Add channel variable that describes why a channel left a ConfBridge()

2013-12-09 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3009/ --- (Updated Dec. 9, 2013, 11:29 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3015: Testsuite: CONFBRIDGE_RESULT test

2013-12-09 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3015/ --- (Updated Dec. 9, 2013, 11:33 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 2944: PJSIP messaging: send message to URI.

2013-12-09 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2944/#review10338 --- Ship it! Ship It! - Mark Michelson On Dec. 9, 2013, 4:17

Re: [asterisk-dev] [Code Review] 3032: Testsuite: ARI device state

2013-12-09 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3032/ --- (Updated Dec. 9, 2013, 1:37 p.m.) Status -- This change has been

[asterisk-dev] [Code Review] 3060: pjsip tests: interactions with chan_sip cause test failures

2013-12-09 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3060/ --- Review request for Asterisk Developers and Matt Jordan. Bugs:

Re: [asterisk-dev] [Code Review] 3046: framehooks: Re-iterate when frame is changed

2013-12-09 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3046/#review10339 --- The loop situation Matt described is possible. When

Re: [asterisk-dev] [Code Review] 3060: pjsip tests: interactions with chan_sip cause test failures

2013-12-09 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3060/#review10340 --- I think this will work well for the testsuite. My only

Re: [asterisk-dev] PJSIP CLI and AMI organization thoughts

2013-12-09 Thread George Joseph
On Mon, Dec 9, 2013 at 10:15 AM, Kevin Harwell kharw...@digium.com wrote: On Mon, 2013-12-09 at 09:17 -0700, George Joseph wrote: If Asterisk were completely OO we could create object factories, interfaces and implementation classes that hide all of that. Unfortunately, it's not. Also

[asterisk-dev] [Code Review] 3061: External MWI core support with AMI using it.

2013-12-09 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3061/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 3045: app_page: Add predial handlers

2013-12-09 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3045/ --- (Updated Dec. 9, 2013, 4:17 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3053: testsuite: Test predial handlers for app_page

2013-12-09 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3053/ --- (Updated Dec. 9, 2013, 4:27 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3042: chan_pjsip: Fixup function is blocking when attempting to push a synchronous task which can lead to a stuck channel container lock.

2013-12-09 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3042/ --- (Updated Dec. 9, 2013, 4:47 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3060: pjsip tests: interactions with chan_sip cause test failures

2013-12-09 Thread Kevin Harwell
On Dec. 9, 2013, 2:27 p.m., Mark Michelson wrote: I think this will work well for the testsuite. My only suggestion would be a way to override default conflict behavior if desired. It may be that we wish to write some sort of test where we transfer a call between a chan_sip endpoint

Re: [asterisk-dev] [Code Review] 3060: pjsip tests: interactions with chan_sip cause test failures

2013-12-09 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3060/ --- (Updated Dec. 9, 2013, 4:52 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 3040: bridge transfers: Make sure ATTENDEDTRANSFER variable gets set for all the expected channels when doing bridge attended transfers. Also make sure BLINDTRANSFER i

2013-12-09 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3040/#review10341 --- /branches/12/include/asterisk/bridge.h

Re: [asterisk-dev] [Code Review] 3025: ARI: Implement device state API

2013-12-09 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3025/ --- (Updated Nov. 23, 2013, 11:38 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3025: ARI: Implement device state API

2013-12-09 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3025/ --- (Updated Nov. 22, 2013, 10:52 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3025: ARI: Implement device state API

2013-12-09 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3025/ --- (Updated Nov. 22, 2013, 1:36 p.m.) Review request for Asterisk

Re: [asterisk-dev] Asterisk Test Suite: Proposed Logging Change

2013-12-09 Thread Matthew Jordan
On Mon, Dec 9, 2013 at 9:32 AM, Scott Griepentrog sgriepent...@digium.comwrote: So you're saying put the logs/full.txt and logs/messages.txt files in the /tmp/asterisk-testsuite path, and only copy them down to the logs/test/path/*.txt on a failure? Kind of. Currently, the python

Re: [asterisk-dev] [Code Review] 3046: framehooks: Re-iterate when frame is changed

2013-12-09 Thread Matt Jordan
On Dec. 9, 2013, 8:02 p.m., Mark Michelson wrote: The loop situation Matt described is possible. When ast_channel_suppress() is called, it results in AST_FRAME_VOICE being turned into AST_FRAME_NULL. If there is a jitter buffer on a channel, then AST_FRAME_NULL gets turned into

Re: [asterisk-dev] [Code Review] 3055: pbx.c: add lock around ast_exten use to prevent memory corruption

2013-12-09 Thread Matt Jordan
On Dec. 7, 2013, 3:48 p.m., Matt Jordan wrote: /branches/1.8/main/pbx.c, lines 4477-4491 https://reviewboard.asterisk.org/r/3055/diff/4/?file=49180#file49180line4477 I don't think we need the extra lock here. The purpose of the contexts lock is to prevent changes to the

Re: [asterisk-dev] [Code Review] 3035: Add a function PJSIP_ENDPOINT to retrieve endpoint configuration details from the dialplan

2013-12-09 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3035/ --- (Updated Dec. 10, 2013, 2:34 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3038: Add CHANNEL function support for PJSIP

2013-12-09 Thread Matt Jordan
On Dec. 4, 2013, 9:02 p.m., Mark Michelson wrote: I have a general thread-safety concern with this addition. In general, the ast_sip_session, pjsip_dialog, and pjsip_inv_session structures are only accessed from SIP servant threads. With this set of changes, you access session data

Re: [asterisk-dev] [Code Review] 3038: Add CHANNEL function support for PJSIP

2013-12-09 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3038/ --- (Updated Dec. 10, 2013, 3:51 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3052: ARI: Allow specifying channel variables during a POST /channels

2013-12-09 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3052/#review10346 --- branches/12/main/http.c