---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3051/
---
(Updated Dec. 9, 2013, 8:49 a.m.)
Review request for Asterisk Developers.
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3051/
---
(Updated Dec. 9, 2013, 8:52 a.m.)
Review request for Asterisk Developers.
So you're saying put the logs/full.txt and logs/messages.txt files in the
/tmp/asterisk-testsuite path, and only copy them down to the
logs/test/path/*.txt on a failure?
On Sun, Dec 8, 2013 at 9:09 AM, Matthew Jordan mjor...@digium.com wrote:
Back when we first added python logging to the
Matthew Jordan
Sunday, December
08, 2013 9:09 AM
Back
when we first added python logging to the Asterisk Test Suite, there
were considerably fewer tests and the log files - while large - were
slightly more manageable. Today, it feels like things have gotten a bit
more
On Dec. 7, 2013, 9:48 a.m., Matt Jordan wrote:
/branches/1.8/main/pbx.c, lines 4477-4491
https://reviewboard.asterisk.org/r/3055/diff/4/?file=49180#file49180line4477
I don't think we need the extra lock here.
The purpose of the contexts lock is to prevent changes to the
On Sat, 2013-12-07 at 09:20 -0700, George Joseph wrote:
snip
It would be nice if endpoint stored all its object relationships the
same way but it doesn't. It stores its related aors as a comma
separated string, its auths in 2 different auth arrays, channels you
have to get through a
On Sun, 2013-12-08 at 09:09 -0600, Matthew Jordan wrote:
Back when we first added python logging to the Asterisk Test Suite,
there were considerably fewer tests and the log files - while large -
were slightly more manageable. Today, it feels like things have gotten
a bit more cumbersome.
On
I believe there is a regression in the CDR code since 1.8.11. It also
affects versions 10 and 11, but probably not version 12.
https://issues.asterisk.org/jira/browse/ASTERISK-22954
After a SIP attended transfer, the code that was added in
ASTERISK-16990 tries to copy userfield etc CDR data onto
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3044/
---
(Updated Dec. 9, 2013, 10:10 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2944/
---
(Updated Dec. 9, 2013, 10:17 a.m.)
Review request for Asterisk
On Mon, Dec 9, 2013 at 8:49 AM, Kevin Harwell kharw...@digium.com wrote:
On Sat, 2013-12-07 at 09:20 -0700, George Joseph wrote:
snip
It would be nice if endpoint stored all its object relationships the
same way but it doesn't. It stores its related aors as a comma
separated string,
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3024/#review10336
---
Ship it!
Ship It!
- Joshua Colp
On Nov. 26, 2013, 5:07
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3023/
---
(Updated Dec. 9, 2013, 10:43 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3024/
---
(Updated Dec. 9, 2013, 10:49 a.m.)
Status
--
This change has been
On Mon, 2013-12-09 at 09:17 -0700, George Joseph wrote:
On Mon, Dec 9, 2013 at 8:49 AM, Kevin Harwell kharw...@digium.com
wrote:
On Sat, 2013-12-07 at 09:20 -0700, George Joseph wrote:
snip
It would be nice if endpoint stored all its object
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3009/
---
(Updated Dec. 9, 2013, 11:29 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3015/
---
(Updated Dec. 9, 2013, 11:33 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2944/#review10338
---
Ship it!
Ship It!
- Mark Michelson
On Dec. 9, 2013, 4:17
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3032/
---
(Updated Dec. 9, 2013, 1:37 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3060/
---
Review request for Asterisk Developers and Matt Jordan.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3046/#review10339
---
The loop situation Matt described is possible.
When
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3060/#review10340
---
I think this will work well for the testsuite. My only
On Mon, Dec 9, 2013 at 10:15 AM, Kevin Harwell kharw...@digium.com wrote:
On Mon, 2013-12-09 at 09:17 -0700, George Joseph wrote:
If Asterisk were completely OO we could create object factories,
interfaces and implementation classes that hide all of that.
Unfortunately, it's not. Also
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3061/
---
Review request for Asterisk Developers.
Repository: Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3045/
---
(Updated Dec. 9, 2013, 4:17 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3053/
---
(Updated Dec. 9, 2013, 4:27 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3042/
---
(Updated Dec. 9, 2013, 4:47 p.m.)
Status
--
This change has been
On Dec. 9, 2013, 2:27 p.m., Mark Michelson wrote:
I think this will work well for the testsuite. My only suggestion would be
a way to override default conflict behavior if desired. It may be that we
wish to write some sort of test where we transfer a call between a chan_sip
endpoint
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3060/
---
(Updated Dec. 9, 2013, 4:52 p.m.)
Review request for Asterisk Developers
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3040/#review10341
---
/branches/12/include/asterisk/bridge.h
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3025/
---
(Updated Nov. 23, 2013, 11:38 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3025/
---
(Updated Nov. 22, 2013, 10:52 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3025/
---
(Updated Nov. 22, 2013, 1:36 p.m.)
Review request for Asterisk
On Mon, Dec 9, 2013 at 9:32 AM, Scott Griepentrog
sgriepent...@digium.comwrote:
So you're saying put the logs/full.txt and logs/messages.txt files in the
/tmp/asterisk-testsuite path, and only copy them down to the
logs/test/path/*.txt on a failure?
Kind of.
Currently, the python
On Dec. 9, 2013, 8:02 p.m., Mark Michelson wrote:
The loop situation Matt described is possible.
When ast_channel_suppress() is called, it results in AST_FRAME_VOICE being
turned into AST_FRAME_NULL.
If there is a jitter buffer on a channel, then AST_FRAME_NULL gets turned
into
On Dec. 7, 2013, 3:48 p.m., Matt Jordan wrote:
/branches/1.8/main/pbx.c, lines 4477-4491
https://reviewboard.asterisk.org/r/3055/diff/4/?file=49180#file49180line4477
I don't think we need the extra lock here.
The purpose of the contexts lock is to prevent changes to the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3035/
---
(Updated Dec. 10, 2013, 2:34 a.m.)
Review request for Asterisk
On Dec. 4, 2013, 9:02 p.m., Mark Michelson wrote:
I have a general thread-safety concern with this addition. In general, the
ast_sip_session, pjsip_dialog, and pjsip_inv_session structures are only
accessed from SIP servant threads. With this set of changes, you access
session data
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3038/
---
(Updated Dec. 10, 2013, 3:51 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3052/#review10346
---
branches/12/main/http.c
40 matches
Mail list logo