On March 5, 2014, 7:34 p.m., Matt Jordan wrote:
So this completely solves the problem in the report, and we may decide this
is sufficient.
In general, however, this problem happens a lot - someone starts MoH on a
channel, hangs it up, does something else with it... and we don't
On March 6, 2014, 1:38 a.m., Matt Jordan wrote:
branches/12/res/res_pjsip_endpoint_identifier_ip.c, lines 364-371
https://reviewboard.asterisk.org/r/3283/diff/1/?file=55030#file55030line364
Any reason you decided to move initialization of the members of the
struct to load_module?
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3283/#review11092
---
branches/12/include/asterisk/res_pjsip_cli.h
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3305/#review11094
---
/branches/12/main/sorcery.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3304/#review11095
---
Ship it!
Ship It!
/branches/12/main/acl.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3287/
---
(Updated March 6, 2014, 9:13 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3193/#review11096
---
/branches/12/include/asterisk/sorcery.h
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3193/
---
(Updated March 6, 2014, 9:44 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3193/#review11097
---
Ship it!
Ship It!
- Joshua Colp
On March 6, 2014, 3:44
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3255/#review11098
---
/asterisk/trunk/tests/channels/SIP/sip_hold_ice/run-test
On March 6, 2014, 10:25 a.m., opticron wrote:
/asterisk/trunk/tests/channels/SIP/sip_hold_ice/run-test, lines 121-131
https://reviewboard.asterisk.org/r/3255/diff/2/?file=54970#file54970line121
These seem out of place. Why aren't they in the SIPHold class?
It's just the way the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3284/#review11100
---
Ship it!
This looks good to me!
- opticron
On March 3,
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3286/#review11101
---
Most of the same comments that apply to 3255 also apply to
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3288/#review11102
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3305/
---
(Updated March 6, 2014, 5:27 p.m.)
Review request for Asterisk Developers
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3255/
---
(Updated March 6, 2014, 11:36 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3305/#review11103
---
/branches/12/main/sorcery.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3286/
---
(Updated March 6, 2014, 11:44 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3299/
---
(Updated March 6, 2014, 6:21 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3303/
---
(Updated March 6, 2014, 6:24 p.m.)
Status
--
This change has been
On March 5, 2014, 7:38 p.m., Matt Jordan wrote:
branches/12/res/res_pjsip_endpoint_identifier_ip.c, lines 364-371
https://reviewboard.asterisk.org/r/3283/diff/1/?file=55030#file55030line364
Any reason you decided to move initialization of the members of the
struct to load_module?
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3308/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-23301
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3309/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-23298
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3310/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-23300
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3311/
---
Review request for Asterisk Developers.
Repository: testsuite
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3311/
---
(Updated March 6, 2014, 2:15 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3305/
---
(Updated March 6, 2014, 8:17 p.m.)
Review request for Asterisk Developers
First, a smidgen of background:
The two sorcery options for pjsip.conf allow and disallow both accept a
list of codecs and set the same table of codecs in behind the scenes. The
difference being of course that the disallow field inverts the meaning.
There is some potential confusion here as to
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3255/#review11106
---
/asterisk/trunk/tests/channels/SIP/sip_hold_ice/run-test
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3312/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-23353
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3287/#review11107
---
Ship it!
Ship It!
- Matt Jordan
On March 6, 2014, 9:13
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3281/#review11077
---
Ship it!
/trunk/include/asterisk/devicestate.h
On March 4, 2014, 4:38 p.m., Matt Jordan wrote:
/branches/12/res/ari/resource_channels.c, lines 753-765
https://reviewboard.asterisk.org/r/3191/diff/10/?file=55326#file55326line753
What was the reason for breaking apart ast_ari_channels_originate_args?
It's probably
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3313/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-23217
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3314/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-23354
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3286/#review11109
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3191/#review0
---
Ship it!
/branches/12/addons/chan_ooh323.c
On March 6, 2014, 2:26 p.m., Matt Jordan wrote:
/asterisk/trunk/tests/channels/SIP/sip_hold_ice/run-test, line 20
https://reviewboard.asterisk.org/r/3255/diff/3/?file=55532#file55532line20
LOGGER, not logger.
A PEP8 checker would have caught that. You should probably
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3255/
---
(Updated March 6, 2014, 2:51 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3277/#review2
---
Ship it!
These are all pedantic (and were commented to be
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3243/#review4
---
Ship it!
On March 6, 2014, 2:44 p.m., Mark Michelson wrote:
/asterisk/trunk/tests/channels/pjsip/hold_ice/configs/ast1/extensions.conf,
line 10
https://reviewboard.asterisk.org/r/3286/diff/2/?file=55538#file55538line10
What is this user event here for?
It's a remnant of the test I based
On March 6, 2014, 2:54 p.m., Matt Jordan wrote:
/asterisk/trunk/tests/rest_api/bridges/bridge_by_id/test-config.yaml, line
60
https://reviewboard.asterisk.org/r/3277/diff/3/?file=55244#file55244line60
Which event are you referring to?
Really just a note to make it clear that the
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3286/
---
(Updated March 6, 2014, 2:59 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3255/#review7
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3305/#review6
---
Ship it!
Minor issue below.
/branches/12/main/sorcery.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3315/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-23356
On March 6, 2014, 3:03 p.m., rmudgett wrote:
/branches/12/main/sorcery.c, line 311
https://reviewboard.asterisk.org/r/3305/diff/3/?file=55576#file55576line311
This function is using spaces and not tabs.
Copying directly from the wiki pages always give spaces even though I
On Feb. 12, 2014, 5:12 p.m., Mark Michelson wrote:
I'm not a fan of this patch for two reasons:
1) We're preventing a crash by introducing a memory leak.
2) The condition of undestroyed channels doesn't seem like enough to
guarantee that the interfaces container is not currently being
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3300/#review11120
---
I'm not a fan of this change, because I think it's not really
On Thu, Mar 6, 2014 at 3:31 PM, George Joseph
george.jos...@fairview5.com wrote:
On Thu, Mar 6, 2014 at 1:22 PM, Scott Griepentrog sgriepent...@digium.com
wrote:
First, a smidgen of background:
The two sorcery options for pjsip.conf allow and disallow both accept
a list of codecs and set
On Thu, Mar 6, 2014 at 3:22 PM, Paul Belanger
paul.belan...@polybeacon.comwrote:
On Thu, Mar 6, 2014 at 3:31 PM, George Joseph
george.jos...@fairview5.com wrote:
On Thu, Mar 6, 2014 at 1:22 PM, Scott Griepentrog
sgriepent...@digium.com
wrote:
First, a smidgen of background:
The
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3304/
---
(Updated March 6, 2014, 3:35 p.m.)
Status
--
This change has been
On 07/03/14 07:29, Matthew Jordan wrote:
On Thu, Mar 6, 2014 at 3:22 PM, Paul Belanger
paul.belan...@polybeacon.com mailto:paul.belan...@polybeacon.com
wrote:
On Thu, Mar 6, 2014 at 3:31 PM, George Joseph
george.jos...@fairview5.com mailto:george.jos...@fairview5.com
wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3283/
---
(Updated March 6, 2014, 2:51 p.m.)
Review request for Asterisk
So in all the current channel drivers (that need it), the convention is
like such:
disallow = all
allow = ulaw, alaw
Which can also be shortened to just:
allow = !all, ulaw, alaw
Which already makes disallow somewhat superfluous.
In PJSIP this has been kept the same way. However, the
On March 6, 2014, 9:03 p.m., rmudgett wrote:
/branches/12/main/sorcery.c, line 311
https://reviewboard.asterisk.org/r/3305/diff/3/?file=55576#file55576line311
This function is using spaces and not tabs.
Copying directly from the wiki pages always give spaces even though I
On March 6, 2014, 9:03 p.m., rmudgett wrote:
/branches/12/main/sorcery.c, line 311
https://reviewboard.asterisk.org/r/3305/diff/3/?file=55576#file55576line311
This function is using spaces and not tabs.
Copying directly from the wiki pages always give spaces even though I
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3286/#review11123
---
Ship it!
Ship It!
- Mark Michelson
On March 6, 2014, 8:59
On Thu, Mar 6, 2014 at 3:42 PM, Damien Wedhorn v...@facts.com.au wrote:
On 07/03/14 07:29, Matthew Jordan wrote:
On Thu, Mar 6, 2014 at 3:22 PM, Paul Belanger
paul.belan...@polybeacon.com wrote:
On Thu, Mar 6, 2014 at 3:31 PM, George Joseph
george.jos...@fairview5.com wrote:
For me
On 07/03/14 08:21, Matthew Jordan wrote:
On Thu, Mar 6, 2014 at 3:42 PM, Damien Wedhorn v...@facts.com.au
mailto:v...@facts.com.au wrote:
On 07/03/14 07:29, Matthew Jordan wrote:
On Thu, Mar 6, 2014 at 3:22 PM, Paul Belanger
paul.belan...@polybeacon.com
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3254/
---
(Updated March 6, 2014, 3:42 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3206/#review11126
---
Ship it!
Ship It!
- Mark Michelson
On Feb. 23, 2014, 6:04
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3102/#review11125
---
Ship it!
- Mark Michelson
On Feb. 23, 2014, 5:57 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3265/#review11124
---
Ship it!
Ship It!
- Mark Michelson
On Feb. 25, 2014, 12:55
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3306/
---
(Updated March 6, 2014, 5:59 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3306/#review11127
---
I have already taken care of the two red blobs next to lines I
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3282/
---
(Updated March 7, 2014, 1:49 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/3294/
---
(Updated March 6, 2014, 10:37 p.m.)
Status
--
This change has been
69 matches
Mail list logo
