[asterisk-dev] OT: Opus Asterisk 13

2015-01-26 Thread Sean Bright
Hi, I've just finished updating codec_opus for Asterisk 13. Unfortunately it still requires a small patch to the core of Asterisk, but the size of that patch is getting smaller with each new major version of Asterisk. You can download the codec implementation and patch file here:

Re: [asterisk-dev] [Code Review] 4365: Adding AMQP backend for CDR and CEL

2015-01-26 Thread David Lee
On Jan. 21, 2015, 5:31 p.m., Mark Michelson wrote: /branches/13/cdr/cdr_amqp.c, lines 37-42 https://reviewboard.asterisk.org/r/4365/diff/1/?file=70953#file70953line37 This needs to have details filled in. The actual doc is immediately below. This is an embarrassing vestigial

Re: [asterisk-dev] [Code Review] 4327: Various fixes for OS X

2015-01-26 Thread David Lee
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4327/ --- (Updated Jan. 26, 2015, 8:49 a.m.) Status -- This change has been

Re: [asterisk-dev] OT: Opus Asterisk 13

2015-01-26 Thread Sean Bright
On 1/26/2015 8:16 AM, Olle E. Johansson wrote: Hi, I've just finished updating codec_opus for Asterisk 13. Unfortunately it still requires a small patch to the core of Asterisk, but the size of that patch is getting smaller with each new major version of Asterisk. You can download the codec

[asterisk-dev] [Code Review] 4372: confbridge: Restore menu name associated with confbridge user to CLI output of 'confbridge list XXX'

2015-01-26 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4372/ --- Review request for Asterisk Developers and Jonathan Rose. Bugs:

Re: [asterisk-dev] [Code Review] 4365: Adding AMQP backend for CDR and CEL

2015-01-26 Thread David Lee
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4365/ --- (Updated Jan. 26, 2015, 9:16 a.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 4373: Manager Action ModuleLoad gives incorrect response when used to reload modules

2015-01-26 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4373/ --- Review request for Asterisk Developers and jbigelow. Repository: Asterisk

Re: [asterisk-dev] OT: Opus Asterisk 13

2015-01-26 Thread Olle E. Johansson
On 26 Jan 2015, at 14:03, Sean Bright sean.bri...@gmail.com wrote: Hi, I've just finished updating codec_opus for Asterisk 13. Unfortunately it still requires a small patch to the core of Asterisk, but the size of that patch is getting smaller with each new major version of Asterisk.

Re: [asterisk-dev] [Code Review] 4368: app_confbridge: Repeatedly starting and stopping recording ref leaks the recording channel. (v11 version)

2015-01-26 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4368/#review14281 --- Ship it! Ship It! - Matt Jordan On Jan. 23, 2015, 5:55

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-26 Thread Ashley Sanders
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4374/ --- (Updated Jan. 26, 2015, 2:03 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4367: chan_sip: stale nonce causes failure

2015-01-26 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4367/#review14285 --- Ship it! Ship It! - Matt Jordan On Jan. 26, 2015, 11:17

Re: [asterisk-dev] [Code Review] 4373: Manager Action ModuleLoad gives incorrect response when used to reload modules

2015-01-26 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4373/#review14284 --- Also, this patch should be against Asterisk 13, not Asterisk

[asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-26 Thread Ashley Sanders
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4374/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24316

[asterisk-dev] [Code Review] 4375: res_parking: Unsubscribe and join when unloading.

2015-01-26 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4375/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 4373: Manager Action ModuleLoad gives incorrect response when used to reload modules

2015-01-26 Thread Jonathan Rose
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4373/ --- (Updated Jan. 26, 2015, 2:16 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4369: app_confbridge: Repeatedly starting and stopping recording ref leaks the recording channel. (v13 version)

2015-01-26 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4369/#review14282 --- Ship it! Ship It! - Matt Jordan On Jan. 23, 2015, 5:55

Re: [asterisk-dev] [Code Review] 4373: Manager Action ModuleLoad gives incorrect response when used to reload modules

2015-01-26 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4373/#review14283 --- /branches/12/main/manager.c

[asterisk-dev] [Code Review] 4377: Testsuite: For httpd server, need option to define server name for security purposes

2015-01-26 Thread Ashley Sanders
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4377/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24316

Re: [asterisk-dev] [Code Review] 4367: chan_sip: stale nonce causes failure

2015-01-26 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4367/ --- (Updated Jan. 26, 2015, 11:17 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4373: Manager Action ModuleLoad gives incorrect response when used to reload modules

2015-01-26 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4373/#review14287 --- Ship it! Ship It! - Matt Jordan On Jan. 26, 2015, 2:16

Re: [asterisk-dev] [Code Review] 4375: res_parking: Unsubscribe and join when unloading.

2015-01-26 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4375/#review14286 --- Ship it! Ship It! - Matt Jordan On Jan. 26, 2015, 2:07

Re: [asterisk-dev] [Code Review] 4377: Testsuite: For httpd server, need option to define server name for security purposes

2015-01-26 Thread Ashley Sanders
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4377/ --- (Updated Jan. 26, 2015, 9:27 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-26 Thread rmudgett
On Jan. 26, 2015, 5:44 p.m., rmudgett wrote: ./branches/13/main/http.c, line 2155 https://reviewboard.asterisk.org/r/4374/diff/1/?file=71085#file71085line2155 Setting a blank string will really mean a blank servername output value: Server: Is it intended for this

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-26 Thread Ashley Sanders
On Jan. 26, 2015, 5:44 p.m., rmudgett wrote: ./branches/13/main/http.c, line 2155 https://reviewboard.asterisk.org/r/4374/diff/1/?file=71085#file71085line2155 Setting a blank string will really mean a blank servername output value: Server: Is it intended for this

Re: [asterisk-dev] [Code Review] 4372: confbridge: Restore menu name associated with confbridge user to CLI output of 'confbridge list XXX'

2015-01-26 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4372/ --- (Updated Jan. 26, 2015, 7:33 p.m.) Review request for Asterisk Developers

Re: [asterisk-dev] [Code Review] 4372: confbridge: Restore menu name associated with confbridge user to CLI output of 'confbridge list XXX'

2015-01-26 Thread rmudgett
On Jan. 26, 2015, 4:55 p.m., Scott Griepentrog wrote: /branches/13/apps/confbridge/conf_config_parser.c, line 2304 https://reviewboard.asterisk.org/r/4372/diff/1/?file=71080#file71080line2304 Use ast_copy_string? rmudgett wrote: I second this should be ast_copy_string() for

Re: [asterisk-dev] [Code Review] 4372: confbridge: Restore menu name associated with confbridge user to CLI output of 'confbridge list XXX'

2015-01-26 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4372/#review14300 --- Ship it! Minor nit about the /* Safe */ comment. - rmudgett

Re: [asterisk-dev] [Code Review] 4372: confbridge: Restore menu name associated with confbridge user to CLI output of 'confbridge list XXX'

2015-01-26 Thread Matt Jordan
On Jan. 26, 2015, 6:14 p.m., rmudgett wrote: /branches/13/apps/confbridge/include/confbridge.h, line 242 https://reviewboard.asterisk.org/r/4372/diff/1/?file=71081#file71081line242 This really should be a define instead of a magic number. Hmm... The bridge profile name is also

Re: [asterisk-dev] [Code Review] 4372: confbridge: Restore menu name associated with confbridge user to CLI output of 'confbridge list XXX'

2015-01-26 Thread Matt Jordan
On Jan. 26, 2015, 4:55 p.m., Scott Griepentrog wrote: /branches/13/apps/confbridge/conf_config_parser.c, line 2304 https://reviewboard.asterisk.org/r/4372/diff/1/?file=71080#file71080line2304 Use ast_copy_string? rmudgett wrote: I second this should be ast_copy_string() for

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-26 Thread Ashley Sanders
On Jan. 26, 2015, 5:44 p.m., rmudgett wrote: ./branches/13/main/http.c, line 2155 https://reviewboard.asterisk.org/r/4374/diff/1/?file=71085#file71085line2155 Setting a blank string will really mean a blank servername output value: Server: Is it intended for this

[asterisk-dev] rtptimeout

2015-01-26 Thread Kelvin Chua
Hi guys, I noticed rtptimeout on asterisk 12 is not working, so i looked at the source. looks like, it has no effect on res_rtp_asterisk? Kelvin Chua -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com --

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-26 Thread rmudgett
On Jan. 26, 2015, 5:44 p.m., rmudgett wrote: ./branches/13/main/http.c, lines 567-568 https://reviewboard.asterisk.org/r/4374/diff/1/?file=71085#file71085line567 Why are the allocation sizes passed in? Ashley Sanders wrote: To account for this handling the error and auth

Re: [asterisk-dev] [Code Review] 4373: Manager Action ModuleLoad gives incorrect response when used to reload modules

2015-01-26 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4373/#review14291 --- Ship it! Tested and the response now matches what is

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-26 Thread Ashley Sanders
On Jan. 26, 2015, 5:44 p.m., rmudgett wrote: ./branches/13/main/http.c, lines 608-615 https://reviewboard.asterisk.org/r/4374/diff/1/?file=71085#file71085line608 Yuck on toothbrush formatting. I think this looks better, personally. It's easier to read and glean intent. On Jan.

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-26 Thread Ashley Sanders
On Jan. 26, 2015, 5:44 p.m., rmudgett wrote: ./branches/13/main/http.c, line 2153 https://reviewboard.asterisk.org/r/4374/diff/1/?file=71085#file71085line2153 -1 is not needed for the sizeof parameter. The sizeof parameter includes the string nul terminator. I saw that

Re: [asterisk-dev] [Code Review] 4377: Testsuite: For httpd server, need option to define server name for security purposes

2015-01-26 Thread wdoekes
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4377/#review14306 --- 1) Server: Asterisk/version 2) Server: JohnMcClane 3)

[asterisk-dev] [Code Review] 4371: Update res_format_attr_opus res_format_attr_silk to new media formats architecture

2015-01-26 Thread Sean Bright
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4371/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 4372: confbridge: Restore menu name associated with confbridge user to CLI output of 'confbridge list XXX'

2015-01-26 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4372/#review14290 --- /branches/13/apps/confbridge/conf_config_parser.c

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-26 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4374/#review14289 --- ./branches/13/configs/samples/http.conf.sample

Re: [asterisk-dev] [Code Review] 4372: confbridge: Restore menu name associated with confbridge user to CLI output of 'confbridge list XXX'

2015-01-26 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4372/#review14292 --- /branches/13/apps/confbridge/include/confbridge.h

Re: [asterisk-dev] [Code Review] 4372: confbridge: Restore menu name associated with confbridge user to CLI output of 'confbridge list XXX'

2015-01-26 Thread rmudgett
On Jan. 26, 2015, 4:55 p.m., Scott Griepentrog wrote: /branches/13/apps/confbridge/conf_config_parser.c, line 2304 https://reviewboard.asterisk.org/r/4372/diff/1/?file=71080#file71080line2304 Use ast_copy_string? I second this should be ast_copy_string() for safety. - rmudgett

Re: [asterisk-dev] [Code Review] 4351: ARI: improve wiki documentation

2015-01-26 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4351/#review14294 --- Ship it! Ship It! - rmudgett On Jan. 17, 2015, 11:28 a.m.,

Re: [asterisk-dev] [Code Review] 4374: Asterisk: For httpd server, need option to define server name for security purposes

2015-01-26 Thread Andrew Nagy
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4374/#review14288 --- Ship it! Ship It! - Andrew Nagy On Jan. 26, 2015, 12:03