Re: [asterisk-dev] AstriDevCon Follow Up - Asterisk and Kamailio - smoother integration

2015-02-11 Thread Matthew Jordan
On Tue, Feb 3, 2015 at 6:11 AM, Daniel-Constantin Mierla mico...@gmail.com wrote: Thanks Matt for all the valuable details -- even quite some time since your answer, I still have to digest parts of it, given that I had some tough cold to deal with and then a bit of traveling. But that gave

Re: [asterisk-dev] [Code Review] 4411: testsuite: fix a number of tests where Asterisk does not shutdown gracefully

2015-02-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4411/ --- (Updated Feb. 11, 2015, 11:09 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4410: testsuite: Fix output of minversion/maxversion of tests that cannot run

2015-02-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4410/ --- (Updated Feb. 11, 2015, 11:04 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4399: HTTP: Stop accepting requests on final system shutdown.

2015-02-11 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4399/ --- (Updated Feb. 11, 2015, 11:28 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4412: res_http_websocket: websocket write timeout fails to fully disconnect underlying socket

2015-02-11 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4412/ --- (Updated Feb. 11, 2015, 10:46 a.m.) Status -- This change has been

Re: [asterisk-dev] AstriDevCon Follow Up - Asterisk and Kamailio - smoother integration

2015-02-11 Thread Olle E. Johansson
On 11 Feb 2015, at 17:50, Matthew Jordan mjor...@digium.com wrote: On Tue, Feb 3, 2015 at 6:11 AM, Daniel-Constantin Mierla mico...@gmail.com wrote: Thanks Matt for all the valuable details -- even quite some time since your answer, I still have to digest parts of it, given that I had

Re: [asterisk-dev] [Code Review] 4409: res_pjsip: dtls_handler causes Asterisk to crash

2015-02-11 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4409/ --- (Updated Feb. 11, 2015, 12:02 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

2015-02-11 Thread rmudgett
On Jan. 27, 2015, 2:34 p.m., Matt Jordan wrote: /branches/13/configs/examples/super_awesome_company/extensions.conf, line 42 https://reviewboard.asterisk.org/r/4379/diff/1/?file=71109#file71109line42 I know '=' is the same as '=', but I (for some reason) still prefer '=' in

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

2015-02-11 Thread Matt Jordan
On Jan. 27, 2015, 2:34 p.m., Matt Jordan wrote: /branches/13/configs/examples/super_awesome_company/extensions.conf, line 42 https://reviewboard.asterisk.org/r/4379/diff/1/?file=71109#file71109line42 I know '=' is the same as '=', but I (for some reason) still prefer '=' in

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

2015-02-11 Thread Matt Jordan
On Jan. 29, 2015, 4:23 p.m., Mark Michelson wrote: /branches/13/configs/examples/super_awesome_company/pjsip.conf, line 41 https://reviewboard.asterisk.org/r/4379/diff/1/?file=71114#file71114line41 I'm curious why you elected to use MAC addresses as the endpoint names.

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

2015-02-11 Thread George Joseph
On Jan. 27, 2015, 1:34 p.m., Matt Jordan wrote: /branches/13/configs/examples/super_awesome_company/extensions.conf, line 42 https://reviewboard.asterisk.org/r/4379/diff/1/?file=71109#file71109line42 I know '=' is the same as '=', but I (for some reason) still prefer '=' in

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

2015-02-11 Thread rnewton
On Jan. 27, 2015, 8:34 p.m., Matt Jordan wrote: /branches/13/configs/examples/super_awesome_company/extensions.conf, line 42 https://reviewboard.asterisk.org/r/4379/diff/1/?file=71109#file71109line42 I know '=' is the same as '=', but I (for some reason) still prefer '=' in

Re: [asterisk-dev] [Code Review] 4411: testsuite: fix a number of tests where Asterisk does not shutdown gracefully

2015-02-11 Thread Corey Farrell
On Feb. 10, 2015, 12:29 p.m., Mark Michelson wrote: The only caveat here is that you may want to watch automated runs of the SIP info_dtmf test to be sure that on awful hardware the 5 second Wait() isn't too short for the test to complete. I suspect it will be okay though. On a

Re: [asterisk-dev] Queue realtime and members ordering

2015-02-11 Thread Matthew Jordan
On Wed, Feb 11, 2015 at 8:14 AM, Matthew Jordan mjor...@digium.com wrote: Do you think it is doable? will such change be accepted? do you think there can be a better way? The problem you are always going to face when modifying app_queue is ensuring that you haven't broken anything else.

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

2015-02-11 Thread rnewton
On Jan. 30, 2015, 7:51 p.m., Paul Belanger wrote: /branches/13/configs/examples/super_awesome_company/extensions.conf, line 78 https://reviewboard.asterisk.org/r/4379/diff/1/?file=71109#file71109line78 I prefer putting include statements at the top of the context.

Re: [asterisk-dev] [Code Review] 4141: Enable REF_DEBUG for ast_module_ref / ast_module_unref

2015-02-11 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4141/ --- (Updated Feb. 11, 2015, 9:38 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

2015-02-11 Thread Steve Edwards
On Fri, 6 Feb 2015, rnewton wrote: I used MAC addresses as that is what we use as an example in our security best practices document: http://svnview.digium.com/svn/asterisk/trunk/README-SERIOUSLY.bestpractices.txt?view=markup Perhaps this is a moot point. SAC's Asterisk system is behind NAT

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

2015-02-11 Thread Steve Edwards
On Fri, 30 Jan 2015, Paul Belanger wrote: I'd also prefer to see the first time always a naked NoOp() exten = 8000,1,NoOp() same = n,Verbose(1, blah) What value does noop() add? I start my contexts with exten = s,1, verbose(1,[${EXTEN}@${CONTEXT}!application

Re: [asterisk-dev] Queue realtime and members ordering

2015-02-11 Thread Matthew Jordan
On Mon, Feb 9, 2015 at 4:17 PM, Leandro Dardini ldard...@gmail.com wrote: I am back to try to fight with the problem highlighted few years ago https://issues.asterisk.org/jira/browse/ASTERISK-18480 In short, when using realtime queue members, it is impossible to use ordered ringing method

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

2015-02-11 Thread rnewton
On Jan. 30, 2015, 7:51 p.m., Paul Belanger wrote: /branches/13/configs/examples/super_awesome_company/indications.conf, line 1 https://reviewboard.asterisk.org/r/4379/diff/1/?file=71110#file71110line1 Again, this file seem to be the default. I'd rather see a symlink. rnewton

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

2015-02-11 Thread George Joseph
On Jan. 27, 2015, 1:34 p.m., Matt Jordan wrote: /branches/13/configs/examples/super_awesome_company/extensions.conf, line 42 https://reviewboard.asterisk.org/r/4379/diff/1/?file=71109#file71109line42 I know '=' is the same as '=', but I (for some reason) still prefer '=' in

[asterisk-dev] t38 488

2015-02-11 Thread James Cloos
Given the case where asterisk has a single peer, such as a local kamailio and multiple remote sip destinations, is it possible to negotiate t38 both will remotes which specify redundancy in their re-invites and with remotes which specify fec? I was helping debug a case where the remote specified

[asterisk-dev] [Code Review] 4414: res_pjsip_session: Fix double re-INVITE collision crash.

2015-02-11 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4414/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24727

[asterisk-dev] [Code Review] 4415: Testsuite: Attended transfers from non-Stasis to a Stasis bridge

2015-02-11 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4415/ --- Review request for Asterisk Developers and Mark Michelson. Bugs:

Re: [asterisk-dev] [Code Review] 4415: Testsuite: Attended transfers from non-Stasis to a Stasis bridge

2015-02-11 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4415/ --- (Updated Feb. 12, 2015, 12:34 a.m.) Review request for Asterisk