Re: [asterisk-dev] [Code Review] 4468: Various: bugfixes discovered through use of chaos

2015-03-10 Thread Corey Farrell
On March 9, 2015, 6:29 p.m., Mark Michelson wrote: /branches/13/main/config.c, lines 1252-1260 https://reviewboard.asterisk.org/r/4468/diff/1/?file=71929#file71929line1252 Handling the possibility of cloned being NULL is necessary, but the problem with just returning here is that

Re: [asterisk-dev] [Code Review] 4465: Update the kqueue timing module to conform to current timer API.

2015-03-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4465/#review14620 --- My immediate question for this is: How does this impact OSX?

Re: [asterisk-dev] [Code Review] 4467: res_pjsip: Fix pjsip.conf type=global object default value handling.

2015-03-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4467/#review14621 --- /branches/13/res/res_pjsip/config_global.c

Re: [asterisk-dev] [BOUNTY] ASTERISK-22708 ODBC failover

2015-03-10 Thread Marek Cervenka
bounty offer prolonged to 31.4.2015 (end of april) Dne 3.3.2015 v 16:22 Marek Cervenka napsal(a): hi, i'm offering bounty[1] $500 (five hundred) US dollars for resolving https://issues.asterisk.org/jira/browse/ASTERISK-22708 fix must be available for asterisk 11.x and asterisk 13.x and

Re: [asterisk-dev] [Code Review] 4465: Update the kqueue timing module to conform to current timer API.

2015-03-10 Thread Ed Hynan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4465/#review14623 --- /trunk/res/res_timing_kqueue.c

[asterisk-dev] [Code Review] 4469: core: Don't allocate snapshots with locks

2015-03-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4469/ --- Review request for Asterisk Developers. Repository: Asterisk

[asterisk-dev] [Code Review] 4470: Testsuite: Generate UserEvent upon PJsua phones being ready.

2015-03-10 Thread jbigelow
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4470/ --- Review request for Asterisk Developers and Mark Michelson. Repository:

Re: [asterisk-dev] [Code Review] 4464: testsuite: Increase timeout for Asterisk shutdown

2015-03-10 Thread Kevin Harwell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4464/#review14630 --- Ship it! I'm fine with this. - Kevin Harwell On March 9,

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

2015-03-10 Thread Ed Hynan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4450/ --- (Updated March 10, 2015, 12:43 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4459: Asterisk terminates when playing a voicemail stored in LDAP

2015-03-10 Thread Graham Barnett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4459/ --- (Updated March 10, 2015, 1:11 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4467: res_pjsip: Fix pjsip.conf type=global object default value handling.

2015-03-10 Thread rmudgett
On March 10, 2015, 11:35 a.m., Kevin Harwell wrote: /branches/13/include/asterisk/res_pjsip.h, lines 1628-1643 https://reviewboard.asterisk.org/r/4467/diff/2/?file=71946#file71946line1628 If these are not referenced outside of res_pjsip then they can be moved to

Re: [asterisk-dev] [Code Review] 4470: Testsuite: Generate UserEvent upon PJsua phones being ready.

2015-03-10 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4470/#review14635 --- /asterisk/trunk/lib/python/asterisk/phones.py

Re: [asterisk-dev] [Code Review] 4465: Update the kqueue timing module to conform to current timer API.

2015-03-10 Thread Justin T. Gibbs
On March 10, 2015, 1:26 p.m., Ed Hynan wrote: /trunk/res/res_timing_kqueue.c, line 240 https://reviewboard.asterisk.org/r/4465/diff/1/?file=71888#file71888line240 Portability: at least EVFILT_USER and NOTE_TRIGGER are not defined on all kqueue(2) systems. Which platforms are you

Re: [asterisk-dev] [Code Review] 4465: Update the kqueue timing module to conform to current timer API.

2015-03-10 Thread Justin T. Gibbs
On March 10, 2015, 1:08 p.m., Joshua Colp wrote: My immediate question for this is: How does this impact OSX? The timing module was originally written for both, do these changes work for both? I haven't tested against OS-X, but it has had EVFILT_USER support since 10.6. - Justin

Re: [asterisk-dev] [Code Review] 4467: res_pjsip: Fix pjsip.conf type=global object default value handling.

2015-03-10 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4467/#review14634 --- Ship it! Ship It! - Matt Jordan On March 10, 2015, 2:45

Re: [asterisk-dev] [Code Review] 4463: core: Introduce chaos into memory allocations

2015-03-10 Thread Corey Farrell
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4463/#review14626 --- Ship it! Ship It! - Corey Farrell On March 10, 2015, 10:46

Re: [asterisk-dev] [Code Review] 4469: core: Don't allocate snapshots with locks

2015-03-10 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4469/#review14627 --- Ship it! Ship It! - rmudgett On March 10, 2015, 8:47 a.m.,

Re: [asterisk-dev] [Code Review] 4467: res_pjsip: Fix pjsip.conf type=global object default value handling.

2015-03-10 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4467/ --- (Updated March 10, 2015, 10:48 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4468: Various: bugfixes discovered through use of chaos

2015-03-10 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4468/ --- (Updated March 10, 2015, 10:27 a.m.) Review request for Asterisk

Re: [asterisk-dev] AstriDevCon Follow Up - Asterisk and Kamailio - smoother integration

2015-03-10 Thread Daniel-Constantin Mierla
Good to see the discussion had more people and wider approach on different levels, covering pure agnostic signaling up to specific application constraints. While being somehow silent, I worked to make a concrete step forward, developing a new module for kamailio named auth_xkeys -- for those

[asterisk-dev] [Code Review] 4471: Recurring asynchronous DNS query unit tests.

2015-03-10 Thread Mark Michelson
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4471/ --- Review request for Asterisk Developers. Repository: Asterisk

Re: [asterisk-dev] [Code Review] 4467: res_pjsip: Fix pjsip.conf type=global object default value handling.

2015-03-10 Thread Matt Jordan
On March 10, 2015, 8:25 a.m., Joshua Colp wrote: /branches/13/res/res_pjsip/config_global.c, line 229 https://reviewboard.asterisk.org/r/4467/diff/1/?file=71922#file71922line229 Why the change of this from a define to not a device? rmudgett wrote: The define did not help

Re: [asterisk-dev] [Code Review] 4467: res_pjsip: Fix pjsip.conf type=global object default value handling.

2015-03-10 Thread rmudgett
On March 10, 2015, 8:25 a.m., Joshua Colp wrote: /branches/13/res/res_pjsip/config_global.c, line 229 https://reviewboard.asterisk.org/r/4467/diff/1/?file=71922#file71922line229 Why the change of this from a define to not a device? rmudgett wrote: The define did not help

Re: [asterisk-dev] [IAX] Need for LAGRQ and LAGRP

2015-03-10 Thread Matthew Jordan
On Mon, Mar 9, 2015 at 5:03 PM, Yousf Ateya y.at...@starkbits.com wrote: While browsing some pcap captures of IAX channel, I found many LAGRQ and LAGRP packets (once per 10 seconds for each call). So, I traced LAGRQ and LAGRP use in code and found that it is almost useless; it sets

Re: [asterisk-dev] [Code Review] 4469: core: Don't allocate snapshots with locks

2015-03-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4469/ --- (Updated March 10, 2015, 6:09 p.m.) Status -- This change has been

[asterisk-dev] [Code Review] 4472: chan_pjsip/res_pjsip_callerid: Make Party ID handling simpler and consistent.

2015-03-10 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4472/ --- Review request for Asterisk Developers. Repository: Asterisk

[asterisk-dev] [Code Review] 4473: chan_pjsip: Add rpid_immediate option to prevent unnecessary 180 Ringing messages.

2015-03-10 Thread rmudgett
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4473/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24781