---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4521/
---
Review request for Asterisk Developers.
Repository: Asterisk
On Wed, Mar 25, 2015 at 8:34 AM, Olle E. Johansson o...@edvina.net wrote:
Friends,
Going through some Asterisk 11 code for my RTCPFB work. There are a lot of
new code in the RTP module - almost zero comments. Those that are there
are generally not doxygen formatted.
Can we please try to add
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4512/
---
(Updated March 25, 2015, 12:32 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4522/#review14832
---
/branches/13/apps/app_queue.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4522/
---
Review request for Asterisk Developers.
Bugs: ASTERISK-23319
On March 24, 2015, 3:39 p.m., Mark Michelson wrote:
I'm not a big fan of this module for a couple of reasons:
1) The data in the request URI is intended to describe who the call is
destined to be sent to, not who the call originated from. There are systems
out there where the
Matt Jordan has uploaded a new change for review.
https://gerrit.asterisk.org/7
Change subject: Add a .gitreview file for the testsuite
..
Add a .gitreview file for the testsuite
This patch adds a .gitreview file so that
Friends,
Going through some Asterisk 11 code for my RTCPFB work. There are a lot of new
code in the RTP module - almost zero comments. Those that are there
are generally not doxygen formatted.
Can we please try to add more comments as you add new code? Please. Names
doesn't explain your logic
Matt Jordan has uploaded a new change for review.
https://gerrit.asterisk.org/8
Change subject: Add .gitignore files
..
Add .gitignore files
This patch adds .gitignore files to hide artifacts created when building
components
Samuel Galarneau has posted comments on this change.
Change subject: Add a .gitreview file for the testsuite
..
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/7
To unsubscribe, visit
Matt Jordan has posted comments on this change.
Change subject: channels/pjsip/publish/asterisk_event_db: Add AstDB clustering
tests
..
Patch Set 1:
Poke the mailing list. A goof in the config prevented the initial e-mail for
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4508/
---
(Updated March 25, 2015, 10:35 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4388/#review14834
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4496/
---
(Updated March 25, 2015, 10:30 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4523/
---
Review request for Asterisk Developers.
Repository: Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4522/
---
(Updated March 25, 2015, 4:10 p.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4490/
---
(Updated March 25, 2015, 10:35 a.m.)
Review request for Asterisk
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4521/
---
(Updated March 25, 2015, 4:24 p.m.)
Review request for Asterisk
Ross Beer wrote:
Hi,
I have been testing the PJSIP Realtime configuration and can't find out
how to write registrations back to the database like when using
chan_sip, is this possible with PJSIP?
Yes, it's documented here[1].
Ideally I am trying to identify which server a phone has
Ross Beer wrote:
Should I raise this as a request in Jira?
It's the final thing we need to have to replace chan_sip so is very
important for us.
Feature requests are not accepted on the issue tracker[1]. It's possible
someone would be interested in writing it upon reading this email but no
Thanks Joshua,
However this configuration does not write anything back to the database when a
phone registers. All registrations are stored within the servers memory which
means I can't locate a device.
Kind regards,
Ross
Date: Wed, 25 Mar 2015 13:34:17 -0300
From: jc...@digium.com
To:
Hi,I have been testing the PJSIP Realtime configuration and can't find out how
to write registrations back to the database like when using chan_sip, is this
possible with PJSIP?
Ideally I am trying to identify which server a phone has registered to in the
same way that chan_sip used the
Thanks Matt,
Using the List-Id header makes a lot of sense - I'll switch my rule to use that
instead.
-Justin
-Original Message-
From: asterisk-dev-boun...@lists.digium.com
[mailto:asterisk-dev-boun...@lists.digium.com] On Behalf Of Matthew Jordan
Sent: Wednesday, March 25, 2015 5:22
Ross Beer wrote:
Thanks Joshua,
However this configuration does not write anything back to the database
when a phone registers. All registrations are stored within the servers
memory which means I can't locate a device.
Add:
contact=realtime,ps_contacts
Under [res_pjsip] in sorcery.conf
--
Russell Bryant has posted comments on this change.
Change subject: Add .gitignore files
..
Patch Set 1: Code-Review+1
looks sane
--
To view, visit https://gerrit.asterisk.org/8
To unsubscribe, visit
Russell Bryant has posted comments on this change.
Change subject: Add a .gitreview file for the testsuite
..
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.asterisk.org/#/c/7/1/.gitreview
File .gitreview:
Line 5:
Michael L. Young has posted comments on this change.
Change subject: Update commit_msg.py output format.
..
Patch Set 2: Code-Review+1
(2 comments)
Everything looks good.
https://gerrit.asterisk.org/#/c/6/2/commit_msg.py
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4502/#review14835
---
Ship it!
Minor nit.
/branches/13/main/utils.c
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4524/
---
Review request for Asterisk Developers.
Repository: Asterisk
Samuel Galarneau has posted comments on this change.
Change subject: Add a .gitreview file for the testsuite
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/7
To unsubscribe, visit
Hello Samuel Galarneau, Russell Bryant,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/7
to look at the new patch set (#2).
Change subject: Add a .gitreview file for the testsuite
..
Add a
Matt Jordan has posted comments on this change.
Change subject: Add a .gitreview file for the testsuite
..
Patch Set 2:
(1 comment)
Fixed the micro-nit :-)
--
To view, visit https://gerrit.asterisk.org/7
To unsubscribe,
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4519/
---
(Updated March 25, 2015, 3:59 p.m.)
Review request for Asterisk
Hello Michael L. Young,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/6
to look at the new patch set (#3).
Change subject: Update commit_msg.py output format.
..
Update commit_msg.py output
Corey Farrell has posted comments on this change.
Change subject: Update commit_msg.py output format.
..
Patch Set 4:
Note this also makes a slight change to make the exception handling for license
retrieval easier to read.
Hello Michael L. Young,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/6
to look at the new patch set (#5).
Change subject: Update commit_msg.py output format.
..
Update commit_msg.py output
Hello Michael L. Young,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/6
to look at the new patch set (#4).
Change subject: Update commit_msg.py output format.
..
Update commit_msg.py output
Michael L. Young has posted comments on this change.
Change subject: Update commit_msg.py output format.
..
Patch Set 4: Code-Review+1
(1 comment)
https://gerrit.asterisk.org/#/c/6/4/commit_msg.py
File commit_msg.py:
Line
Corey Farrell has posted comments on this change.
Change subject: Update commit_msg.py output format.
..
Patch Set 5:
I actually had changed the wrong Patch:\n line. The first one is for the
interface when it asks which
Corey Farrell has posted comments on this change.
Change subject: Add a .gitreview file for the testsuite
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/7
To unsubscribe, visit
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4490/#review14836
---
/trunk/funcs/func_db.c
Matt Jordan has submitted this change and it was merged.
Change subject: Add a .gitreview file for the testsuite
..
Add a .gitreview file for the testsuite
This patch adds a .gitreview file so that 'git review' can find the
Matt Jordan has posted comments on this change.
Change subject: Add .gitignore files
..
Patch Set 1:
(3 comments)
https://gerrit.asterisk.org/#/c/8/1/.gitignore
File .gitignore:
Line 3
While we're here can we add /astroot?
Hello Russell Bryant, Corey Farrell,
I'd like you to reexamine a change. Please visit
https://gerrit.asterisk.org/8
to look at the new patch set (#2).
Change subject: Add .gitignore files
..
Add .gitignore files
This
Corey Farrell has posted comments on this change.
Change subject: Add .gitignore files
..
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/8
To unsubscribe, visit https://gerrit.asterisk.org/settings
Corey Farrell has posted comments on this change.
Change subject: Add .gitignore files
..
Patch Set 1: Code-Review+1
(3 comments)
Looks pretty good to me. Up to you if you want to address the comments I've
made or just let
Michael L. Young has posted comments on this change.
Change subject: Update commit_msg.py output format.
..
Patch Set 6: Code-Review+1
--
To view, visit https://gerrit.asterisk.org/6
To unsubscribe, visit
47 matches
Mail list logo
