Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

2015-03-16 Thread Joshua Colp
PRE-CREATION /trunk/include/asterisk/dns_core.h PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4474/diff/ Testing --- Ran DNS unit tests as done by Mark, they are happy. Thanks, Joshua Colp -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 4489: res_pjsip: allow configuration of endpoint identifier query order

2015-03-13 Thread Joshua Colp
, but that's just me - Joshua Colp On March 13, 2015, 5:15 p.m., Kevin Harwell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4489

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

2015-03-13 Thread Joshua Colp
, visit: https://reviewboard.asterisk.org/r/4474/#review14641 --- On March 11, 2015, 11:42 a.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit

Re: [asterisk-dev] [Code Review] 4462: DNS core unit tests

2015-03-13 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4462/#review14679 --- Ship it! Ship It! - Joshua Colp On March 6, 2015, 9:02 p.m

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

2015-03-13 Thread Joshua Colp
PRE-CREATION /trunk/include/asterisk/dns_core.h PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4474/diff/ Testing --- Ran DNS unit tests as done by Mark, they are happy. Thanks, Joshua Colp -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 4471: Recurring asynchronous DNS query unit tests.

2015-03-13 Thread Joshua Colp
these look good to go. - Joshua Colp On March 10, 2015, 8:53 p.m., Mark Michelson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4471

Re: [asterisk-dev] [Code Review] 4471: Recurring asynchronous DNS query unit tests.

2015-03-13 Thread Joshua Colp
to the recurring query, causing it to get left behind. - Joshua Colp On March 10, 2015, 8:53 p.m., Mark Michelson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4471

Re: [asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

2015-03-12 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4474/#review14660 --- On March 11, 2015, 11:42 a.m., Joshua Colp wrote

Re: [asterisk-dev] [Code Review] 4475: audiohooks: Update internal sample rate on reads to prevent miscalculation of expected samples

2015-03-11 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4475/#review14640 --- Ship it! Ship It! - Joshua Colp On March 11, 2015, 5:30

[asterisk-dev] [Code Review] 4474: core: Add basic DNS API implementation

2015-03-11 Thread Joshua Colp
/trunk/include/asterisk/dns_naptr.h PRE-CREATION /trunk/include/asterisk/dns_internal.h PRE-CREATION /trunk/include/asterisk/dns_core.h PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4474/diff/ Testing --- Ran DNS unit tests as done by Mark, they are happy. Thanks, Joshua

Re: [asterisk-dev] [Code Review] 4465: Update the kqueue timing module to conform to current timer API.

2015-03-10 Thread Joshua Colp
? The timing module was originally written for both, do these changes work for both? - Joshua Colp On March 9, 2015, 6:21 p.m., Justin T. Gibbs wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 4467: res_pjsip: Fix pjsip.conf type=global object default value handling.

2015-03-10 Thread Joshua Colp
? - Joshua Colp On March 9, 2015, 7:43 p.m., rmudgett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4467

[asterisk-dev] [Code Review] 4469: core: Don't allocate snapshots with locks

2015-03-10 Thread Joshua Colp
/endpoints.c 432666 Diff: https://reviewboard.asterisk.org/r/4469/diff/ Testing --- Did some basic scenarios and confirmed that stuff did not explode. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 4469: core: Don't allocate snapshots with locks

2015-03-10 Thread Joshua Colp
. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4463: core: Introduce chaos into memory allocations

2015-03-09 Thread Joshua Colp
On March 9, 2015, 1:19 p.m., Corey Farrell wrote: /branches/13/main/utils.c, line 614 https://reviewboard.asterisk.org/r/4463/diff/2/?file=71877#file71877line614 This looks like it should be applied to 11 as well. I'd go so far as to say that bug fixes as a result of this should be

Re: [asterisk-dev] [Code Review] 4463: core: Introduce chaos into memory allocations

2015-03-09 Thread Joshua Colp
is really just memory allocation failures, nothing outside the scope of that. - Joshua Colp On March 7, 2015, 6:01 a.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 4460: res_pjsip_refer: Fix occasional unexpected BYE sent after receiving a REFER.

2015-03-09 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4460/#review14611 --- Ship it! Ship It! - Joshua Colp On March 6, 2015, 11:27

Re: [asterisk-dev] [Code Review] 4456: testsuite: res_pjsip - conflicting endpoint identifiers test

2015-03-09 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4456/#review14612 --- Ship it! Ship It! - Joshua Colp On March 5, 2015, 11:34

Re: [asterisk-dev] [Code Review] 4437: dns: Define a core DNS API with examples.

2015-03-06 Thread Joshua Colp
://reviewboard.asterisk.org/r/4437/diff/ Testing --- I've logically run through the API and examples to ensure they provide what is needed for the future, to make them as easy as possible to use, and to ensure higher level APIs can be created. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 4438: add auto-dtmf mode for pjsip

2015-03-05 Thread Joshua Colp
On March 3, 2015, 7:10 p.m., Joshua Colp wrote: /trunk/res/res_pjsip_session.c, lines 1107-1109 https://reviewboard.asterisk.org/r/4438/diff/1/?file=71568#file71568line1107 If telephone-event is negotiated the DSP should be dropped since it will not be used and will needlessly

Re: [asterisk-dev] [Code Review] 4437: dns: Define a core DNS API with examples.

2015-03-03 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4437/#review14572 --- I've incorporated feedback! Continue. - Joshua Colp On Feb

Re: [asterisk-dev] [Code Review] 4455: res_pjsip: conflicting endpoint identifiers

2015-03-03 Thread Joshua Colp
to invalid memory. The return value needs to be strduped. - Joshua Colp On March 2, 2015, 8:04 p.m., Kevin Harwell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4455

Re: [asterisk-dev] [Code Review] 4456: testsuite: res_pjsip - conflicting endpoint identifiers test

2015-03-03 Thread Joshua Colp
-config.yaml https://reviewboard.asterisk.org/r/4456/#comment25125 Describe the test in more detail. What is the test actually doing? IP based matching followed by username? - Joshua Colp On March 2, 2015, 8:04 p.m., Kevin Harwell wrote

Re: [asterisk-dev] [Code Review] 4457: translator: Prevent invalid memory accesses on fast shutdown

2015-03-03 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4457/#review14573 --- Ship it! Ship It! - Joshua Colp On March 3, 2015, 5:23 p.m

Re: [asterisk-dev] [Code Review] 4438: add auto-dtmf mode for pjsip

2015-03-03 Thread Joshua Colp
-event is negotiated the DSP should be dropped since it will not be used and will needlessly look at inband. - Joshua Colp On March 1, 2015, 1:34 p.m., yaron nahum wrote: --- This is an automatically generated e-mail. To reply, visit

Re: [asterisk-dev] [Code Review] 4437: dns: Define a core DNS API with examples.

2015-03-03 Thread Joshua Colp
not use DNS terminology? Can you elaborate on what you mean? Are you referring to query set as a concept (I'm unaware if there's a specific term for a group of queries in DNS) or to other stuff in the DNS API itself? -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW

Re: [asterisk-dev] [Code Review] 4437: dns: Define a core DNS API with examples.

2015-03-03 Thread Joshua Colp
, visit: https://reviewboard.asterisk.org/r/4437/#review14580 --- On Feb. 23, 2015, 12:25 a.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 4437: dns: Define a core DNS API with examples.

2015-03-03 Thread Joshua Colp
? queries are what you send. This seems to handle a result set. A query set is a higher level concept of grouped queries that are executed in parallel, with a callback being invoked upon completion of all of them. Each query holds result information respectively. -- Joshua Colp Digium, Inc

Re: [asterisk-dev] [Code Review] 4437: dns: Define a core DNS API with examples.

2015-02-26 Thread Joshua Colp
nicer comes along mjordan true mjordan You may want to think about adding a unit test enabled API only that allows us to add a test resolver * oej has quit (Quit: Leaving.) mjordan that way you can test out the threading mechanisms/callbacks from unit tests * file nods - Joshua Colp On Feb. 23

Re: [asterisk-dev] [Code Review] 4451: testsuite: Add DNS server pluggable module.

2015-02-26 Thread Joshua Colp
server and confirm records. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 4437: dns: Define a core DNS API with examples.

2015-02-25 Thread Joshua Colp
offer quality support for it. And Asterisk should use them. I've added this as a comment on the review so it's all nicely together if someone looks at things. -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out

Re: [asterisk-dev] [Code Review] 4437: dns: Define a core DNS API with examples.

2015-02-25 Thread Joshua Colp
to the dns_naptr.h and dns_srv.h apis, there should be a similar dns_tlsa.h api. Even if tlsa is not yet widespread, Asterisk's dns code should offer quality support for it. And Asterisk should use them. - Joshua Colp On Feb. 23, 2015, 12:25 a.m., Joshua Colp wrote

Re: [asterisk-dev] [Code Review] 4437: dns: Define a core DNS API with examples.

2015-02-25 Thread Joshua Colp
--- On Feb. 23, 2015, 12:25 a.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4437

[asterisk-dev] [Code Review] 4451: testsuite: Add DNS server pluggable module.

2015-02-25 Thread Joshua Colp
used the pluggable module to start a DNS server for a domain. Used dig to contact the DNS server and confirm records. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev

Re: [asterisk-dev] [Code Review] 4451: testsuite: Add DNS server pluggable module.

2015-02-25 Thread Joshua Colp
PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4451/diff/ Testing --- Hacked up a quick test which used the pluggable module to start a DNS server for a domain. Used dig to contact the DNS server and confirm records. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 4420: testsuite: Add nominal and off-nominal SRTP negotiation tests for key lifetime/MKI

2015-02-25 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4420/#review14554 --- Ship it! Ship It! - Joshua Colp On Feb. 20, 2015, 2:59 a.m

Re: [asterisk-dev] [Code Review] 4437: dns: Define a core DNS API with examples.

2015-02-25 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4437/#review14556 --- On Feb. 23, 2015, 12:25 a.m., Joshua Colp wrote

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

2015-02-24 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4379/#review14526 --- Ship it! Ship It! - Joshua Colp On Feb. 24, 2015, 1:20 p.m

Re: [asterisk-dev] [Code Review] 4443: dial api: add self destruction option

2015-02-24 Thread Joshua Colp
/4443/#comment25079 I'm personally a fan of always doing an enum ast_dial_result state = dial-state and only having the one return path. But that's just me. - Joshua Colp On Feb. 23, 2015, 11:26 p.m., Scott Griepentrog wrote

Re: [asterisk-dev] [Code Review] 4443: dial api: add self destruction option

2015-02-24 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4443/#review14528 --- Ship it! Ship It! - Joshua Colp On Feb. 23, 2015, 11:26

[asterisk-dev] [Code Review] 4437: dns: Define a core DNS API with examples.

2015-02-22 Thread Joshua Colp
they provide what is needed for the future, to make them as easy as possible to use, and to ensure higher level APIs can be created. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 4434: ARI/PJSIP: Apply requesting channel's capabilities to originated channels in ARI; clean up a bit of PJSIP's usage of format capabalities

2015-02-21 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4434/#review14518 --- Ship it! Ship It! - Joshua Colp On Feb. 20, 2015, 2:28 p.m

Re: [asterisk-dev] [Code Review] 4428: Allow graceful shutdown to unload modules that register bucket scheme's or codec's.

2015-02-19 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4428/#review14493 --- Ship it! Ship It! - Joshua Colp On Feb. 16, 2015, 6:58 p.m

Re: [asterisk-dev] [Code Review] 4429: bridge_softmix: G.729 codec license held

2015-02-17 Thread Joshua Colp
, and the lifetime of the helper entry. As it is it's very... confusing... - Joshua Colp On Feb. 16, 2015, 6:30 p.m., Kevin Harwell wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 4428: Allow graceful shutdown to unload modules that register bucket scheme's or codec's.

2015-02-17 Thread Joshua Colp
/4428/#comment25012 Why the !mod addition? Something trigger it? - Joshua Colp On Feb. 16, 2015, 6:58 p.m., Corey Farrell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r

Re: [asterisk-dev] [Code Review] 4427: Fix crash when AOC-E message is received after the channel has been destroyed.

2015-02-17 Thread Joshua Colp
On Feb. 16, 2015, 6:50 p.m., Matt Jordan wrote: /branches/12/main/aoc.c, lines 1871-1880 https://reviewboard.asterisk.org/r/4427/diff/1/?file=71450#file71450line1871 I don't think this is the right way to fix the problem. This is really just working around the

Re: [asterisk-dev] [Code Review] 4424: res_pjsip: Add show version CLI command.

2015-02-15 Thread Joshua Colp
it returns the version. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 4423: res_sorcery_config: Improve object lookup times using SCIENCE!

2015-02-15 Thread Joshua Colp
+ endpoints to see performance impact. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

[asterisk-dev] [Code Review] 4423: res_sorcery_config: Improve object lookup times using SCIENCE!

2015-02-14 Thread Joshua Colp
was chosen using the debug message depending on the number of objects. Confirmed that objects can still be looked up. Did some spot checking with 10,000+ endpoints to see performance impact. Thanks, Joshua Colp -- _ -- Bandwidth

[asterisk-dev] [Code Review] 4424: res_pjsip: Add show version CLI command.

2015-02-14 Thread Joshua Colp
for this. Diffs - /branches/13/res/res_pjsip/pjsip_cli.c 431750 Diff: https://reviewboard.asterisk.org/r/4424/diff/ Testing --- Ran CLI command. Confirmed it returns the version. Thanks, Joshua Colp -- _ -- Bandwidth

Re: [asterisk-dev] DNS Support in Asterisk

2015-02-12 Thread Joshua Colp
, and has a cache. Cheers, [1] https://wiki.asterisk.org/wiki/display/~jcolp/DNS+Support+in+Asterisk#DNSSupportinAsterisk-c-ares [2] https://wiki.asterisk.org/wiki/display/~jcolp/DNS+Support+in+Asterisk#DNSSupportinAsterisk-libunbound -- Joshua Colp Digium, Inc. | Senior Software Developer 445

Re: [asterisk-dev] [Code Review] 4412: res_http_websocket: websocket write timeout fails to fully disconnect underlying socket

2015-02-10 Thread Joshua Colp
://reviewboard.asterisk.org/r/4412/#comment24958 Add a comment with a description of what 1011 is. I had to look it up, myself. - Joshua Colp On Feb. 10, 2015, 6:06 p.m., Kevin Harwell wrote: --- This is an automatically generated e-mail. To reply

Re: [asterisk-dev] [Code Review] 4409: res_pjsip: dtls_handler causes Asterisk to crash

2015-02-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4409/#review14434 --- Ship it! Ship It! - Joshua Colp On Feb. 7, 2015, 12:25 a.m

Re: [asterisk-dev] [Code Review] 4383: res_pjsip_config_wizard: Add ability to auto-create hints.

2015-02-10 Thread Joshua Colp
://reviewboard.asterisk.org/r/4383/#comment24955 App and data could still be empty after this. Besides the minor finding looks good to me. - Joshua Colp On Feb. 4, 2015, 5:31 p.m., George Joseph wrote: --- This is an automatically

[asterisk-dev] DNS Support in Asterisk

2015-02-09 Thread Joshua Colp
. Thoughts? Cheers, [1] https://wiki.asterisk.org/wiki/display/AST/AstriDevCon+2014 [2] https://wiki.asterisk.org/wiki/display/~jcolp/DNS+Support+in+Asterisk -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com

Re: [asterisk-dev] DNS Support in Asterisk

2015-02-09 Thread Joshua Colp
, -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] DNS Support in Asterisk

2015-02-09 Thread Joshua Colp
Agreed. I'd also add Package Availability to your list. Cheers, -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org

Re: [asterisk-dev] [Code Review] 4365: Adding AMQP backend for CDR and CEL

2015-02-06 Thread Joshua Colp
Ditto. - Joshua Colp On Feb. 6, 2015, 1:13 a.m., David Lee wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4365

Re: [asterisk-dev] [Code Review] 4383: res_pjsip_config_wizard: Add ability to auto-create hints.

2015-02-04 Thread Joshua Colp
(and by extension people subscribed to it using something like SIP)? This also opens up a window where someone may try to use the configured extension and it won't be available. - Joshua Colp On Jan. 30, 2015, 6:16 p.m., George Joseph wrote

Re: [asterisk-dev] [Code Review] 4370: RAII_VAR: nested functions aren't portable. Adapting RAII_VAR to use clang/llvm blocks to get the same/similar functionality. TAKE 2

2015-02-04 Thread Joshua Colp
/4370/#comment24928 If the compiler being used is clang I think this should be required here and not just a warning when you actually try to compile. If the support doesn't exist it's just not going to work and having configure succeed is just putting off the inevitable failure. - Joshua

Re: [asterisk-dev] [Code Review] 4400: Add no_answer to ARI hangup causes

2015-02-04 Thread Joshua Colp
. - Joshua Colp On Feb. 3, 2015, 4:30 p.m., Ben Merrills wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4400/ --- (Updated

Re: [asterisk-dev] [Code Review] 4394: chan_pjsip: Port over attribute passthrough tests and add test for sprop-parameter-sets.

2015-01-31 Thread Joshua Colp
/ Testing --- Ran tests. They ran. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

Re: [asterisk-dev] [Code Review] 4392: res_format_attr_h264: Fix crash when using sprop-parameter-sets.

2015-01-31 Thread Joshua Colp
. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

2015-01-30 Thread Joshua Colp
, we could split the concept of the endpoint name from the auth user, which would then allow the endpoints to be named 107 (for example) and the auth user to be her MAC address. Joshua Colp wrote: I think in practice this would just cause problems. Not all devices allow those two things

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

2015-01-30 Thread Joshua Colp
On Jan. 27, 2015, 8:34 p.m., Matt Jordan wrote: /branches/13/configs/examples/super_awesome_company/extensions.conf, line 42 https://reviewboard.asterisk.org/r/4379/diff/1/?file=71109#file71109line42 I know '=' is the same as '=', but I (for some reason) still prefer '=' in

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

2015-01-30 Thread Joshua Colp
On Jan. 29, 2015, 10:29 p.m., Mark Michelson wrote: /branches/13/configs/examples/super_awesome_company/extensions.conf, lines 72-75 https://reviewboard.asterisk.org/r/4379/diff/1/?file=71109#file71109line72 Heh, I have one more comment and it's a real nitpicky thing.

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

2015-01-30 Thread Joshua Colp
On Jan. 29, 2015, 10:23 p.m., Mark Michelson wrote: /branches/13/configs/examples/super_awesome_company/pjsip.conf, line 41 https://reviewboard.asterisk.org/r/4379/diff/1/?file=71114#file71114line41 I'm curious why you elected to use MAC addresses as the endpoint names.

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

2015-01-30 Thread Joshua Colp
: I use _1[01]XX for all smaller PBXs. In the US it can't be confused with anything else. Joshua Colp wrote: Yeah, and it still allows the dialplan on the phone to be configured such that dialing the 4 digits has it dial immediately. 3 digit. I blame early morning. - Joshua

Re: [asterisk-dev] [Code Review] 4390: app_agent_pool: Fix initial module load agent device state reporting.

2015-01-30 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4390/#review14388 --- Ship it! Ship It! - Joshua Colp On Jan. 29, 2015, 10:31

Re: [asterisk-dev] [Code Review] 4379: Example configuration scenario - Super Awesome Company: Phase 1 - Patch 1

2015-01-30 Thread Joshua Colp
. On installation it's wise to have these sounds installed as well. /branches/13/configs/examples/super_awesome_company/pjsip.conf https://reviewboard.asterisk.org/r/4379/#comment24891 Agreed, and yay g722. - Joshua Colp On Jan. 27, 2015, 7:15 p.m., rnewton wrote

[asterisk-dev] [Code Review] 4392: res_format_attr_h264: Fix crash when using sprop-parameter-sets.

2015-01-30 Thread Joshua Colp
431296 Diff: https://reviewboard.asterisk.org/r/4392/diff/ Testing --- Ran new test to cover this. It crashed without patch. With patch it was happy. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http

[asterisk-dev] [Code Review] 4394: chan_pjsip: Port over attribute passthrough tests and add test for sprop-parameter-sets.

2015-01-30 Thread Joshua Colp
/tests/channels/pjsip/sdp_offer_answer/attribute_passthrough/configs/ast1/extensions.conf PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4394/diff/ Testing --- Ran tests. They ran. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 4384: res_pjsip_outbound_publish: eventually crashes when no response is ever received

2015-01-29 Thread Joshua Colp
On Jan. 29, 2015, 4:14 p.m., Joshua Colp wrote: branches/13/res/res_pjsip_outbound_publish.c, line 927 https://reviewboard.asterisk.org/r/4384/diff/2/?file=71172#file71172line927 So... This may actually cause publish state to be reflected incorrectly on the remote

Re: [asterisk-dev] [Code Review] 4387: res_pjsip_exten_state: Reduce log clutter... change a WARNING to a VERBOSE/2.

2015-01-29 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4387/#review14353 --- Ship it! Ship It! - Joshua Colp On Jan. 29, 2015, 1:10 a.m

Re: [asterisk-dev] [Code Review] 4384: res_pjsip_outbound_publish: eventually crashes when no response is ever received

2015-01-29 Thread Joshua Colp
://reviewboard.asterisk.org/r/4384/#comment24866 What does a user see when this happens? Any indication? - Joshua Colp On Jan. 28, 2015, 11:44 p.m., Kevin Harwell wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 4384: res_pjsip_outbound_publish: eventually crashes when no response is ever received

2015-01-29 Thread Joshua Colp
then it will be out of order. As well - wouldn't this cause to the queue to potentially grow uncontrollably? - Joshua Colp On Jan. 29, 2015, 3:55 p.m., Kevin Harwell wrote: --- This is an automatically generated e-mail. To reply

Re: [asterisk-dev] [Code Review] 4375: res_parking: Unsubscribe and join when unloading.

2015-01-27 Thread Joshua Colp
- /branches/13/res/parking/parking_manager.c 431112 Diff: https://reviewboard.asterisk.org/r/4375/diff/ Testing --- Unloaded module a few times, it unloaded. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation

Re: [asterisk-dev] [Code Review] 4371: Update res_format_attr_opus res_format_attr_silk to new media formats architecture

2015-01-27 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4371/#review14307 --- Ship it! Ship It! - Joshua Colp On Jan. 26, 2015, 11:38

[asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

2015-01-27 Thread Joshua Colp
: https://reviewboard.asterisk.org/r/4378/diff/ Testing --- Tried various scenarios including attended transfers and multiple Asterisk instances in the path. Previously media would go via the wrong route or not at all. With patch reinvites occur as expected. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

2015-01-27 Thread Joshua Colp
would go via the wrong route or not at all. With patch reinvites occur as expected. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

2015-01-27 Thread Joshua Colp
. Previously media would go via the wrong route or not at all. With patch reinvites occur as expected. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

2015-01-27 Thread Joshua Colp
with the technology join/leave callbacks. Otherwise, what is the point of the join/leave technology callbacks if the technology is going to look at the bridge channel member list at inappropriate times? Joshua Colp wrote: That flag can be unset and reset appropriately. The bridge

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

2015-01-27 Thread Joshua Colp
://reviewboard.asterisk.org/r/4378/#review14308 --- On Jan. 27, 2015, 12:06 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4378

Re: [asterisk-dev] [Code Review] 4362: chan_sip Invite: Replaces hangup bug fix

2015-01-27 Thread Joshua Colp
On Jan. 23, 2015, 3:30 p.m., Matt Jordan wrote: After reading through the analysis on the underlying ASTERISK issue, I don't have any findings with the patch. I'm always a little concerned when we have to add a new state to keep track of on the sip_pvt, but right now I can't think of

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

2015-01-27 Thread Joshua Colp
in the path. Previously media would go via the wrong route or not at all. With patch reinvites occur as expected. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

2015-01-27 Thread Joshua Colp
route or not at all. With patch reinvites occur as expected. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

Re: [asterisk-dev] [Code Review] 4378: bridge / res_pjsip_sdp_rtp: Fix issues with media not being reinvited during direct media.

2015-01-27 Thread Joshua Colp
or not at all. With patch reinvites occur as expected. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

[asterisk-dev] [Code Review] 4375: res_parking: Unsubscribe and join when unloading.

2015-01-26 Thread Joshua Colp
a few times, it unloaded. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 4356: realtime: Updates fail to work due to update fields being passed over for lookup fields

2015-01-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4356/#review14274 --- Ship it! Ship It! - Joshua Colp On Jan. 20, 2015, 3:10 a.m

Re: [asterisk-dev] [Code Review] 4345: Use SIPS Contact headers as prescribed by RFC 3261 (res_pjsip)

2015-01-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4345/#review14273 --- Ship it! Ship It! - Joshua Colp On Jan. 15, 2015, 8:07 p.m

Re: [asterisk-dev] [Code Review] 4363: res_pjsip: make it unloadable (take 2)

2015-01-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4363/#review14275 --- Ship it! Ship It! - Joshua Colp On Jan. 21, 2015, 4:30 p.m

Re: [asterisk-dev] [Code Review] 4335: res_pjsip_multihomed: Test to ensure correct message contents when multiple transports exist

2015-01-19 Thread Joshua Colp
/incoming_call_on_second_transport/configs/ast1/extensions.conf PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4335/diff/ Testing --- Ran it. It passed. Sabotaged it. It failed. Rolled back fix. It failed. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 4331: res_pjsip / res_pjsip_multihomed: Use the correct transport and addressing information on UAS sessions

2015-01-19 Thread Joshua Colp
/res/res_pjsip_multihomed.c 430683 /branches/13/res/res_pjsip.c 430683 Diff: https://reviewboard.asterisk.org/r/4331/diff/ Testing --- Ran test and confirmed it failed without patch, passed with patch. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 4345: Use SIPS Contact headers as prescribed by RFC 3261 (res_pjsip)

2015-01-19 Thread Joshua Colp
this: Why can we not construct a proper URI from the beginning, why is a module required to alter it afterwards? - Joshua Colp On Jan. 15, 2015, 8:07 p.m., Mark Michelson wrote: --- This is an automatically generated e-mail. To reply

Re: [asterisk-dev] [Code Review] 4316: ARI/PJSIP: Add the ability to redirect (transfer) a channel in a Stasis dialplan application to another system; improve and fix PJSIP's transfer ability

2015-01-19 Thread Joshua Colp
/res_pjsip_transport_websocket.c https://reviewboard.asterisk.org/r/4316/#comment24685 Etc. - Joshua Colp On Jan. 19, 2015, 3:16 a.m., Matt Jordan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4316

Re: [asterisk-dev] [Code Review] 4350: AMI: Add documentation for the missing Cdr/CEL events.

2015-01-19 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4350/#review14225 --- Ship it! Ship It! - Joshua Colp On Jan. 17, 2015, 5:32 p.m

Re: [asterisk-dev] [Code Review] 4328: res_pjsip: Document transport selection process

2015-01-16 Thread Joshua Colp
://wiki.asterisk.org/wiki/display/~jcolp/Transport+Selection Diffs - Diff: https://reviewboard.asterisk.org/r/4328/diff/ Testing --- I opened the wiki page. It opened. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation

Re: [asterisk-dev] [Code Review] 4331: res_pjsip / res_pjsip_multihomed: Use the correct transport and addressing information on UAS sessions

2015-01-16 Thread Joshua Colp
and makes sense. Diffs (updated) - /branches/13/res/res_pjsip_multihomed.c 430683 /branches/13/res/res_pjsip.c 430683 Diff: https://reviewboard.asterisk.org/r/4331/diff/ Testing --- Ran test and confirmed it failed without patch, passed with patch. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 4328: res_pjsip: Document transport selection process

2015-01-15 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4328/#review14194 --- On Jan. 12, 2015, 1:33 p.m., Joshua Colp wrote

Re: [asterisk-dev] [Code Review] 4328: res_pjsip: Document transport selection process

2015-01-15 Thread Joshua Colp
. As a side note, SRV may change your port address. Joshua Colp wrote: I've tweaked the page slightly to include this condition but have not gone further. Specifically because this page is for how a local transport is selected based on the existing code and not the process of target

<    1   2   3   4   5   6   7   8   9   10   >