Re: [asterisk-dev] [Code Review] 3479: chan_pjsip: Call pickup test.

2014-04-26 Thread Joshua Colp
://reviewboard.asterisk.org/r/3479/diff/ Testing --- I tested the test by running the test. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 3409: app_queue: Fix for queue members receiving calls when in call and with ringinuse=no

2014-04-26 Thread Joshua Colp
on here. When you do a sip reload any realtime peers in chan_sip are pruned and removed. This is probably causing the device state to change to an incorrect value which app_queue is then using. The change probably works around this by re-checking using any channels that exist. - Joshua Colp

[asterisk-dev] [Code Review] 3478: chan_pjsip: Add call pickup support.

2014-04-25 Thread Joshua Colp
://reviewboard.asterisk.org/r/3478/diff/ Testing --- Ran test and confirmed failed on normal 12. Applied change. Re-ran test and confirmed fixed. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http

[asterisk-dev] [Code Review] 3479: chan_pjsip: Call pickup test.

2014-04-25 Thread Joshua Colp
. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] [Code Review] 3480: chan_pjsip: Implement get_pvt_uniqueid channel technology callback.

2014-04-25 Thread Joshua Colp
, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

[asterisk-dev] [Code Review] 3472: res_pjsip_sdp_rtp: Fix issue with unholding when it shouldn't.

2014-04-23 Thread Joshua Colp
it is stopped. Diffs - /branches/12/res/res_pjsip_sdp_rtp.c 412900 Diff: https://reviewboard.asterisk.org/r/3472/diff/ Testing --- Ran test before fixing and confirmed broken. Ran test after fixing and confirmed fixed. Thanks, Joshua Colp

[asterisk-dev] [Code Review] 3473: res_pjsip_sdp_rtp: Add tests for receiving same SDP when call is already held.

2014-04-23 Thread Joshua Colp
and confirmed happy (after fixes were applied). Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

Re: [asterisk-dev] [Code Review] 3405: Add ast_spinlock capability

2014-04-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3405/#review11723 --- Ship it! Ship It! - Joshua Colp On April 22, 2014, 7:50

Re: [asterisk-dev] [Code Review] 3475: pjsip realtime: increase the size of some columns

2014-04-23 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3475/#review11724 --- Ship it! Ship It! - Joshua Colp On April 23, 2014, 7:28

Re: [asterisk-dev] [Code Review] 3462: PJSIP: Allow for multiple contacts to be set in a single contact= line in an aor section of pjsip.conf

2014-04-18 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3462/#review11684 --- Ship it! Ship It! - Joshua Colp On April 17, 2014, 8:52

Re: [asterisk-dev] [Code Review] 3466: HTTP: Add TCP_NODELAY to accepted connections

2014-04-18 Thread Joshua Colp
/3466/#comment21449 The other use of this uses tcp - is there any difference between that and tls? Do we need to choose one or the other based on the connection? I think this deprecates the change Scott originally did when closing the connection. - Joshua Colp On April 18, 2014, 2:41 p.m

Re: [asterisk-dev] [Code Review] 3466: HTTP: Add TCP_NODELAY to accepted connections

2014-04-18 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3466/#review11689 --- Ship it! Ship It! - Joshua Colp On April 18, 2014, 3:42

Re: [asterisk-dev] [Code Review] 3448: res_pjsip: Handle reloading when permanent contacts exist and qualify is configured

2014-04-17 Thread Joshua Colp
that changes were reflected. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

2014-04-16 Thread Joshua Colp
://reviewboard.asterisk.org/r/3447/#comment21402 Where do the anonymous values now get placed into the num/name/domain? - Joshua Colp On April 16, 2014, 9:23 p.m., Jonathan Rose wrote: --- This is an automatically generated e-mail. To reply, visit

Re: [asterisk-dev] [Code Review] 3447: Send real CallerID information with P-Asserted-Identity (RFC-3325)

2014-04-16 Thread Joshua Colp
was such that it wasn't allowed... then the anonymous header would get added. Reading this logic I don't see how the header would get added. - Joshua Colp On April 16, 2014, 9:23 p.m., Jonathan Rose wrote: --- This is an automatically

Re: [asterisk-dev] [Code Review] 3445: res_pjsip_refer: Channel variable SIPREFERTOHDR not being set during blind transfer

2014-04-15 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3445/#review11605 --- Ship it! Ship It! - Joshua Colp On April 14, 2014, 9:17

Re: [asterisk-dev] [Code Review] 3433: bridge_unreal: An alternative implementation for optimizing Unreal/Local channels.

2014-04-15 Thread Joshua Colp
numbers of Local channels in chains (100, 200, 300) and confirmed that stuff works as expected. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list

Re: [asterisk-dev] [Code Review] 3427: ARI: Add tones playback resource

2014-04-15 Thread Joshua Colp
/3427/#comment21371 This log message isn't really useful. /branches/12/main/app.c https://reviewboard.asterisk.org/r/3427/#comment21372 This doesn't allow the tone zone to be specified by the user, restricting us to US only. This needs to be made configurable somehow. - Joshua Colp

[asterisk-dev] [Code Review] 3448: res_pjsip: Handle reloading when permanent contacts exist and qualify is configured

2014-04-15 Thread Joshua Colp
/res_pjsip.c 412327 Diff: https://reviewboard.asterisk.org/r/3448/diff/ Testing --- Reloaded multiple times changing configuration and confirmed that changes were reflected. Thanks, Joshua Colp -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3429: monitor: use app options parsing helper code

2014-04-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3429/#review11543 --- Ship it! Ship It! - Joshua Colp On April 9, 2014, 12:46

Re: [asterisk-dev] [Code Review] 3427: ARI: Add tones playback resource

2014-04-10 Thread Joshua Colp
, 10:46 p.m.) Review request for Asterisk Developers, David Lee, Joshua Colp, and Matt Jordan. Bugs: ASTERISK-23433 https://issues.asterisk.org/jira/browse/ASTERISK-23433 Repository: Asterisk Description --- Adds a tones URI type to the playback resource. The tone can

Re: [asterisk-dev] [Code Review] 3427: ARI: Add tones playback resource

2014-04-10 Thread Joshua Colp
these you don't refer to them as plural. Busy tone for an example. Thoughts? - Joshua Colp On April 8, 2014, 10:46 p.m., Jonathan Rose wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 3433: bridge_unreal: An alternative implementation for optimizing Unreal/Local channels.

2014-04-10 Thread Joshua Colp
://reviewboard.asterisk.org/r/3433/#review11554 --- On April 9, 2014, 7:49 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 3433: bridge_unreal: An alternative implementation for optimizing Unreal/Local channels.

2014-04-10 Thread Joshua Colp
--- On April 9, 2014, 7:49 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3433

[asterisk-dev] [Code Review] 3433: bridge_unreal: An alternative implementation for optimizing Unreal/Local channels.

2014-04-09 Thread Joshua Colp
as expected. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3433: bridge_unreal: An alternative implementation for optimizing Unreal/Local channels.

2014-04-09 Thread Joshua Colp
documentation of how it works would also be great. I'd like to have the documentation be such that someone coming fresh into this could have a really good vision and understanding of what is going on. - Joshua Colp On April 9, 2014, 7:49 p.m., Joshua Colp wrote

Re: [asterisk-dev] Audiohook dropping frames

2014-04-08 Thread Joshua Colp
. The audiohook got just has to replace the frame with ast_null_frame if a manipulation audiohook returns NULL. Cheers, -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org

Re: [asterisk-dev] Audiohook dropping frames

2014-04-08 Thread Joshua Colp
allocation in most cases. -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org -- _ -- Bandwidth and Colocation Provided

Re: [asterisk-dev] Audiohook dropping frames

2014-04-08 Thread Joshua Colp
it would be what I would do, indeed. -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org -- _ -- Bandwidth and Colocation

Re: [asterisk-dev] Audiohook dropping frames

2014-04-08 Thread Joshua Colp
is that there's no way around it, just go for option #2 and do what Josh says again... ;-) I think it would be what I would do, indeed. Do you always do what you say you should do? I fight for the users. -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806

Re: [asterisk-dev] [Code Review] 3413: media_formats: move app.c and file.c over

2014-04-04 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3413/#review11497 --- Ship it! Ship It! - Joshua Colp On April 2, 2014, 10:02

Re: [asterisk-dev] [Code Review] 3320: media_formats: Move format modules over.

2014-04-01 Thread Joshua Colp
/r/3320/diff/ Testing --- Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 3348: Test Suite: MWI subscription test for PJSIP

2014-04-01 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3348/#review11462 --- Ship it! Ship It! - Joshua Colp On March 21, 2014, 2:20

[asterisk-dev] [Code Review] 3410: media_formats: Move chan_multicast_rtp, chan_console, app_jack, and chan_ooh323 over.

2014-03-31 Thread Joshua Colp
://reviewboard.asterisk.org/r/3410/diff/ Testing --- Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

Re: [asterisk-dev] [Code Review] 3389: media_formats: Move chan_nbs, chan_phone, and chan_vpb over.

2014-03-30 Thread Joshua Colp
/team/group/media_formats-reviewed/channels/chan_nbs.c 409286 Diff: https://reviewboard.asterisk.org/r/3389/diff/ Testing --- Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 3390: media_formats: Move chan_motif, chan_jingle, and chan_gtalk over.

2014-03-30 Thread Joshua Colp
/ Testing --- Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk

Re: [asterisk-dev] Enable dtls_cfg

2014-03-28 Thread Joshua Colp
://issues.asterisk.org/jira/browse/ASTERISK-22961 -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org -- _ -- Bandwidth and Colocation Provided

Re: [asterisk-dev] Enable dtls_cfg

2014-03-28 Thread Joshua Colp
and WebRTC. Cheers, -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 3401: Sorcery: Give sorcery instances references to the underlying wizards.

2014-03-26 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3401/#review11383 --- Ship it! Ship It! - Joshua Colp On March 26, 2014, 6:20

Re: [asterisk-dev] [Code Review] 3251: res_bucket_sounds: Add 'sounds' URI scheme implementation

2014-03-25 Thread Joshua Colp
via the bucket API. Additional information about the sounds is provided in the form of metadata. Diffs - /trunk/res/res_bucket_sounds.c PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3251/diff/ Testing --- Executed CLI commands, output is as expected. Thanks, Joshua Colp

[asterisk-dev] [Code Review] 3387: media_formats: Move chan_dahdi over.

2014-03-25 Thread Joshua Colp
/ Testing --- Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo

[asterisk-dev] [Code Review] 3390: media_formats: Move chan_motif, chan_jingle, and chan_gtalk over.

2014-03-25 Thread Joshua Colp
/channels/chan_jingle.c 409286 /team/group/media_formats-reviewed/channels/chan_gtalk.c 409286 Diff: https://reviewboard.asterisk.org/r/3390/diff/ Testing --- Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided

[asterisk-dev] [Code Review] 3388: media_formats: Move chan_mgcp, chan_unistim, and chan_skinny over.

2014-03-25 Thread Joshua Colp
-reviewed/channels/chan_unistim.c 409286 /team/group/media_formats-reviewed/channels/chan_skinny.c 409286 /team/group/media_formats-reviewed/channels/chan_mgcp.c 409286 Diff: https://reviewboard.asterisk.org/r/3388/diff/ Testing --- Thanks, Joshua Colp

[asterisk-dev] [Code Review] 3389: media_formats: Move chan_nbs, chan_phone, and chan_vpb over.

2014-03-25 Thread Joshua Colp
, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3385: Testsuite: Add simple test for message_context PJSIP endpoint option.

2014-03-25 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3385/#review11366 --- Ship it! Ship It! - Joshua Colp On March 24, 2014, 7:31

Re: [asterisk-dev] [Code Review] 3391: ARI: Don't complain about missing ARI users when we aren't enabled

2014-03-25 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3391/#review11368 --- Ship it! Ship It! - Joshua Colp On March 25, 2014, 11:33

Re: [asterisk-dev] [Code Review] 3384: PJSIP: Add 'message_context' configuration option.

2014-03-24 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3384/#review11357 --- Ship it! Ship It! - Joshua Colp On March 24, 2014, 7:31

Re: [asterisk-dev] [Code Review] 3318: media_formats: Move bridges over.

2014-03-23 Thread Joshua Colp
409286 /team/group/media_formats-reviewed/bridges/bridge_simple.c 409286 /team/group/media_formats-reviewed/bridges/bridge_holding.c 409286 Diff: https://reviewboard.asterisk.org/r/3318/diff/ Testing --- Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3322: media_formats: Move resource modules over.

2014-03-23 Thread Joshua Colp
://reviewboard.asterisk.org/r/3322/diff/ Testing --- Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 3319: media_formats: Add some additional functionality to core.

2014-03-23 Thread Joshua Colp
://reviewboard.asterisk.org/r/3319/diff/ Testing --- Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

Re: [asterisk-dev] [Code Review] 3318: media_formats: Move bridges over.

2014-03-20 Thread Joshua Colp
/media_formats-reviewed/bridges/bridge_holding.c 409286 Diff: https://reviewboard.asterisk.org/r/3318/diff/ Testing --- Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk

Re: [asterisk-dev] [Code Review] 3319: media_formats: Add some additional functionality to core.

2014-03-20 Thread Joshua Colp
/media_formats-reviewed/include/asterisk/format.h 410186 /team/group/media_formats-reviewed/include/asterisk/codec.h 410188 /team/group/media_formats-reviewed/include/asterisk/callerid.h 409286 Diff: https://reviewboard.asterisk.org/r/3319/diff/ Testing --- Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3319: media_formats: Add some additional functionality to core.

2014-03-19 Thread Joshua Colp
--- On March 8, 2014, 5:36 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3319/ --- (Updated March 8, 2014

Re: [asterisk-dev] [Code Review] 3359: res_stasis: Extend bridge type to include attributes

2014-03-19 Thread Joshua Colp
are as expected. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

2014-03-18 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3343/#review11269 --- On March 17, 2014, 10:53 p.m., Joshua Colp wrote

Re: [asterisk-dev] [Code Review] 3321: media_formats: Move dialplan functions over.

2014-03-17 Thread Joshua Colp
/team/group/media_formats-reviewed/funcs/func_pitchshift.c 409286 /team/group/media_formats-reviewed/funcs/func_frame_trace.c 409286 /team/group/media_formats-reviewed/funcs/func_channel.c 409286 Diff: https://reviewboard.asterisk.org/r/3321/diff/ Testing --- Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3322: media_formats: Move resource modules over.

2014-03-17 Thread Joshua Colp
, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3359: res_stasis: Extend bridge type to include attributes

2014-03-17 Thread Joshua Colp
/branches/12/res/ari/resource_bridges.h 410512 /branches/12/CHANGES 410512 Diff: https://reviewboard.asterisk.org/r/3359/diff/ Testing --- Using Swagger to create bridges of various types and confirmed that the resulting bridge technologies are as expected. Thanks, Joshua Colp

[asterisk-dev] Alembic in 12 SVN

2014-03-17 Thread Joshua Colp
- 21e526ad3040 (branchpoint), add pjsip debug option - 21e526ad3040 - 28887f25a46f (head), Create queue tables - 21e526ad3040 - 4c573e7135bd (head), Fix tos and cos field types Looks like we're going to need to change them to get a clean upgrade path. Cheers, -- Joshua Colp

Re: [asterisk-dev] Alembic in 12 SVN

2014-03-17 Thread Joshua Colp
Matthew Jordan wrote: snip Technically, it's probably not hard. I wonder how horrible it'd be for end users, however. Probably pretty horrible, since it's basically changing everything. -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806

[asterisk-dev] [Code Review] 3369: res_pjsip_multihomed: Be less aggressive when changing address

2014-03-17 Thread Joshua Colp
/res_pjsip_multihomed.c 410669 Diff: https://reviewboard.asterisk.org/r/3369/diff/ Testing --- Ran tests that were failing because of this, they now pass! Ran normal calls which should trigger rewriting, and stuff got rewritten. Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3369: res_pjsip_multihomed: Be less aggressive when changing address

2014-03-17 Thread Joshua Colp
calls which should trigger rewriting, and stuff got rewritten. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

2014-03-17 Thread Joshua Colp
. Disabled it and confirmed that the DNS client was disabled. Set to auto (explicitly and by default) and confirmed that the system nameservers were used. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

2014-03-14 Thread Joshua Colp
their DNS resolution pluggable. That would allow us to modify the res_pjsip stack to use Asterisk's DNS support. Inobtrusive, not obtrusive. Two different words. -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com

Re: [asterisk-dev] [Code Review] 3209: Crash in ast_format_cmp on shutdown

2014-03-14 Thread Joshua Colp
introducing problems, such as this. I think reducing the chance of a crash is good enough but if it still presents a problem we may want to think about reverting the original change. - Joshua Colp On March 14, 2014, 6:35 p.m., Scott Griepentrog wrote

[asterisk-dev] [Code Review] 3359: res_stasis: Extend bridge type to include attributes

2014-03-14 Thread Joshua Colp
--- Using Swagger to create bridges of various types and confirmed that the resulting bridge technologies are as expected. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

2014-03-13 Thread Joshua Colp
Olle E. Johansson wrote: On 12 Mar 2014, at 19:53, Joshua Colp reviewbo...@asterisk.org mailto:reviewbo...@asterisk.org wrote: This change adds a configuration option for setting nameservers to be used by the PJSIP DNS client. If this option is not set then the system nameservers

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

2014-03-13 Thread Joshua Colp
they were used by PJSIP. Disabled it and confirmed that the DNS client was disabled. Set to auto (explicitly and by default) and confirmed that the system nameservers were used. Thanks, Joshua Colp -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

2014-03-13 Thread Joshua Colp
Olle E. Johansson wrote: On 12 Mar 2014, at 19:53, Joshua Colp reviewbo...@asterisk.org mailto:reviewbo...@asterisk.org wrote: This change adds a configuration option for setting nameservers to be used by the PJSIP DNS client. If this option is not set then the system nameservers

Re: [asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

2014-03-13 Thread Joshua Colp
Olle E. Johansson wrote: On 13 Mar 2014, at 11:42, Joshua Colp reviewbo...@asterisk.org mailto:reviewbo...@asterisk.org wrote: In case others are wondering as Olle was: PJLIB-Util (part of pjproject) provides a DNS client which can optionally (but is highly suggested) to be used with PJSIP

Re: [asterisk-dev] [Code Review] 3344: PJSIP MWI: Prevent endpoints from subscribing to AORs that provide MWI for a mailbox for which they are already receiving unsolicited MWI.

2014-03-13 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3344/#review11159 --- Ship it! Ship It! - Joshua Colp On March 12, 2014, 9:52

Re: [asterisk-dev] [Code Review] 3340: ARI: Bridge Playback needs to have PlaybackStarted and PlaybackFinished messages get relayed to the bridge topic

2014-03-13 Thread Joshua Colp
of the event you are forwarding it is unrelated to the channel and allowed to pass. - Joshua Colp On March 12, 2014, 6:02 p.m., Jonathan Rose wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 3323: res_pjsip: Update PJSIP tests that evaluate ToS settings to go back to anticipating decimal values. Also fix another failure that is more recent.

2014-03-13 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3323/#review11163 --- Ship it! Ship It! - Joshua Colp On March 10, 2014, 7:13

Re: [asterisk-dev] [Code Review] 3324: res_pjsip: Make ToS values show up as decimals in sorcery object output

2014-03-13 Thread Joshua Colp
://reviewboard.asterisk.org/r/3324/#comment20800 Why not just use ast_asprintf for both of the to_str functions? - Joshua Colp On March 10, 2014, 7:04 p.m., Jonathan Rose wrote: --- This is an automatically generated e-mail. To reply, visit

Re: [asterisk-dev] [Code Review] 3340: ARI: Bridge Playback needs to have PlaybackStarted and PlaybackFinished messages get relayed to the bridge topic (also recording)

2014-03-13 Thread Joshua Colp
https://reviewboard.asterisk.org/r/3340/#comment20804 Speeling mistake. - Joshua Colp On March 13, 2014, 3:57 p.m., Jonathan Rose wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 3324: res_pjsip: Make ToS values show up as decimals in sorcery object output

2014-03-13 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3324/#review11176 --- Ship it! Ship It! - Joshua Colp On March 13, 2014, 4:11

Re: [asterisk-dev] [Code Review] 3326: Sorcery: Do not apply the same wizard to an object type twice; Automatically apply sorcery configuration when sorcery is opened.

2014-03-12 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3326/#review11155 --- Ship it! Ship It! - Joshua Colp On March 12, 2014, 5:54

[asterisk-dev] [Code Review] 3343: res_pjsip: Enable DNS support.

2014-03-12 Thread Joshua Colp
it and confirmed that the DNS client was disabled. Set to auto (explicitly and by default) and confirmed that the system nameservers were used. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] bridge_unreal: An alternative approach to Local/Unreal channel optimization

2014-03-11 Thread Joshua Colp
/asterisk/team/file/bridge_unreal_optimizer/ -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org -- _ -- Bandwidth and Colocation

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

2014-03-11 Thread Joshua Colp
interface went into the message. Some additional testing by others would be nice. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

Re: [asterisk-dev] [Code Review] 3326: Sorcery: Do not apply the same wizard to an object type twice; Automatically apply sorcery configuration when sorcery is opened.

2014-03-11 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3326/#review11149 --- Update the documentation ^_^ - Joshua Colp On March 11

Re: [asterisk-dev] bridge_unreal: An alternative approach to Local/Unreal channel optimization

2014-03-10 Thread Joshua Colp
optimize and how it isn't inside of chan_local... what do you think NOW? ;) -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out at: www.digium.com www.asterisk.org

[asterisk-dev] [Code Review] 3318: media_formats: Move bridges over.

2014-03-08 Thread Joshua Colp
Diff: https://reviewboard.asterisk.org/r/3318/diff/ Testing --- Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options

[asterisk-dev] [Code Review] 3320: media_formats: Move format modules over.

2014-03-08 Thread Joshua Colp
/media_formats-reviewed/formats/format_g723.c 409286 /team/group/media_formats-reviewed/formats/format_g719.c 409286 Diff: https://reviewboard.asterisk.org/r/3320/diff/ Testing --- Thanks, Joshua Colp -- _ -- Bandwidth

[asterisk-dev] [Code Review] 3322: media_formats: Move resource modules over.

2014-03-08 Thread Joshua Colp
/media_formats-reviewed/res/ari/resource_channels.c 409286 /team/group/media_formats-reviewed/res/ari/resource_bridges.c 409286 Diff: https://reviewboard.asterisk.org/r/3322/diff/ Testing --- Thanks, Joshua Colp

[asterisk-dev] [Code Review] 3321: media_formats: Move dialplan functions over.

2014-03-08 Thread Joshua Colp
/group/media_formats-reviewed/funcs/func_channel.c 409286 Diff: https://reviewboard.asterisk.org/r/3321/diff/ Testing --- Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com

Re: [asterisk-dev] [Code Review] 3308: tests/apps/confbridge: Add the 'triple lindy' test of marked, waitmarked, and unmarked users

2014-03-08 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3308/#review11133 --- Ship it! Ship It! - Joshua Colp On March 6, 2014, 7:58 p.m

Re: [asterisk-dev] [Code Review] 3309: tests/apps/confbridge: Test for two waitmarked users in a conference

2014-03-08 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3309/#review11135 --- Ship it! Ship It! - Joshua Colp On March 6, 2014, 8:02 p.m

Re: [asterisk-dev] [Code Review] 3310: tests/apps/confbridge: Add a test for waitmarked/normal user interaction

2014-03-08 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3310/#review11136 --- Ship it! Ship It! - Joshua Colp On March 6, 2014, 8:05 p.m

Re: [asterisk-dev] [Code Review] 3311: tests/apps/agents/agent_request: Add nominal agent request test

2014-03-08 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3311/#review11137 --- Ship it! Ship It! - Joshua Colp On March 6, 2014, 8:15 p.m

[asterisk-dev] bridge_unreal: An alternative approach to Local/Unreal channel optimization

2014-03-08 Thread Joshua Colp
. (Although, since channels stick around... when would you need to use /n? Hrm...) So, thoughts? [1] http://svn.digium.com/svn/asterisk/team/file/bridge_unreal/ -- Joshua Colp Digium, Inc. | Senior Software Developer 445 Jan Davis Drive NW - Huntsville, AL 35806 - US Check us out

Re: [asterisk-dev] [Code Review] 3178: media_formats: Moving of existing code around, implementation, and unit tests

2014-03-07 Thread Joshua Colp
throws a fit and it's because a container isn't getting initialized. Getting said container initialized requires beginning the hacking apart process. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 3283: pjsip_cli: Create pjsip show channel and pjsip show contact, and general cli code cleanup

2014-03-07 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3283/#review11132 --- Ship it! Ship It! - Joshua Colp On March 6, 2014, 9:51 p.m

Re: [asterisk-dev] [Code Review] 3234: media_formats: Initial channel driver conversion and application conversion

2014-03-07 Thread Joshua Colp
407953 /team/file/media_formats-impl/apps/app_amd.c 407953 /team/file/media_formats-impl/apps/app_alarmreceiver.c 407953 /team/file/media_formats-impl/apps/app_agent_pool.c 407953 Diff: https://reviewboard.asterisk.org/r/3234/diff/ Testing --- Thanks, Joshua Colp

Re: [asterisk-dev] [Code Review] 3266: media_formats: Move codecs over.

2014-03-07 Thread Joshua Colp
/codec_dahdi.c 407953 /team/file/media_formats-impl/codecs/codec_alaw.c 407953 /team/file/media_formats-impl/codecs/codec_adpcm.c 407954 /team/file/media_formats-impl/codecs/codec_a_mu.c 407953 Diff: https://reviewboard.asterisk.org/r/3266/diff/ Testing --- They compile, yay! Thanks, Joshua

Re: [asterisk-dev] [Code Review] 3265: media_formats: Move app_fax over

2014-03-07 Thread Joshua Colp
--- It compiles. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 3283: pjsip_cli: Create pjsip show channel and pjsip show contact, and general cli code cleanup

2014-03-06 Thread Joshua Colp
On March 6, 2014, 1:38 a.m., Matt Jordan wrote: branches/12/res/res_pjsip_endpoint_identifier_ip.c, lines 364-371 https://reviewboard.asterisk.org/r/3283/diff/1/?file=55030#file55030line364 Any reason you decided to move initialization of the members of the struct to load_module?

Re: [asterisk-dev] [Code Review] 3283: pjsip_cli: Create pjsip show channel and pjsip show contact, and general cli code cleanup

2014-03-06 Thread Joshua Colp
with other stuff, it may not be. Can't know. The set_extended usage has to go. Create a structure to contain additional information, put stuff in that, and pass it in. - Joshua Colp On March 3, 2014, 12:26 a.m., George Joseph wrote

Re: [asterisk-dev] [Code Review] 3305: Sorcery: Be lenient when extra realtime fields are retrieved.

2014-03-06 Thread Joshua Colp
/r/3305/#comment20740 Less RAII_VAR please. :P - Joshua Colp On March 5, 2014, 11:40 p.m., Mark Michelson wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3305

Re: [asterisk-dev] [Code Review] 3304: pjsip configuration: Make TOS values for transports consistent in behavior to TOS values in endpoints. Allow DSCP strings to be used for TOS configuration. Fix A

2014-03-06 Thread Joshua Colp
://reviewboard.asterisk.org/r/3304/#comment20741 Remove. - Joshua Colp On March 5, 2014, 8:19 p.m., Jonathan Rose wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3304

<    5   6   7   8   9   10   11   12   13   >