Re: [asterisk-dev] [Code Review] 3003: ARI: Add the ability to snoop (spy/whisper) on channels

2013-11-21 Thread Matt Jordan
. It may be worthwhile having an assert in here, or something that indicates that this should not have occurred - even if we do try to 'handle it gracefully'. - Matt Jordan On Nov. 12, 2013, 6:43 p.m., Joshua Colp wrote

Re: [asterisk-dev] [Code Review] 3003: ARI: Add the ability to snoop (spy/whisper) on channels

2013-11-21 Thread Matt Jordan
On Nov. 14, 2013, 4:53 p.m., Mark Michelson wrote: /branches/12/res/res_stasis_snoop.c, line 142 https://reviewboard.asterisk.org/r/3003/diff/3/?file=48153#file48153line142 Hm, would it be more useful to publish the snoop messages on the spyee channel's topic? I would suspect

Re: [asterisk-dev] [Code Review] 3020: Test for consistent from tag on outbound REGISTER

2013-11-21 Thread Matt Jordan
/outbound_reregister_from/sipp/register.xml https://reviewboard.asterisk.org/r/3020/#comment19584 And here /asterisk/trunk/tests/channels/SIP/outbound_reregister_from/sipp/register.xml https://reviewboard.asterisk.org/r/3020/#comment19583 Here too - Matt Jordan On Nov. 15, 2013, 9:42

Re: [asterisk-dev] [Code Review] 3003: ARI: Add the ability to snoop (spy/whisper) on channels

2013-11-22 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3003/#review10263 --- Ship it! Ship It! - Matt Jordan On Nov. 22, 2013, 5:20 p.m

Re: [asterisk-dev] [Code Review] 3026: ari: Add playback and recording events.

2013-11-22 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3026/#review10264 --- Ship it! Ship It! - Matt Jordan On Nov. 22, 2013, 5:54 p.m

Re: [asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events

2013-11-22 Thread Matt Jordan
/#comment19610 Is there any reason why we aren't exporting all ast_sip* symbols? branches/12/res/res_pjsip_pubsub.c https://reviewboard.asterisk.org/r/2959/#comment19611 Blobs - Matt Jordan On Nov. 15, 2013, 7:58 p.m., Kevin Harwell wrote

Re: [asterisk-dev] [Code Review] 3025: ARI: Implement device state API

2013-11-22 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3025/#review10266 --- Ship it! Ship It! - Matt Jordan On Nov. 22, 2013, 7:36 p.m

Re: [asterisk-dev] [Code Review] 2959: pjsip: AMI commands and events

2013-11-22 Thread Matt Jordan
shipping this in. - Matt Jordan On Nov. 15, 2013, 7:58 p.m., Kevin Harwell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2959

Re: [asterisk-dev] [Code Review] 3028: ari: Add 'number', 'digits', and 'characters' URI scheme playback implementations

2013-11-24 Thread Matt Jordan
On Nov. 23, 2013, 5:38 p.m., Paul Belanger wrote: Wouldn't this be the same path as /dial? I know asterisk has native functionality to play numbers however, feel like libraries on top of ARI could handle this. /me shrugs. Joshua Colp wrote: To play numbers in various languages

Re: [asterisk-dev] [Code Review] 3023: Add MixMonitor() option to specify channel variable into which to store the recording filename

2013-11-25 Thread Matt Jordan
On Nov. 21, 2013, 4:40 p.m., Tilghman Lesher wrote: Shouldn't something like this be a channel function from which you retrieve the value, instead of specifying a variable into which the name is placed? Seems like a significant regression in spitting things out to channel variables,

Re: [asterisk-dev] [Code Review] 3007: ARI: Snoop tests

2013-11-26 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3007/#review10279 --- Ship it! Ship It! - Matt Jordan On Nov. 16, 2013, 4:47 p.m

Re: [asterisk-dev] [Code Review] 3021: Testsuite: Test that DIRECTORY_RESULT is set to the expected value under a set of test cases

2013-11-26 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3021/#review10280 --- Ship it! Ship It! - Matt Jordan On Nov. 20, 2013, 11:01

Re: [asterisk-dev] [Code Review] 3018: testsuite: Add tests for Say application jump behavior with SAY_DTMF_INTERRUPT enabled and disabled

2013-11-26 Thread Matt Jordan
hangups on these as well. /asterisk/trunk/tests/apps/say_interrupt/test-config.yaml https://reviewboard.asterisk.org/r/3018/#comment19645 While it works just fine, I don't think you need to shout LOCAL. Local is just fine :-) - Matt Jordan On Nov. 15, 2013, 12:07 a.m., Jonathan Rose wrote

Re: [asterisk-dev] [Code Review] 3024: Testsuite: Test the MixMonitor 'f' option

2013-11-26 Thread Matt Jordan
On Nov. 21, 2013, 3:38 p.m., Joshua Colp wrote: I don't see where the user event is actually checked... shouldn't you have specified the requirement of a Yay event in your test-config.yaml? Mark Michelson wrote: Nope, SimpleTestCase determines pass/fail based solely on the number

Re: [asterisk-dev] [Code Review] 3028: ari: Add 'number', 'digits', and 'characters' URI scheme playback implementations

2013-11-26 Thread Matt Jordan
/#comment19656 I'd throw out an error here as well, at least to the CLI - %s not a valid number , etc. - Matt Jordan On Nov. 23, 2013, 2:35 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit

Re: [asterisk-dev] [Code Review] 3023: Add MixMonitor() option to specify channel variable into which to store the recording filename

2013-11-26 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3023/#review10284 --- Ship it! Ship It! - Matt Jordan On Nov. 26, 2013, 5:07 p.m

Re: [asterisk-dev] [Code Review] 2994: ari:Add application/json parameter support

2013-11-26 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2994/#review10286 --- Ship it! Ship It! - Matt Jordan On Nov. 21, 2013, 8:47 p.m

Re: [asterisk-dev] [Code Review] 3032: Testsuite: ARI device state

2013-11-27 Thread Matt Jordan
to 'subscribe-device-state' - Matt Jordan On Nov. 25, 2013, 6 p.m., Kevin Harwell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3032

Re: [asterisk-dev] [Code Review] 2958: Testsuite - pjsip: AMI commands and events

2013-11-27 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/2958/#review10293 --- Ship it! Ship It! - Matt Jordan On Nov. 25, 2013, 6:31 p.m

[asterisk-dev] [Code Review] 3035: Add a function PJSIP_ENDPOINT to retrieve endpoint configuration details from the dialplan

2013-11-27 Thread Matt Jordan
/appdocsxml.xslt PRE-CREATION /branches/12/doc/appdocsxml.dtd 403234 /branches/12/Makefile 403234 Diff: https://reviewboard.asterisk.org/r/3035/diff/ Testing --- Testsuite test written and available here: https://reviewboard.asterisk.org/r/3034/ Thanks, Matt Jordan

[asterisk-dev] [Code Review] 3034: Tests for PJSIP_ENDPOINT

2013-11-27 Thread Matt Jordan
-CREATION Diff: https://reviewboard.asterisk.org/r/3034/diff/ Testing --- Thanks, Matt Jordan -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

Re: [asterisk-dev] [Code Review] 3036: res_pjsip_transport_websocket: Fix crash with security events and improve implementation

2013-11-29 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3036/#review10294 --- Ship it! Ship It! - Matt Jordan On Nov. 28, 2013, 9:16 p.m

[asterisk-dev] [Code Review] 3038: Add CHANNEL function support for PJSIP

2013-12-01 Thread Matt Jordan
://reviewboard.asterisk.org/r/3038/diff/ Testing --- See https://reviewboard.asterisk.org/r/3037 Thanks, Matt Jordan -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

[asterisk-dev] [Code Review] 3037: Add tests for CHANNEL function for PJSIP

2013-12-01 Thread Matt Jordan
://reviewboard.asterisk.org/r/3037/diff/ Testing --- Thanks, Matt Jordan -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 3055: pbx.c: add lock around ast_exten use to prevent memory corruption

2013-12-07 Thread Matt Jordan
and the values extracted in this function, or pbx_substitute_variables should be responsible for unlocking the contexts lock before calling the variable substiution function. - Matt Jordan On Dec. 6, 2013, 10:44 p.m., Scott Griepentrog wrote

Re: [asterisk-dev] [Code Review] 3046: framehooks: Re-iterate when frame is changed

2013-12-07 Thread Matt Jordan
that they don't otherwise consume. - Matt Jordan On Dec. 5, 2013, 5:20 p.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3046

Re: [asterisk-dev] [Code Review] 3027: Valgrind support in TestSuite

2013-12-08 Thread Matt Jordan
to detect/find errors can't really be reviewed until this gets finalized. - Matt Jordan On Nov. 25, 2013, 11:10 p.m., Scott Griepentrog wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 3032: Testsuite: ARI device state

2013-12-08 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3032/#review10333 --- Ship it! Ship It! - Matt Jordan On Dec. 2, 2013, 5:35 p.m

[asterisk-dev] [Code Review] 3057: CDRs: Synchronize dialplan access through Stasis; clean up Answer and DISA

2013-12-08 Thread Matt Jordan
/branches/12/UPGRADE.txt 403448 /branches/12/CHANGES 403448 Diff: https://reviewboard.asterisk.org/r/3057/diff/ Testing --- * The CDR tests pass (now deterministicly) * The hangup handler tests now pass, as they can get reliable values in the h extension from the CDR engine Thanks, Matt

Re: [asterisk-dev] [Code Review] 3048: PJSIP: Add T.38 fax tests

2013-12-08 Thread Matt Jordan
. /asterisk/trunk/tests/fax/tests.yaml https://reviewboard.asterisk.org/r/3048/#comment19730 While you're here (and when you've committed this), go ahead and throw the existing chan_sip based tests under a 'sip' directory. - Matt Jordan On Dec. 5, 2013, 5:24 p.m., Joshua Colp wrote

Re: [asterisk-dev] [Code Review] 3046: framehooks: Re-iterate when frame is changed

2013-12-08 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3046/#review10334 --- Ship it! Ship It! - Matt Jordan On Dec. 9, 2013, 1:27 a.m

Re: [asterisk-dev] [Code Review] 3046: framehooks: Re-iterate when frame is changed

2013-12-09 Thread Matt Jordan
On Dec. 9, 2013, 8:02 p.m., Mark Michelson wrote: The loop situation Matt described is possible. When ast_channel_suppress() is called, it results in AST_FRAME_VOICE being turned into AST_FRAME_NULL. If there is a jitter buffer on a channel, then AST_FRAME_NULL gets turned into

Re: [asterisk-dev] [Code Review] 3055: pbx.c: add lock around ast_exten use to prevent memory corruption

2013-12-09 Thread Matt Jordan
On Dec. 7, 2013, 3:48 p.m., Matt Jordan wrote: /branches/1.8/main/pbx.c, lines 4477-4491 https://reviewboard.asterisk.org/r/3055/diff/4/?file=49180#file49180line4477 I don't think we need the extra lock here. The purpose of the contexts lock is to prevent changes

Re: [asterisk-dev] [Code Review] 3035: Add a function PJSIP_ENDPOINT to retrieve endpoint configuration details from the dialplan

2013-12-09 Thread Matt Jordan
and available here: https://reviewboard.asterisk.org/r/3034/ Thanks, Matt Jordan -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 3038: Add CHANNEL function support for PJSIP

2013-12-09 Thread Matt Jordan
handy. - Matt --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3038/#review10299 --- On Dec. 1, 2013, 2:08 p.m., Matt Jordan wrote

Re: [asterisk-dev] [Code Review] 3038: Add CHANNEL function support for PJSIP

2013-12-09 Thread Matt Jordan
/branches/12/channels/pjsip/dialplan_functions.c PRE-CREATION /branches/12/channels/chan_pjsip.c 403470 /branches/12/channels/Makefile 403470 Diff: https://reviewboard.asterisk.org/r/3038/diff/ Testing --- See https://reviewboard.asterisk.org/r/3037 Thanks, Matt Jordan

Re: [asterisk-dev] [Code Review] 3052: ARI: Allow specifying channel variables during a POST /channels

2013-12-09 Thread Matt Jordan
://reviewboard.asterisk.org/r/3052/#comment19754 Since nothing else calls get_content_type, you don't really need this function. You could have is_content_type be get_content_type. - Matt Jordan On Dec. 5, 2013, 10:42 p.m., Kevin Harwell wrote

Re: [asterisk-dev] [Code Review] 3038: Add CHANNEL function support for PJSIP

2013-12-10 Thread Matt Jordan
On Dec. 4, 2013, 9:02 p.m., Mark Michelson wrote: /branches/12/channels/pjsip/dialplan_functions.c, lines 316-327 https://reviewboard.asterisk.org/r/3038/diff/1/?file=48949#file48949line316 These descriptions are inaccurate when used on outgoing channels. Matt Jordan wrote

Re: [asterisk-dev] [Code Review] 3057: CDRs: Synchronize dialplan access through Stasis; clean up Answer and DISA

2013-12-10 Thread Matt Jordan
. To reply, visit: https://reviewboard.asterisk.org/r/3057/#review10352 --- On Dec. 10, 2013, 4:48 p.m., Matt Jordan wrote: --- This is an automatically generated e-mail. To reply, visit

Re: [asterisk-dev] [Code Review] 3057: CDRs: Synchronize dialplan access through Stasis; clean up Answer and DISA

2013-12-10 Thread Matt Jordan
pass, as they can get reliable values in the h extension from the CDR engine Thanks, Matt Jordan -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

Re: [asterisk-dev] [Code Review] 3061: External MWI core support with AMI using it.

2013-12-10 Thread Matt Jordan
the mailbox. It should still just be a string unique ID. This design flaw has a ripple effect through this entire patch - but until we resolve this fundamental problem, I'm not sure I'd look at this patch any further. - Matt Jordan On Dec. 9, 2013, 9:51 p.m., rmudgett wrote

Re: [asterisk-dev] [Code Review] 3060: pjsip tests: interactions with chan_sip cause test failures

2013-12-10 Thread Matt Jordan
, and chan_console. I'm pretty sure all of the old console tests no longer use chan_console. - Matt Jordan On Dec. 9, 2013, 10:52 p.m., Kevin Harwell wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 3038: Add CHANNEL function support for PJSIP

2013-12-10 Thread Matt Jordan
--- On Dec. 10, 2013, 3:51 a.m., Matt Jordan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3038

Re: [asterisk-dev] [Code Review] 3035: Add a function PJSIP_ENDPOINT to retrieve endpoint configuration details from the dialplan

2013-12-10 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3035/#review10375 --- On Dec. 10, 2013, 2:34 a.m., Matt Jordan wrote

Re: [asterisk-dev] [Code Review] 3055: pbx.c: put copy of ast_exten.data on stack to prevent memory corruption

2013-12-10 Thread Matt Jordan
*e_data = NULL; ... if (!ast_strlen_zero(e-data)) { *passdata = '\0'; } else { e_data = ast_strdupa(e-data); } ast_unlock_contexts(); if (!ast_strlen_zero(e_data)) { pbx_substitute_variables(...); } etc. - Matt Jordan On Dec

Re: [asterisk-dev] [Code Review] 3035: Add a function PJSIP_ENDPOINT to retrieve endpoint configuration details from the dialplan

2013-12-11 Thread Matt Jordan
and available here: https://reviewboard.asterisk.org/r/3034/ Thanks, Matt Jordan -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 3034: Tests for PJSIP_ENDPOINT

2013-12-11 Thread Matt Jordan
/trunk/tests/channels/pjsip/dialplan_functions/pjsip_endpoint/configs/ast1/extensions.conf PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3034/diff/ Testing --- Thanks, Matt Jordan -- _ -- Bandwidth and Colocation

Re: [asterisk-dev] [Code Review] 3037: Add tests for CHANNEL function for PJSIP

2013-12-11 Thread Matt Jordan
/dialplan_functions/pjsip_channel/configs/ast1/extensions.conf PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3037/diff/ Testing --- Thanks, Matt Jordan -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 3038: Add CHANNEL function support for PJSIP

2013-12-11 Thread Matt Jordan
/chan_pjsip.c 403470 /branches/12/channels/Makefile 403470 Diff: https://reviewboard.asterisk.org/r/3038/diff/ Testing --- See https://reviewboard.asterisk.org/r/3037 Thanks, Matt Jordan -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3064: realtime: Create extensions in alembic ast-db-manage contribution

2013-12-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3064/#review10381 --- Ship it! Ship It! - Matt Jordan On Dec. 10, 2013, 5:21 p.m

Re: [asterisk-dev] [Code Review] 3065: Reset peer outboundproxy on sip.conf reload

2013-12-11 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3065/#review10384 --- Ship it! Ship It! - Matt Jordan On Dec. 11, 2013, 12:16

[asterisk-dev] [Code Review] 3068: ARI: provide a default format capability to channels that are created

2013-12-12 Thread Matt Jordan
this patch: bad audio, bad performance. With this patch: acceptable performance/audio. Thanks, Matt Jordan -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE

Re: [asterisk-dev] [Code Review] 3057: CDRs: Synchronize dialplan access through Stasis; clean up Answer and DISA

2013-12-12 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3057/#review10394 --- On Dec. 10, 2013, 10:48 a.m., Matt Jordan wrote

Re: [asterisk-dev] [Code Review] 3057: CDRs: Synchronize dialplan access through Stasis; clean up Answer and DISA

2013-12-12 Thread Matt Jordan
now pass, as they can get reliable values in the h extension from the CDR engine Thanks, Matt Jordan -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

Re: [asterisk-dev] [Code Review] 3057: CDRs: Synchronize dialplan access through Stasis; clean up Answer and DISA

2013-12-12 Thread Matt Jordan
On Dec. 12, 2013, 11:48 a.m., opticron wrote: /branches/12/funcs/func_cdr.c, lines 472-474 https://reviewboard.asterisk.org/r/3057/diff/2/?file=49301#file49301line472 Return and reduce indentation. Matt Jordan wrote: Normally I'd agree, but that approach has one drawback

Re: [asterisk-dev] [Code Review] 3057: CDRs: Synchronize dialplan access through Stasis; clean up Answer and DISA

2013-12-12 Thread Matt Jordan
On Dec. 12, 2013, 11:48 a.m., opticron wrote: /branches/12/funcs/func_cdr.c, lines 472-474 https://reviewboard.asterisk.org/r/3057/diff/2/?file=49301#file49301line472 Return and reduce indentation. Matt Jordan wrote: Normally I'd agree, but that approach has one drawback

Re: [asterisk-dev] [Code Review] 3071: Testsuite: Check CEL Extra fields in an order-agnostic way

2013-12-13 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3071/#review10414 --- Ship it! Ship It! - Matt Jordan On Dec. 13, 2013, 12:50

Re: [asterisk-dev] [Code Review] 3069: Fix deadlock experienced during multi-party PJSIP transfer through masquerade rework

2013-12-13 Thread Matt Jordan
://reviewboard.asterisk.org/r/3069/ --- (Updated Dec. 12, 2013, 3:59 p.m.) Review request for Asterisk Developers, Joshua Colp, Jonathan Rose, Matt Jordan, and rmudgett. Bugs: ASTERISK-22936 https://issues.asterisk.org/jira/browse/ASTERISK

Re: [asterisk-dev] [Code Review] 3055: pbx.c: put copy of ast_exten.data on stack to prevent memory corruption

2013-12-16 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3055/#review10419 --- Ship it! Ship It! - Matt Jordan On Dec. 11, 2013, 9:31 a.m

Re: [asterisk-dev] [Code Review] 3074: Fix old regression where config.c unescapes semicolons in embedded values in extensions.conf.

2013-12-16 Thread Matt Jordan
there are no other escaped characters that have special meaning in config files. I'm not sure we want to go crazy here, but ideally we would have a way to re-write out a '\' when we write out the config. - Matt Jordan On Dec. 16, 2013, 7:18 p.m., George Joseph wrote

Re: [asterisk-dev] [Code Review] 3067: channels: Return channel locked when allocating.

2013-12-16 Thread Matt Jordan
/r/3067/#comment19887 I think a comment here stating that the locking inversion is okay here, as no other thread can obtain the channel prior to linking it into the channels container. Normally, this would be a big ol' red flag :-) - Matt Jordan On Dec. 12, 2013, 11:43 a.m

Re: [asterisk-dev] [Code Review] 3067: channels: Return channel locked when allocating.

2013-12-16 Thread Matt Jordan
there - we ran into it only through some seriously aggressive use of channel redirect. We should also probably put a \since 12.0.0 before the \note you've added that the channel is returned locked. - Matt Jordan On Dec. 12, 2013, 11:43 a.m., Joshua Colp wrote

Re: [asterisk-dev] [Code Review] 3073: chan_sip+CEL: Add missing ANSWER and PICKUP events to INVITE/w/replaces pickup

2013-12-16 Thread Matt Jordan
after all) - Matt Jordan On Dec. 16, 2013, 3:26 a.m., wdoekes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3073

Re: [asterisk-dev] [Code Review] 3068: ARI: provide a default format capability to channels that are created

2013-12-17 Thread Matt Jordan
/resource_channels.c 403703 Diff: https://reviewboard.asterisk.org/r/3068/diff/ Testing --- Without this patch: bad audio, bad performance. With this patch: acceptable performance/audio. Thanks, Matt Jordan -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3075: Add support for Lua 5.2

2013-12-17 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3075/#review10441 --- Ship it! Ship It! - Matt Jordan On Dec. 17, 2013, 4:13 p.m

Re: [asterisk-dev] [Code Review] 3072: Voicemail: Remove mailbox identifier format (box@context) assumptions in the system.

2013-12-17 Thread Matt Jordan
This change should be documented in CHANGES/UPGRADE as well - Matt Jordan On Dec. 13, 2013, 5:45 p.m., rmudgett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3072

Re: [asterisk-dev] [Code Review] 3048: PJSIP: Add T.38 fax tests

2013-12-17 Thread Matt Jordan
) /asterisk/trunk/tests/fax/pjsip/t38/run-test https://reviewboard.asterisk.org/r/3048/#comment19911 Blob - Matt Jordan On Dec. 11, 2013, 6:33 a.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 3072: Voicemail: Remove mailbox identifier format (box@context) assumptions in the system.

2013-12-18 Thread Matt Jordan
://reviewboard.asterisk.org/r/3072/#comment19925 For formatting consistency, add a line of '' below VMCOUNT. - Matt Jordan On Dec. 18, 2013, 12:51 p.m., rmudgett wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 3057: CDRs: Synchronize dialplan access through Stasis; clean up Answer and DISA

2013-12-18 Thread Matt Jordan
now pass, as they can get reliable values in the h extension from the CDR engine Thanks, Matt Jordan -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update

Re: [asterisk-dev] [Code Review] 3079: udptl: Dead code elimination. ast_udptl_bridge not used.

2013-12-19 Thread Matt Jordan
On Dec. 19, 2013, 9:10 a.m., opticron wrote: Ship It! Well, hold on. Don't Ship It! just yet. :-) The fact that this isn't called in Asterisk 1.8 doesn't mean it shouldn't be called - it just means someone, at some point in time, fixed the glitch. If we aren't calling this function, then

Re: [asterisk-dev] [Code Review] 3081: security_events: log events with descriptive names

2013-12-19 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3081/#review10465 --- Ship it! Ship It! - Matt Jordan On Dec. 19, 2013, 2:06 p.m

Re: [asterisk-dev] [Code Review] 3082: say: correct time for polish

2013-12-19 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3082/#review10466 --- Ship it! Ship It! - Matt Jordan On Dec. 19, 2013, 2:04 p.m

Re: [asterisk-dev] [Code Review] 3086: pjsip.conf.sample update: improve documentation of pjsip endpoints behind NAT and update for snake case change

2013-12-19 Thread Matt Jordan
external links. branches/12/configs/pjsip.conf.sample https://reviewboard.asterisk.org/r/3086/#comment19938 May as well align the comment with the others - Matt Jordan On Dec. 19, 2013, 6:18 p.m., rnewton wrote

Re: [asterisk-dev] [Code Review] 3043: pjsip: CLI commands

2013-12-19 Thread Matt Jordan
res_pjsip_endpoint_identifier_ip.h and the exports file. - Matt Jordan On Dec. 19, 2013, 9:04 p.m., George Joseph wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3043

Re: [asterisk-dev] [Code Review] 3084: testsuite: Insure core waitfullybooted command has completed succesfully

2013-12-20 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3084/#review10473 --- Ship it! Ship It! - Matt Jordan On Dec. 19, 2013, 3 p.m

Re: [asterisk-dev] [Code Review] 3086: pjsip.conf.sample update: improve documentation of pjsip endpoints behind NAT and update for snake case change

2013-12-20 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3086/#review10475 --- Ship it! Ship It! - Matt Jordan On Dec. 20, 2013, 9:28 a.m

Re: [asterisk-dev] [Code Review] 3087: Mini-audit of the ao2_iterator loops in the new code files.

2013-12-20 Thread Matt Jordan
expected lifetime. I personally dislike this use of RAII_VAR - it's wasteful in its processing and it takes careful looking to understand that its cleaning up after the bump from ao2_iterator_next; but at least we're not mixing it with the for loop now. - Matt Jordan On Dec. 20, 2013, 1

Re: [asterisk-dev] [Code Review] 3088: ari: Remove support for specifying channel vars during origination.

2013-12-20 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3088/#review10487 --- Ship it! Ship It! - Matt Jordan On Dec. 20, 2013, 3:50 p.m

[asterisk-dev] [Code Review] 3099: CDRs and Stasis take 2: Synchronize publication of application CDR messages to the CDR engine subscription

2013-12-31 Thread Matt Jordan
. All CDR and hangup handler test in the test suite now pass. Previously, the hangup handler tests would fail due to getting wrong data back from the CDR engine when reading a value using the CDR function. Thanks, Matt Jordan

Re: [asterisk-dev] [Code Review] 3095: chan_pjsip: add 'set_var' support on endpoints

2013-12-31 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3095/#review10496 --- Ship it! Ship It! - Matt Jordan On Dec. 27, 2013, 5:28 p.m

Re: [asterisk-dev] [Code Review] 3095: chan_pjsip: add 'set_var' support on endpoints

2013-12-31 Thread Matt Jordan
or 512. - Matt Jordan On Dec. 27, 2013, 5:28 p.m., Kevin Harwell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3095

Re: [asterisk-dev] [Code Review] 3097: Testsuite - chan_pjsip: add 'set_var' support on endpoints

2013-12-31 Thread Matt Jordan
. - Matt Jordan On Dec. 30, 2013, 3:26 p.m., Kevin Harwell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3097

Re: [asterisk-dev] [Code Review] 3097: Testsuite - chan_pjsip: add 'set_var' support on endpoints

2013-12-31 Thread Matt Jordan
file with the enhancement. - Matt Jordan On Dec. 30, 2013, 3:26 p.m., Kevin Harwell wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3097

Re: [asterisk-dev] [Code Review] 3062: a systemd service

2013-12-31 Thread Matt Jordan
to have that here as well. - Matt Jordan On Dec. 24, 2013, 10:49 a.m., Tzafrir Cohen wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3062

[asterisk-dev] [Code Review] 3107: chan_sip: Prevent orphaned channel during a failed SIP transfer to Park

2014-01-07 Thread Matt Jordan
. This is not a bug in 12+. Diffs - /branches/11/channels/chan_sip.c 404856 Diff: https://reviewboard.asterisk.org/r/3107/diff/ Testing --- Prior to the patch, the channels were stuck. With the patch, the two channels are properly hung up. Thanks, Matt Jordan

[asterisk-dev] [Code Review] 3108: confbridge: Prevent race condition leading to crash in state transitions during bridge announcement in MULTI_MARKED state

2014-01-07 Thread Matt Jordan
: Explosions. With the patch: Asterisk allowed the users to be kicked without terminating itself. Note that the tests will be posted under a separate review. Thanks, Matt Jordan -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 3107: chan_sip: Prevent orphaned channel during a failed SIP transfer to Park

2014-01-08 Thread Matt Jordan
. With the patch, the two channels are properly hung up. Thanks, Matt Jordan -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 3099: CDRs and Stasis take 2: Synchronize publication of application CDR messages to the CDR engine subscription

2014-01-09 Thread Matt Jordan
, 2013, 1:24 p.m., Matt Jordan wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3099/ --- (Updated Dec. 31, 2013, 1:24 p.m

Re: [asterisk-dev] [Code Review] 3099: CDRs and Stasis take 2: Synchronize publication of application CDR messages to the CDR engine subscription

2014-01-09 Thread Matt Jordan
. Thanks, Matt Jordan -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3089: Presenting AO2_ITERATOR_SAFE_LOOP_START() for ao2_iterator looping safety.

2014-01-09 Thread Matt Jordan
On Jan. 3, 2014, 11:12 a.m., Mark Michelson wrote: So...I just don't really like this. 1) Making a macro like this makes the code more esoteric than it previously was. 2) The fact that the loop_obj has to be NULLed out before breaking or returning from the loop if no reference

Re: [asterisk-dev] [Code Review] 3108: confbridge: Prevent race condition leading to crash in state transitions during bridge announcement in MULTI_MARKED state

2014-01-09 Thread Matt Jordan
--- An automated test was written that reproduced the scenario. Without the patch: Explosions. With the patch: Asterisk allowed the users to be kicked without terminating itself. Note that the tests will be posted under a separate review. Thanks, Matt Jordan

Re: [asterisk-dev] [Code Review] 3112: wideband streaming with res_musiconhold

2014-01-09 Thread Matt Jordan
that MoH will now support wide band audio. Nice work! - Matt Jordan On Jan. 9, 2014, 8:50 a.m., wdoekes wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3112

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

2014-01-09 Thread Matt Jordan
on the description of pjsip_tx_data_invalidate_msg, I would suspect we only need to call this once before returning. Do we need to call it for each change we make to tdata? - Matt Jordan On Jan. 6, 2014, 2:06 p.m., Joshua Colp wrote

Re: [asterisk-dev] [Code Review] 3102: res_pjsip_multihomed: Add multihomed support

2014-01-09 Thread Matt Jordan
On Jan. 7, 2014, 3:29 a.m., Olle E Johansson wrote: Please also check the sender IP address in the IP packet. That's where things go wrong with chan_sip. Thanks. Olle - just so I understand your comment, are you referring to what would happen if the sender was behind a NAT? - Matt

Re: [asterisk-dev] [Code Review] 3093: res_pjsip_dialog_info: Add dialog-info+xml presence functionality.

2014-01-09 Thread Matt Jordan
On Jan. 9, 2014, 2:11 p.m., opticron wrote: /branches/12/res/res_pjsip_dialog_info.c, line 109 https://reviewboard.asterisk.org/r/3093/diff/2/?file=51127#file51127line109 dialog-info+xml seems to get used quite a bit in this file. Put this in a #define or a static variable. I'd

Re: [asterisk-dev] [Code Review] 3114: verbosity: Fix performance of console verbose messages.

2014-01-09 Thread Matt Jordan
as much editing. Plus it makes this look like the rest of our code, which is nice. - Matt Jordan On Jan. 9, 2014, 1:30 p.m., rmudgett wrote: --- This is an automatically generated e-mail. To reply, visit: https

Re: [asterisk-dev] [Code Review] 3099: CDRs and Stasis take 2: Synchronize publication of application CDR messages to the CDR engine subscription

2014-01-09 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3099/#review10549 --- On Jan. 9, 2014, 9:16 a.m., Matt Jordan wrote

Re: [asterisk-dev] [Code Review] 3099: CDRs and Stasis take 2: Synchronize publication of application CDR messages to the CDR engine subscription

2014-01-09 Thread Matt Jordan
. Thanks, Matt Jordan -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3116: chan_sip: eliminate channel state down prior to hangup

2014-01-09 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3116/#review10557 --- Ship it! Ship It! - Matt Jordan On Jan. 9, 2014, 5:07 p.m

Re: [asterisk-dev] [Code Review] 3105: Testsuite: Test PJSIP hold and unhold for various conditions for INVITE SDPs

2014-01-09 Thread Matt Jordan
called when Asterisk is started/stopped. - Matt Jordan On Jan. 6, 2014, 3:59 p.m., Jonathan Rose wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3105

  1   2   3   4   5   6   7   8   9   10   >