Re: [asterisk-dev] [Code Review] 4470: Testsuite: Generate UserEvent upon PJsua phones being ready.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4470/ --- (Updated March 13, 2015, 10:43 a.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers and Mark Michelson. Changes --- Committed in revision 6523 Repository: testsuite Description --- The test that has been modified on this review would sometimes fail due to the PJsua phone not being ready to receive calls even though it had registered to Asterisk. The changes here resolve the issue by generating a UserEvent on all AMI connections when all PJsua phones are ready. Originating calls to the PJsua phones is now triggered by the 'PJsuaPhonesReady' UserEvent instead of the registration event. Diffs - /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/test-config.yaml 6506 /asterisk/trunk/sample-yaml/phones-config.yaml.sample PRE-CREATION /asterisk/trunk/lib/python/asterisk/phones.py 6506 Diff: https://reviewboard.asterisk.org/r/4470/diff/ Testing --- * Executed each test successfully 50+ times on local system and build agent where the test would sometimes fail. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] [Code Review] 4470: Testsuite: Generate UserEvent upon PJsua phones being ready.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4470/ --- Review request for Asterisk Developers and Mark Michelson. Repository: testsuite Description --- The test that has been modified on this review would sometimes fail due to the PJsua phone not being ready to receive calls even though it had registered to Asterisk. The changes here resolve the issue by generating a UserEvent on all AMI connections when all PJsua phones are ready. Originating calls to the PJsua phones is now triggered by the 'PJsuaPhonesReady' UserEvent instead of the registration event. Diffs - /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/test-config.yaml 6506 /asterisk/trunk/lib/python/asterisk/phones.py 6506 Diff: https://reviewboard.asterisk.org/r/4470/diff/ Testing --- * Executed each test successfully 50+ times on local system and build agent where the test would sometimes fail. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4452: Testsuite: ARI channel subscription tests
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4452/ --- (Updated March 6, 2015, 1:45 p.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers. Changes --- Committed in revision 6491 Bugs: ASTERISK-24586 https://issues.asterisk.org/jira/browse/ASTERISK-24586 Repository: testsuite Description --- This adds some local and non-local channel subscription tests for ARI. These tests ensure ARI events occur and/or don't occur for the appropriate stasis app(s). Due to the variations and small differences of these, the test-config.yaml descriptions of each is the best way to describe what they do. Four tests have been added under 'tests/rest_api/applications/channel-subscriptions/'. : * originate_to_dialplan/non_local_channels - Similiar to the existing test that this patch modifies as mentioned below. This required modifying pjsua_mod.py to allow more calls. * originate_to_other_stasis_app/local_channels - Creates two websockets, one for for each stasis app. Originates a local channel from AppA where half is sent into AppB and the other half send into the dialplan. * originate_to_other_stasis_app/non_local_channels - Creates two websockets, one for for each stasis app. Originates a PJSIP channel from AppA to a pjsua phone where is is placed into AppB. * originate_to_stasis_app/local_channels Note: The test 'tests/rest_api/applications/subscribe-channel' test has been renamed to 'basic-subscribe' under the same location as the new tests. The following test has been modified to ensure no ARI events are received: * tests/rest_api/channels/originate_to_dialplan Diffs - /asterisk/trunk/tests/rest_api/channels/originate_to_dialplan/test-config.yaml 6475 /asterisk/trunk/tests/rest_api/applications/tests.yaml 6475 /asterisk/trunk/tests/rest_api/applications/subscribe-channel/test-config.yaml 6475 /asterisk/trunk/tests/rest_api/applications/subscribe-channel/subscribe_channel.py 6475 /asterisk/trunk/tests/rest_api/applications/subscribe-channel/configs/ast1/extensions.conf 6475 /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/local_channels/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/local_channels/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/run-test PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/configs/ast1/http.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/run-test PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/configs/ast1/http.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 6475 Diff: https://reviewboard.asterisk.org/r/4452/diff/ Testing --- * Executed each test successfully 30+ times. * Changed the code to force a failure to ensure tests properly failed. * Review logs to ensure operation is as expected. Thanks, jbigelow
Re: [asterisk-dev] [Code Review] 4452: Testsuite: ARI channel subscription tests
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4452/ --- (Updated March 5, 2015, 8:55 p.m.) Review request for Asterisk Developers. Changes --- Forgot 'Keyword Arguments:' in the docstring/ Bugs: ASTERISK-24586 https://issues.asterisk.org/jira/browse/ASTERISK-24586 Repository: testsuite Description --- This adds some local and non-local channel subscription tests for ARI. These tests ensure ARI events occur and/or don't occur for the appropriate stasis app(s). Due to the variations and small differences of these, the test-config.yaml descriptions of each is the best way to describe what they do. Four tests have been added under 'tests/rest_api/applications/channel-subscriptions/'. : * originate_to_dialplan/non_local_channels - Similiar to the existing test that this patch modifies as mentioned below. This required modifying pjsua_mod.py to allow more calls. * originate_to_other_stasis_app/local_channels - Creates two websockets, one for for each stasis app. Originates a local channel from AppA where half is sent into AppB and the other half send into the dialplan. * originate_to_other_stasis_app/non_local_channels - Creates two websockets, one for for each stasis app. Originates a PJSIP channel from AppA to a pjsua phone where is is placed into AppB. * originate_to_stasis_app/local_channels Note: The test 'tests/rest_api/applications/subscribe-channel' test has been renamed to 'basic-subscribe' under the same location as the new tests. The following test has been modified to ensure no ARI events are received: * tests/rest_api/channels/originate_to_dialplan Diffs (updated) - /asterisk/trunk/tests/rest_api/channels/originate_to_dialplan/test-config.yaml 6475 /asterisk/trunk/tests/rest_api/applications/tests.yaml 6475 /asterisk/trunk/tests/rest_api/applications/subscribe-channel/test-config.yaml 6475 /asterisk/trunk/tests/rest_api/applications/subscribe-channel/subscribe_channel.py 6475 /asterisk/trunk/tests/rest_api/applications/subscribe-channel/configs/ast1/extensions.conf 6475 /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/local_channels/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/local_channels/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/run-test PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/configs/ast1/http.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/run-test PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/configs/ast1/http.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 6475 Diff: https://reviewboard.asterisk.org/r/4452/diff/ Testing --- * Executed each test successfully 30+ times. * Changed the code to force a failure to ensure tests properly failed. * Review logs to ensure operation is as expected. Thanks, jbigelow
Re: [asterisk-dev] [Code Review] 4452: Testsuite: ARI channel subscription tests
On March 5, 2015, 1:53 p.m., Ashley Sanders wrote: /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/test-config.yaml, line 5 https://reviewboard.asterisk.org/r/4452/diff/2/?file=71751#file71751line5 You are missing the description for the Extension, Priority, Label, Context case. That is covered by this on line 13: * All of the above repeated, this time specifying a context. On March 5, 2015, 1:53 p.m., Ashley Sanders wrote: /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/run-test, line 173 https://reviewboard.asterisk.org/r/4452/diff/2/?file=71759#file71759line173 I think I would rework this to either use this structure (which is used throughout this file), or the self.orig_dst_app and self.orig_src_app variables. From what I can tell, this is redundant. Yea it could be redundant but I specifically did it this way so that it's easier to understand what specifically the test is doing and easier to just specify the apps and the src/dst apps as in different combinations if ever reused. On March 5, 2015, 1:53 p.m., Ashley Sanders wrote: /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/run-test, line 174 https://reviewboard.asterisk.org/r/4452/diff/2/?file=71759#file71759line174 Curious, what is the purpose of having a temporary variable at the class level? See comment regarding issue opened on line 206. On March 5, 2015, 1:53 p.m., Ashley Sanders wrote: /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/run-test, line 206 https://reviewboard.asterisk.org/r/4452/diff/2/?file=71759#file71759line206 You could use a temporary variable here, in the local scope, w/o having to rely on something at the class level. self.tmp_app_names is an instance variable which is used by both the run() and protocol_connected() methods. On March 5, 2015, 1:53 p.m., Ashley Sanders wrote: /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/run-test, line 67 https://reviewboard.asterisk.org/r/4452/diff/2/?file=71759#file71759line67 Just an observation... Here, you are using the reStructuredText (reST) style for your docstring (with the :param), but you don't use that style on line 58 (or anywhere else from what I can tell). Yea this was copied from another test. Fixed. On March 5, 2015, 1:53 p.m., Ashley Sanders wrote: /asterisk/trunk/lib/python/asterisk/pjsua_mod.py, line 140 https://reviewboard.asterisk.org/r/4452/diff/2/?file=71748#file71748line140 Suggestion, you could remove the ua_cfg variable on line 136 and here, on line 140, use: self.lib.init(ua_cfg=pj.UAConfig()) I checked and you aren't using the ua_cfg variable anywhere else that I can tell. I'm using 'ua_cfg' to be able to set max_calls. On March 5, 2015, 1:53 p.m., jbigelow wrote: I see a lot of duplication in the run-test files. I suggest that we refactor and abstract the common pieces of code into a base class somewhere. For instance the check_results function could be abstracted and I saw a couple of more instances where we could apply some smart refactoring such that reuse would be possible. Ashley Sanders wrote: Also, if these tests are copies of other tests, with a few tweaks for this particular use-case, that would be a good reason to consider pushing some of this logic into lib/python. There is duplication for the two tests with the run-test files. There is also some duplication between them and the test tests/rest_api/channels/redirect/nominal/run-test that was used as a base. Needing to create multiple websocket connections doesn't happen to often and I don't believe it will be needed much, at least in the short term. Therefore I'm not sure if refactoring and creating a library for just a few tests is worth the effort at this point. But if and when more tests need this functionality then it would be a good time then. - jbigelow --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4452/#review14600 --- On March 4, 2015, 12:58 p.m., jbigelow wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4452/ --- (Updated March 4, 2015, 12:58 p.m.) Review request for Asterisk Developers. Bugs: ASTERISK-24586 https://issues.asterisk.org/jira/browse/ASTERISK-24586 Repository: testsuite Description
Re: [asterisk-dev] [Code Review] 4452: Testsuite: ARI channel subscription tests
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4452/ --- (Updated March 5, 2015, 8:51 p.m.) Review request for Asterisk Developers. Bugs: ASTERISK-24586 https://issues.asterisk.org/jira/browse/ASTERISK-24586 Repository: testsuite Description --- This adds some local and non-local channel subscription tests for ARI. These tests ensure ARI events occur and/or don't occur for the appropriate stasis app(s). Due to the variations and small differences of these, the test-config.yaml descriptions of each is the best way to describe what they do. Four tests have been added under 'tests/rest_api/applications/channel-subscriptions/'. : * originate_to_dialplan/non_local_channels - Similiar to the existing test that this patch modifies as mentioned below. This required modifying pjsua_mod.py to allow more calls. * originate_to_other_stasis_app/local_channels - Creates two websockets, one for for each stasis app. Originates a local channel from AppA where half is sent into AppB and the other half send into the dialplan. * originate_to_other_stasis_app/non_local_channels - Creates two websockets, one for for each stasis app. Originates a PJSIP channel from AppA to a pjsua phone where is is placed into AppB. * originate_to_stasis_app/local_channels Note: The test 'tests/rest_api/applications/subscribe-channel' test has been renamed to 'basic-subscribe' under the same location as the new tests. The following test has been modified to ensure no ARI events are received: * tests/rest_api/channels/originate_to_dialplan Diffs (updated) - /asterisk/trunk/tests/rest_api/channels/originate_to_dialplan/test-config.yaml 6475 /asterisk/trunk/tests/rest_api/applications/tests.yaml 6475 /asterisk/trunk/tests/rest_api/applications/subscribe-channel/test-config.yaml 6475 /asterisk/trunk/tests/rest_api/applications/subscribe-channel/subscribe_channel.py 6475 /asterisk/trunk/tests/rest_api/applications/subscribe-channel/configs/ast1/extensions.conf 6475 /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/local_channels/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/local_channels/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/run-test PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/configs/ast1/http.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/run-test PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/configs/ast1/http.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 6475 Diff: https://reviewboard.asterisk.org/r/4452/diff/ Testing --- * Executed each test successfully 30+ times. * Changed the code to force a failure to ensure tests properly failed. * Review logs to ensure operation is as expected. Thanks, jbigelow -- _ -- Bandwidth and Colocation
Re: [asterisk-dev] [Code Review] 4452: Testsuite: ARI channel subscription tests
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4452/ --- (Updated March 4, 2015, 12:58 p.m.) Review request for Asterisk Developers. Bugs: ASTERISK-24586 https://issues.asterisk.org/jira/browse/ASTERISK-24586 Repository: testsuite Description --- This adds some local and non-local channel subscription tests for ARI. These tests ensure ARI events occur and/or don't occur for the appropriate stasis app(s). Due to the variations and small differences of these, the test-config.yaml descriptions of each is the best way to describe what they do. Four tests have been added under 'tests/rest_api/applications/channel-subscriptions/'. : * originate_to_dialplan/non_local_channels - Similiar to the existing test that this patch modifies as mentioned below. This required modifying pjsua_mod.py to allow more calls. * originate_to_other_stasis_app/local_channels - Creates two websockets, one for for each stasis app. Originates a local channel from AppA where half is sent into AppB and the other half send into the dialplan. * originate_to_other_stasis_app/non_local_channels - Creates two websockets, one for for each stasis app. Originates a PJSIP channel from AppA to a pjsua phone where is is placed into AppB. * originate_to_stasis_app/local_channels Note: The test 'tests/rest_api/applications/subscribe-channel' test has been renamed to 'basic-subscribe' under the same location as the new tests. The following test has been modified to ensure no ARI events are received: * tests/rest_api/channels/originate_to_dialplan Diffs (updated) - /asterisk/trunk/tests/rest_api/channels/originate_to_dialplan/test-config.yaml 6475 /asterisk/trunk/tests/rest_api/applications/tests.yaml 6475 /asterisk/trunk/tests/rest_api/applications/subscribe-channel/test-config.yaml 6475 /asterisk/trunk/tests/rest_api/applications/subscribe-channel/subscribe_channel.py 6475 /asterisk/trunk/tests/rest_api/applications/subscribe-channel/configs/ast1/extensions.conf 6475 /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/local_channels/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/local_channels/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/run-test PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/configs/ast1/http.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/run-test PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/configs/ast1/http.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 6475 Diff: https://reviewboard.asterisk.org/r/4452/diff/ Testing --- * Executed each test successfully 30+ times. * Changed the code to force a failure to ensure tests properly failed. * Review logs to ensure operation is as expected. Thanks, jbigelow -- _ -- Bandwidth and Colocation
Re: [asterisk-dev] [Code Review] 4452: Testsuite: ARI channel subscription tests
On March 3, 2015, 3:40 p.m., Mark Michelson wrote: /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/run-test, line 291 https://reviewboard.asterisk.org/r/4452/diff/1/?file=71670#file71670line291 Why or 0 ? Isn't that a no-op? Good question. I used 'tests/rest_api/channels/redirect/nominal/run-test' as a base and I'm not sure why myself. I've removed it though. - jbigelow --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4452/#review14583 --- On March 4, 2015, 12:58 p.m., jbigelow wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4452/ --- (Updated March 4, 2015, 12:58 p.m.) Review request for Asterisk Developers. Bugs: ASTERISK-24586 https://issues.asterisk.org/jira/browse/ASTERISK-24586 Repository: testsuite Description --- This adds some local and non-local channel subscription tests for ARI. These tests ensure ARI events occur and/or don't occur for the appropriate stasis app(s). Due to the variations and small differences of these, the test-config.yaml descriptions of each is the best way to describe what they do. Four tests have been added under 'tests/rest_api/applications/channel-subscriptions/'. : * originate_to_dialplan/non_local_channels - Similiar to the existing test that this patch modifies as mentioned below. This required modifying pjsua_mod.py to allow more calls. * originate_to_other_stasis_app/local_channels - Creates two websockets, one for for each stasis app. Originates a local channel from AppA where half is sent into AppB and the other half send into the dialplan. * originate_to_other_stasis_app/non_local_channels - Creates two websockets, one for for each stasis app. Originates a PJSIP channel from AppA to a pjsua phone where is is placed into AppB. * originate_to_stasis_app/local_channels Note: The test 'tests/rest_api/applications/subscribe-channel' test has been renamed to 'basic-subscribe' under the same location as the new tests. The following test has been modified to ensure no ARI events are received: * tests/rest_api/channels/originate_to_dialplan Diffs - /asterisk/trunk/tests/rest_api/channels/originate_to_dialplan/test-config.yaml 6475 /asterisk/trunk/tests/rest_api/applications/tests.yaml 6475 /asterisk/trunk/tests/rest_api/applications/subscribe-channel/test-config.yaml 6475 /asterisk/trunk/tests/rest_api/applications/subscribe-channel/subscribe_channel.py 6475 /asterisk/trunk/tests/rest_api/applications/subscribe-channel/configs/ast1/extensions.conf 6475 /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/local_channels/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/local_channels/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/run-test PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/configs/ast1/http.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/run-test PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/configs/ast1/http.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/tests.yaml PRE-CREATION /asterisk/trunk/tests
[asterisk-dev] [Code Review] 4452: Testsuite: ARI channel subscription tests
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4452/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24586 https://issues.asterisk.org/jira/browse/ASTERISK-24586 Repository: testsuite Description --- This adds some local and non-local channel subscription tests for ARI. These tests ensure ARI events occur and/or don't occur for the appropriate stasis app(s). Due to the variations and small differences of these, the test-config.yaml descriptions of each is the best way to describe what they do. Four tests have been added under 'tests/rest_api/applications/channel-subscriptions/'. : * originate_to_dialplan/non_local_channels - Similiar to the existing test that this patch modifies as mentioned below. This required modifying pjsua_mod.py to allow more calls. * originate_to_other_stasis_app/local_channels - Creates two websockets, one for for each stasis app. Originates a local channel from AppA where half is sent into AppB and the other half send into the dialplan. * originate_to_other_stasis_app/non_local_channels - Creates two websockets, one for for each stasis app. Originates a PJSIP channel from AppA to a pjsua phone where is is placed into AppB. * originate_to_stasis_app/local_channels Note: The test 'tests/rest_api/applications/subscribe-channel' test has been renamed to 'basic-subscribe' under the same location as the new tests. The following test has been modified to ensure no ARI events are received: * tests/rest_api/channels/originate_to_dialplan Diffs - /asterisk/trunk/tests/rest_api/channels/originate_to_dialplan/test-config.yaml 6475 /asterisk/trunk/tests/rest_api/applications/tests.yaml 6475 /asterisk/trunk/tests/rest_api/applications/subscribe-channel/test-config.yaml 6475 /asterisk/trunk/tests/rest_api/applications/subscribe-channel/subscribe_channel.py 6475 /asterisk/trunk/tests/rest_api/applications/subscribe-channel/configs/ast1/extensions.conf 6475 /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/local_channels/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_stasis_app/local_channels/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/run-test PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/non_local_channels/configs/ast1/http.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/run-test PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/configs/ast1/http.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_other_stasis_app/local_channels/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/applications/channel-subscriptions/originate_to_dialplan/non_local_channels/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 6475 Diff: https://reviewboard.asterisk.org/r/4452/diff/ Testing --- * Executed each test successfully 30+ times. * Changed the code to force a failure to ensure tests properly failed. * Review logs to ensure operation is as expected. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk
[asterisk-dev] [Code Review] 4416: Testsuite: Attended transfers from Stasis bridge to Stasis bridge
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4416/ --- Review request for Asterisk Developers and Mark Michelson. Bugs: ASTERISK-24580, ASTERISK-24755 and ASTERISK-24782 https://issues.asterisk.org/jira/browse/ASTERISK-24580 https://issues.asterisk.org/jira/browse/ASTERISK-24755 https://issues.asterisk.org/jira/browse/ASTERISK-24782 Repository: testsuite Description --- This adds the Attended Transfers from a Stasis bridge to a Stasis bridge tests 1.6 1.7 as described on the StasisStart/StasisEnd Test Plan at: https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=30279826 Notes: * These tests use the phones.py module that is up for review at https://reviewboard.asterisk.org/r/4413/ * The tests may occasionally fail due to bug ASTERISK-24755. * These tests constantly fail due to ASTERISK-24782. The YAML config 'expected-result: False' has been set for the tests. Once the bug has been resolved the config line should be removed from both. Diffs - /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/tests.yaml 6389 /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_bridge/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_bridge/same_stasis_app/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_bridge/same_stasis_app/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_bridge/same_stasis_app/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_bridge/different_stasis_app/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_bridge/different_stasis_app/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_bridge/different_stasis_app/configs/ast1/extensions.conf PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4416/diff/ Testing --- * Because of bug ASTERISK-24782, a few ARI/AMI events aren't received and actions don't fire. Therefore those events/actions in the YAML haven't been tested. * Executed tests multiple times. * Reviewed logs to ensure the tests were executing as expected. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.
On Feb. 12, 2015, 12:42 p.m., Mark Michelson wrote: /asterisk/trunk/lib/python/asterisk/pjsua_mod.py, lines 258-259 https://reviewboard.asterisk.org/r/4413/diff/1/?file=71349#file71349line258 Is this change necessary since you ended up overriding reg_success() in your new pluggable object? jbigelow wrote: If that condition is removed then it will blow up if callback_module callback_method are not defined in YAML and pjsua_mod.PJsua is being used as a test module. If it remains with the same scenario then things won't blow up and no user code is called into(maybe there's a need for that?). Suggestions? Mark Michelson wrote: Hm, I guess my thoughts here are that if someone is trying to use the pjsua_mod.PJsua pluggable module directly (as opposed to using the phone controller), then it is an error currently to not specify a callback_module and callback_method. Changed to log an error, stop reactor, and then return. - jbigelow --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/#review14450 --- On Feb. 12, 2015, 6:27 p.m., jbigelow wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/ --- (Updated Feb. 12, 2015, 6:27 p.m.) Review request for Asterisk Developers and Mark Michelson. Bugs: ASTERISK-24578 https://issues.asterisk.org/jira/browse/ASTERISK-24578 Repository: testsuite Description --- Pluggable modules to place, receive, and transfer (blind/attended) calls to simulate phones using PJSUA and YAML configuration. Calls are placed and/or transferred using the new pluggable action module. This should allow many currrent and future tests to easily send/receive calls to/from Asterisk along with transferring calls within YAML configuration. The pluggable test module (phones.PjsuaPhoneController) initializes the PJSUA accounts and once all have registered, the account callbacks are setup and are ready to receive calls. The pluggable action module (pluggable_modules.PjsuaPhoneActionModule) provides the ability to place calls and transfer calls using the accounts from YAML and the action is referenced with 'pjsua_phone'. The only time a call is hung up by this is when a transfer is performed and a 200 OK sipfrag NOTIFY is received. None of the modules set a pass/fail result and are only for driving and manipulating calls. See attached file for YAML demo. Diffs - /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 6379 /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 6379 /asterisk/trunk/lib/python/asterisk/phones.py PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4413/diff/ Testing --- * Tested placing calls, receiving calls, transfering via blind attended. * Pylint score of 9.40/10 for phones.py * See attached test-config.yaml for a demonstration. File Attachments Demonstration https://reviewboard.asterisk.org/media/uploaded/files/2015/02/11/659ab31f-8401-4f24-be5e-da1db0be3156__test-config.yaml Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/ --- (Updated Feb. 13, 2015, 9:48 a.m.) Review request for Asterisk Developers and Mark Michelson. Changes --- Addressed finding. Bugs: ASTERISK-24578 https://issues.asterisk.org/jira/browse/ASTERISK-24578 Repository: testsuite Description --- Pluggable modules to place, receive, and transfer (blind/attended) calls to simulate phones using PJSUA and YAML configuration. Calls are placed and/or transferred using the new pluggable action module. This should allow many currrent and future tests to easily send/receive calls to/from Asterisk along with transferring calls within YAML configuration. The pluggable test module (phones.PjsuaPhoneController) initializes the PJSUA accounts and once all have registered, the account callbacks are setup and are ready to receive calls. The pluggable action module (pluggable_modules.PjsuaPhoneActionModule) provides the ability to place calls and transfer calls using the accounts from YAML and the action is referenced with 'pjsua_phone'. The only time a call is hung up by this is when a transfer is performed and a 200 OK sipfrag NOTIFY is received. None of the modules set a pass/fail result and are only for driving and manipulating calls. See attached file for YAML demo. Diffs (updated) - /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 6379 /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 6379 /asterisk/trunk/lib/python/asterisk/phones.py PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4413/diff/ Testing --- * Tested placing calls, receiving calls, transfering via blind attended. * Pylint score of 9.40/10 for phones.py * See attached test-config.yaml for a demonstration. File Attachments Demonstration https://reviewboard.asterisk.org/media/uploaded/files/2015/02/11/659ab31f-8401-4f24-be5e-da1db0be3156__test-config.yaml Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/ --- (Updated Feb. 13, 2015, 12:28 p.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers and Mark Michelson. Changes --- Committed in revision 6406 Bugs: ASTERISK-24578 https://issues.asterisk.org/jira/browse/ASTERISK-24578 Repository: testsuite Description --- Pluggable modules to place, receive, and transfer (blind/attended) calls to simulate phones using PJSUA and YAML configuration. Calls are placed and/or transferred using the new pluggable action module. This should allow many currrent and future tests to easily send/receive calls to/from Asterisk along with transferring calls within YAML configuration. The pluggable test module (phones.PjsuaPhoneController) initializes the PJSUA accounts and once all have registered, the account callbacks are setup and are ready to receive calls. The pluggable action module (pluggable_modules.PjsuaPhoneActionModule) provides the ability to place calls and transfer calls using the accounts from YAML and the action is referenced with 'pjsua_phone'. The only time a call is hung up by this is when a transfer is performed and a 200 OK sipfrag NOTIFY is received. None of the modules set a pass/fail result and are only for driving and manipulating calls. See attached file for YAML demo. Diffs - /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 6379 /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 6379 /asterisk/trunk/lib/python/asterisk/phones.py PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4413/diff/ Testing --- * Tested placing calls, receiving calls, transfering via blind attended. * Pylint score of 9.40/10 for phones.py * See attached test-config.yaml for a demonstration. File Attachments Demonstration https://reviewboard.asterisk.org/media/uploaded/files/2015/02/11/659ab31f-8401-4f24-be5e-da1db0be3156__test-config.yaml Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4415: Testsuite: Attended transfers from non-Stasis to a Stasis bridge
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4415/ --- (Updated Feb. 13, 2015, 12:54 p.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers and Mark Michelson. Changes --- Committed in revision 6407 Bugs: ASTERISK-24578, ASTERISK-24755 and ASTERISK-24782 https://issues.asterisk.org/jira/browse/ASTERISK-24578 https://issues.asterisk.org/jira/browse/ASTERISK-24755 https://issues.asterisk.org/jira/browse/ASTERISK-24782 Repository: testsuite Description --- This adds the Attended Transfers from non-Stasis to a Stasis bridge tests 1.1 1.2 as described on the StasisStart/StasisEnd Test Plan at: https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=30279826 Notes: * These tests use the phones.py module that is up for review at https://reviewboard.asterisk.org/r/4413/ * The tests may occasionally fail due to bug ASTERISK-24755. * These tests constantly fail due to ASTERISK-24782. The YAML config 'expected-result: False' has been set for the tests. Once the bug has been resolved the config line should be removed from both. Diffs - /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/tests.yaml 6379 /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/non_stasis_app_to_stasis_bridge/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/non_stasis_app_to_stasis_bridge/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/non_stasis_app_to_stasis_bridge/configs/ast1/extensions.conf PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4415/diff/ Testing --- * Because of bug ASTERISK-24782, a few ARI/AMI events aren't received and actions don't fire. Therefore those events/actions in the YAML haven't been tested. * Executed tests multiple times. * Reviewed logs to ensure the tests were executing as expected. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4416: Testsuite: Attended transfers from Stasis bridge to Stasis bridge
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4416/ --- (Updated Feb. 13, 2015, 4:46 p.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers and Mark Michelson. Changes --- Committed in revision 6415 Bugs: ASTERISK-24580, ASTERISK-24755 and ASTERISK-24782 https://issues.asterisk.org/jira/browse/ASTERISK-24580 https://issues.asterisk.org/jira/browse/ASTERISK-24755 https://issues.asterisk.org/jira/browse/ASTERISK-24782 Repository: testsuite Description --- This adds the Attended Transfers from a Stasis bridge to a Stasis bridge tests 1.6 1.7 as described on the StasisStart/StasisEnd Test Plan at: https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=30279826 Notes: * These tests use the phones.py module that is up for review at https://reviewboard.asterisk.org/r/4413/ * The tests may occasionally fail due to bug ASTERISK-24755. * These tests constantly fail due to ASTERISK-24782. The YAML config 'expected-result: False' has been set for the tests. Once the bug has been resolved the config line should be removed from both. Diffs - /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/tests.yaml 6389 /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_bridge/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_bridge/same_stasis_app/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_bridge/same_stasis_app/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_bridge/same_stasis_app/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_bridge/different_stasis_app/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_bridge/different_stasis_app/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/stasis_bridge_to_stasis_bridge/different_stasis_app/configs/ast1/extensions.conf PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4416/diff/ Testing --- * Because of bug ASTERISK-24782, a few ARI/AMI events aren't received and actions don't fire. Therefore those events/actions in the YAML haven't been tested. * Executed tests multiple times. * Reviewed logs to ensure the tests were executing as expected. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/ --- (Updated Feb. 12, 2015, 6:27 p.m.) Review request for Asterisk Developers and Mark Michelson. Changes --- Addressed all but one issue which I'm looking for feedback on. Bugs: ASTERISK-24578 https://issues.asterisk.org/jira/browse/ASTERISK-24578 Repository: testsuite Description --- Pluggable modules to place, receive, and transfer (blind/attended) calls to simulate phones using PJSUA and YAML configuration. Calls are placed and/or transferred using the new pluggable action module. This should allow many currrent and future tests to easily send/receive calls to/from Asterisk along with transferring calls within YAML configuration. The pluggable test module (phones.PjsuaPhoneController) initializes the PJSUA accounts and once all have registered, the account callbacks are setup and are ready to receive calls. The pluggable action module (pluggable_modules.PjsuaPhoneActionModule) provides the ability to place calls and transfer calls using the accounts from YAML and the action is referenced with 'pjsua_phone'. The only time a call is hung up by this is when a transfer is performed and a 200 OK sipfrag NOTIFY is received. None of the modules set a pass/fail result and are only for driving and manipulating calls. See attached file for YAML demo. Diffs (updated) - /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 6379 /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 6379 /asterisk/trunk/lib/python/asterisk/phones.py PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4413/diff/ Testing --- * Tested placing calls, receiving calls, transfering via blind attended. * Pylint score of 9.40/10 for phones.py * See attached test-config.yaml for a demonstration. File Attachments Demonstration https://reviewboard.asterisk.org/media/uploaded/files/2015/02/11/659ab31f-8401-4f24-be5e-da1db0be3156__test-config.yaml Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.
https://reviewboard.asterisk.org/r/4413/diff/1/?file=71348#file71348line272 If this exception occurs, does lock get properly unlocked? Fixed this by removing the locking :) Apparently a lock isn't needed when making call. Unless perhaps a callback isn't passed and then set later using call.set_callback() but that's not the case here. On Feb. 12, 2015, 12:42 p.m., Mark Michelson wrote: /asterisk/trunk/lib/python/asterisk/pjsua_mod.py, lines 258-259 https://reviewboard.asterisk.org/r/4413/diff/1/?file=71349#file71349line258 Is this change necessary since you ended up overriding reg_success() in your new pluggable object? If that condition is removed then it will blow up if callback_module callback_method are not defined in YAML and pjsua_mod.PJsua is being used as a test module. If it remains with the same scenario then things won't blow up and no user code is called into(maybe there's a need for that?). Suggestions? - jbigelow --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/#review14450 --- On Feb. 12, 2015, 10:25 a.m., jbigelow wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/ --- (Updated Feb. 12, 2015, 10:25 a.m.) Review request for Asterisk Developers and Mark Michelson. Bugs: ASTERISK-24578 https://issues.asterisk.org/jira/browse/ASTERISK-24578 Repository: testsuite Description --- Pluggable modules to place, receive, and transfer (blind/attended) calls to simulate phones using PJSUA and YAML configuration. Calls are placed and/or transferred using the new pluggable action module. This should allow many currrent and future tests to easily send/receive calls to/from Asterisk along with transferring calls within YAML configuration. The pluggable test module (phones.PjsuaPhoneController) initializes the PJSUA accounts and once all have registered, the account callbacks are setup and are ready to receive calls. The pluggable action module (pluggable_modules.PjsuaPhoneActionModule) provides the ability to place calls and transfer calls using the accounts from YAML and the action is referenced with 'pjsua_phone'. The only time a call is hung up by this is when a transfer is performed and a 200 OK sipfrag NOTIFY is received. None of the modules set a pass/fail result and are only for driving and manipulating calls. See attached file for YAML demo. Diffs - /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 6379 /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 6379 /asterisk/trunk/lib/python/asterisk/phones.py PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4413/diff/ Testing --- * Tested placing calls, receiving calls, transfering via blind attended. * Pylint score of 9.40/10 for phones.py * See attached test-config.yaml for a demonstration. File Attachments Demonstration https://reviewboard.asterisk.org/media/uploaded/files/2015/02/11/659ab31f-8401-4f24-be5e-da1db0be3156__test-config.yaml Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/ --- (Updated Feb. 12, 2015, 10:25 a.m.) Review request for Asterisk Developers and Mark Michelson. Bugs: ASTERISK-24578 https://issues.asterisk.org/jira/browse/ASTERISK-24578 Repository: testsuite Description (updated) --- Pluggable modules to place, receive, and transfer (blind/attended) calls to simulate phones using PJSUA and YAML configuration. Calls are placed and/or transferred using the new pluggable action module. This should allow many currrent and future tests to easily send/receive calls to/from Asterisk along with transferring calls within YAML configuration. The pluggable test module (phones.PjsuaPhoneController) initializes the PJSUA accounts and once all have registered, the account callbacks are setup and are ready to receive calls. The pluggable action module (pluggable_modules.PjsuaPhoneActionModule) provides the ability to place calls and transfer calls using the accounts from YAML and the action is referenced with 'pjsua_phone'. The only time a call is hung up by this is when a transfer is performed and a 200 OK sipfrag NOTIFY is received. None of the modules set a pass/fail result and are only for driving and manipulating calls. See attached file for YAML demo. Diffs - /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 6379 /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 6379 /asterisk/trunk/lib/python/asterisk/phones.py PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4413/diff/ Testing --- * Tested placing calls, receiving calls, transfering via blind attended. * Pylint score of 9.40/10 for phones.py * See attached test-config.yaml for a demonstration. File Attachments Demonstration https://reviewboard.asterisk.org/media/uploaded/files/2015/02/11/659ab31f-8401-4f24-be5e-da1db0be3156__test-config.yaml Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4408: Testsuite: Add external bridging tests for Stasis (two channel) interactions
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4408/ --- (Updated Feb. 12, 2015, 10:48 a.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers and Mark Michelson. Changes --- Committed in revision 6389 Bugs: ASTERISK-24611 https://issues.asterisk.org/jira/browse/ASTERISK-24611 Repository: testsuite Description --- This adds external bridging tests for Stasis (two channel) interactions as defined on the StasisStart/StasisEnd Test Plan (tests 2.5, 2.6, 2.7, and 2.8) at: https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=30279826#StasisStart/StasisEndTestplan-ExternalBridging This also renames (move to sub directory) the test 'tests/rest_api/external_interaction/ami_bridge/stasis_app/' to 'tests/rest_api/external_interaction/ami_bridge/stasis_app/non_stasis_app/'. NOTE: The files for the renamed test don't appear just because of how things work. Diffs - /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/tests.yaml 6377 /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/two_channel_same_stasis_app/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/two_channel_same_stasis_app/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/two_channel_different_stasis_app/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/two_channel_different_stasis_app/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/tests.yaml 6377 /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_app/two_channel_same_stasis_app/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_app/two_channel_same_stasis_app/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_app/two_channel_different_stasis_app/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_app/two_channel_different_stasis_app/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_app/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_app/test-config.yaml 6377 /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_app/configs/ast1/extensions.conf 6377 Diff: https://reviewboard.asterisk.org/r/4408/diff/ Testing --- * Executed each test in a loop of 100 iterations with no failures. * Reviewed logs to ensure the tests were executing as expected. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] [Code Review] 4415: Testsuite: Attended transfers from non-Stasis to a Stasis bridge
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4415/ --- Review request for Asterisk Developers and Mark Michelson. Bugs: ASTERISK-24578 and ASTERISK-24782 https://issues.asterisk.org/jira/browse/ASTERISK-24578 https://issues.asterisk.org/jira/browse/ASTERISK-24782 Repository: testsuite Description --- This adds the Attended Transfers from non-Stasis to a Stasis bridge tests 1.1 1.2 as described on the StasisStart/StasisEnd Test Plan at: https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=30279826 Notes: * These tests use the phones.py module that is up for review at https://reviewboard.asterisk.org/r/4413/ * These tests fail due to ASTERISK-24782. The YAML config 'expected-result: False' has been set for the tests. Once the bug has been resolved the config line should be removed from both. Diffs - /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/tests.yaml 6379 /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/non_stasis_app_to_stasis_bridge/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/non_stasis_app_to_stasis_bridge/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/non_stasis_app_to_stasis_bridge/configs/ast1/extensions.conf PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4415/diff/ Testing --- * Because of bug ASTERISK-24782, a few ARI/AMI events aren't received and actions don't fire. Therefore those events/actions in the YAML haven't been tested. * Executed tests multiple times. * Reviewed logs to ensure the tests were executing as expected. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4415: Testsuite: Attended transfers from non-Stasis to a Stasis bridge
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4415/ --- (Updated Feb. 12, 2015, 12:34 a.m.) Review request for Asterisk Developers and Mark Michelson. Changes --- Listed bug ASTERISK-24755 and noted it. Bugs: ASTERISK-24578, ASTERISK-24755 and ASTERISK-24782 https://issues.asterisk.org/jira/browse/ASTERISK-24578 https://issues.asterisk.org/jira/browse/ASTERISK-24755 https://issues.asterisk.org/jira/browse/ASTERISK-24782 Repository: testsuite Description (updated) --- This adds the Attended Transfers from non-Stasis to a Stasis bridge tests 1.1 1.2 as described on the StasisStart/StasisEnd Test Plan at: https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=30279826 Notes: * These tests use the phones.py module that is up for review at https://reviewboard.asterisk.org/r/4413/ * The tests may occasionally fail due to bug ASTERISK-24755. * These tests constantly fail due to ASTERISK-24782. The YAML config 'expected-result: False' has been set for the tests. Once the bug has been resolved the config line should be removed from both. Diffs - /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/tests.yaml 6379 /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/non_stasis_bridge_to_stasis_bridge/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/non_stasis_app_to_stasis_bridge/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/non_stasis_app_to_stasis_bridge/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/attended_transfer/non_stasis_app_to_stasis_bridge/configs/ast1/extensions.conf PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4415/diff/ Testing --- * Because of bug ASTERISK-24782, a few ARI/AMI events aren't received and actions don't fire. Therefore those events/actions in the YAML haven't been tested. * Executed tests multiple times. * Reviewed logs to ensure the tests were executing as expected. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/ --- Review request for Asterisk Developers. Repository: testsuite Description --- Pluggable modules to place, receive, and transfer (blind/attended) calls to simulate phones using PJSUA and YAML configuration. Calls are placed and/or transferred using the new pluggable action module. This should allow many currrent and future tests to easily send/receive calls to/from Asterisk along with transferring calls within YAML configuration. See attached file for YAML demo. Diffs - /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 6379 /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 6379 /asterisk/trunk/lib/python/asterisk/phones.py PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4413/diff/ Testing --- * Tested placing calls, receiving calls, transfering via blind attended. * Pylint score of 9.40/10 for phones.py * See attached test-config.yaml for a demonstration. File Attachments Demonstration https://reviewboard.asterisk.org/media/uploaded/files/2015/02/11/659ab31f-8401-4f24-be5e-da1db0be3156__test-config.yaml Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4413: Testsuite: Simulate phones and control from YAML.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4413/ --- (Updated Feb. 11, 2015, 12:32 a.m.) Review request for Asterisk Developers. Repository: testsuite Description --- Pluggable modules to place, receive, and transfer (blind/attended) calls to simulate phones using PJSUA and YAML configuration. Calls are placed and/or transferred using the new pluggable action module. This should allow many currrent and future tests to easily send/receive calls to/from Asterisk along with transferring calls within YAML configuration. See attached file for YAML demo. Diffs - /asterisk/trunk/lib/python/asterisk/pluggable_modules.py 6379 /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 6379 /asterisk/trunk/lib/python/asterisk/phones.py PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4413/diff/ Testing --- * Tested placing calls, receiving calls, transfering via blind attended. * Pylint score of 9.40/10 for phones.py * See attached test-config.yaml for a demonstration. File Attachments Demonstration https://reviewboard.asterisk.org/media/uploaded/files/2015/02/11/659ab31f-8401-4f24-be5e-da1db0be3156__test-config.yaml Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] [Code Review] 4408: Testsuite: Add external bridging tests for Stasis (two channel) interactions
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4408/ --- Review request for Asterisk Developers and Mark Michelson. Bugs: ASTERISK-24611 https://issues.asterisk.org/jira/browse/ASTERISK-24611 Repository: testsuite Description --- This adds external bridging tests for Stasis (two channel) interactions as defined on the StasisStart/StasisEnd Test Plan (tests 2.5, 2.6, 2.7, and 2.8) at: https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=30279826#StasisStart/StasisEndTestplan-ExternalBridging This also renames (move to sub directory) the test 'tests/rest_api/external_interaction/ami_bridge/stasis_app/' to 'tests/rest_api/external_interaction/ami_bridge/stasis_app/non_stasis_app/'. NOTE: The files for the renamed test don't appear just because of how things work. Diffs - /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/tests.yaml 6377 /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/two_channel_same_stasis_app/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/two_channel_same_stasis_app/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/two_channel_different_stasis_app/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/two_channel_different_stasis_app/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/tests.yaml 6377 /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_app/two_channel_same_stasis_app/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_app/two_channel_same_stasis_app/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_app/two_channel_different_stasis_app/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_app/two_channel_different_stasis_app/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_app/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_app/test-config.yaml 6377 /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_app/configs/ast1/extensions.conf 6377 Diff: https://reviewboard.asterisk.org/r/4408/diff/ Testing --- * Executed each test in a loop of 100 iterations with no failures. * Reviewed logs to ensure the tests were executing as expected. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4330: Testsuite: Add external bridging tests for Stasis bridge (one channel) interactions
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4330/ --- (Updated Jan. 29, 2015, 3:37 p.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers, kmoore and Mark Michelson. Changes --- Committed in revision 6349 Bugs: ASTERISK-24610 https://issues.asterisk.org/jira/browse/ASTERISK-24610 Repository: testsuite Description --- This adds the remaining external bridging tests for Stasis bridge (one channel) interactions as defined on the StasisStart/StasisEnd Test Plan (tests 2.2, 2.3, and 2.4) at: https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=30279826#StasisStart/StasisEndTestplan-ExternalBridging This also renames the test 'tests/rest_api/external_interaction/ami_bridge/stasis_bridge/' to 'tests/rest_api/external_interaction/ami_bridge/stasis_bridge/non_stasis_app' and adds these new tests under 'tests/rest_api/external_interaction/ami_bridge/stasis_bridge/'. Diffs - /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/tests.yaml 6226 /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/test-config.yaml 6226 /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/same_stasis_app/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/same_stasis_app/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/non_stasis_bridge/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/non_stasis_bridge/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/different_stasis_app/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/different_stasis_app/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/configs/ast1/extensions.conf 6226 Diff: https://reviewboard.asterisk.org/r/4330/diff/ Testing --- * Executed each test in a loop of 100 iterations with no failures. * Reviewed logs to ensure the tests were executing as expected. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4373: Manager Action ModuleLoad gives incorrect response when used to reload modules
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4373/#review14291 --- Ship it! Tested and the response now matches what is expected. - jbigelow On Jan. 26, 2015, 2:16 p.m., Jonathan Rose wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4373/ --- (Updated Jan. 26, 2015, 2:16 p.m.) Review request for Asterisk Developers and jbigelow. Repository: Asterisk Description --- ModuleLoad actions give the wrong response when used to reload a module. On success, it will issue a 'no such module' error instead of a success response even though the module was reloaded successfully. Diffs - /branches/13/main/manager.c 431112 Diff: https://reviewboard.asterisk.org/r/4373/diff/ Testing --- Before Patch: Action: ModuleLoad LoadType: reload Module: pbx_config.so Response: Error Message: No such module. CLI output showed the module was actually reloaded successfully. After Patch: Action: ModuleLoad LoadType: reload Module: pbx_config.so Response: Success Message: Module reloaded. Thanks, Jonathan Rose -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4330: Testsuite: Add external bridging tests for Stasis bridge (one channel) interactions
On Jan. 14, 2015, 4:45 p.m., opticron wrote: /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/tests.yaml, line 2 https://reviewboard.asterisk.org/r/4330/diff/1/?file=70508#file70508line2 The files for this test seem to be missing. They are but for whatever reason not shown here on reviewboard. # svn status -v tests/rest_api/external_interaction/ami_bridge/stasis_bridge/ 6226 6047 kmoore tests/rest_api/external_interaction/ami_bridge/stasis_bridge A0 ? ? tests/rest_api/external_interaction/ami_bridge/stasis_bridge/non_stasis_app A + - ? ? tests/rest_api/external_interaction/ami_bridge/stasis_bridge/non_stasis_app/test-config.yaml A + - 6047 kmoore tests/rest_api/external_interaction/ami_bridge/stasis_bridge/non_stasis_app/configs + - 6047 kmoore tests/rest_api/external_interaction/ami_bridge/stasis_bridge/non_stasis_app/configs/ast1 + - 6047 kmoore tests/rest_api/external_interaction/ami_bridge/stasis_bridge/non_stasis_app/configs/ast1/extensions.conf D 6226 6047 kmoore tests/rest_api/external_interaction/ami_bridge/stasis_bridge/test-config.yaml D 6226 6047 kmoore tests/rest_api/external_interaction/ami_bridge/stasis_bridge/configs D 6226 6047 kmoore tests/rest_api/external_interaction/ami_bridge/stasis_bridge/configs/ast1 D 6226 6047 kmoore tests/rest_api/external_interaction/ami_bridge/stasis_bridge/configs/ast1/extensions.conf - jbigelow --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4330/#review14188 --- On Jan. 12, 2015, 5:52 p.m., jbigelow wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4330/ --- (Updated Jan. 12, 2015, 5:52 p.m.) Review request for Asterisk Developers, kmoore and Mark Michelson. Bugs: ASTERISK-24610 https://issues.asterisk.org/jira/browse/ASTERISK-24610 Repository: testsuite Description --- This adds the remaining external bridging tests for Stasis bridge (one channel) interactions as defined on the StasisStart/StasisEnd Test Plan (tests 2.2, 2.3, and 2.4) at: https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=30279826#StasisStart/StasisEndTestplan-ExternalBridging This also renames the test 'tests/rest_api/external_interaction/ami_bridge/stasis_bridge/' to 'tests/rest_api/external_interaction/ami_bridge/stasis_bridge/non_stasis_app' and adds these new tests under 'tests/rest_api/external_interaction/ami_bridge/stasis_bridge/'. Diffs - /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/tests.yaml 6226 /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/test-config.yaml 6226 /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/same_stasis_app/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/same_stasis_app/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/non_stasis_bridge/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/non_stasis_bridge/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/different_stasis_app/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/different_stasis_app/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/configs/ast1/extensions.conf 6226 Diff: https://reviewboard.asterisk.org/r/4330/diff/ Testing --- * Executed each test in a loop of 100 iterations with no failures. * Reviewed logs to ensure the tests were executing as expected. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4328: res_pjsip: Document transport selection process
On Jan. 13, 2015, 9:48 a.m., jbigelow wrote: * Under 'URI Parsing' it states: For the purposes of transport selection the transport parameter is examined. I suggest clarifing that the transport parameter being spoke of is the 'transport' parameter for endpoint types in pjsip.conf. * Under 'DNS SRV Resolution (If host portion is not an IP address)' it states: This means that the original URI *must* include... I believe 'must' should be bold without the surrounding '*'. * Under 'Best Configuration Strategies': * 'IPv4 Only (Single Interface)' it states Configure a wildcard transport. Does this mean not specifying the 'transport' parameter on endpoints? I suggest to clarify this and to include an endpoint in the configuration showing that the 'transport' parameter is not specified (assuming thats what this example is about). * 'IPv4 Only (Multiple Interfaces)': it states This allows each transport to be specified on endpoints Some clarification on whether this means specifying a single transport using the 'transport' parameter or specifying multiple transports using multiple 'transport' parameters for a single endpoint? I also suggest to include configuration of endpoints showing the 'transport' parameter being used for the example. * I suggest to either add additional examples with TLS transports. One showing the recommended way to configure endpoints where some use UDP and others use TLS. Joshua Colp wrote: That's not the transport being spoken of. It literally means a SIP URI such as sip:1000@127.0.0.1;transport=tcp Joshua Colp wrote: I've tweaked things some, added some endpoints, and referenced the applicable section that will be used depending on their configuration. * Under 'Best Configuration Strategies': * 'IPv4 Only (Single Interface)' it states Since there is only one transport configured this will always be used. For requests to this endpoint the logic in section 3a will be used. which needs updated due to the last couple changes. - jbigelow --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4328/#review14168 --- On Jan. 12, 2015, 7:33 a.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4328/ --- (Updated Jan. 12, 2015, 7:33 a.m.) Review request for Asterisk Developers. Repository: Asterisk Description --- The transport selection process of PJSIP (and by extension some of our own logic) can be a dark dark thing. To help illuminate what happens I have created a wiki page[1] which goes through (based on the message type) the process by which a transport is chosen and how it can potentially change. Stuff to look at: 1. Is this detailed enough? 2. Can you follow it? If not, how could it be made clearer? 3. Are there additional common issues that should be covered? [1] https://wiki.asterisk.org/wiki/display/~jcolp/Transport+Selection Diffs - Diff: https://reviewboard.asterisk.org/r/4328/diff/ Testing --- I opened the wiki page. It opened. Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] [Code Review] 4330: Testsuite: Add external bridging tests for Stasis bridge (one channel) interactions
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4330/ --- Review request for Asterisk Developers, kmoore and Mark Michelson. Bugs: ASTERISK-24610 https://issues.asterisk.org/jira/browse/ASTERISK-24610 Repository: testsuite Description --- This adds the remaining external bridging tests for Stasis bridge (one channel) interactions as defined on the StasisStart/StasisEnd Test Plan (tests 2.2, 2.3, and 2.4) at: https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=30279826#StasisStart/StasisEndTestplan-ExternalBridging This also renames the test 'tests/rest_api/external_interaction/ami_bridge/stasis_bridge/' to 'tests/rest_api/external_interaction/ami_bridge/stasis_bridge/non_stasis_app' and adds these new tests under 'tests/rest_api/external_interaction/ami_bridge/stasis_bridge/'. Diffs - /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/tests.yaml 6226 /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/test-config.yaml 6226 /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/same_stasis_app/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/same_stasis_app/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/non_stasis_bridge/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/non_stasis_bridge/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/different_stasis_app/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/different_stasis_app/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/ami_bridge/stasis_bridge/configs/ast1/extensions.conf 6226 Diff: https://reviewboard.asterisk.org/r/4330/diff/ Testing --- * Executed each test in a loop of 100 iterations with no failures. * Reviewed logs to ensure the tests were executing as expected. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4267: Testsuite: Add blind transfer tests for Stasis application interaction.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4267/ --- (Updated Jan. 9, 2015, 11:45 a.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers and Mark Michelson. Changes --- Committed in revision 6220 Bugs: ASTERISK-24581 and ASTERISK-24649 https://issues.asterisk.org/jira/browse/ASTERISK-24581 https://issues.asterisk.org/jira/browse/ASTERISK-24649 Repository: testsuite Description --- This adds the remaining blind transfer tests 1.9 1.10 as described on the StasisStart/StasisEnd Test Plan at: https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=30279826 This additionally updates the existing test 'stasis_bridge_to_non_stasis_app' (1.8) to verify the StasisEnd events of the channels per the test plan. An additional (dummy) channel was added for the test to prevent the test from ending when the channels involved in the test are hung up. This allows the StasisEnd events of all the other channels to be verified before the test has ended. The test description has also been updated to include more details about the test. The two new tests use the 'call_transfer.py' module which is a modified copy of tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/transfer.py for these two new tests. The module uses the pjsua python library to place calls into Asterisk and perform the blind transfer. Notes: * Due to the architecture of pjsua_mod.py, the call_transfer.py module is used as both a pluggable module and a callback module. With a little more work the module could be made to handle other common variations (ex. who places calls, who receives a call, who performs the transfer, handle a transfer target that is another pjsua endpoint like the original module) with everything configurable via YAML. I imagine it would be useful for future tests. Any takers? :) * The bug ASTERISK-24649 was found during the development of the new tests here and will likely cause them to fail every so often. Diffs - /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/tests.yaml 6155 /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_non_stasis_app/test-config.yaml 6155 /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_non_stasis_app/configs/ast1/extensions.conf 6155 /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_non_stasis_app/blind_transfer.py 6155 /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_different_stasis_app/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_different_stasis_app/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_different_stasis_app/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/call_transfer.py PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4267/diff/ Testing --- * Executed tests multiple times * Reviewed logs to manually verify StasisStart/StasisEnd events occurred. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4301: res_pjsip_outbound_registration: Add 'pjsip send register' command and update behavior of 'send unregister'
On Dec. 30, 2014, 9:39 a.m., Joshua Colp wrote: branches/13/res/res_pjsip_outbound_registration.c, lines 1155-1159 https://reviewboard.asterisk.org/r/4301/diff/1/?file=70050#file70050line1155 I'm concerned that the behavior that used to happen was explicitly documented, it wasn't overlooked. We're now changing it - why was it the previous way in the first place? George Joseph wrote: Well opticron wrote the original unregister stuff over a year ago and it never stopped the timer. sgriepentrog added the comments only about 2 months ago. If they're around, they can comment but if you call unregister why would you WANT it to start again automatically (other than there was no way to restart it)? When I dug into this area of code for the patch I wrote that sgriepentrog committed in 426924, I also thought it would be best to have it stay unregistered until the user decided to start registrations again with a command. I believe at the time it was decided for it not to be expanded to include what this very review is for. Thus I added a note to the CLI usage about how it will eventually attempt to re-register. So the patch here has my vote but I can't speak for what was originally intended. - jbigelow --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4301/#review14053 --- On Dec. 30, 2014, 4:09 p.m., George Joseph wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4301/ --- (Updated Dec. 30, 2014, 4:09 p.m.) Review request for Asterisk Developers, opticron and Scott Griepentrog. Repository: Asterisk Description --- The current behavior of 'pjsip send unregister' is to send the unregister (REGISTER with 0 exp) but let the next scheduled register proceed normally. I don't think that's a good idea. If you unregister, it should stay unregistered until you decide to start registrations again. So this patch just adds a cancel_registration call to the current unregister_task to cancel the timer. Of course, now you need a way to start registration again so I've added a 'pjsip send register' command that unregisters and cancels any existing registration (the same as send unregister), then sends an immediate registration and starts the timer back up again. Both changes also ripple to AMI. There's a new PJSIPRegister command. There's no harm in calling either command repeatedly. They don't care about the actual state. I did discover a previously existing ref count leak for state though. Every time asterisk sends a register, the count gets incremented but never decremented. I'll look at this separately. Diffs - branches/13/res/res_pjsip_outbound_registration.c 430163 Diff: https://reviewboard.asterisk.org/r/4301/diff/ Testing --- The current tests/channels/pjsip/registration/outbound/unregister tests run fine. I'm working on additional tests to exercise the register command. Thanks, George Joseph -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4291: Testsuite: Add external bridging tests for Stasis application interaction - Stasis bridge to non-stasis application.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4291/ --- (Updated Dec. 30, 2014, 10:36 a.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers and Mark Michelson. Bugs: ASTERISK-24583 and ASTERISK-24637 https://issues.asterisk.org/jira/browse/ASTERISK-24583 https://issues.asterisk.org/jira/browse/ASTERISK-24637 Repository: testsuite Description --- This adds a couple external bridging tests for Stasis application interaction. These specifically cover tests 2.1.2 2.1.3 as defined on the StasisStart/StasisEnd Test Plan at: https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=30279826#StasisStart/StasisEndTestplan-OnechannelinStasisBridge,Onechannelinnon-Stasisapplication The difference between the tests (and as defined in the test plan) is that one test does not use any options on the Bridge() dial plan app while the other uses the 'x' option. Note: The test not using any options for the Bridge() app fails due to ASTERISK-24637. The YAML config 'expected-result: False' has been set for this test. Once the bug has been resolved the config line should be removed. Diffs - /asterisk/trunk/tests/rest_api/external_interaction/tests.yaml 6133 /asterisk/trunk/tests/rest_api/external_interaction/bridge_app/x_option/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/bridge_app/x_option/stasis_bridge/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/bridge_app/x_option/stasis_bridge/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/bridge_app/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/bridge_app/stasis_bridge/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/bridge_app/stasis_bridge/configs/ast1/extensions.conf PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4291/diff/ Testing --- * Executed tests multiple times. * Review logs to ensure the tests were executing as expected. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4267: Testsuite: Add blind transfer tests for Stasis application interaction.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4267/ --- (Updated Dec. 30, 2014, 6:12 p.m.) Review request for Asterisk Developers and Mark Michelson. Changes --- Addresses issue that mjordan opened: * Added a new module that uses the PJSUA python libraries and removed the usage of SIPp for the tests * Updated test-config.yaml pjsip.conf files Note: For some reason when viewing the changes between r2 r3 on this review, it shows the SIPp scenario files as added instead of removed. Viewing r3 alone properly doesn't show the files. Bugs: ASTERISK-24581 https://issues.asterisk.org/jira/browse/ASTERISK-24581 Repository: testsuite Description (updated) --- This adds the remaining blind transfer tests 1.9 1.10 as described on the StasisStart/StasisEnd Test Plan at: https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=30279826 This additionally updates the existing test 'stasis_bridge_to_non_stasis_app' (1.8) to verify the StasisEnd events of the channels per the test plan. An additional (dummy) channel was added for the test to prevent the test from ending when the channels involved in the test are hung up. This allows the StasisEnd events of all the other channels to be verified before the test has ended. The test description has also been updated to include more details about the test. The two new tests use the 'call_transfer.py' module which is a modified copy of tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/transfer.py for these two new tests. The module uses the pjsua python library to place calls into Asterisk and perform the blind transfer. Notes: * Due to the architecture of pjsua_mod.py, the call_transfer.py module is used as both a pluggable module and a callback module. With a little more work the module could be made to handle other common variations (ex. who places calls, who receives a call, who performs the transfer, handle a transfer target that is another pjsua endpoint like the original module) with everything configurable via YAML. I imagine it would be useful for future tests. Any takers? :) * The bug ASTERISK-24649 was found during the development of the new tests here and will likely cause them to fail every so often. Diffs (updated) - /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/tests.yaml 6155 /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_non_stasis_app/test-config.yaml 6155 /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_non_stasis_app/configs/ast1/extensions.conf 6155 /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_non_stasis_app/blind_transfer.py 6155 /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_different_stasis_app/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_different_stasis_app/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_different_stasis_app/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/call_transfer.py PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4267/diff/ Testing --- * Executed tests multiple times * Reviewed logs to manually verify StasisStart/StasisEnd events occurred. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] [Code Review] 4291: Testsuite: Add external bridging tests for Stasis application interaction - Stasis bridge to non-stasis application.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4291/ --- Review request for Asterisk Developers and Mark Michelson. Bugs: ASTERISK-24583 and ASTERISK-24637 https://issues.asterisk.org/jira/browse/ASTERISK-24583 https://issues.asterisk.org/jira/browse/ASTERISK-24637 Repository: testsuite Description --- This adds a couple external bridging tests for Stasis application interaction. These specifically cover tests 2.1.2 2.1.3 as defined on the StasisStart/StasisEnd Test Plan at: https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=30279826#StasisStart/StasisEndTestplan-OnechannelinStasisBridge,Onechannelinnon-Stasisapplication The difference between the tests (and as defined in the test plan) is that one test does not use any options on the Bridge() dial plan app while the other uses the 'x' option. Note: The test not using any options for the Bridge() app fails due to ASTERISK-24637. The YAML config 'expected-result: False' has been set for this test. Once the bug has been resolved the config line should be removed. Diffs - /asterisk/trunk/tests/rest_api/external_interaction/tests.yaml 6133 /asterisk/trunk/tests/rest_api/external_interaction/bridge_app/x_option/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/bridge_app/x_option/stasis_bridge/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/bridge_app/x_option/stasis_bridge/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/bridge_app/tests.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/bridge_app/stasis_bridge/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/bridge_app/stasis_bridge/configs/ast1/extensions.conf PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4291/diff/ Testing --- * Executed tests multiple times. * Review logs to ensure the tests were executing as expected. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4267: Testsuite: Add blind transfer tests for Stasis application interaction.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4267/ --- (Updated Dec. 19, 2014, 1:54 p.m.) Review request for Asterisk Developers and Mark Michelson. Changes --- Implemented suggestion along with additional checks for the channels of the BridgeBlindTransfer event. Bugs: ASTERISK-24581 https://issues.asterisk.org/jira/browse/ASTERISK-24581 Repository: testsuite Description --- This adds the remaining blind transfer tests 1.9 1.10 as described on the StasisStart/StasisEnd Test Plan at: https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=30279826 This additionally updates the existing test 'stasis_bridge_to_non_stasis_app' (1.8) to verify the StasisEnd events of the channels per the test plan. An additional (dummy) channel was added for the test to prevent the test from ending when the channels involved in the test are hung up. This allows the StasisEnd events of all the other channels to be verified before the test has ended. The test description has also been updated to include more details about the test. Diffs (updated) - /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/tests.yaml 6105 /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/sipp/referer.xml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/sipp/referee.xml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_non_stasis_app/test-config.yaml 6105 /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_non_stasis_app/configs/ast1/extensions.conf 6105 /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_non_stasis_app/blind_transfer.py 6105 /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_different_stasis_app/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_different_stasis_app/sipp/referer.xml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_different_stasis_app/sipp/referee.xml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_different_stasis_app/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_different_stasis_app/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/blind_transfer.py PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4267/diff/ Testing --- * Executed tests multiple times * Reviewed logs to manually verify StasisStart/StasisEnd events occurred. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] [Code Review] 4267: Testsuite: Add blind transfer tests for Stasis application interaction.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4267/ --- Review request for Asterisk Developers and Mark Michelson. Bugs: ASTERISK-24581 https://issues.asterisk.org/jira/browse/ASTERISK-24581 Repository: testsuite Description --- This adds the remaining blind transfer tests 1.9 1.10 as described on the StasisStart/StasisEnd Test Plan at: https://wiki.asterisk.org/wiki/pages/viewpage.action?pageId=30279826 This additionally updates the existing test 'stasis_bridge_to_non_stasis_app' (1.8) to verify the StasisEnd events of the channels per the test plan. An additional (dummy) channel was added for the test to prevent the test from ending when the channels involved in the test are hung up. This allows the StasisEnd events of all the other channels to be verified before the test has ended. The test description has also been updated to include more details about the test. Diffs - /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/tests.yaml 6105 /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/sipp/referer.xml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/sipp/referee.xml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_same_stasis_app/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_non_stasis_app/test-config.yaml 6105 /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_non_stasis_app/configs/ast1/extensions.conf 6105 /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_non_stasis_app/blind_transfer.py 6105 /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_different_stasis_app/test-config.yaml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_different_stasis_app/sipp/referer.xml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_different_stasis_app/sipp/referee.xml PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_different_stasis_app/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/stasis_bridge_to_different_stasis_app/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/rest_api/external_interaction/blind_transfer/blind_transfer.py PRE-CREATION Diff: https://reviewboard.asterisk.org/r/4267/diff/ Testing --- * Executed tests multiple times * Reviewed logs to manually verify StasisStart/StasisEnd events occurred. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4156: Test Suite: Allow setting snaplen buffer_size for packet capturing
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4156/ --- (Updated Nov. 17, 2014, 2:59 p.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers. Changes --- Committed in revision 5935 Repository: testsuite Description --- This allows setting the snaplen and buffer_size for packet capturing. The defaults set are the same as the defaults that yappcap.PcapLive sets. Diffs - /asterisk/trunk/lib/python/pcap_listener.py 5913 /asterisk/trunk/lib/python/asterisk/test_case.py 5913 /asterisk/trunk/lib/python/asterisk/pcap.py 5913 Diff: https://reviewboard.asterisk.org/r/4156/diff/ Testing --- Used the options to set a lower snaplen and a higher buffer successfully. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4156: Test Suite: Allow setting snaplen buffer_size for packet capturing
On Nov. 13, 2014, 5:17 p.m., Kevin Harwell wrote: /asterisk/trunk/lib/python/pcap_listener.py, lines 61-64 https://reviewboard.asterisk.org/r/4156/diff/1/?file=68770#file68770line61 Instead of checking for None here and then setting the value just set these as the defaults on the function parameters (similar to what you did on PcapFile _init_). I thought of doing it that way while writing it but decided not to so that the defaults are in a single place and to keep things consistent in this area of code. Thoughts? - jbigelow --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4156/#review13757 --- On Nov. 6, 2014, 5:05 p.m., jbigelow wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4156/ --- (Updated Nov. 6, 2014, 5:05 p.m.) Review request for Asterisk Developers. Repository: testsuite Description --- This allows setting the snaplen and buffer_size for packet capturing. The defaults set are the same as the defaults that yappcap.PcapLive sets. Diffs - /asterisk/trunk/lib/python/pcap_listener.py 5913 /asterisk/trunk/lib/python/asterisk/test_case.py 5913 /asterisk/trunk/lib/python/asterisk/pcap.py 5913 Diff: https://reviewboard.asterisk.org/r/4156/diff/ Testing --- Used the options to set a lower snaplen and a higher buffer successfully. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] [Code Review] 4156: Test Suite: Allow setting snaplen buffer_size for packet capturing
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4156/ --- Review request for Asterisk Developers. Repository: testsuite Description --- This allows setting the snaplen and buffer_size for packet capturing. The defaults set are the same as the defaults that yappcap.PcapLive sets. Diffs - /asterisk/trunk/lib/python/pcap_listener.py 5913 /asterisk/trunk/lib/python/asterisk/test_case.py 5913 /asterisk/trunk/lib/python/asterisk/pcap.py 5913 Diff: https://reviewboard.asterisk.org/r/4156/diff/ Testing --- Used the options to set a lower snaplen and a higher buffer successfully. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3992: res_pjsip_sdp_rtp: Add optimistic SRTP support.
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3992/#review13611 --- I suggest reusing the 'media_encryption' pjsip.conf option with possible values of 'yes', 'no', 'attempt'/'try' instead of a new option. If not I suggest renaming the option to something like 'media_encryption_attempt' or 'media_encryption_try'. - jbigelow On Oct. 21, 2014, 8:36 a.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3992/ --- (Updated Oct. 21, 2014, 8:36 a.m.) Review request for Asterisk Developers. Repository: Asterisk Description --- When enabling SRTP support in PJSIP it is either forced on or disabled. This means that if you specify SRTP but the client does not support it the session will fail. For situations where this guarantee is not required this new functionality can be used to optimistically use SRTP if possible. This has the added benefit of encrypting the media when possible but does not guarantee it. This also fixes an issue where a client may offer SRTP using the normal transport but we reject it. Diffs - /trunk/res/res_pjsip_session.c 426078 /trunk/res/res_pjsip_sdp_rtp.c 426078 /trunk/res/res_pjsip/pjsip_configuration.c 426078 /trunk/res/res_pjsip.c 426078 /trunk/include/asterisk/res_pjsip_session.h 426078 /trunk/include/asterisk/res_pjsip.h 426078 /trunk/contrib/ast-db-manage/config/versions/1443687dda65_add_media_encryption_optimistic_to_pjsip.py PRE-CREATION /trunk/configs/samples/pjsip.conf.sample 426078 /trunk/CHANGES 426078 Diff: https://reviewboard.asterisk.org/r/3992/diff/ Testing --- Used Blink to place calls with optimistic enabled and disabled on the PJSIP side. In Blink I alternated between disabled/mandatory/optional. Confirmed that for each scenario the expected outcome occurred. Blink Asterisk Result Disabled Optimistic Off Failed Disabled Optimistic On Success (Not encrypted) Mandatory Optimistic Off Success (Encrypted) Mandatory Optimistic On Success (Encrypted) Optional Optimistic Off Success (Encrypted) Optional Optimistic On Success (Encrypted) Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3992: res_pjsip_sdp_rtp: Add optimistic SRTP support.
On Oct. 29, 2014, 8:49 a.m., jbigelow wrote: I suggest reusing the 'media_encryption' pjsip.conf option with possible values of 'yes', 'no', 'attempt'/'try' instead of a new option. If not I suggest renaming the option to something like 'media_encryption_attempt' or 'media_encryption_try'. Joshua Colp wrote: media_encryption isn't a yes/no, it specifies which encryption method to use. Ah, the sample file with 'media_encryption=no' threw me off. Could possibly have values such as 'attempt_sdes' / 'try_sdes' but then again I don't recall any other values of options being in a format like that. Just a thought. Otherwise I still suggest the option being named something like 'media_encryption_attempt' or 'media_encryption_try'. Or possibly reverse the name to 'media_encryption_force' with a default of 'yes'. - jbigelow --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3992/#review13611 --- On Oct. 21, 2014, 8:36 a.m., Joshua Colp wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3992/ --- (Updated Oct. 21, 2014, 8:36 a.m.) Review request for Asterisk Developers. Repository: Asterisk Description --- When enabling SRTP support in PJSIP it is either forced on or disabled. This means that if you specify SRTP but the client does not support it the session will fail. For situations where this guarantee is not required this new functionality can be used to optimistically use SRTP if possible. This has the added benefit of encrypting the media when possible but does not guarantee it. This also fixes an issue where a client may offer SRTP using the normal transport but we reject it. Diffs - /trunk/res/res_pjsip_session.c 426078 /trunk/res/res_pjsip_sdp_rtp.c 426078 /trunk/res/res_pjsip/pjsip_configuration.c 426078 /trunk/res/res_pjsip.c 426078 /trunk/include/asterisk/res_pjsip_session.h 426078 /trunk/include/asterisk/res_pjsip.h 426078 /trunk/contrib/ast-db-manage/config/versions/1443687dda65_add_media_encryption_optimistic_to_pjsip.py PRE-CREATION /trunk/configs/samples/pjsip.conf.sample 426078 /trunk/CHANGES 426078 Diff: https://reviewboard.asterisk.org/r/3992/diff/ Testing --- Used Blink to place calls with optimistic enabled and disabled on the PJSIP side. In Blink I alternated between disabled/mandatory/optional. Confirmed that for each scenario the expected outcome occurred. Blink Asterisk Result Disabled Optimistic Off Failed Disabled Optimistic On Success (Not encrypted) Mandatory Optimistic Off Success (Encrypted) Mandatory Optimistic On Success (Encrypted) Optional Optimistic Off Success (Encrypted) Optional Optimistic On Success (Encrypted) Thanks, Joshua Colp -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4077: Test Suite: Unregister registered outbound registrations
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4077/ --- (Updated Oct. 24, 2014, 11:53 a.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers. Changes --- Committed in revision 5773 Repository: testsuite Description --- This tests unregistering outbound registrations that are registered using the PJSIPUnregister AMI action. It ensures that Asterisk sends a REGISTER message with an Expires header of '0' upon executing the PJSIPUnregister AMI action and that AMI Registry events are present with a status of Unregistered. The test uses all combinations of IPv4/IPv6 and UDP/TCP. Upon an outbound registration registering, the PJSIPUnregister action is executed to unregister it. SIPp is used as the registrar to respond when Asterisk registers and unregisters where the Expires header is checked. Note: This test currently fails due to the following Asterisk bugs: * https://issues.asterisk.org/jira/browse/ASTERISK-24411 * https://issues.asterisk.org/jira/browse/ASTERISK-24414 The SIPp scenario contains a pause at the end to work around ASTERISK-24414 for the time being. The 'expectedResult' property is set within the YAML file to expect the test to fail (and thus pass) while ASTERISK-24411 is unresolved however there appears to be a bug in testsuite as it's still marked as failed. Diffs - /asterisk/trunk/tests/channels/pjsip/registration/outbound/unregister/unauthed/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/registration/outbound/unregister/unauthed/sipp/unregister.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/registration/outbound/unregister/unauthed/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/registration/outbound/unregister/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/registration/outbound/tests.yaml 5726 Diff: https://reviewboard.asterisk.org/r/4077/diff/ Testing --- * Ran test in a shell loop 300 times without failure (with patch for Asterisk applied from ASTERISK-24411 and work around for ASTERISK-24414) * Ran test several times without patch applied from ASTERISK-24411 which constantly failed as expected. * Ran test several times without work around for ASTERISK-24414 which frequently failed as expected. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4080: Test Suite: Fix the 'expected-result' YAML property for test configuration
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4080/ --- (Updated Oct. 21, 2014, 9:57 a.m.) Review request for Asterisk Developers. Changes --- Added a new line. Repository: testsuite Description --- When the 'expected-result' (or 'expectedResult') YAML property for test configuration is set to False and the test fails, the test should be marked as passed. However it is marked as failed. This patch should fix the issue so that tests are marked as passed in this scenario. Additionally: * Check if p.returncode is not zero so self.passed is a boolean rather than an int in some cases. * Added some print statements to make it clear why a test was marked as passed or failed when the 'expected-result' YAML property is set to False. * Added text to the failure message so it's easily known when looking at the results file that the test was expected to fail but passed and therefore marked as failed. Diffs (updated) - /asterisk/trunk/runtests.py 5766 /asterisk/trunk/lib/python/asterisk/test_config.py 5766 Diff: https://reviewboard.asterisk.org/r/4080/diff/ Testing --- Tested the various scenarios and they all seem to properly work as expected now. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4080: Test Suite: Fix the 'expected-result' YAML property for test configuration
On Oct. 16, 2014, 5:29 p.m., Scott Griepentrog wrote: /asterisk/trunk/runtests.py, line 75 https://reviewboard.asterisk.org/r/4080/diff/2/?file=68354#file68354line75 This should include a + \n like line 59 does. jbigelow wrote: Line 59 adds a newline to visually separate the test that was run from the tests output. Line 67 doesn't add a new line to the tests output and I don't believe I should just for this message that I'm appending to the output either. Scott Griepentrog wrote: My concern is that another function executing later could (optionally, on some error) write to self.stdout. If there is zero possibility of that, then omitting the \n is not an issue. I don't see anything else being concatenated to self.stdout but can't guarantee some code will be added in the future that does so I've added the new line. - jbigelow --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4080/#review13558 --- On Oct. 20, 2014, 11:38 a.m., jbigelow wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4080/ --- (Updated Oct. 20, 2014, 11:38 a.m.) Review request for Asterisk Developers. Repository: testsuite Description --- When the 'expected-result' (or 'expectedResult') YAML property for test configuration is set to False and the test fails, the test should be marked as passed. However it is marked as failed. This patch should fix the issue so that tests are marked as passed in this scenario. Additionally: * Check if p.returncode is not zero so self.passed is a boolean rather than an int in some cases. * Added some print statements to make it clear why a test was marked as passed or failed when the 'expected-result' YAML property is set to False. * Added text to the failure message so it's easily known when looking at the results file that the test was expected to fail but passed and therefore marked as failed. Diffs - /asterisk/trunk/runtests.py 5726 /asterisk/trunk/lib/python/asterisk/test_config.py 5726 Diff: https://reviewboard.asterisk.org/r/4080/diff/ Testing --- Tested the various scenarios and they all seem to properly work as expected now. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4080: Test Suite: Fix the 'expected-result' YAML property for test configuration
On Oct. 16, 2014, 5:29 p.m., Scott Griepentrog wrote: /asterisk/trunk/runtests.py, line 75 https://reviewboard.asterisk.org/r/4080/diff/2/?file=68354#file68354line75 This should include a + \n like line 59 does. Line 59 adds a newline to visually separate the test that was run from the tests output. Line 67 doesn't add a new line to the tests output and I don't believe I should just for this message that I'm appending to the output either. - jbigelow --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4080/#review13558 --- On Oct. 20, 2014, 11:38 a.m., jbigelow wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4080/ --- (Updated Oct. 20, 2014, 11:38 a.m.) Review request for Asterisk Developers. Repository: testsuite Description --- When the 'expected-result' (or 'expectedResult') YAML property for test configuration is set to False and the test fails, the test should be marked as passed. However it is marked as failed. This patch should fix the issue so that tests are marked as passed in this scenario. Additionally: * Check if p.returncode is not zero so self.passed is a boolean rather than an int in some cases. * Added some print statements to make it clear why a test was marked as passed or failed when the 'expected-result' YAML property is set to False. * Added text to the failure message so it's easily known when looking at the results file that the test was expected to fail but passed and therefore marked as failed. Diffs - /asterisk/trunk/runtests.py 5726 /asterisk/trunk/lib/python/asterisk/test_config.py 5726 Diff: https://reviewboard.asterisk.org/r/4080/diff/ Testing --- Tested the various scenarios and they all seem to properly work as expected now. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4080: Test Suite: Fix the 'expected-result' YAML property for test configuration
On Oct. 15, 2014, 4:43 p.m., Matt Jordan wrote: /asterisk/trunk/runtests.py, lines 82-83 https://reviewboard.asterisk.org/r/4080/diff/1/?file=68347#file68347line82 While the extra parantheses are probably needed, generally, this doesn't feel like the pythonic way to write this (although the original code isn't either). You shouldn't have to explicitly test for 0 or not 0. self.passed = ((p.returncode and self.test_config.expect_pass) or (not p.returncode and not self.test_config.expect_pass)) This will evaluate self.passed to a boolean still. jbigelow wrote: test_runner.py returns 0 if passed and 1 if failed. So the above suggestion would need to be like so: self.passed = ((not p.returncode and self.test_config.expect_pass) or (p.returncode and not self.test_config.expect_pass)) However it's still possible for self.passed to be an INT. Maybe I've gone crazy but the below examples say I'm not. Example of not explicitly testing for 0 or not 0 as suggested: for returncode in (0, 1): ... for expect_pass in (True, False): ... ((not returncode and expect_pass) or (returncode and not expect_pass)) ... True 0 False True Example of explicitly testing for 0 and not 0 as posted for review: for returncode in (0, 1): ... for expect_pass in (True, False): ... ((returncode == 0 and expect_pass) or (returncode != 0 and not expect_pass)) ... True False False True Scott Griepentrog wrote: I did not notice this exchange before my review. Normally open issue sections are not collapsed, but that wasn't the case? My testing of the current patch showed correct function. After reviewing this discussion, I would suggest sanitizing p.returncode first to simplify the comparison thusly: for returncode in (0,1): ... for expect_pass in (True, False): ... did_pass = (returncode == 0) ... print returncode, expect_pass, did_pass, did_pass == expect_pass ... 0 True True True 0 False True False 1 True False False 1 False False True resulting in: did_pass = (p.returncode == 0) self.passed = (did_pass == expect_pass) Implemented Scott Griepentrog's suggestion. - jbigelow --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4080/#review13533 --- On Oct. 20, 2014, 11:38 a.m., jbigelow wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4080/ --- (Updated Oct. 20, 2014, 11:38 a.m.) Review request for Asterisk Developers. Repository: testsuite Description --- When the 'expected-result' (or 'expectedResult') YAML property for test configuration is set to False and the test fails, the test should be marked as passed. However it is marked as failed. This patch should fix the issue so that tests are marked as passed in this scenario. Additionally: * Check if p.returncode is not zero so self.passed is a boolean rather than an int in some cases. * Added some print statements to make it clear why a test was marked as passed or failed when the 'expected-result' YAML property is set to False. * Added text to the failure message so it's easily known when looking at the results file that the test was expected to fail but passed and therefore marked as failed. Diffs - /asterisk/trunk/runtests.py 5726 /asterisk/trunk/lib/python/asterisk/test_config.py 5726 Diff: https://reviewboard.asterisk.org/r/4080/diff/ Testing --- Tested the various scenarios and they all seem to properly work as expected now. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] [Code Review] 4080: Test Suite: Fix the 'expected-result' YAML property for test configuration
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4080/ --- Review request for Asterisk Developers. Repository: testsuite Description --- When the 'expected-result' (or 'expectedResult') YAML property for test configuration is set to False and the test fails, the test should be marked as passed. However it is marked as failed. This patch should fix the issue so that tests are marked as passed in this scenario. Additionally: * Check if p.returncode is not zero so self.passed is a boolean rather than an int in some cases. * Added some print statements to make it clear why a test was marked as passed or failed when the 'expected-result' YAML property is set to False. * Added text to the failure message so it's easily known when looking at the results file that the test was expected to fail but passed and therefore marked as failed. Diffs - /asterisk/trunk/runtests.py 5726 /asterisk/trunk/lib/python/asterisk/test_config.py 5726 Diff: https://reviewboard.asterisk.org/r/4080/diff/ Testing --- Tested the various scenarios and they all seem to properly work as expected now. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4080: Test Suite: Fix the 'expected-result' YAML property for test configuration
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4080/ --- (Updated Oct. 15, 2014, 5:34 p.m.) Review request for Asterisk Developers. Changes --- Removed 'NOTICE: ' from strings that are printed. Repository: testsuite Description --- When the 'expected-result' (or 'expectedResult') YAML property for test configuration is set to False and the test fails, the test should be marked as passed. However it is marked as failed. This patch should fix the issue so that tests are marked as passed in this scenario. Additionally: * Check if p.returncode is not zero so self.passed is a boolean rather than an int in some cases. * Added some print statements to make it clear why a test was marked as passed or failed when the 'expected-result' YAML property is set to False. * Added text to the failure message so it's easily known when looking at the results file that the test was expected to fail but passed and therefore marked as failed. Diffs (updated) - /asterisk/trunk/runtests.py 5726 /asterisk/trunk/lib/python/asterisk/test_config.py 5726 Diff: https://reviewboard.asterisk.org/r/4080/diff/ Testing --- Tested the various scenarios and they all seem to properly work as expected now. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 4080: Test Suite: Fix the 'expected-result' YAML property for test configuration
On Oct. 15, 2014, 4:43 p.m., Matt Jordan wrote: /asterisk/trunk/runtests.py, lines 82-83 https://reviewboard.asterisk.org/r/4080/diff/1/?file=68347#file68347line82 While the extra parantheses are probably needed, generally, this doesn't feel like the pythonic way to write this (although the original code isn't either). You shouldn't have to explicitly test for 0 or not 0. self.passed = ((p.returncode and self.test_config.expect_pass) or (not p.returncode and not self.test_config.expect_pass)) This will evaluate self.passed to a boolean still. test_runner.py returns 0 if passed and 1 if failed. So the above suggestion would need to be like so: self.passed = ((not p.returncode and self.test_config.expect_pass) or (p.returncode and not self.test_config.expect_pass)) However it's still possible for self.passed to be an INT. Maybe I've gone crazy but the below examples say I'm not. Example of not explicitly testing for 0 or not 0 as suggested: for returncode in (0, 1): ... for expect_pass in (True, False): ... ((not returncode and expect_pass) or (returncode and not expect_pass)) ... True 0 False True Example of explicitly testing for 0 and not 0 as posted for review: for returncode in (0, 1): ... for expect_pass in (True, False): ... ((returncode == 0 and expect_pass) or (returncode != 0 and not expect_pass)) ... True False False True - jbigelow --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4080/#review13533 --- On Oct. 15, 2014, 5:34 p.m., jbigelow wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4080/ --- (Updated Oct. 15, 2014, 5:34 p.m.) Review request for Asterisk Developers. Repository: testsuite Description --- When the 'expected-result' (or 'expectedResult') YAML property for test configuration is set to False and the test fails, the test should be marked as passed. However it is marked as failed. This patch should fix the issue so that tests are marked as passed in this scenario. Additionally: * Check if p.returncode is not zero so self.passed is a boolean rather than an int in some cases. * Added some print statements to make it clear why a test was marked as passed or failed when the 'expected-result' YAML property is set to False. * Added text to the failure message so it's easily known when looking at the results file that the test was expected to fail but passed and therefore marked as failed. Diffs - /asterisk/trunk/runtests.py 5726 /asterisk/trunk/lib/python/asterisk/test_config.py 5726 Diff: https://reviewboard.asterisk.org/r/4080/diff/ Testing --- Tested the various scenarios and they all seem to properly work as expected now. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] [Code Review] 4077: Test Suite: Unregister registered outbound registrations
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4077/ --- Review request for Asterisk Developers. Repository: testsuite Description --- This tests unregistering outbound registrations that are registered using the PJSIPUnregister AMI action. It ensures that Asterisk sends a REGISTER message with an Expires header of '0' upon executing the PJSIPUnregister AMI action and that AMI Registry events are present with a status of Unregistered. The test uses all combinations of IPv4/IPv6 and UDP/TCP. Upon an outbound registration registering, the PJSIPUnregister action is executed to unregister it. SIPp is used as the registrar to respond when Asterisk registers and unregisters where the Expires header is checked. Note: This test currently fails due to the following Asterisk bugs: * https://issues.asterisk.org/jira/browse/ASTERISK-24411 * https://issues.asterisk.org/jira/browse/ASTERISK-24414 The SIPp scenario contains a pause at the end to work around ASTERISK-24414 for the time being. The 'expectedResult' property is set within the YAML file to expect the test to fail (and thus pass) while ASTERISK-24411 is unresolved however there appears to be a bug in testsuite as it's still marked as failed. Diffs - /asterisk/trunk/tests/channels/pjsip/registration/outbound/unregister/unauthed/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/registration/outbound/unregister/unauthed/sipp/unregister.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/registration/outbound/unregister/unauthed/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/registration/outbound/unregister/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/registration/outbound/tests.yaml 5726 Diff: https://reviewboard.asterisk.org/r/4077/diff/ Testing --- * Ran test in a shell loop 300 times without failure (with patch for Asterisk applied from ASTERISK-24411 and work around for ASTERISK-24414) * Ran test several times without patch applied from ASTERISK-24411 which constantly failed as expected. * Ran test several times without work around for ASTERISK-24414 which frequently failed as expected. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3348: Test Suite: MWI subscription test for PJSIP
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3348/ --- (Updated April 16, 2014, 4:46 p.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers. Changes --- Committed in revision 4961 Bugs: ASTERISK-23343 https://issues.asterisk.org/jira/browse/ASTERISK-23343 Repository: testsuite Description --- This test depends on some changes in the PJSIP python library pjsua.py. The plan is to submit this upstream. See in-line with this description below. This basic nominal test ensures that a mailbox on an AOR for an enpoint can be subscribed to for MWI and that a NOTIFY is received. It creates endpoint alice with subscribing to MWI. Upon receiving a notify for message summary indicating no messages the test will be marked as passed otherwise it will be failed. The other two tests on ASTERISK-23343 aren't currently possible with the PJSUA API v1 and are up for review at https://reviewboard.asterisk.org/r/3354/ with using SIPp. Note: the following patch for pjsua.py adds modify_account() which isn't currently used by the testsuite but was added for possible future use. Index: pjsip-apps/src/python/pjsua.py === --- pjsip-apps/src/python/pjsua.py (revision 4791) +++ pjsip-apps/src/python/pjsua.py (working copy) @@ -775,6 +775,7 @@ use_srtp = 0 srtp_secure_signaling = 1 rtp_transport_cfg = None +mwi_enabled = False def __init__(self, domain=, username=, password=, display=, registrar=, proxy=): @@ -865,6 +866,7 @@ self.ka_data = cfg.ka_data self.use_srtp = cfg.use_srtp self.srtp_secure_signaling = cfg.srtp_secure_signaling +self.mwi_enabled = cfg.mwi_enabled if (self.rtp_transport_cfg is not None): self.rtp_transport_cfg._cvt_from_pjsua(cfg.rtp_transport_cfg) @@ -896,6 +898,7 @@ cfg.ka_data = self.ka_data cfg.use_srtp = self.use_srtp cfg.srtp_secure_signaling = self.srtp_secure_signaling +cfg.mwi_enabled = self.mwi_enabled if (self.rtp_transport_cfg is not None): cfg.rtp_transport_cfg = self.rtp_transport_cfg._cvt_to_pjsua() @@ -2337,6 +2340,18 @@ self._err_check(create_account_for_transport(), self, err) return Account(self, acc_id, cb) +def modify_account(self, acc_id, acc_config): +Modify configuration of a pjsua account. + +Keyword arguments: +acc_id -- ID of the account to be modified. +acc_config -- New account configuration. + + +lck = self.auto_lock() +err = _pjsua.acc_modify(acc_id, acc_config._cvt_to_pjsua()) +self._err_check(modify_account(), self, err) + def hangup_all(self): Hangup all calls. Diffs - /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/tests.yaml 4836 /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/basic_mailbox_subscribe/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/basic_mailbox_subscribe/subscribe.py PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/basic_mailbox_subscribe/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/basic_mailbox_subscribe/configs/ast1/modules.conf PRE-CREATION /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 4836 Diff: https://reviewboard.asterisk.org/r/3348/diff/ Testing --- * Ensured tests pass on multiple executions * Ensured the testsuite Asterisk logs looked good. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3407: Test Suite: Nominal caller initiated blind transfer tests using PJSIP
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3407/ --- (Updated April 16, 2014, 5:34 p.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers. Changes --- Committed in revision 4964 Bugs: ASTERISK-23446 https://issues.asterisk.org/jira/browse/ASTERISK-23446 Repository: testsuite Description --- These tests cover nominal caller initiated blind transfer tests using PJSIP. Note: All three tests currently fail due to the issues described in ASTERISK-23501 ASTERISK-23502. Each test ensures the presents and values of the following: * channel variables SIPREFERREDBYHDR, SIPREFERTOHDR, SIPTRANSFER, and SIPREFERRINGCONTEXT. * the BlindTransfer event. * the 'Referred-By' header in the INVITE sent to Charlie. Each test also sets the TRANSFER_CONTEXT channel variable to ensure the transfer still occurs properly. The 'caller_with_hold' test additionally requires and checks the MusicOnHoldStart MusicOnHoldStop events. Tests: * caller_refer_only: Uses PJSua library. Basic blind transfer without a hold or direct media being performed at any time. Changes were required to the pjsua_mod.py library to be able to associate pjsua accounts with a specific pjsua transport. * caller_direct_media: Uses SIPp. Blind transfer with direct media between the endpoints before and after the transfer. * caller_with_hold: Uses SIPp. Blind transfer with putting the callee on hold before the transfer. Diffs - /asterisk/trunk/tests/channels/pjsip/transfers/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/charlie.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/bob.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/alice.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/transfer.py PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/charlie.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/bob.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/alice.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/tests.yaml 4911 /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 4911 Diff: https://reviewboard.asterisk.org/r/3407/diff/ Testing --- * Added a pre-dial handler when dialing charlie to add the Referred-By header and commented out the header match for the SIPREFERTOHDR channel variable. This was to mimic a successful pass to validate the test. This was done for each. ** Executed tests in a loop 50+ times to ensure stability. * Reviewed test suite Asterisk logs. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3444: Testsuite: PJSIP Callee Initiated Nominal Blind Transfers
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3444/#review11644 --- ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_hold/test-config.yaml https://reviewboard.asterisk.org/r/3444/#comment21405 Should be blind transfers Alice to Charlie. - jbigelow On April 14, 2014, 4:17 p.m., Scott Emidy wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3444/ --- (Updated April 14, 2014, 4:17 p.m.) Review request for Asterisk Developers. Bugs: ASTERISK-23447 https://issues.asterisk.org/jira/browse/ASTERISK-23447 Repository: testsuite Description --- These three tests involve using PJSIP in order to execute callee initiated blind transfers. Also all three of these tests fail due to the unresolved issues ASTERISK-23501 and ASTERISK-23502. These tests required a few aspects in each test such as the SIPREFERTOHDR, SIPREFERREDBYHDR, SIPTRANSFER, SIPREFERRINGCONTEXT, BLINDTRANSFER Event, TRANSFER_CONTEXT that comes into play in the second iterations, and Referred-By header. MusicOnHOldStart and MusicOnHoldStop were only required for the callee_hold test. The three tests were: 1) Callee initiated transfer with direct media (callee_direct_media) - This consists of direct media being initiated between the endpoints before and after the transfer. 2) Callee initiated transfer with hold (callee_hold) - This consists of a blind transfer that puts the caller on hold before they are transferred. 3) Callee initiated transfer with REFER only (callee_only_refer) - This consists of no hold or media just a basic REFER. Also John Bigelow made changes to the pjsua_mod.py to be able to associate pjsua accounts with a specific pjsua transport. Diffs - ./asterisk/trunk/tests/channels/pjsip/transfers/tests.yaml PRE-CREATION ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/tests.yaml PRE-CREATION ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_only_refer/transfer.py PRE-CREATION ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_only_refer/test-config.yaml PRE-CREATION ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_only_refer/configs/ast1/pjsip.conf PRE-CREATION ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_only_refer/configs/ast1/extensions.conf PRE-CREATION ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_hold/test-config.yaml PRE-CREATION ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_hold/sipp/charlie.xml PRE-CREATION ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_hold/sipp/bob.xml PRE-CREATION ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_hold/sipp/alice.xml PRE-CREATION ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_hold/configs/ast1/pjsip.conf PRE-CREATION ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_hold/configs/ast1/extensions.conf PRE-CREATION ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_direct_media/test-config.yaml PRE-CREATION ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_direct_media/sipp/charlie.xml PRE-CREATION ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_direct_media/sipp/bob.xml PRE-CREATION ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_direct_media/sipp/alice.xml PRE-CREATION ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_direct_media/configs/ast1/pjsip.conf PRE-CREATION ./asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/callee_direct_media/configs/ast1/extensions.conf PRE-CREATION ./asterisk/trunk/tests/channels/pjsip/tests.yaml 4957 ./asterisk/trunk/lib/python/asterisk/pjsua_mod.py 4957 Diff: https://reviewboard.asterisk.org/r/3444/diff/ Testing --- Thanks, Scott Emidy -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3407: Test Suite: Nominal caller initiated blind transfer tests using PJSIP
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3407/ --- (Updated April 4, 2014, 5:44 p.m.) Review request for Asterisk Developers. Changes --- Addressed all feedback. Bugs: ASTERISK-23446 https://issues.asterisk.org/jira/browse/ASTERISK-23446 Repository: testsuite Description --- These tests cover nominal caller initiated blind transfer tests using PJSIP. Note: All three tests currently fail due to the issues described in ASTERISK-23501 ASTERISK-23502. Each test ensures the presents and values of the following: * channel variables SIPREFERREDBYHDR, SIPREFERTOHDR, SIPTRANSFER, and SIPREFERRINGCONTEXT. * the BlindTransfer event. * the 'Referred-By' header in the INVITE sent to Charlie. Each test also sets the TRANSFER_CONTEXT channel variable to ensure the transfer still occurs properly. The 'caller_with_hold' test additionally requires and checks the MusicOnHoldStart MusicOnHoldStop events. Tests: * caller_refer_only: Uses PJSua library. Basic blind transfer without a hold or direct media being performed at any time. Changes were required to the pjsua_mod.py library to be able to associate pjsua accounts with a specific pjsua transport. * caller_direct_media: Uses SIPp. Blind transfer with direct media between the endpoints before and after the transfer. * caller_with_hold: Uses SIPp. Blind transfer with putting the callee on hold before the transfer. Diffs (updated) - /asterisk/trunk/tests/channels/pjsip/transfers/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/charlie.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/bob.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/alice.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/transfer.py PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/charlie.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/bob.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/alice.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/tests.yaml 4911 /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 4911 Diff: https://reviewboard.asterisk.org/r/3407/diff/ Testing --- * Added a pre-dial handler when dialing charlie to add the Referred-By header and commented out the header match for the SIPREFERTOHDR channel variable. This was to mimic a successful pass to validate the test. This was done for each. ** Executed tests in a loop 50+ times to ensure stability. * Reviewed test suite Asterisk logs. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3407: Test Suite: Nominal caller initiated blind transfer tests using PJSIP
On April 3, 2014, 2:24 p.m., Mark Michelson wrote: /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/test-config.yaml, lines 46-54 https://reviewboard.asterisk.org/r/3407/diff/1/?file=56911#file56911line46 The comments here contradict what is said in the test description. The test description says that Alice transfers Bob to Charlie, but these comments say that Bob transfers Alice to Charlie. Same applies for the second scenario. I blame my copy paste for not automatically making the changes. :) - jbigelow --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3407/#review11484 --- On April 4, 2014, 5:44 p.m., jbigelow wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3407/ --- (Updated April 4, 2014, 5:44 p.m.) Review request for Asterisk Developers. Bugs: ASTERISK-23446 https://issues.asterisk.org/jira/browse/ASTERISK-23446 Repository: testsuite Description --- These tests cover nominal caller initiated blind transfer tests using PJSIP. Note: All three tests currently fail due to the issues described in ASTERISK-23501 ASTERISK-23502. Each test ensures the presents and values of the following: * channel variables SIPREFERREDBYHDR, SIPREFERTOHDR, SIPTRANSFER, and SIPREFERRINGCONTEXT. * the BlindTransfer event. * the 'Referred-By' header in the INVITE sent to Charlie. Each test also sets the TRANSFER_CONTEXT channel variable to ensure the transfer still occurs properly. The 'caller_with_hold' test additionally requires and checks the MusicOnHoldStart MusicOnHoldStop events. Tests: * caller_refer_only: Uses PJSua library. Basic blind transfer without a hold or direct media being performed at any time. Changes were required to the pjsua_mod.py library to be able to associate pjsua accounts with a specific pjsua transport. * caller_direct_media: Uses SIPp. Blind transfer with direct media between the endpoints before and after the transfer. * caller_with_hold: Uses SIPp. Blind transfer with putting the callee on hold before the transfer. Diffs - /asterisk/trunk/tests/channels/pjsip/transfers/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/charlie.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/bob.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/alice.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/transfer.py PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/charlie.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/bob.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/alice.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/tests.yaml 4911 /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 4911 Diff: https://reviewboard.asterisk.org/r/3407/diff/ Testing --- * Added a pre-dial handler when dialing charlie to add the Referred-By header and commented out the header match for the SIPREFERTOHDR channel variable. This was to mimic a successful pass to validate the test. This was done
[asterisk-dev] [Code Review] 3407: Test Suite: Nominal caller initiated blind transfer tests using PJSIP
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3407/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23446 https://issues.asterisk.org/jira/browse/ASTERISK-23446 Repository: testsuite Description --- These tests cover nominal caller initiated blind transfer tests using PJSIP. Note: All three tests currently fail due to the issues described in ASTERISK-23501 ASTERISK-23502. Each test ensures the presents and values of the following: * channel variables SIPREFERREDBYHDR, SIPREFERTOHDR, SIPTRANSFER, and SIPREFERRINGCONTEXT. * the BlindTransfer event. * the 'Referred-By' header in the INVITE sent to Charlie. Each test also sets the TRANSFER_CONTEXT channel variable to ensure the transfer still occurs properly. The 'caller_with_hold' test additionally requires and checks the MusicOnHoldStart MusicOnHoldStop events. Tests: * caller_refer_only: Uses PJSua library. Basic blind transfer without a hold or direct media being performed at any time. Changes were required to the pjsua_mod.py library to be able to associate pjsua accounts with a specific pjsua transport. * caller_direct_media: Uses SIPp. Blind transfer with direct media between the endpoints before and after the transfer. * caller_with_hold: Uses SIPp. Blind transfer with putting the callee on hold before the transfer. Diffs - /asterisk/trunk/tests/channels/pjsip/transfers/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/charlie.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/bob.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/sipp/alice.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_with_hold/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/transfer.py PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_refer_only/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/charlie.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/bob.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/sipp/alice.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/transfers/blind_transfer/caller_direct_media/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/tests.yaml 4911 /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 4911 Diff: https://reviewboard.asterisk.org/r/3407/diff/ Testing --- * Added a pre-dial handler when dialing charlie to add the Referred-By header and commented out the header match for the SIPREFERTOHDR channel variable. This was to mimic a successful pass to validate the test. This was done for each. ** Executed tests in a loop 50+ times to ensure stability. * Reviewed test suite Asterisk logs. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3354: Test Suite: MWI subscribe, re-subscribe, and un-subscribe test for PJSIP
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3354/ --- (Updated March 24, 2014, 9:14 a.m.) Status -- This change has been marked as submitted. Review request for Asterisk Developers. Changes --- Committed in revision 4886 Bugs: ASTERISK-23343 https://issues.asterisk.org/jira/browse/ASTERISK-23343 Repository: testsuite Description --- This basic nominal test ensures that a mailbox on an AOR for an endpoint can be subscribed to for MWI, re-subscribe, and un-subscribe. It ensures the Event and Subscription-State headers of the NOTIFY are what is expected. This takes care the first two tests listed on ASTERISK-23343 and uses SIPp instead of the PJSUA library as used for the 3rd test up for review at https://reviewboard.asterisk.org/r/3348/ Diffs - /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/tests.yaml 4836 /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/sub_setup_teardown/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/sub_setup_teardown/sipp/mwi_subscription.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/sub_setup_teardown/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/sub_setup_teardown/configs/ast1/modules.conf PRE-CREATION Diff: https://reviewboard.asterisk.org/r/3354/diff/ Testing --- * Ensured tests pass on multiple executions * Ensured the testsuite Asterisk logs looked good. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3348: Test Suite: MWI subscription test for PJSIP
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3348/ --- (Updated March 21, 2014, 9:20 a.m.) Review request for Asterisk Developers. Changes --- Addressed issues. Bugs: ASTERISK-23343 https://issues.asterisk.org/jira/browse/ASTERISK-23343 Repository: testsuite Description --- This test depends on some changes in the PJSIP python library pjsua.py. The plan is to submit this upstream. See in-line with this description below. This basic nominal test ensures that a mailbox on an AOR for an enpoint can be subscribed to for MWI and that a NOTIFY is received. It creates endpoint alice with subscribing to MWI. Upon receiving a notify for message summary indicating no messages the test will be marked as passed otherwise it will be failed. The other two tests on ASTERISK-23343 aren't currently possible with the PJSUA API v1 and are up for review at https://reviewboard.asterisk.org/r/3354/ with using SIPp. Note: the following patch for pjsua.py adds modify_account() which isn't currently used by the testsuite but was added for possible future use. Index: pjsip-apps/src/python/pjsua.py === --- pjsip-apps/src/python/pjsua.py (revision 4791) +++ pjsip-apps/src/python/pjsua.py (working copy) @@ -775,6 +775,7 @@ use_srtp = 0 srtp_secure_signaling = 1 rtp_transport_cfg = None +mwi_enabled = False def __init__(self, domain=, username=, password=, display=, registrar=, proxy=): @@ -865,6 +866,7 @@ self.ka_data = cfg.ka_data self.use_srtp = cfg.use_srtp self.srtp_secure_signaling = cfg.srtp_secure_signaling +self.mwi_enabled = cfg.mwi_enabled if (self.rtp_transport_cfg is not None): self.rtp_transport_cfg._cvt_from_pjsua(cfg.rtp_transport_cfg) @@ -896,6 +898,7 @@ cfg.ka_data = self.ka_data cfg.use_srtp = self.use_srtp cfg.srtp_secure_signaling = self.srtp_secure_signaling +cfg.mwi_enabled = self.mwi_enabled if (self.rtp_transport_cfg is not None): cfg.rtp_transport_cfg = self.rtp_transport_cfg._cvt_to_pjsua() @@ -2337,6 +2340,18 @@ self._err_check(create_account_for_transport(), self, err) return Account(self, acc_id, cb) +def modify_account(self, acc_id, acc_config): +Modify configuration of a pjsua account. + +Keyword arguments: +acc_id -- ID of the account to be modified. +acc_config -- New account configuration. + + +lck = self.auto_lock() +err = _pjsua.acc_modify(acc_id, acc_config._cvt_to_pjsua()) +self._err_check(modify_account(), self, err) + def hangup_all(self): Hangup all calls. Diffs (updated) - /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/tests.yaml 4836 /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/basic_mailbox_subscribe/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/basic_mailbox_subscribe/subscribe.py PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/basic_mailbox_subscribe/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/basic_mailbox_subscribe/configs/ast1/modules.conf PRE-CREATION /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 4836 Diff: https://reviewboard.asterisk.org/r/3348/diff/ Testing --- * Ensured tests pass on multiple executions * Ensured the testsuite Asterisk logs looked good. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3348: Test Suite: MWI subscription test for PJSIP
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3348/ --- (Updated March 14, 2014, 9:24 a.m.) Review request for Asterisk Developers. Changes --- Link to other test up for review with related tests. Bugs: ASTERISK-23343 https://issues.asterisk.org/jira/browse/ASTERISK-23343 Repository: testsuite Description (updated) --- This test depends on some changes in the PJSIP python library pjsua.py. The plan is to submit this upstream. See in-line with this description below. This basic nominal test ensures that a mailbox on an AOR for an enpoint can be subscribed to for MWI and that a NOTIFY is received. It creates endpoint alice with subscribing to MWI. Upon receiving a notify for message summary indicating no messages the test will be marked as passed otherwise it will be failed. The other two tests on ASTERISK-23343 aren't currently possible with the PJSUA API v1 and are up for review at https://reviewboard.asterisk.org/r/3354/ with using SIPp. Note: the following patch for pjsua.py adds modify_account() which isn't currently used by the testsuite but was added for possible future use. Index: pjsip-apps/src/python/pjsua.py === --- pjsip-apps/src/python/pjsua.py (revision 4791) +++ pjsip-apps/src/python/pjsua.py (working copy) @@ -775,6 +775,7 @@ use_srtp = 0 srtp_secure_signaling = 1 rtp_transport_cfg = None +mwi_enabled = False def __init__(self, domain=, username=, password=, display=, registrar=, proxy=): @@ -865,6 +866,7 @@ self.ka_data = cfg.ka_data self.use_srtp = cfg.use_srtp self.srtp_secure_signaling = cfg.srtp_secure_signaling +self.mwi_enabled = cfg.mwi_enabled if (self.rtp_transport_cfg is not None): self.rtp_transport_cfg._cvt_from_pjsua(cfg.rtp_transport_cfg) @@ -896,6 +898,7 @@ cfg.ka_data = self.ka_data cfg.use_srtp = self.use_srtp cfg.srtp_secure_signaling = self.srtp_secure_signaling +cfg.mwi_enabled = self.mwi_enabled if (self.rtp_transport_cfg is not None): cfg.rtp_transport_cfg = self.rtp_transport_cfg._cvt_to_pjsua() @@ -2337,6 +2340,18 @@ self._err_check(create_account_for_transport(), self, err) return Account(self, acc_id, cb) +def modify_account(self, acc_id, acc_config): +Modify configuration of a pjsua account. + +Keyword arguments: +acc_id -- ID of the account to be modified. +acc_config -- New account configuration. + + +lck = self.auto_lock() +err = _pjsua.acc_modify(acc_id, acc_config._cvt_to_pjsua()) +self._err_check(modify_account(), self, err) + def hangup_all(self): Hangup all calls. Diffs - /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/tests.yaml 4836 /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/basic_mailbox_subscribe/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/basic_mailbox_subscribe/subscribe.py PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/basic_mailbox_subscribe/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/basic_mailbox_subscribe/configs/ast1/modules.conf PRE-CREATION /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 4836 Diff: https://reviewboard.asterisk.org/r/3348/diff/ Testing --- * Ensured tests pass on multiple executions * Ensured the testsuite Asterisk logs looked good. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] [Code Review] 3348: Test Suite: MWI subscription test for PJSIP
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3348/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23343 https://issues.asterisk.org/jira/browse/ASTERISK-23343 Repository: testsuite Description --- This test depends on some changes in the PJSIP python library pjsua.py. The plan is to submit this upstream. See in-line with this description below. This basic nominal test ensures that a mailbox on an AOR for an enpoint can be subscribed to for MWI and that a NOTIFY is received. It creates endpoint alice with subscribing to MWI. Upon receiving a notify for message summary indicating no messages the test will be marked as passed otherwise it will be failed. The other two tests on ASTERISK-23343 aren't currently possible with the PJSUA API v1. Note: the following patch for pjsua.py adds modify_account() which isn't currently used by the testsuite but was added for possible future use. Index: pjsip-apps/src/python/pjsua.py === --- pjsip-apps/src/python/pjsua.py (revision 4791) +++ pjsip-apps/src/python/pjsua.py (working copy) @@ -775,6 +775,7 @@ use_srtp = 0 srtp_secure_signaling = 1 rtp_transport_cfg = None +mwi_enabled = False def __init__(self, domain=, username=, password=, display=, registrar=, proxy=): @@ -865,6 +866,7 @@ self.ka_data = cfg.ka_data self.use_srtp = cfg.use_srtp self.srtp_secure_signaling = cfg.srtp_secure_signaling +self.mwi_enabled = cfg.mwi_enabled if (self.rtp_transport_cfg is not None): self.rtp_transport_cfg._cvt_from_pjsua(cfg.rtp_transport_cfg) @@ -896,6 +898,7 @@ cfg.ka_data = self.ka_data cfg.use_srtp = self.use_srtp cfg.srtp_secure_signaling = self.srtp_secure_signaling +cfg.mwi_enabled = self.mwi_enabled if (self.rtp_transport_cfg is not None): cfg.rtp_transport_cfg = self.rtp_transport_cfg._cvt_to_pjsua() @@ -2337,6 +2340,18 @@ self._err_check(create_account_for_transport(), self, err) return Account(self, acc_id, cb) +def modify_account(self, acc_id, acc_config): +Modify configuration of a pjsua account. + +Keyword arguments: +acc_id -- ID of the account to be modified. +acc_config -- New account configuration. + + +lck = self.auto_lock() +err = _pjsua.acc_modify(acc_id, acc_config._cvt_to_pjsua()) +self._err_check(modify_account(), self, err) + def hangup_all(self): Hangup all calls. Diffs - /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/tests.yaml 4836 /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/basic_mailbox_subscribe/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/basic_mailbox_subscribe/subscribe.py PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/basic_mailbox_subscribe/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/basic_mailbox_subscribe/configs/ast1/modules.conf PRE-CREATION /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 4836 Diff: https://reviewboard.asterisk.org/r/3348/diff/ Testing --- * Ensured tests pass on multiple executions * Ensured the testsuite Asterisk logs looked good. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3348: Test Suite: MWI subscription test for PJSIP
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3348/ --- (Updated March 13, 2014, 4:27 p.m.) Review request for Asterisk Developers. Changes --- Updated to handle the scenario of the on_mwi_info() callback not be called. Bugs: ASTERISK-23343 https://issues.asterisk.org/jira/browse/ASTERISK-23343 Repository: testsuite Description --- This test depends on some changes in the PJSIP python library pjsua.py. The plan is to submit this upstream. See in-line with this description below. This basic nominal test ensures that a mailbox on an AOR for an enpoint can be subscribed to for MWI and that a NOTIFY is received. It creates endpoint alice with subscribing to MWI. Upon receiving a notify for message summary indicating no messages the test will be marked as passed otherwise it will be failed. The other two tests on ASTERISK-23343 aren't currently possible with the PJSUA API v1. Note: the following patch for pjsua.py adds modify_account() which isn't currently used by the testsuite but was added for possible future use. Index: pjsip-apps/src/python/pjsua.py === --- pjsip-apps/src/python/pjsua.py (revision 4791) +++ pjsip-apps/src/python/pjsua.py (working copy) @@ -775,6 +775,7 @@ use_srtp = 0 srtp_secure_signaling = 1 rtp_transport_cfg = None +mwi_enabled = False def __init__(self, domain=, username=, password=, display=, registrar=, proxy=): @@ -865,6 +866,7 @@ self.ka_data = cfg.ka_data self.use_srtp = cfg.use_srtp self.srtp_secure_signaling = cfg.srtp_secure_signaling +self.mwi_enabled = cfg.mwi_enabled if (self.rtp_transport_cfg is not None): self.rtp_transport_cfg._cvt_from_pjsua(cfg.rtp_transport_cfg) @@ -896,6 +898,7 @@ cfg.ka_data = self.ka_data cfg.use_srtp = self.use_srtp cfg.srtp_secure_signaling = self.srtp_secure_signaling +cfg.mwi_enabled = self.mwi_enabled if (self.rtp_transport_cfg is not None): cfg.rtp_transport_cfg = self.rtp_transport_cfg._cvt_to_pjsua() @@ -2337,6 +2340,18 @@ self._err_check(create_account_for_transport(), self, err) return Account(self, acc_id, cb) +def modify_account(self, acc_id, acc_config): +Modify configuration of a pjsua account. + +Keyword arguments: +acc_id -- ID of the account to be modified. +acc_config -- New account configuration. + + +lck = self.auto_lock() +err = _pjsua.acc_modify(acc_id, acc_config._cvt_to_pjsua()) +self._err_check(modify_account(), self, err) + def hangup_all(self): Hangup all calls. Diffs (updated) - /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/tests.yaml 4836 /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/basic_mailbox_subscribe/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/basic_mailbox_subscribe/subscribe.py PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/basic_mailbox_subscribe/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/basic_mailbox_subscribe/configs/ast1/modules.conf PRE-CREATION /asterisk/trunk/lib/python/asterisk/pjsua_mod.py 4836 Diff: https://reviewboard.asterisk.org/r/3348/diff/ Testing --- * Ensured tests pass on multiple executions * Ensured the testsuite Asterisk logs looked good. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
Re: [asterisk-dev] [Code Review] 3288: Test Suite: PJSIP presence un-subscribe re-subscribe tests
/asterisk/trunk/tests/channels/pjsip/mwi/configs/ast1/pjsip.conf 4799 /asterisk/trunk/tests/channels/pjsip/mwi/configs/ast1/modules.conf 4799 Diff: https://reviewboard.asterisk.org/r/3288/diff/ Testing --- * Ensured tests pass on multiple executions * Ensured the testsuite Asterisk logs looked good. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev
[asterisk-dev] [Code Review] 3288: Test Suite: PJSIP presence un-subscribe re-subscribe tests
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3288/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23344 https://issues.asterisk.org/jira/browse/ASTERISK-23344 Repository: testsuite Description --- These tests cover re-subscribe and un-subscribe for presence using PJSIP. Note: This review request also re-organizes existing subscription tests. Tests: * unsubscribe - Nominal test using the pjsua pluggable module where alice subscribes to bob. Alice then un-subscribes (expiration of '0') and the pass result is set based upon the subscription state being reported as terminated. Otherwise the fail result is set. * resubscribe - Nominal test that uses SIPp (aka. alice) to subscribe to bob with an expiration of 300. Upon successfully subscribing, alice then subscribes to bob again but with an expiration of 600. This ensures the re-subscribe is successful per receiving a 200 response and a Notify with the expected expiration in the Subscription-State header. Diffs - /asterisk/trunk/tests/channels/pjsip/tests.yaml 4765 /asterisk/trunk/tests/channels/pjsip/subscriptions/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/unsubscribe/unsubscribe.py PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/unsubscribe/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/unsubscribe/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/unsubscribe/configs/ast1/modules.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/unsubscribe/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/resubscribe/test-config.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/resubscribe/sipp/subscribe.xml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/resubscribe/configs/ast1/pjsip.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/resubscribe/configs/ast1/modules.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/presence/resubscribe/configs/ast1/extensions.conf PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscriptions/mwi/tests.yaml PRE-CREATION /asterisk/trunk/tests/channels/pjsip/subscribe/tests.yaml 4765 /asterisk/trunk/tests/channels/pjsip/subscribe/missing_aor/test-config.yaml 4765 /asterisk/trunk/tests/channels/pjsip/subscribe/missing_aor/sipp/subscribe.xml 4765 /asterisk/trunk/tests/channels/pjsip/subscribe/missing_aor/run-test 4765 /asterisk/trunk/tests/channels/pjsip/subscribe/missing_aor/configs/ast1/pjsip.conf 4765 /asterisk/trunk/tests/channels/pjsip/subscribe/missing_aor/configs/ast1/modules.conf 4765 /asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/test-config.yaml 4765 /asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/sipp/subscribe.xml 4765 /asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/run-test 4765 /asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/configs/ast1/pjsip.conf 4765 /asterisk/trunk/tests/channels/pjsip/subscribe/digium_presence/configs/ast1/extensions.conf 4765 /asterisk/trunk/tests/channels/pjsip/presence_xpidf/test-config.yaml 4765 /asterisk/trunk/tests/channels/pjsip/presence_xpidf/state_check.py 4765 /asterisk/trunk/tests/channels/pjsip/presence_xpidf/configs/ast1/pjsip.conf 4765 /asterisk/trunk/tests/channels/pjsip/presence_xpidf/configs/ast1/modules.conf 4765 /asterisk/trunk/tests/channels/pjsip/presence_xpidf/configs/ast1/extensions.conf 4765 /asterisk/trunk/tests/channels/pjsip/presence_pidf/test-config.yaml 4765 /asterisk/trunk/tests/channels/pjsip/presence_pidf/state_check.py 4765 /asterisk/trunk/tests/channels/pjsip/presence_pidf/configs/ast1/pjsip.conf 4765 /asterisk/trunk/tests/channels/pjsip/presence_pidf/configs/ast1/modules.conf 4765 /asterisk/trunk/tests/channels/pjsip/presence_pidf/configs/ast1/extensions.conf 4765 /asterisk/trunk/tests/channels/pjsip/mwi/test-config.yaml 4765 /asterisk/trunk/tests/channels/pjsip/mwi/mwi_check.py 4765 /asterisk/trunk/tests/channels/pjsip/mwi/configs/ast1/pjsip.conf 4765 /asterisk/trunk/tests/channels/pjsip/mwi/configs/ast1/modules.conf 4765 Diff: https://reviewboard.asterisk.org/r/3288/diff/ Testing --- * Ensured tests pass on multiple executions * Ensured the testsuite Asterisk logs looked good. Thanks, jbigelow -- _ -- Bandwidth and Colocation Provided by http://www.api
