://reviewboard.asterisk.org/r/4470/diff/
Testing
---
* Executed each test successfully 50+ times on local system and build agent
where the test would sometimes fail.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api
/asterisk/trunk/lib/python/asterisk/phones.py 6506
Diff: https://reviewboard.asterisk.org/r/4470/diff/
Testing
---
* Executed each test successfully 50+ times on local system and build agent
where the test would sometimes fail.
Thanks,
jbigelow
---
* Executed each test successfully 30+ times.
* Changed the code to force a failure to ensure tests properly failed.
* Review logs to ensure operation is as expected.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided
successfully 30+ times.
* Changed the code to force a failure to ensure tests properly failed.
* Review logs to ensure operation is as expected.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com
using the ua_cfg variable anywhere else that I
can tell.
I'm using 'ua_cfg' to be able to set max_calls.
On March 5, 2015, 1:53 p.m., jbigelow wrote:
I see a lot of duplication in the run-test files. I suggest that we
refactor and abstract the common pieces of code into a base class
tests properly failed.
* Review logs to ensure operation is as expected.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options
tests properly failed.
* Review logs to ensure operation is as expected.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options
that a no-op?
Good question. I used 'tests/rest_api/channels/redirect/nominal/run-test' as a
base and I'm not sure why myself. I've removed it though.
- jbigelow
---
This is an automatically generated e-mail. To reply, visit:
https
operation is as expected.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo
,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
pluggable object?
jbigelow wrote:
If that condition is removed then it will blow up if callback_module
callback_method are not defined in YAML and pjsua_mod.PJsua is being used as
a test module. If it remains with the same scenario then things won't blow up
and no user code is called
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
/11/659ab31f-8401-4f24-be5e-da1db0be3156__test-config.yaml
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http
aren't received and
actions don't fire. Therefore those events/actions in the YAML haven't been
tested.
* Executed tests multiple times.
* Reviewed logs to ensure the tests were executing as expected.
Thanks,
jbigelow
in the YAML haven't been
tested.
* Executed tests multiple times.
* Reviewed logs to ensure the tests were executing as expected.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com
-8401-4f24-be5e-da1db0be3156__test-config.yaml
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http
then it will blow up if callback_module
callback_method are not defined in YAML and pjsua_mod.PJsua is being used as a
test module. If it remains with the same scenario then things won't blow up and
no user code is called into(maybe there's a need for that?). Suggestions?
- jbigelow
.
* Pylint score of 9.40/10 for phones.py
* See attached test-config.yaml for a demonstration.
File Attachments
Demonstration
https://reviewboard.asterisk.org/media/uploaded/files/2015/02/11/659ab31f-8401-4f24-be5e-da1db0be3156__test-config.yaml
Thanks,
jbigelow
as expected.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
events aren't received and
actions don't fire. Therefore those events/actions in the YAML haven't been
tested.
* Executed tests multiple times.
* Reviewed logs to ensure the tests were executing as expected.
Thanks,
jbigelow
. Therefore those events/actions in the YAML haven't been
tested.
* Executed tests multiple times.
* Reviewed logs to ensure the tests were executing as expected.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided
https://reviewboard.asterisk.org/media/uploaded/files/2015/02/11/659ab31f-8401-4f24-be5e-da1db0be3156__test-config.yaml
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev
Demonstration
https://reviewboard.asterisk.org/media/uploaded/files/2015/02/11/659ab31f-8401-4f24-be5e-da1db0be3156__test-config.yaml
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http
/4408/diff/
Testing
---
* Executed each test in a loop of 100 iterations with no failures.
* Reviewed logs to ensure the tests were executing as expected.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http
://reviewboard.asterisk.org/r/4330/diff/
Testing
---
* Executed each test in a loop of 100 iterations with no failures.
* Reviewed logs to ensure the tests were executing as expected.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation
.
- jbigelow
On Jan. 26, 2015, 2:16 p.m., Jonathan Rose wrote:
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4373
/ami_bridge/stasis_bridge/configs/ast1
D 6226 6047 kmoore
tests/rest_api/external_interaction/ami_bridge/stasis_bridge/configs/ast1/extensions.conf
- jbigelow
---
This is an automatically generated e-mail. To reply, visit
On Jan. 13, 2015, 9:48 a.m., jbigelow wrote:
* Under 'URI Parsing' it states: For the purposes of transport selection
the transport parameter is examined. I suggest clarifing that the
transport parameter being spoke of is the 'transport' parameter for
endpoint types in pjsip.conf
the tests were executing as expected.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman
/external_interaction/blind_transfer/call_transfer.py
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/4267/diff/
Testing
---
* Executed tests multiple times
* Reviewed logs to manually verify StasisStart/StasisEnd events occurred.
Thanks,
jbigelow
vote but I can't speak for what was originally intended.
- jbigelow
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4301/#review14053
Diff: https://reviewboard.asterisk.org/r/4291/diff/
Testing
---
* Executed tests multiple times.
* Review logs to ensure the tests were executing as expected.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided
://reviewboard.asterisk.org/r/4267/diff/
Testing
---
* Executed tests multiple times
* Reviewed logs to manually verify StasisStart/StasisEnd events occurred.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided
times.
* Review logs to ensure the tests were executing as expected.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit
/diff/
Testing
---
* Executed tests multiple times
* Reviewed logs to manually verify StasisStart/StasisEnd events occurred.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com
/tests/rest_api/external_interaction/blind_transfer/blind_transfer.py
PRE-CREATION
Diff: https://reviewboard.asterisk.org/r/4267/diff/
Testing
---
* Executed tests multiple times
* Reviewed logs to manually verify StasisStart/StasisEnd events occurred.
Thanks,
jbigelow
buffer successfully.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo
on the function parameters (similar to what you did
on PcapFile _init_).
I thought of doing it that way while writing it but decided not to so that the
defaults are in a single place and to keep things consistent in this area of
code. Thoughts?
- jbigelow
/lib/python/asterisk/pcap.py 5913
Diff: https://reviewboard.asterisk.org/r/4156/diff/
Testing
---
Used the options to set a lower snaplen and a higher buffer successfully.
Thanks,
jbigelow
--
_
-- Bandwidth
with possible values
of 'yes', 'no', 'attempt'/'try' instead of a new option. If not I suggest
renaming the option to something like 'media_encryption_attempt' or
'media_encryption_try'.
- jbigelow
On Oct. 21, 2014, 8:36 a.m., Joshua Colp wrote
On Oct. 29, 2014, 8:49 a.m., jbigelow wrote:
I suggest reusing the 'media_encryption' pjsip.conf option with possible
values of 'yes', 'no', 'attempt'/'try' instead of a new option. If not I
suggest renaming the option to something like 'media_encryption_attempt
as expected.
* Ran test several times without work around for ASTERISK-24414 which
frequently failed as expected.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
/test_config.py 5766
Diff: https://reviewboard.asterisk.org/r/4080/diff/
Testing
---
Tested the various scenarios and they all seem to properly work as expected now.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation
On Oct. 16, 2014, 5:29 p.m., Scott Griepentrog wrote:
/asterisk/trunk/runtests.py, line 75
https://reviewboard.asterisk.org/r/4080/diff/2/?file=68354#file68354line75
This should include a + \n like line 59 does.
jbigelow wrote:
Line 59 adds a newline to visually separate
the
tests output. Line 67 doesn't add a new line to the tests output and I don't
believe I should just for this message that I'm appending to the output either.
- jbigelow
---
This is an automatically generated e-mail. To reply, visit
.
jbigelow wrote:
test_runner.py returns 0 if passed and 1 if failed. So the above
suggestion would need to be like so:
self.passed = ((not p.returncode and self.test_config.expect_pass) or
(p.returncode and not self.test_config.expect_pass))
However it's still
---
Tested the various scenarios and they all seem to properly work as expected now.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE
/asterisk/trunk/lib/python/asterisk/test_config.py 5726
Diff: https://reviewboard.asterisk.org/r/4080/diff/
Testing
---
Tested the various scenarios and they all seem to properly work as expected now.
Thanks,
jbigelow
of explicitly testing for 0 and not 0 as posted for review:
for returncode in (0, 1):
... for expect_pass in (True, False):
... ((returncode == 0 and expect_pass) or (returncode != 0 and not
expect_pass))
...
True
False
False
True
- jbigelow
from ASTERISK-24411 and work around for ASTERISK-24414)
* Ran test several times without patch applied from ASTERISK-24411 which
constantly failed as expected.
* Ran test several times without work around for ASTERISK-24414 which
frequently failed as expected.
Thanks,
jbigelow
/trunk/lib/python/asterisk/pjsua_mod.py 4836
Diff: https://reviewboard.asterisk.org/r/3348/diff/
Testing
---
* Ensured tests pass on multiple executions
* Ensured the testsuite Asterisk logs looked good.
Thanks,
jbigelow
test suite Asterisk logs.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman
/blind_transfer/callee_hold/test-config.yaml
https://reviewboard.asterisk.org/r/3444/#comment21405
Should be blind transfers Alice to Charlie.
- jbigelow
On April 14, 2014, 4:17 p.m., Scott Emidy wrote:
---
This is an automatically generated e
the Referred-By
header and commented out the header match for the SIPREFERTOHDR channel
variable. This was to mimic a successful pass to validate the test. This was
done for each.
** Executed tests in a loop 50+ times to ensure stability.
* Reviewed test suite Asterisk logs.
Thanks,
jbigelow
in the test description. The
test description says that Alice transfers Bob to Charlie, but these
comments say that Bob transfers Alice to Charlie.
Same applies for the second scenario.
I blame my copy paste for not automatically making the changes. :)
- jbigelow
variable. This was to mimic a successful pass to validate the test. This was
done for each.
** Executed tests in a loop 50+ times to ensure stability.
* Reviewed test suite Asterisk logs.
Thanks,
jbigelow
--
_
-- Bandwidth
Diff: https://reviewboard.asterisk.org/r/3354/diff/
Testing
---
* Ensured tests pass on multiple executions
* Ensured the testsuite Asterisk logs looked good.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation
://reviewboard.asterisk.org/r/3348/diff/
Testing
---
* Ensured tests pass on multiple executions
* Ensured the testsuite Asterisk logs looked good.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http
/asterisk/pjsua_mod.py 4836
Diff: https://reviewboard.asterisk.org/r/3348/diff/
Testing
---
* Ensured tests pass on multiple executions
* Ensured the testsuite Asterisk logs looked good.
Thanks,
jbigelow
--
_
-- Bandwidth
,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/asterisk-dev
/r/3348/diff/
Testing
---
* Ensured tests pass on multiple executions
* Ensured the testsuite Asterisk logs looked good.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com
/channels/pjsip/mwi/configs/ast1/modules.conf 4799
Diff: https://reviewboard.asterisk.org/r/3288/diff/
Testing
---
* Ensured tests pass on multiple executions
* Ensured the testsuite Asterisk logs looked good.
Thanks,
jbigelow
* Ensured the testsuite Asterisk logs looked good.
Thanks,
jbigelow
--
_
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http
63 matches
Mail list logo
