Re: [asterisk-dev] [Code Review] 3283: pjsip_cli: Create pjsip show channel and pjsip show contact, and general cli code cleanup

2014-03-08 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3283/ --- (Updated March 8, 2014, 9:56 a.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 3283: pjsip_cli: Create pjsip show channel and pjsip show contact, and general cli code cleanup

2014-03-07 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3283/#review11132 --- Ship it! Ship It! - Joshua Colp On March 6, 2014, 9:51

Re: [asterisk-dev] [Code Review] 3283: pjsip_cli: Create pjsip show channel and pjsip show contact, and general cli code cleanup

2014-03-06 Thread Joshua Colp
On March 6, 2014, 1:38 a.m., Matt Jordan wrote: branches/12/res/res_pjsip_endpoint_identifier_ip.c, lines 364-371 https://reviewboard.asterisk.org/r/3283/diff/1/?file=55030#file55030line364 Any reason you decided to move initialization of the members of the struct to load_module?

Re: [asterisk-dev] [Code Review] 3283: pjsip_cli: Create pjsip show channel and pjsip show contact, and general cli code cleanup

2014-03-06 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3283/#review11092 --- branches/12/include/asterisk/res_pjsip_cli.h

Re: [asterisk-dev] [Code Review] 3283: pjsip_cli: Create pjsip show channel and pjsip show contact, and general cli code cleanup

2014-03-06 Thread Matt Jordan
On March 5, 2014, 7:38 p.m., Matt Jordan wrote: branches/12/res/res_pjsip_endpoint_identifier_ip.c, lines 364-371 https://reviewboard.asterisk.org/r/3283/diff/1/?file=55030#file55030line364 Any reason you decided to move initialization of the members of the struct to load_module?

Re: [asterisk-dev] [Code Review] 3283: pjsip_cli: Create pjsip show channel and pjsip show contact, and general cli code cleanup

2014-03-06 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3283/ --- (Updated March 6, 2014, 2:51 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 3283: pjsip_cli: Create pjsip show channel and pjsip show contact, and general cli code cleanup

2014-03-05 Thread Matt Jordan
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3283/#review11082 --- branches/12/include/asterisk/res_pjsip_cli.h

[asterisk-dev] [Code Review] 3283: pjsip_cli: Create pjsip show channel and pjsip show contact, and general cli code cleanup

2014-03-02 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3283/ --- Review request for Asterisk Developers. Bugs: ASTERISK-23276