Re: [asterisk-dev] [Code Review] 4383: res_pjsip_config_wizard: Add ability to auto-create hints.

2015-02-10 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4383/#review14435 --- Ship it! branches/13/res/res_pjsip_config_wizard.c

Re: [asterisk-dev] [Code Review] 4383: res_pjsip_config_wizard: Add ability to auto-create hints.

2015-02-10 Thread rmudgett
On Feb. 10, 2015, 12:50 p.m., Joshua Colp wrote: branches/13/res/res_pjsip_config_wizard.c, lines 427-430 https://reviewboard.asterisk.org/r/4383/diff/3/?file=71271#file71271line427 App and data could still be empty after this. Not to mention that data is not NULL checked. -

Re: [asterisk-dev] [Code Review] 4383: res_pjsip_config_wizard: Add ability to auto-create hints.

2015-02-10 Thread George Joseph
On Feb. 10, 2015, 11:50 a.m., Joshua Colp wrote: branches/13/res/res_pjsip_config_wizard.c, lines 427-430 https://reviewboard.asterisk.org/r/4383/diff/3/?file=71271#file71271line427 App and data could still be empty after this. rmudgett wrote: Not to mention that data is not

Re: [asterisk-dev] [Code Review] 4383: res_pjsip_config_wizard: Add ability to auto-create hints.

2015-02-10 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4383/ --- (Updated Feb. 10, 2015, 5:16 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4383: res_pjsip_config_wizard: Add ability to auto-create hints.

2015-02-04 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4383/ --- (Updated Feb. 4, 2015, 10:31 a.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4383: res_pjsip_config_wizard: Add ability to auto-create hints.

2015-02-04 Thread Joshua Colp
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4383/#review14405 --- branches/13/res/res_pjsip_config_wizard.c

Re: [asterisk-dev] [Code Review] 4383: res_pjsip_config_wizard: Add ability to auto-create hints.

2015-01-30 Thread Scott Griepentrog
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4383/#review14394 --- The dialplan Dial() app entry can conflict with existing

Re: [asterisk-dev] [Code Review] 4383: res_pjsip_config_wizard: Add ability to auto-create hints.

2015-01-30 Thread George Joseph
On Jan. 30, 2015, 8:49 a.m., Scott Griepentrog wrote: The dialplan Dial() app entry can conflict with existing dialplan in the same context. I'm assuming that I won't enable the hint dialplan unless I mean to do it through the wizard, but there is no option to skip the addition of

[asterisk-dev] [Code Review] 4383: res_pjsip_config_wizard: Add ability to auto-create hints.

2015-01-27 Thread George Joseph
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4383/ --- Review request for Asterisk Developers. Repository: Asterisk