Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4450/ --- (Updated March 10, 2015, 12:43 p.m.) Status -- This change has been

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4450/ --- (Updated March 6, 2015, 10:59 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4450/#review14608 --- Ship it! I've given this several looks, and I think it's good

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4450/ --- (Updated March 3, 2015, 3:25 p.m.) Review request for Asterisk

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

On Feb. 25, 2015, 6:15 p.m., Matt Jordan wrote: tags/11.7.0/main/stdtime/localtime.c, lines 395-403 https://reviewboard.asterisk.org/r/4450/diff/1/?file=71624#file71624line395 Using a global static struct without locking is not thread safe. More on this below. This should be

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4450/#review14550 --- - Ed Hynan On March 3, 2015, 3:25 p.m., Ed Hynan wrote:

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4450/ --- (Updated March 3, 2015, 2:47 p.m.) Review request for Asterisk

[asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4450/ --- Review request for Asterisk Developers. Bugs: ASTERISK-24739

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/4450/#review14553 --- tags/11.7.0/main/stdtime/localtime.c

Re: [asterisk-dev] [Code Review] 4450: locatime.c file descriptor leak on kqueue(2) systems

On Feb. 25, 2015, 6:15 p.m., Matt Jordan wrote: tags/11.7.0/main/stdtime/localtime.c, lines 482-484 https://reviewboard.asterisk.org/r/4450/diff/1/?file=71624#file71624line482 I'm not sure why we are printing out to stderr here, but generally Asterisk does not do that unless (a)