On March 23, 2015, 9:57 a.m., Matt Jordan wrote:
Ship It!
As an addendum to this, this patch does not merge cleanly on Asterisk 11. As
such, I'll be merging this to Asterisk 13+.
Alas, as I don't run a system that can compile kqueue, it's kind of hard for me
to backport that. If someone
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4465/
---
(Updated March 27, 2015, 9:41 a.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4465/#review14766
---
Ship it!
Ship It!
- Matt Jordan
On March 18, 2015, 11:44
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4465/
---
(Updated March 18, 2015, 4:44 p.m.)
Review request for Asterisk
On March 16, 2015, 3:18 a.m., Matt Jordan wrote:
/trunk/res/res_timing_kqueue.c, lines 76-83
https://reviewboard.asterisk.org/r/4465/diff/2/?file=72098#file72098line76
For structure packing, you may want to declare this as:
struct kqueue_timer {
int handle;
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4465/#review14696
---
Thanks for the patch - there's a few other kqueue related
On March 10, 2015, 1:26 p.m., Ed Hynan wrote:
/trunk/res/res_timing_kqueue.c, line 240
https://reviewboard.asterisk.org/r/4465/diff/1/?file=71888#file71888line240
Portability: at least EVFILT_USER and NOTE_TRIGGER are not defined on
all kqueue(2) systems.
Justin T. Gibbs
On March 10, 2015, 1:26 p.m., Ed Hynan wrote:
/trunk/res/res_timing_kqueue.c, line 240
https://reviewboard.asterisk.org/r/4465/diff/1/?file=71888#file71888line240
Portability: at least EVFILT_USER and NOTE_TRIGGER are not defined on
all kqueue(2) systems.
Justin T. Gibbs
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4465/
---
(Updated March 13, 2015, 2:07 a.m.)
Review request for Asterisk
On March 10, 2015, 1:26 p.m., Ed Hynan wrote:
/trunk/res/res_timing_kqueue.c, line 240
https://reviewboard.asterisk.org/r/4465/diff/1/?file=71888#file71888line240
Portability: at least EVFILT_USER and NOTE_TRIGGER are not defined on
all kqueue(2) systems.
Justin T. Gibbs
On March 10, 2015, 1:26 p.m., Ed Hynan wrote:
/trunk/res/res_timing_kqueue.c, line 240
https://reviewboard.asterisk.org/r/4465/diff/1/?file=71888#file71888line240
Portability: at least EVFILT_USER and NOTE_TRIGGER are not defined on
all kqueue(2) systems.
Justin T. Gibbs
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4465/#review14620
---
My immediate question for this is: How does this impact OSX?
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4465/#review14623
---
/trunk/res/res_timing_kqueue.c
On March 10, 2015, 1:26 p.m., Ed Hynan wrote:
/trunk/res/res_timing_kqueue.c, line 240
https://reviewboard.asterisk.org/r/4465/diff/1/?file=71888#file71888line240
Portability: at least EVFILT_USER and NOTE_TRIGGER are not defined on
all kqueue(2) systems.
Which platforms are you
On March 10, 2015, 1:08 p.m., Joshua Colp wrote:
My immediate question for this is: How does this impact OSX? The timing
module was originally written for both, do these changes work for both?
I haven't tested against OS-X, but it has had EVFILT_USER support since 10.6.
- Justin
---
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/4465/
---
Review request for Asterisk Developers.
Repository: Asterisk
16 matches
Mail list logo
