[asterisk-dev] [Code Review] 3733: Added a pluggable module for pluggable_modules.py that allows the user to test different attributes of a given sound file

2014-07-09 Thread Christopher Wolfe
://reviewboard.asterisk.org/r/3733/diff/ Testing --- Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http

Re: [asterisk-dev] [Code Review] 3733: Added a pluggable module for pluggable_modules.py that allows the user to test different attributes of a given sound file

2014-07-09 Thread Christopher Wolfe
that more than one test could be run and that things could be run sequentially. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE

[asterisk-dev] [Code Review] 3796: Added tests to check whether accountcodes and LinkedIds propagated when two channels are put in a mixing bridge, but not in a holding bridge

2014-07-15 Thread Christopher Wolfe
to progress the test. Compared the channels that entered the bridge with one that didn't. Originally had a python code approach, but then used strictly YAML and ari pluggable modules. Thanks, Christopher Wolfe

Re: [asterisk-dev] [Code Review] 3796: Added tests to check whether accountcodes and LinkedIds propagated when two channels are put in a mixing bridge, but not in a holding bridge

2014-07-17 Thread Christopher Wolfe
, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk-dev

Re: [asterisk-dev] [Code Review] 3733: Added a pluggable module for pluggable_modules.py that allows the user to test different attributes of a given sound file

2014-07-21 Thread Christopher Wolfe
the various tests could fail if a certain sound file didn't meet the size criteria or silence threshold criteria. - Made sure that more than one test could be run and that things could be run sequentially. Thanks, Christopher Wolfe

Re: [asterisk-dev] [Code Review] 3733: Added a pluggable module for pluggable_modules.py that allows the user to test different attributes of a given sound file

2014-07-22 Thread Christopher Wolfe
meet the size criteria or silence threshold criteria. - Made sure that more than one test could be run and that things could be run sequentially. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 3839: Added a test to check the duration and energy_duration values of an ARI recording

2014-07-22 Thread Christopher Wolfe
had to add maxSilenceSeconds in the recording request in order to make energy_detection work AT ALL. Other than that, this test was pretty straightforward and easy to write. Thanks, Christopher Wolfe -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3839: Added a test to check the duration and energy_duration values of an ARI recording

2014-07-22 Thread Christopher Wolfe
in the recording request in order to make energy_detection work AT ALL. Other than that, this test was pretty straightforward and easy to write. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 3839: Added a test to check the duration and energy_duration values of an ARI recording

2014-07-23 Thread Christopher Wolfe
this test was the fact that you had to add maxSilenceSeconds in the recording request in order to make energy_detection work AT ALL. Other than that, this test was pretty straightforward and easy to write. Thanks, Christopher Wolfe

Re: [asterisk-dev] [Code Review] 3842: Tests the forward and reverse playback ARI functions for both channels and bridges

2014-07-23 Thread Christopher Wolfe
received. These tests were pretty straightforward otherwise. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

Re: [asterisk-dev] [Code Review] 3733: Added a pluggable module for pluggable_modules.py that allows the user to test different attributes of a given sound file

2014-07-24 Thread Christopher Wolfe
--- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3733/#review12853 --- On July 22, 2014, 6:46 p.m., Christopher Wolfe wrote: --- This is an automatically

Re: [asterisk-dev] [Code Review] 3733: Added a pluggable module for pluggable_modules.py that allows the user to test different attributes of a given sound file

2014-07-24 Thread Christopher Wolfe
sequentially. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman/listinfo/asterisk

Re: [asterisk-dev] [Code Review] 3842: Tests the forward and reverse playback ARI functions for both channels and bridges

2014-07-24 Thread Christopher Wolfe
://reviewboard.asterisk.org/r/3842/diff/ Testing --- Made sure that expected values were received. These tests were pretty straightforward otherwise. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http

Re: [asterisk-dev] [Code Review] 3733: Added a pluggable module for pluggable_modules.py that allows the user to test different attributes of a given sound file

2014-07-25 Thread Christopher Wolfe
other pluggable modules. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com/mailman

Re: [asterisk-dev] [Code Review] 3839: Added a test to check the duration and energy_duration values of an ARI recording

2014-07-25 Thread Christopher Wolfe
. One bottleneck to finishing this test was the fact that you had to add maxSilenceSeconds in the recording request in order to make energy_detection work AT ALL. Other than that, this test was pretty straightforward and easy to write. Thanks, Christopher Wolfe

Re: [asterisk-dev] [Code Review] 3842: Tests the forward and reverse playback ARI functions for both channels and bridges

2014-07-30 Thread Christopher Wolfe
://reviewboard.asterisk.org/r/3842/diff/ Testing --- Made sure that expected values were received. These tests were pretty straightforward otherwise. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http://www.api

[asterisk-dev] [Code Review] 3872: Tests the various ARI channel muting applications (the both, in, and out directions)

2014-07-30 Thread Christopher Wolfe
the test just shows what happens in certain muting events. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit

Re: [asterisk-dev] [Code Review] 3872: Tests the various ARI channel muting applications (the both, in, and out directions)

2014-08-01 Thread Christopher Wolfe
, 2014, 4:21 p.m., Christopher Wolfe wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviewboard.asterisk.org/r/3872/ --- (Updated July 30, 2014, 4:21

Re: [asterisk-dev] [Code Review] 3872: Tests the various ARI channel muting applications (the both, in, and out directions)

2014-08-01 Thread Christopher Wolfe
playback is done. This is so that the results aren't fudged. It was discovered during testing that muting is overzealous, so the test just shows what happens in certain muting events. Thanks, Christopher Wolfe -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3733: Added a pluggable module for pluggable_modules.py that allows the user to test different attributes of a given sound file

2014-08-12 Thread Christopher Wolfe
(with the first element in the list being triggered first) and not asynchronous, unlike other pluggable modules. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk

Re: [asterisk-dev] [Code Review] 3839: Added a test to check the duration and energy_duration values of an ARI recording

2014-08-12 Thread Christopher Wolfe
in the recording request in order to make energy_detection work AT ALL. Other than that, this test was pretty straightforward and easy to write. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http://www.api

Re: [asterisk-dev] [Code Review] 3796: Added tests to check whether accountcodes and LinkedIds propagated when two channels are put in a mixing bridge, but not in a holding bridge

2014-08-12 Thread Christopher Wolfe
and ari pluggable modules. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options visit: http://lists.digium.com

Re: [asterisk-dev] [Code Review] 3842: Tests the forward and reverse playback ARI functions for both channels and bridges

2014-08-14 Thread Christopher Wolfe
-CREATION Diff: https://reviewboard.asterisk.org/r/3842/diff/ Testing --- Made sure that expected values were received. These tests were pretty straightforward otherwise. Thanks, Christopher Wolfe -- _ -- Bandwidth

Re: [asterisk-dev] [Code Review] 3872: Tests the various ARI channel muting applications (the both, in, and out directions)

2014-08-29 Thread Christopher Wolfe
, so the test just shows what happens in certain muting events. Thanks, Christopher Wolfe -- _ -- Bandwidth and Colocation Provided by http://www.api-digital.com -- asterisk-dev mailing list To UNSUBSCRIBE or update options