[Babel-users] [PATCH 2/6] Make v4prefix a shared constant between util.c and message.c

2017-03-09 Thread Dave Taht
From: Dave Taht Share the data better. --- message.c | 3 +-- util.c| 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/message.c b/message.c index fdc1999..f8c4ad2 100644 --- a/message.c +++ b/message.c @@ -54,8 +54,7 @@ unsigned char *unicast_buffer =

[Babel-users] [PATCH 4/6] Tests: Add subdir and test for structure packing

2017-03-09 Thread Dave Taht
From: Dave Taht An initial run of this test on x86_64 shows suboptimal packing for the filter structure (can be 96), and kernel_route (can be 64). Other things, such as kernel_rule, buffered_update and xroute could be padded to more natural 8 byte boundaries for this arch. Other

[Babel-users] Misc cleanups to the babeld build system

2017-03-09 Thread Dave Taht
This patch series makes it easier to work on babeld's source code in a variety of ways. [PATCH 1/6] Improve Makefile [PATCH 2/6] Make v4prefix a shared constant between util.c and [PATCH 3/6] Quiet the compiler on two uninitialized variable warnings [PATCH 4/6] Tests: Add subdir and test for

[Babel-users] [PATCH 1/6] Improve Makefile

2017-03-09 Thread Dave Taht
From: Dave Taht - Add INCLUDES variable for headers - Add support for tags and TAGS - create "reallyclean" to get rid of tags, TAGS, gmon.out, cscope.out - remove TAGs and gmon.out from "clean" - Add full and correct dependencies on internal headers --- Makefile | 58

[Babel-users] [PATCH 3/6] Quiet the compiler on two uninitialized variable warnings

2017-03-09 Thread Dave Taht
From: Dave Taht When compiled on arm and gcc 4.9.2, the compiler picks out two sets of variables passed by reference that "might be used uninitialized". They aren't, but certainly in the getnet case it was not immediately obvious to either me or the compiler. Quiet the warnings

[Babel-users] [PATCH 5/6] gitignore tags TAGS emacs and vi temp files and bad patch attempts

2017-03-09 Thread Dave Taht
From: Dave Taht Quiet git more. --- .gitignore | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/.gitignore b/.gitignore index 635e60b..d298e6e 100644 --- a/.gitignore +++ b/.gitignore @@ -2,6 +2,13 @@ babeld babeld.html version.h -cscope.out

[Babel-users] [PATCH 6/6] babeld-whole: Enable single unit compilation of all of babeld

2017-03-09 Thread Dave Taht
From: Dave Taht This adds compile guards and Makefile support to building all of babeld in a single shot, as "babeld-whole". This has compelling advantages: - It lets you A/B two versions with different compilation options such as debugging on or off, or selectively enable

Re: [Babel-users] [PATCH 4/6] Tests: Add subdir and test for structure packing

2017-03-09 Thread Juliusz Chroboczek
Rejected. ___ Babel-users mailing list Babel-users@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/babel-users

Re: [Babel-users] [PATCH 5/6] gitignore tags TAGS emacs and vi temp files and bad patch attempts

2017-03-09 Thread Juliusz Chroboczek
Applied. ___ Babel-users mailing list Babel-users@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/babel-users

Re: [Babel-users] [PATCH 1/6] Improve Makefile

2017-03-09 Thread Juliusz Chroboczek
Not applied. > - Add INCLUDES variable for headers What for? Why do I need to maintain an extra variable? > - Add support for tags and TAGS No objection, but I just use a private shell alias. > - create "reallyclean" to get rid of tags, TAGS, gmon.out, cscope.out Rejected. There's no need

Re: [Babel-users] [PATCHes] Misc cleanups to the babeld build system

2017-03-09 Thread Juliusz Chroboczek
> In part I broke up the makefile changes because I figured you wouldn't > like the compile guards > and whole program stuff, but I found that really helpful later on in the > rabeld effort, while optimizing and trying to understand how things > worked. You're right, don't overdo the squashing.