Re: [A] Preserve hooks locality
Adrian Aichner wrote: Interesting! Didier, have you also observed bbdb losing coding cookie of line 1 on write? nope. This might be the reason for the coding system breakage reported on bbdb-info recently. See, e.g. http://www.mail-archive.com/bbdb-info@lists.sourceforge.net/index.html#04609 Could the issue you found have to do with this? At a first glance, I don't think so. BBDB uses only local-write-file-hooks, which is permanent-local. The bug I'm fixing was causing the *global* hooks values to be lost after their first execution. -- MySpace: http://www.myspace.com/didierverna Didier Verna, [EMAIL PROTECTED], http://www.lrde.epita.fr/~didier EPITA / LRDE, 14-16 rue Voltaire Tel.+33 (1) 44 08 01 85 94276 Le Kremlin-Bicêtre, France Fax.+33 (1) 53 14 59 22 [EMAIL PROTECTED] - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now http://get.splunk.com/ ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
Re: [A] Preserve hooks locality
Didier Verna [EMAIL PROTECTED] writes: Dear reviewers, This patch fixes the loss of locality that I have observed on write-file-hooks and friends (the 't in the local value was lost). It is also recommended for 21.4. I'll apply it by the end of the week if nobody objects. Interesting! Didier, have you also observed bbdb losing coding cookie of line 1 on write? This might be the reason for the coding system breakage reported on bbdb-info recently. See, e.g. http://www.mail-archive.com/bbdb-info@lists.sourceforge.net/index.html#04609 Could the issue you found have to do with this? Adrian lisp/ChangeLog addition: 2007-08-29 Didier Verna [EMAIL PROTECTED] * files.el (files-fetch-hook-value): Preserve locality of hooks by working on copies. XEmacs source patch: Diff command: cvs -q diff -u -t -b -B -w Files affected: lisp/files.el Index: lisp/files.el === RCS file: /pack/xemacscvs/XEmacs/xemacs/lisp/files.el,v retrieving revision 1.78 diff -u -u -t -b -B -w -r1.78 files.el --- lisp/files.el 21 Jun 2007 23:27:16 - 1.78 +++ lisp/files.el 29 Aug 2007 09:02:03 - @@ -2809,8 +2809,8 @@ (put 'save-buffer-coding-system 'permanent-local t) (defun files-fetch-hook-value (hook) - (let ((localval (symbol-value hook)) -(globalval (default-value hook))) + (let ((localval (copy-list (symbol-value hook))) +(globalval (copy-list (default-value hook (if (memq t localval) (setq localval (append (delq t localval) (delq t globalval localval)) -- Adrian Aichner mailto:[EMAIL PROTECTED] http://www.xemacs.org/ - This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now http://get.splunk.com/ ___ bbdb-info@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/bbdb-info BBDB Home Page: http://bbdb.sourceforge.net/
