Re: [PATCH] b43: Fix Bugzilla #14181 without introducing a new problem

2009-10-16 Thread Larry Finger
On 10/14/2009 03:06 AM, Michael Buesch wrote: On Wednesday 14 October 2009 03:25:30 Larry Finger wrote: Commit 93bad2b757586fb153ef73b028953a8dcaccde77 entitled b43: Fix PPC crash in rfkill polling on unload fixed the bug reported in Bugzilla No. 14181; however, it introduced a new bug.

Re: [PATCH] b43: Fix Bugzilla #14181 without introducing a new problem

2009-10-16 Thread John W. Linville
On Fri, Oct 16, 2009 at 08:42:08AM -0500, Larry Finger wrote: On 10/14/2009 03:06 AM, Michael Buesch wrote: On Wednesday 14 October 2009 03:25:30 Larry Finger wrote: Commit 93bad2b757586fb153ef73b028953a8dcaccde77 entitled b43: Fix PPC crash in rfkill polling on unload fixed the bug

Re: [PATCH] b43: Fix Bugzilla #14181 without introducing a new problem

2009-10-16 Thread Michael Buesch
On Friday 16 October 2009 16:44:14 John W. Linville wrote: On Fri, Oct 16, 2009 at 08:42:08AM -0500, Larry Finger wrote: On 10/14/2009 03:06 AM, Michael Buesch wrote: On Wednesday 14 October 2009 03:25:30 Larry Finger wrote: Commit 93bad2b757586fb153ef73b028953a8dcaccde77 entitled b43:

Re: [PATCH] b43: Fix Bugzilla #14181 without introducing a new problem

2009-10-16 Thread Larry Finger
On 10/16/2009 09:44 AM, John W. Linville wrote: On Fri, Oct 16, 2009 at 08:42:08AM -0500, Larry Finger wrote: On 10/14/2009 03:06 AM, Michael Buesch wrote: On Wednesday 14 October 2009 03:25:30 Larry Finger wrote: Commit 93bad2b757586fb153ef73b028953a8dcaccde77 entitled b43: Fix PPC crash

Re: [PATCH] b43: Fix Bugzilla #14181 without introducing a new problem

2009-10-14 Thread Michael Buesch
On Wednesday 14 October 2009 03:25:30 Larry Finger wrote: Commit 93bad2b757586fb153ef73b028953a8dcaccde77 entitled b43: Fix PPC crash in rfkill polling on unload fixed the bug reported in Bugzilla No. 14181; however, it introduced a new bug. Whenever the radio switch was turned off, it was

Re: [PATCH] b43: Fix Bugzilla #14181 without introducing a new problem

2009-10-14 Thread Larry Finger
On 10/14/2009 03:06 AM, Michael Buesch wrote: On Wednesday 14 October 2009 03:25:30 Larry Finger wrote: Commit 93bad2b757586fb153ef73b028953a8dcaccde77 entitled b43: Fix PPC crash in rfkill polling on unload fixed the bug reported in Bugzilla No. 14181; however, it introduced a new bug.

Re: [PATCH] b43: Fix Bugzilla #14181 without introducing a new problem

2009-10-14 Thread Michael Buesch
On Wednesday 14 October 2009 17:04:15 Larry Finger wrote: No, the logic in b43_rfkill_poll gets the device into a state that it works for newer hardware. There is something about the PPC G4 (at least) that is not in a state where the B43_MMIO_RADIO_HWENABLED_LO register can be read and the

[PATCH] b43: Fix Bugzilla #14181 without introducing a new problem

2009-10-13 Thread Larry Finger
Commit 93bad2b757586fb153ef73b028953a8dcaccde77 entitled b43: Fix PPC crash in rfkill polling on unload fixed the bug reported in Bugzilla No. 14181; however, it introduced a new bug. Whenever the radio switch was turned off, it was necessary to unload and reload the driver for it to recognize the