Re: N-PHY init: current code vs. specs

2010-01-05 Thread Michael Buesch
On Monday 04 January 2010 23:34:19 Rafał Miłecki wrote: W dniu 4 stycznia 2010 21:36 użytkownik Rafał Miłecki zaj...@gmail.com napisał: Next there is a lot of code after b43_nphy_workarounds(dev); call that I can not recognize. Let's just take some lines for example:

Re: N-PHY init: current code vs. specs

2010-01-05 Thread Larry Finger
On 01/05/2010 11:21 AM, Michael Buesch wrote: Well, just do the thing that makes most sense. In general we all agree that we should _not_ implement crap, just because broadcom does so, if we can do better. So, in this case, if we can do a subfunction call and that function does make sense,

N-PHY init: current code vs. specs

2010-01-04 Thread Rafał Miłecki
I try to update int b43_phy_initn(struct b43_wldev *dev) to match current specs. Currently it contains many operations/calls that I can not find in http://bcm-v4.sipsolutions.net/802.11/PHY/Init/N First I've just posted patch that removed //TODO: Spectral management. I don't see anything about

Re: N-PHY init: current code vs. specs

2010-01-04 Thread Larry Finger
On 01/04/2010 02:36 PM, Rafał Miłecki wrote: I try to update int b43_phy_initn(struct b43_wldev *dev) to match current specs. Currently it contains many operations/calls that I can not find in http://bcm-v4.sipsolutions.net/802.11/PHY/Init/N First I've just posted patch that removed

Re: N-PHY init: current code vs. specs

2010-01-04 Thread Rafał Miłecki
W dniu 4 stycznia 2010 21:55 użytkownik Larry Finger larry.fin...@lwfinger.net napisał: On 01/04/2010 02:36 PM, Rafał Miłecki wrote: I try to update int b43_phy_initn(struct b43_wldev *dev) to match current specs. Currently it contains many operations/calls that I can not find in

Re: N-PHY init: current code vs. specs

2010-01-04 Thread Rafał Miłecki
W dniu 4 stycznia 2010 21:36 użytkownik Rafał Miłecki zaj...@gmail.com napisał: Next there is a lot of code after b43_nphy_workarounds(dev); call that I can not recognize. Let's just take some lines for example: b43_nphy_reset_cca(dev); Actually specs still tell about resetting CCA, but that

Re: N-PHY init: current code vs. specs

2010-01-04 Thread Larry Finger
On 01/04/2010 04:34 PM, Rafał Miłecki wrote: W dniu 4 stycznia 2010 21:36 użytkownik Rafał Miłecki zaj...@gmail.com napisał: Next there is a lot of code after b43_nphy_workarounds(dev); call that I can not recognize. Let's just take some lines for example: b43_nphy_reset_cca(dev); Actually

Re: N-PHY init: current code vs. specs

2010-01-04 Thread Rafał Miłecki
W dniu 4 stycznia 2010 23:43 użytkownik Larry Finger larry.fin...@lwfinger.net napisał: On 01/04/2010 04:34 PM, Rafał Miłecki wrote: W dniu 4 stycznia 2010 21:36 użytkownik Rafał Miłecki zaj...@gmail.com napisał: Next there is a lot of code after b43_nphy_workarounds(dev); call that I can not