Re: 4318 Question Frame Check Sequence Errors

2009-01-26 Thread Gábor Stefanik
On Mon, Jan 26, 2009 at 10:17 PM, Tex ccmc...@verizon.net wrote: I have been running some surveys with the Atheros and Broadcom Drivers. When viewing the frames from wireshark , while in monitor mode, I noticed that the Atheros driver is reporting FCS errors on some frames, but the Broadcom

Re: b43 driver support ?(14e4:4300) - Japanese Buffalo card

2009-01-27 Thread Gábor Stefanik
On Tue, Jan 27, 2009 at 11:07 PM, Kajikawa Jeremy belxjan...@gmail.com wrote: Ive had this card a while and know it worked with the old bcm43xx driver... but I would like to get it working on the newer drivers with an updated kernel. especially as this is an install for 64bit and the old

Re: PCI adapters do not work for rate control and high bit rates

2009-03-03 Thread Gábor Stefanik
On Tue, Mar 3, 2009 at 2:41 PM, Bo Han hanb...@gmail.com wrote: Hi, I am having troubles when using ASUS WL-138G V2 Wireless LAN PCI Adapters. I am using ad-hoc mode and kernel version 2.6.28.7.  There is no rate control for these cards.  When I set the bit rate to auto, they always use 1

Re: [PATCH, RFC] b44: Add fw capabilities

2009-04-08 Thread Gábor Stefanik
I assume b44 in the title is a typo. On Wed, Apr 8, 2009 at 2:11 AM, Michael Buesch m...@bu3sch.de wrote: Completely untested patch to implement firmware capabilities and automagic QoS-disabling. Index: wireless-testing/drivers/net/wireless/b43/b43.h

Re: b43 Hostap Performance

2009-04-10 Thread Gábor Stefanik
On Fri, Apr 10, 2009 at 12:28 AM, Francesco Gringoli francesco.gring...@ing.unibs.it wrote: On Apr 9, 2009, at 11:56 PM, Michael Buesch wrote: 4318 is good enough for STA mode, but in AP mode it doesn't work correctly, because it simply loses too many packets. So it loses important management

Re: 4311 not detected at all

2009-06-13 Thread Gábor Stefanik
On Sat, Jun 13, 2009 at 1:35 AM, Larry Fingerlarry.fin...@lwfinger.net wrote: Fabio A. Correa wrote: Hey, I found an updated BIOS available in the HP site, obviously requiring Windows. I had deleted those partitions, so I will get a Windows hard disk/CD and try to flash it. I did not work

Re: [PATCH] b43 : remove old kidx API

2009-06-19 Thread Gábor Stefanik
On Fri, Jun 19, 2009 at 9:29 PM, Michael Bueschm...@bu3sch.de wrote: On Friday 19 June 2009 21:17:04 gregor kowski wrote: On 6/12/09, gregor kowski gregor.kow...@gmail.com wrote: Remove old kidx API. This simplify the code, and fix a potential key overflow. Michael, any comment on this

Re: BCM4312 and phy_lp.c

2009-06-28 Thread Gábor Stefanik
On Sun, Jun 28, 2009 at 4:14 PM, Michael Bueschm...@bu3sch.de wrote: On Sunday 28 June 2009 15:18:30 Richard Hughes wrote: Are you awaiting more data about the chipset, or have just run out of developer time? The documentation looks pretty comprehensive, although core bit of the code still

Re: Who is working on b43 LP-PHY?

2009-07-25 Thread Gábor Stefanik
On Sat, Jul 25, 2009 at 10:31 PM, Michael Bueschm...@bu3sch.de wrote: I'm wondering who is currently working on the b43 LP-PHY code. I'm just wondering, because there are maybe 20 people who promised to me to work on the code. Who is left _working_ on it? (I mean _working_, not looking or

Re:

2009-07-29 Thread Gábor Stefanik
On Wed, Jul 29, 2009 at 6:38 PM, Larry Fingerlarry.fin...@lwfinger.net wrote: Brian J. Mc Hugh wrote: I have a Gateway Solo 9300 laptop and a Linksys Wireless-G Notebook Adapter. I've installed the latest Debian release (v5.0.2) and the latest b43 driver (4.150.10.5). This is a firmware

[PATCH RESEND] b43: implement baseband init for LP-PHY = rev1

2009-08-03 Thread Gábor Stefanik
Implement baseband init for rev.0 and rev.1 LP PHYs. Convert boardflags_hi values to defines. Implement b43_phy_copy for easier copying between registers, as needed by LP-PHY init. Signed-off-by: Gábor Stefaniknetrolller...@gmail.com Cc: Michael Bueschm...@bu3sch.de Cc: Larry

[PATCH] b43: implement baseband init for LP-PHY = rev1

2009-08-03 Thread Gábor Stefanik
Implement baseband init for rev.0 and rev.1 LP PHYs. Convert boardflags_hi values to defines. Implement b43_phy_copy for easier copying between registers, as needed by LP-PHY init. Signed-off-by: Gábor Stefanik netrolller...@gmail.com Cc: Michael Buesch m...@bu3sch.de Cc: Larry Finger larry.fin

Re: [PATCH RESEND] b43: implement baseband init for LP-PHY = rev1

2009-08-03 Thread Gábor Stefanik
2009/8/3 Gábor Stefanik netrolller...@gmail.com: Implement baseband init for rev.0 and rev.1 LP PHYs. Convert boardflags_hi values to defines. Implement b43_phy_copy for easier copying between registers, as needed by LP-PHY init. Signed-off-by: Gábor Stefaniknetrolller...@gmail.com Cc

Re: [PATCH] b43: implement baseband init for LP-PHY = rev1

2009-08-03 Thread Gábor Stefanik
Whitespace-damaged, sorry. Resend coming soon. 2009/8/3 Gábor Stefanik netrolller...@gmail.com: Implement baseband init for rev.0 and rev.1 LP PHYs. Convert boardflags_hi values to defines. Implement b43_phy_copy for easier copying between registers, as needed by LP-PHY init. Signed-off

Re: [PATCH V2] b43: implement baseband init for LP-PHY = rev1

2009-08-03 Thread Gábor Stefanik
On Mon, Aug 3, 2009 at 1:28 AM, Gábor Stefaniknetrolller...@gmail.com wrote: Implement baseband init for rev.0 and rev.1 LP PHYs. Convert boardflags_hi values to defines. Implement b43_phy_copy for easier copying between registers, as needed by LP-PHY init. Signed-off-by: Gábor

[PATCH V2] b43: implement baseband init for LP-PHY = rev1

2009-08-03 Thread Gábor Stefanik
Implement baseband init for rev.0 and rev.1 LP PHYs. Convert boardflags_hi values to defines. Implement b43_phy_copy for easier copying between registers, as needed by LP-PHY init. Signed-off-by: Gábor Stefaniknetrolller...@gmail.com Cc: Michael Bueschm...@bu3sch.de Cc: Larry

Re: [PATCH RESEND] b43: implement baseband init for LP-PHY = rev1

2009-08-03 Thread Gábor Stefanik
On Mon, Aug 3, 2009 at 11:15 AM, Michael Bueschm...@bu3sch.de wrote: On Monday 03 August 2009 11:13:37 Michael Buesch wrote: On Monday 03 August 2009 00:18:22 Gábor Stefanik wrote: Implement baseband init for rev.0 and rev.1 LP PHYs. Convert boardflags_hi values to defines. Implement

Re: [PATCH RESEND] b43: implement baseband init for LP-PHY = rev1

2009-08-03 Thread Gábor Stefanik
2009/8/3 Michael Buesch m...@bu3sch.de: On Monday 03 August 2009 15:55:29 Gábor Stefanik wrote: On Mon, Aug 3, 2009 at 11:15 AM, Michael Bueschm...@bu3sch.de wrote: On Monday 03 August 2009 11:13:37 Michael Buesch wrote: On Monday 03 August 2009 00:18:22 Gábor Stefanik wrote: Implement

Re: [PATCH RESEND] b43: implement baseband init for LP-PHY = rev1

2009-08-03 Thread Gábor Stefanik
On Mon, Aug 3, 2009 at 11:16 PM, Michael Bueschm...@bu3sch.de wrote: On Monday 03 August 2009 22:58:30 Larry Finger wrote: Gábor states it the way the Broadcom routine is written. They have the flags divided into 3 16-bit values - high, middle, and low. The values are kept in arrays - one set

[PATCH] b43: Typo fixes minor cleanup

2009-08-04 Thread Gábor Stefanik
Fix a typo in the HostFlags #defines. Make use of HostFlags defines in the LP-PHY code. Fix fallout from the IEEE80211_IF_TYPE to NL80211_IFTYPE change. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- drivers/net/wireless/b43/b43.h|4 ++-- drivers/net/wireless/b43/phy_lp.c

[PATCH V3] b43: implement baseband init for LP-PHY = rev1

2009-08-04 Thread Gábor Stefanik
Implement baseband init for rev.0 and rev.1 LP PHYs. Convert boardflags_hi values to defines. Implement b43_phy_copy for easier copying between registers, as needed by LP-PHY init. Signed-off-by: Gábor Stefanik netrolller...@gmail.com Cc: Michael Buesch m...@bu3sch.de Cc: Larry Finger larry.fin

[PATCH] b43: Fix fallout from the IEEE80211_IF_TYPE to NL80211_IFTYPE change.

2009-08-04 Thread Gábor Stefanik
Update a comment that still says IEEE80211_IF_TYPE instead of NL80211_IFTYPE. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- This patch replaces b43: Typo fixes and minor cleanup, the other half of which has been integrated into the LP rev01 init patch. drivers/net/wireless/b43/b43.h

Re: [PATCH V3] b43: implement baseband init for LP-PHY = rev1

2009-08-04 Thread Gábor Stefanik
2009/8/5 Larry Finger larry.fin...@lwfinger.net: Gábor Stefanik wrote: Implement baseband init for rev.0 and rev.1 LP PHYs. Convert boardflags_hi values to defines. Implement b43_phy_copy for easier copying between registers, as needed by LP-PHY init. Signed-off-by: Gábor Stefanik

Re: BCM 4310 USB (14e4:4315). Any progress?

2009-08-05 Thread Gábor Stefanik
On Thu, Aug 6, 2009 at 12:05 AM, Roman Medina-Heigl Hernandezro...@rs-labs.com wrote: Hello, Sorry for pinging this list but I did some searches and I couldn't find responses... I've got a new Dell Mini-10 (Inspiron 1010), with the following wifi chipset: BCM 4310 USB. It's got PCI-ID:

[PATCH] b43: LP-PHY: Implement STX synchronization

2009-08-09 Thread Gábor Stefanik
The v2+ radio init (B2063) is now complete, modulo BCM4325 support. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- drivers/net/wireless/b43/phy_lp.c | 57 +++- 1 files changed, 55 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/b43

Re: [RFC PATCH] b43: Implement LP-PHY baseband table initialization

2009-08-10 Thread Gábor Stefanik
2009/8/10 Larry Finger larry.fin...@lwfinger.net: Gábor Stefanik wrote: Implement LP-PHY baseband table init for all revisions. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- Sorry for the size; it's difficult to cut short changes like this (most of the patch is just table data

Re: [RFC PATCH] b43: Implement LP-PHY baseband table initialization

2009-08-10 Thread Gábor Stefanik
2009/8/10 Michael Buesch m...@bu3sch.de: On Monday 10 August 2009 03:00:46 Gábor Stefanik wrote: +static const u16 lpphy_sw_control_table[] = { +     0x0128, +     0x0128, +     0x0009, +     0x0009, +     0x0028, +     0x0028, Is it possible to use more than one value per line for all

Re: [RFC PATCH] b43: Implement LP-PHY baseband table initialization

2009-08-10 Thread Gábor Stefanik
2009/8/10 Larry Finger larry.fin...@lwfinger.net: Gábor Stefanik wrote: 2009/8/10 Larry Finger larry.fin...@lwfinger.net: Gábor Stefanik wrote: Implement LP-PHY baseband table init for all revisions. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- Sorry for the size; it's

[PATCH] b43: Update LP-PHY rev2+ baseband init to match the specs

2009-08-10 Thread Gábor Stefanik
The rev2+ BB init spec has changed behind us, and thus the code is no longer up to date. Update the code to match the current specs. Also implement save/restore dig filt state, as required by the new specification (implemented as 2 separate functions). Signed-off-by: Gábor Stefanik netrolller

[PATCH RFC] ssb: Implement the remaining rev.8 SPROM vars needed for LP-PHY

2009-08-10 Thread Gábor Stefanik
Also add a SPEX32 macro for extracting 32-bit SPROM variables. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- I'm not quite sure that the SPEX32 macro is sane endianness-wise; please review it carefully. (In the future, we will probably need a SPEX64 macro too, to correctly extract

Re: [PATCH] b43: Implement LP-PHY baseband table initialization

2009-08-10 Thread Gábor Stefanik
2009/8/10 Larry Finger larry.fin...@lwfinger.net: Gábor Stefanik wrote: Implement LP-PHY baseband table init for all revisions. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- Changes from RFC: -Improved table formatting in the code. -The 2GHz check in adjust_gain_table now uses

Re: [PATCH RFC] ssb: Implement the remaining rev.8 SPROM vars needed for LP-PHY

2009-08-10 Thread Gábor Stefanik
2009/8/10 Michael Buesch m...@bu3sch.de: On Monday 10 August 2009 20:49:02 Gábor Stefanik wrote: Also add a SPEX32 macro for extracting 32-bit SPROM variables. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- I'm not quite sure that the SPEX32 macro is sane endianness-wise; please

[PATCH] ssb: Implement the remaining rev.8 SPROM vars needed for LP-PHY

2009-08-10 Thread Gábor Stefanik
Also add a SPEX32 macro for extracting 32-bit SPROM variables. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- Changes from RFC: -Fixed a bug in the SPEX32 macro. -in[SPOFF...] is now cast to u32 to be extra-safe. The macro still extracts little-endian, as that is probably what

Re: [PATCH] b43: Implement LP-PHY baseband table initialization

2009-08-10 Thread Gábor Stefanik
2009/8/10 John W. Linville linvi...@tuxdriver.com: On Mon, Aug 10, 2009 at 08:58:44PM +0200, Gábor Stefanik wrote: 2009/8/10 Larry Finger larry.fin...@lwfinger.net: Gábor Stefanik wrote: Implement LP-PHY baseband table init for all revisions. Signed-off-by: Gábor Stefanik netrolller

[PATCH RFC] b43: LP-PHY: Implement reading band SPROM

2009-08-10 Thread Gábor Stefanik
Some of the new variables in b43_phy_lp appear to be dead code in the vendor driver; they will be removed if they remain unused when LP-PHY implementation is finished. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- I've added a few FIXME comments, please review them. Also please check

[PATCH] b43: Fix a typo in the sync_stx routine

2009-08-10 Thread Gábor Stefanik
I completely missed the one's complement instruction from the specs. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- drivers/net/wireless/b43/phy_lp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43

[RFC] b43: LP-PHY: Initialize SW TX power control

2009-08-11 Thread Gábor Stefanik
I'm not sure at all if writing to offset 0 in the TX gain table is the right thing to do... please clarify. Not-yet-signed-off-by: Gábor Stefanik netrolller...@gmail.com --- If this is indeed the right thing to do, please inform me, and I will resubmit this as a formal patch. phy_lp.c | 16

[PATCH] b43: Implement RC calibration for rev.0/1 LP-PHYs

2009-08-12 Thread Gábor Stefanik
Also implement get/set BB mult, get/set TX gain, set RX gain, disable/restore CRS, run/stop DDFS, RX IQ est and QDIV roundup in the process. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- Larry, please review the SPEC FIXME comments! drivers/net/wireless/b43/phy_lp.c | 414

[PATCH v2] b43: Implement RC calibration for rev.0/1 LP-PHYs

2009-08-12 Thread Gábor Stefanik
Also implement get/set BB mult, get/set TX gain, set RX gain, disable/restore CRS, run/stop DDFS, RX IQ est and QDIV roundup in the process. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- Changes from v1-v2: -Coding style fixes as suggested by Michael. -Added missing static

[PATCH] b43: Update dummy transmission to match V4 specs

2009-08-12 Thread Gábor Stefanik
The V4 dummy transmission function has two extra bools in its prototype, so add a wrapper function for callers that expect the V3 version. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- drivers/net/wireless/b43/main.c | 60 --- drivers/net

[PATCH v2] b43: Update dummy transmission to match V4 specs

2009-08-13 Thread Gábor Stefanik
The V4 dummy transmission has two extra bools in its prototype, so update all callers with the 2 bools. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- v2: Convert all callers to v4, and drop the v3-v4 wrapper. drivers/net/wireless/b43/lo.c|2 +- drivers/net/wireless/b43

[PATCH v3] b43: LP-PHY: Initialize TX power control

2009-08-13 Thread Gábor Stefanik
The HW TX power control init still needs work. The SW init is complete according to the specs. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- v3: WARN_ON() setting TSSI mux mode to Ext, per Larry's suggestion. v2: Address Michael's comments, and update for the dummy transmission

Re: [PATCH] b43: LP-PHY: Implement channel switching for rev0/1/B2062 radio

2009-08-14 Thread Gábor Stefanik
2009/8/14 Mark Huijgen mark.sf@huijgen.tk: Gábor Stefanik wrote: Rev0/1/B2062 will now hopefully show some signs of life, though it won't work at full performance, as calibration is still missing. Just compiled wireless-testing.git**, enabled LP phy support in config, to see how far

Re: [PATCH] b43: LP-PHY: Implement channel switching for rev0/1/B2062 radio

2009-08-14 Thread Gábor Stefanik
2009/8/14 Mark Huijgen mark.sf@huijgen.tk: Gábor Stefanik wrote: ifconfig wlan0 wlan0     Link encap:Ethernet  HWaddr FF:FF:FF:FF:FF:FF          BROADCAST MULTICAST  MTU:1500  Metric:1          RX packets:0 errors:0 dropped:0 overruns:0 frame:0          TX packets:0 errors:0 dropped:0

[PATCH] b43: LP-PHY: Fix another TX power control abuse

2009-08-14 Thread Gábor Stefanik
This should fix the remaining WARN_ON. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- drivers/net/wireless/b43/phy_lp.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c index bf89173

Re: [PATCH] b43: Fix sparse warnings

2009-08-14 Thread Gábor Stefanik
On Fri, Aug 14, 2009 at 11:00 PM, Michael Bueschm...@bu3sch.de wrote: On Friday 14 August 2009 22:52:13 Pavel Roskin wrote: On Fri, 2009-08-14 at 22:15 +0200, Michael Buesch wrote: -                 b43_phy_mask(dev, 0x048A, (u16)~0x8000); +                 b43_phy_mask(dev, 0x048A,

Re: [PATCH] b43: LP-PHY: Fix another TX power control abuse

2009-08-14 Thread Gábor Stefanik
2009/8/14 Larry Finger larry.fin...@lwfinger.net: Gábor Stefanik wrote: This should fix the remaining WARN_ON. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- drivers/net/wireless/b43/phy_lp.c |    7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers

[PATCH] b43: Handle B43_PHYTYPE_LP in RX path

2009-08-14 Thread Gábor Stefanik
Don't drop all packets received from an LP-PHY with WARN_ON. Also update a comment with LP-specific information. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- drivers/net/wireless/b43/wa.c |2 +- drivers/net/wireless/b43/xmit.c |1 + 2 files changed, 2 insertions(+), 1

BCM4325 question

2009-08-15 Thread Gábor Stefanik
has only a rev.0 or rev.1 chip). Also, where did you obtain a 4325-based wireless solution; is it a custom-built board with a 4325 chip mounted directly, or some commercially available BCM4325-based solution? (The team will likely need one for testing.) Thanks, Gábor Stefanik B43 Linux wireless

[PATCH] b43: LP-PHY: Update baseband init for recent spec changes

2009-08-15 Thread Gábor Stefanik
.) Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- drivers/net/wireless/b43/phy_lp.c | 71 ++--- 1 files changed, 66 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c index 3872a31..72e1d8c

[PATCH v2] b43: LP-PHY: Update baseband init for recent spec changes

2009-08-15 Thread Gábor Stefanik
.) Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- V2: Coding style fix suggested by Michael on IRC. drivers/net/wireless/b43/phy_lp.c | 72 ++--- 1 files changed, 67 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers

[PATCH v3] b43: LP-PHY: Update baseband init for recent spec changes

2009-08-15 Thread Gábor Stefanik
.) Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- V2: Coding style fix suggested by Michael on IRC. V3: Another coding style fix. drivers/net/wireless/b43/phy_lp.c | 73 ++--- 1 files changed, 68 insertions(+), 5 deletions(-) diff --git a/drivers/net

[PATCH] b43: LP-PHY: Fix a spec error in the B2062 channel switch routine

2009-08-16 Thread Gábor Stefanik
The channel switch routine had a whole instruction missing. Add it. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- drivers/net/wireless/b43/phy_lp.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless

[PATCH v2] b43: LP-PHY: Update code for spec fixes, and fix a few typos

2009-08-16 Thread Gábor Stefanik
A few typos have been discovered in both the specs and the code. This patch fixes them. Also use lpphy_op_switch_channel consistently, and make all users of it print its return value for easier debugging. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- V2: Fix one more typo (this time

[PATCH] b43: LP-PHY: Remove BROKEN from B43_PHY_LP

2009-08-16 Thread Gábor Stefanik
Larry has reported success getting scan data with an LP-PHY device, so it's probably time to release LP-PHY support for testing. Also add a temporary BROKEN Kconfig symbol to disable 5GHz support, as 5GHz currently causes the driver to panic (NULL pointer deref). Signed-off-by: Gábor Stefanik

[PATCH] b43: LP-PHY: Update B2062 radio init with recent spec changes

2009-08-16 Thread Gábor Stefanik
The spec for initializing the B2062 radio have changed recently, update the code to match the changes. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- drivers/net/wireless/b43/phy_lp.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/net/wireless/b43

[PATCH v2] b43: LP-PHY: Remove BROKEN from B43_PHY_LP

2009-08-16 Thread Gábor Stefanik
Larry has reported success getting scan data with an LP-PHY device, so it's probably time to release LP-PHY support for testing. Also disable 802.11a support for now, as 802.11a currently causes the driver to panic on startup (NULL pointer dereference). Signed-off-by: Gábor Stefanik netrolller

Re: [PATCH] b43: LP-PHY: Fix reading old mode in the set TX power control routine

2009-08-17 Thread Gábor Stefanik
2009/8/14 Gábor Stefanik netrolller...@gmail.com: Check the mode the hardware is in, not the mode we used the last time. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- Mark, please test if this fixes the TX power control WARN_ON you were seeing. drivers/net/wireless/b43/phy_lp.c

Re: [PATCH] b43: LP-PHY: Fix setting TX power control mode during RC calibration

2009-08-17 Thread Gábor Stefanik
2009/8/17 John W. Linville linvi...@tuxdriver.com: On Mon, Aug 17, 2009 at 09:32:42PM +0200, Gábor Stefanik wrote: 2009/8/14 Gábor Stefanik netrolller...@gmail.com: Call set_tx_power_control with a LPPHY_TXPCTL rather than an LPPHY_TX_PWR_CTL_CMD_MODE. Signed-off-by: Gábor Stefanik

Re: [PATCH] b43: LP-PHY: Fix reading old mode in the set TX power control routine

2009-08-17 Thread Gábor Stefanik
2009/8/17 John W. Linville linvi...@tuxdriver.com: On Mon, Aug 17, 2009 at 09:33:06PM +0200, Gábor Stefanik wrote: 2009/8/14 Gábor Stefanik netrolller...@gmail.com: Check the mode the hardware is in, not the mode we used the last time. Signed-off-by: Gábor Stefanik netrolller...@gmail.com

[PATCH] b43: LP-PHY: Implement spec updates and remove resolved FIXMEs

2009-08-18 Thread Gábor Stefanik
the values has been implemented. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- drivers/net/wireless/b43/phy_lp.c | 98 +++ drivers/net/wireless/b43/phy_lp.h | 18 +++--- drivers/net/wireless/b43/tables_lpphy.c | 12 - 3 files changed

[PATCH] b43: LP-PHY: Two small spec updates

2009-08-18 Thread Gábor Stefanik
identification. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- drivers/net/wireless/b43/phy_lp.c | 17 - 1 files changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/b43/phy_lp.c b/drivers/net/wireless/b43/phy_lp.c index 6c69cdb..65f0010 100644

[ANN] b43 LP-PHY support (BCM4310/4312/4315) now ready for testing!

2009-08-18 Thread Gábor Stefanik
Hello World! Great news for Broadcom BCM4310/4312/4315 (PCI 14e4:4315) users: LP-PHY support is now at the point where it can be tested for functionality! There are still problems with channel switching (a few patches ago, only 802.11b/g channels 7 and 8 were working - no tests have been

Re: [ANN] b43 LP-PHY support (BCM4310/4312/4315) now ready for testing!

2009-08-19 Thread Gábor Stefanik
2009/8/19 Mark Huijgen mark.sf@huijgen.tk: Gábor Stefanik wrote: Hello World! Great news for Broadcom BCM4310/4312/4315 (PCI 14e4:4315) users: LP-PHY support is now at the point where it can be tested for functionality! So, go ahead, give it a try, and let's rock! Patches applied

Re: [PATCH] b43: LP-PHY: Implement spec updates and remove resolved FIXMEs

2009-08-19 Thread Gábor Stefanik
John, please hold off this patch for now, it appears to be causing regressions. I will investigate this. 2009/8/18 Gábor Stefanik netrolller...@gmail.com: Larry has started re-checking all current routines against a new version of the Broadcom MIPS driver. This patch implements the first round

Re: [ANN] b43 LP-PHY support (BCM4310/4312/4315) working (partially)!

2009-08-19 Thread Gábor Stefanik
On Wed, Aug 19, 2009 at 3:04 PM, Johannes Bergjohan...@sipsolutions.net wrote: On Wed, 2009-08-19 at 14:43 +0200, Mark Huijgen wrote: After running the included python script, patching the cutter and extracting firmware, I now get ucode version 478.104 in dmesg. Next test is also without the

Re: [ANN] b43 LP-PHY support (BCM4310/4312/4315) working (partially)!

2009-08-19 Thread Gábor Stefanik
2009/8/19 Mark Huijgen mark.sf@huijgen.tk: Gábor Stefanik wrote: Mark, could you produce a dmesg output with the new firmware, patches applied, and channel set to 1? Post the output of dmesg after scanning probably associating, if possible. (Scan/assoc may produce messages in dmesg.) I

Re: [ANN] b43 LP-PHY support (BCM4310/4312/4315) working (partially)!

2009-08-19 Thread Gábor Stefanik
2009/8/19 Mark Huijgen mark.sf@huijgen.tk: Gábor Stefanik wrote: 2009/8/19 Mark Huijgen mark.sf@huijgen.tk: Gábor Stefanik wrote: Mark, could you produce a dmesg output with the new firmware, patches applied, and channel set to 1? Post the output of dmesg after scanning probably

Re: [ANN] b43 LP-PHY support (BCM4310/4312/4315) working (partially)!

2009-08-19 Thread Gábor Stefanik
2009/8/19 Mark Huijgen mark.sf@huijgen.tk: Gábor Stefanik wrote: 2009/8/19 Mark Huijgen mark.sf@huijgen.tk: Gábor Stefanik wrote: 2009/8/19 Mark Huijgen mark.sf@huijgen.tk: Gábor Stefanik wrote: Mark, could you produce a dmesg output with the new firmware, patches applied

Re: [PATCH] b43: LP-PHY: Implement spec updates and remove resolved FIXMEs

2009-08-19 Thread Gábor Stefanik
False alert, sorry. Feel free to apply. The regression apparently resulted from the use of an incorrect firmware image - when Mark switched to the same firmware as Larry, his card started working again. 2009/8/19 Gábor Stefanik netrolller...@gmail.com: John, please hold off this patch for now

Re: [PATCH] b43: LP-PHY: Implement spec updates and remove resolved FIXMEs

2009-08-19 Thread Gábor Stefanik
upgraded to v478 firmware, his card too came to life.) So, please apply. 2009/8/18 Gábor Stefanik netrolller...@gmail.com: Larry has started re-checking all current routines against a new version of the Broadcom MIPS driver. This patch implements the first round of changes he documented on the specs

Re: [ANN] b43 LP-PHY support (BCM4310/4312/4315) working (partially)!

2009-08-20 Thread Gábor Stefanik
2009/8/20 Mark Huijgen mark.sf@huijgen.tk: Gábor Stefanik wrote: 2009/8/19 Mark Huijgen mark.sf@huijgen.tk: To summarize, all cases with patches and new firmware: case 1: cold boot with default channel 7, RC calib error and 'init channel failed' error, case 2: recompile+reload b43

[PATCH] b43: LP-PHY: Fix a few typos in the RC calibration code

2009-08-25 Thread Gábor Stefanik
The RC calibration code has some typos - fix them. Also, make the default channel 7, as channel 1 is still broken (only channels 7 and 8, and occasionally 9 work). Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- drivers/net/wireless/b43/phy_lp.c |7 --- 1 files changed, 4

[PATCH] b43: LP-PHY: Fix and simplify Qdiv roundup

2009-08-25 Thread Gábor Stefanik
The Qdiv roundup routine is essentially a fixed-point division algorithm, using only integer math. However, the version in the specs had a major error that has been recently fixed (a missing quotient++). Replace Qdiv roundup with a rewritten, simplified version. Signed-off-by: Gábor Stefanik

[PATCH v2] b43: LP-PHY: Fix and simplify Qdiv roundup

2009-08-26 Thread Gábor Stefanik
The Qdiv roundup routine is essentially a fixed-point division algorithm, using only integer math. However, the version in the specs had a major error that has been recently fixed (a missing quotient++). Replace Qdiv roundup with a rewritten, simplified version. Signed-off-by: Gábor Stefanik

[PATCH] ssb: Implement PMU LDO control and use it in b43

2009-08-26 Thread Gábor Stefanik
Implement the PMU LDO set voltage and PMU LDO PA ref enable functions, and use them during LP-PHY baseband init in b43. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- drivers/net/wireless/b43/phy_lp.c | 10 +-- drivers/ssb/driver_chipcommon_pmu.c | 94

[PATCH] b43: Fix and update LP-PHY code

2009-08-26 Thread Gábor Stefanik
functional. Sensitivity and TX power are still sub-optimal, due to the lack of calibration (that's next on my list). Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- drivers/net/wireless/b43/phy_common.c | 27 +++-- drivers/net/wireless/b43/phy_common.h |3 + drivers/net/wireless

[PATCH] b43: Remove scary message from LP-PHY's Kconfig

2009-08-26 Thread Gábor Stefanik
From: root Gábor Stefanik netrolller...@gmail.com The most common LP-PHY device, BCM4312, is now fully functional. So, no need to say probably won't work for you anymore. It's also not for debuggers and developers only, as it is perfectly usable for end-users now (at least for BCM4312). Signed

Re: [PATCH] b43: Fix and update LP-PHY code

2009-08-26 Thread Gábor Stefanik
2009/8/26 Michael Buesch m...@bu3sch.de: On Wednesday 26 August 2009 20:51:25 Gábor Stefanik wrote: -Fix a few nasty typos (b43_phy_* operations instead of b43_radio_*)  in the channel tune routines. -Fix some typos spec errors found by MMIO tracing. -Optimize b43_phy_write b43_phy_mask/set

[PATCH] b43: LP-PHY: Revert to the original PHY register write routine

2009-08-26 Thread Gábor Stefanik
From: root r...@nr3dmain.nr3d After some discussion on IRC about the PHY register write change, I am not sure anymore if this is the right thing to do. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- drivers/net/wireless/b43/phy_lp.c |3 ++- 1 files changed, 2 insertions(+), 1

Re: [PATCH] b43: LP-PHY: Revert to the original PHY register write routine

2009-08-26 Thread Gábor Stefanik
2009/8/26 Gábor Stefanik netrolller...@gmail.com: From: root r...@nr3dmain.nr3d The joys of an accidental sudo git format-patch... :-) After some discussion on IRC about the PHY register write change, I am not sure anymore if this is the right thing to do. Signed-off-by: Gábor Stefanik

[PATCH v2] b43: LP-PHY: Revert to the original PHY register write routine

2009-08-26 Thread Gábor Stefanik
After some discussion on IRC about the PHY register write change, I am not sure anymore if this is the right thing to do. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- v2: No more From: root. drivers/net/wireless/b43/phy_lp.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions

[PATCH v3] b43: LP-PHY: Revert to the original PHY register write routine

2009-08-26 Thread Gábor Stefanik
After some discussion on IRC about the PHY register write change, I am not sure anymore if this is the right thing to do. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- v3: Use 16-bit writes. drivers/net/wireless/b43/phy_lp.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions

Re: Congratulations

2009-08-26 Thread Gábor Stefanik
2009/8/27 Larry Finger larry.fin...@lwfinger.net: Gábor, Congratulations on your progress. With today's patches my BCM4312 802.11b/g card with PCI ID 14e4:4315 works - I'm using it at the moment. I'm using WPA2 encryption and have connected to APs on channels 1 and 11. My logs are clean.

[PATCH] b43: Enable LP-PHY support by default and remove Kconfig warning

2009-08-27 Thread Gábor Stefanik
The most common LP-PHY device, BCM4312, is now fully functional. So, no need to say probably won't work for you anymore. It's also not for debuggers and developers only, as it is perfectly usable for end-users now (at least for BCM4312). Signed-off-by: Gábor Stefanik netrolller...@gmail.com

[PATCH v2] b43: Enable LP-PHY support by default and remove Kconfig warning

2009-08-27 Thread Gábor Stefanik
The most common LP-PHY device, BCM4312, is now fully functional. So, no need to say probably won't work for you anymore. It's also not for debuggers and developers only, as it is perfectly usable for end-users now (at least for BCM4312). Signed-off-by: Gábor Stefanik netrolller...@gmail.com

[RFC/RFT] b43: Implement antenna diversity support for LP-PHY

2009-08-27 Thread Gábor Stefanik
Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- This intentionally deviates slightly from the spec (writing the antenna ID in one pass instead of two) - please test if this works. (I don't have the tools to test if it actually selects the right antenna.) The A/G-PHY changes are fallout

[PATCH] b43: Implement antenna diversity support for LP-PHY

2009-08-27 Thread Gábor Stefanik
The A/G-PHY changes are fallout fixes from the enum change, which in turn allows the LP-PHY code to be much simpler. The antenna_to_phyctl change is a fix for a potential existing bug that this patch may otherwise trigger. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- Note

Re: [PATCH] b43: Implement antenna diversity support for LP-PHY

2009-08-27 Thread Gábor Stefanik
2009/8/27 Michael Buesch m...@bu3sch.de: On Thursday 27 August 2009 20:56:22 Gábor Stefanik wrote: The A/G-PHY changes are fallout fixes from the enum change, which in turn allows the LP-PHY code to be much simpler. The antenna_to_phyctl change is a fix for a potential existing bug

[PATCH v2] b43: Implement antenna diversity support for LP-PHY

2009-08-27 Thread Gábor Stefanik
The A/G-PHY changes are fallout fixes from the enum change, which in turn allows the LP-PHY code to be much simpler. The antenna_to_phyctl change is a fix for a potential existing bug that this patch may otherwise trigger. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- v2: Fix a typo

[PATCH] b43: Refactor and update antenna diversity for A/G-PHY

2009-08-28 Thread Gábor Stefanik
-Make use of the b43_phy_set/mask/maskset helpers. -Fix a few errors in the code. -Make the code more readable. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- The phy-analog == 3 to phy-rev == 3 change in A-PHY is intentional, it's a bugfix/spec conformance fix. drivers/net/wireless

[PATCH] b43: Add myself to module authors to LP-PHY file copyright notices

2009-08-28 Thread Gábor Stefanik
Also mark the LP-PHY driver 802.11a/g instead of 802.11g, as LP-PHY is capable of both 2GHz and 5GHz operation. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- drivers/net/wireless/b43/main.c |1 + drivers/net/wireless/b43/phy_lp.c |3 ++- drivers/net/wireless/b43

[PATCH] b43: Fix typo in modparam_btcoex description

2009-08-28 Thread Gábor Stefanik
Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- drivers/net/wireless/b43/main.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/b43/main.c b/drivers/net/wireless/b43/main.c index 1263f4b..f2c5b2d 100644 --- a/drivers/net/wireless/b43/main.c

b43: LP-PHY: Fix TX gain tables

2009-08-28 Thread Gábor Stefanik
The rev1 2GHz and rev2 5GHz gain tables were incorrectly documented on the specs originally. Update these gaintables to match the cor- rected specs. Signed-off-by: Gábor Stefanik netroller...@gmail.com --- drivers/net/wireless/b43/tables_lpphy.c | 306 +++--- 1 files

[PATCH] b43: LP-PHY: Fix TX gain tables

2009-08-28 Thread Gábor Stefanik
Just noticed that the [PATCH] tag is accidentally missing on this one - I hope you can still apply it. 2009/8/28 Gábor Stefanik netrolller...@gmail.com: The rev1 2GHz and rev2 5GHz gain tables were incorrectly documented on the specs originally. Update these gaintables to match the cor- rected

[PATCH] b43: LP-PHY: Begin implementing calibration software RFKILL support

2009-08-29 Thread Gábor Stefanik
(required by calibration) is also implemented in this round. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- Larry, please check if I got the math in PHY Cordic right! drivers/net/wireless/b43/main.c |2 +- drivers/net/wireless/b43/main.h |2 + drivers/net/wireless/b43/phy_lp.c

[PATCH v2] b43: LP-PHY: Begin implementing calibration software RFKILL support

2009-08-29 Thread Gábor Stefanik
(required by calibration) is also implemented in this round. Signed-off-by: Gábor Stefanik netrolller...@gmail.com --- V2: Fix a mistake I made in the PHY Cordic routine. drivers/net/wireless/b43/main.c |2 +- drivers/net/wireless/b43/main.h |2 + drivers/net/wireless/b43/phy_lp.c | 686

Re: [PATCH v2] b43: LP-PHY: Begin implementing calibration software RFKILL support

2009-08-31 Thread Gábor Stefanik
2009 02:15:55 Gábor Stefanik wrote:  static void lpphy_pr41573_workaround(struct b43_wldev *dev)  {        struct b43_phy_lp *lpphy = dev-phy.lp; @@ -1357,28 +1488,440 @@ static void lpphy_pr41573_workaround(struct b43_wldev *dev)                b43_lptab_read_bulk(dev

Test message, please ignore.

2009-08-31 Thread Gábor Stefanik
I suspect that this will trigger a response from a spambot. reset ___ Bcm43xx-dev mailing list Bcm43xx-dev@lists.berlios.de https://lists.berlios.de/mailman/listinfo/bcm43xx-dev

Re: Help again please

2009-09-02 Thread Gábor Stefanik
(CCing bcm43xx-dev.) Could you post the dmesg output when this happens? (Enable debugging in b43 before taking the log.) 2009/9/2 Brian J. Mc Hugh bjmch...@aya.yale.edu: Hi Gábor, I seem to remember you explaining there was a bluetooth problem and it couldn't coexist. Is that right? Brian

  1   2   >