Re: [blink-dev] Re: Intent to Implement and Ship : onslotchange event handler IDL attribute

2021-09-02 Thread Chris Harrelson
LGTM3 On Thu, Sep 2, 2021 at 10:10 AM Mike West wrote: > LGTM2. I agree that this is a tiny ergonomic change, and matching Safari's > behavior (with Mozilla's positive signals) should increase interop in the > future. > > -mike > > > On Thu, Sep 2, 2021 at 3:39 PM Yoav Weiss wrote: > >> LGTM1

Re: [blink-dev] Re: Intent to Implement and Ship : onslotchange event handler IDL attribute

2021-09-02 Thread Mike West
LGTM2. I agree that this is a tiny ergonomic change, and matching Safari's behavior (with Mozilla's positive signals) should increase interop in the future. -mike On Thu, Sep 2, 2021 at 3:39 PM Yoav Weiss wrote: > LGTM1 > > This seems like a small addition to improve the platform's

Re: [blink-dev] Re: Intent to Implement and Ship : onslotchange event handler IDL attribute

2021-09-02 Thread Yoav Weiss
LGTM1 This seems like a small addition to improve the platform's consistency. On Thu, Sep 2, 2021 at 2:57 PM Frédéric Wang wrote: > Le 02/09/2021 à 13:46, Yoav Weiss a écrit : > > > The motivation section brings up use cases that this would make easier, > but it's not super clear what they

Re: [blink-dev] Re: Intent to Implement and Ship : onslotchange event handler IDL attribute

2021-09-02 Thread Frédéric Wang
Le 02/09/2021 à 13:46, Yoav Weiss a écrit : The motivation section brings up use cases that this would make easier, but it's not super clear what they are, and if developers feel they are important. I wondered if this is something you have evidence for. With that said, now that I understand

Re: [blink-dev] Re: Intent to Implement and Ship : onslotchange event handler IDL attribute

2021-09-02 Thread Yoav Weiss
On Thu, Sep 2, 2021 at 1:18 PM Frédéric Wang wrote: > Le 02/09/2021 à 12:15, Yoav Weiss a écrit : > > > An actual explainer that outlines what the feature does, and its developer > and user benefits would be helpful for reviewing this. > > Just to clarify, the slotchange event is already

Re: [blink-dev] Re: Intent to Implement and Ship : onslotchange event handler IDL attribute

2021-09-02 Thread Frédéric Wang
Le 02/09/2021 à 12:15, Yoav Weiss a écrit : An actual explainer that outlines what the feature does, and its developer and user benefits would be helpful for reviewing this. Just to clarify, the slotchange event is already implemented in all browsers, one can find document on MDN [1] [2].

[blink-dev] Re: Intent to Implement and Ship : onslotchange event handler IDL attribute

2021-09-02 Thread Yoav Weiss
On Friday, August 27, 2021 at 8:37:49 PM UTC+2 ssi...@igalia.com wrote: > Contact emails > ssin...@igalia.com, fw...@chromium.org > > Explainer: > Currently, the way to listen an event is: > target.addEventListener("slotchange", listener); > > After this addition an alternative