bug#58005: 13.1.4; Can't work with indirect buffers

2024-05-05 Thread Arash Esbati
Vangelis Evangelou writes: > Hi all. I agree with Paul. Sorry for the oversight. For some reason, > in my local installation, I have what Paul suggests, which is why I > hadn't picked it up when I submitted the patch. Thank you all for your comments. I installed that change (0caa170649).

bug#58005: 13.1.4; Can't work with indirect buffers

2024-05-05 Thread Vangelis Evangelou
Hi all. I agree with Paul. Sorry for the oversight. For some reason, in my local installation, I have what Paul suggests, which is why I hadn't picked it up when I submitted the patch. On Sun, 5 May 2024 at 04:04, Ikumi Keita wrote: > Hi all, > > > Arash Esbati writes: > > Paul Nelson

bug#58005: 13.1.4; Can't work with indirect buffers

2024-05-04 Thread Ikumi Keita
Hi all, > Arash Esbati writes: > Paul Nelson writes: >> Somewhere between when I tried Vangelis's patch (earlier in this >> thread) and when it was installed, it seems that a further change was >> made to preview-region that breaks previews in indirect buffers. >> Specifically, the

bug#58005: 13.1.4; Can't work with indirect buffers

2024-05-04 Thread Arash Esbati
Paul Nelson writes: > Somewhere between when I tried Vangelis's patch (earlier in this > thread) and when it was installed, it seems that a further change was > made to preview-region that breaks previews in indirect buffers. > Specifically, the substitution buffer-file-name -> >

bug#58005: 13.1.4; Can't work with indirect buffers

2024-05-04 Thread Paul Nelson
Somewhere between when I tried Vangelis's patch (earlier in this thread) and when it was installed, it seems that a further change was made to preview-region that breaks previews in indirect buffers. Specifically, the substitution buffer-file-name -> (TeX-buffer-file-name) was applied where it

bug#58005: 13.1.4; Can't work with indirect buffers

2024-04-25 Thread Arash Esbati
Hi Keita, Ikumi Keita writes: > >>> To AUCTeX admins: Do you think Vangelis'es patch needs copyright >>> assignment? In my opinion, it doesn't because definition of >>> `TeX-buffer-file-name' is straightforward and other changes are trivial >>> (replacements of `buffer-file-name' ->

bug#58005: 13.1.4; Can't work with indirect buffers

2024-04-25 Thread Ikumi Keita
[ To phil...@haselwarter.org: I'm sorry, the thread began to fail to include you in Cc:; It seems to reach a reasonable solution. ] > Vangelis Evangelou writes: > OK. I attach the diff. > On Wed, 24 Apr 2024 at 10:57, Ikumi Keita wrote: Thanks, I added small adaptaion and a paragraph

bug#58005: 13.1.4; Can't work with indirect buffers

2024-04-25 Thread Vangelis Evangelou
OK. I attach the diff. On Wed, 24 Apr 2024 at 10:57, Ikumi Keita wrote: > Hi Vangelis, > > > Vangelis Evangelou writes: > > Hi all. > > I'm not sure what the ideal outcome is. It depends on each user's case. > In > > principle, indirect buffers have identical text content as their base > >

bug#58005: 13.1.4; Can't work with indirect buffers

2024-04-24 Thread Ikumi Keita
Hi Vangelis, > Vangelis Evangelou writes: > Hi all. > I'm not sure what the ideal outcome is. It depends on each user's case. In > principle, indirect buffers have identical text content as their base > buffer, but different view properties, so the previews not showing in the > indirect

bug#58005: 13.1.4; Can't work with indirect buffers

2024-04-24 Thread Vangelis Evangelou
Hi all. I'm not sure what the ideal outcome is. It depends on each user's case. In principle, indirect buffers have identical text content as their base buffer, but different view properties, so the previews not showing in the indirect buffer agrees with this principle. I therefore, agree with

bug#58005: 13.1.4; Can't work with indirect buffers

2024-04-23 Thread Ikumi Keita
Hi Paul and Vangelis, > Paul Nelson writes: >> Ah, I see. Thanks for confirmation. I didn't try region preview. The >> previews do appear in the indirect buffer if I type C-c C-p C-b etc. >> >> I expect you see what I described if you type C-c C-p C-d in the >> indirect buffer. > OK, good

bug#58005: 13.1.4; Can't work with indirect buffers

2024-04-23 Thread Paul Nelson
Hi Ikumi, > Ah, I see. Thanks for confirmation. I didn't try region preview. The > previews do appear in the indirect buffer if I type C-c C-p C-b etc. > > I expect you see what I described if you type C-c C-p C-d in the > indirect buffer. OK, good -- we're on the same page then. For whatever

bug#58005: 13.1.4; Can't work with indirect buffers

2024-04-23 Thread Ikumi Keita
Hi Paul, > Paul Nelson writes: > For me, previews work fine in indirect buffers with this patch (based > on 20 mins of usage). I don't see anything like what you described > (previews appearing in the base buffer). Ah, I see. Thanks for confirmation. I didn't try region preview. The

bug#58005: 13.1.4; Can't work with indirect buffers

2024-04-23 Thread Paul Nelson
> I used > patch -p1 < indirect2.patch > in the top directory of the local git repo and took care of the rejected > hunks manually. > Thanks Ikuya, I did this just now and tried the patch out (and have attached the master-relative patch that I obtained after merging, in case it's of convenience

bug#58005: 13.1.4; Can't work with indirect buffers

2024-04-23 Thread Ikumi Keita
Hi, > Paul Nelson writes: >> Can you try the following command on terminal? Replace auctex-dir below with >> our auctex directory. >> patch -ruN -d auctex-dir < indirect2.patch > I'm trying this from the latest origin/master, but happy to try > something else if you think that'd be a good

bug#58005: 13.1.4; Can't work with indirect buffers

2024-04-23 Thread Paul Nelson
> Can you try the following command on terminal? Replace auctex-dir below with > our auctex directory. > patch -ruN -d auctex-dir < indirect2.patch I'm trying this from the latest origin/master, but happy to try something else if you think that'd be a good idea. auctex % patch -ruN -d . <

bug#58005: 13.1.4; Can't work with indirect buffers

2024-04-23 Thread Vangelis Evangelou
Can you try the following command on terminal? Replace auctex-dir below with our auctex directory. patch -ruN -d auctex-dir < indirect2.patch On Tue, 23 Apr 2024 at 12:30, Paul Nelson wrote: > > Sorry, I forgot to reply all in my previous email. The patch is attached > here. > > > > Sorry to

bug#58005: 13.1.4; Can't work with indirect buffers

2024-04-23 Thread Paul Nelson
> Sorry, I forgot to reply all in my previous email. The patch is attached here. > Sorry to turn this thread into "git tech support", but when I try applying this patch using "magit-apply", I get the error: 128 git … am --3way -- /Users/au710211/.emacs.d/elpaca/repos/auctex/indirect2.patch

bug#58005: 13.1.4; Can't work with indirect buffers

2024-04-23 Thread Vangelis Evangelou
Sorry, I forgot to reply all in my previous email. The patch is attached here. Original message Hi Ikumi. Sorry I missed preview.el.in. Yes, I can change that too. Regarding `TeX-master-file', I don't know what is the correct order that the various conditions need to be checked.

bug#58005: 13.1.4; Can't work with indirect buffers

2024-04-23 Thread Paul Nelson
> A brief testing didn't show fatal behavior. Here are two notes I noticed: > 1. In indirect buffer, preview-latex doesn't work. All preview images >appear in the base buffer. > 2. TeX Fold mode works independently in indirect and base buffers. > > I suppose there will be dissatisfied users

bug#58005: 13.1.4; Can't work with indirect buffers

2024-04-23 Thread Ikumi Keita
[ Please keep Cc: 58...@debbugs.gnu.org when you reply so that the record remains in the bug tracker. ] > Vangelis Evangelou writes: > Regarding `TeX-master-file', I don't know what is the correct order that > the various conditions need to be checked. There might be a situation where >

bug#58005: 13.1.4; Can't work with indirect buffers

2024-04-17 Thread Ikumi Keita
Hi Vangelis, > Vangelis Evangelou writes: > ./tex.el:2440: (and buffer-file-name > ./tex.el:2441: (file-name-directory buffer-file-name))) > In the above, I think that part of the code is in fact redundant. That's > because if the function's `expand-file-name' second

bug#58005: 13.1.4; Can't work with indirect buffers

2024-04-15 Thread Vangelis Evangelou
Hi Ikumi. Thank you for your email. Current AUCTeX source has some references to the variable > `buffer-file-name', as well as call to the function of the same name. It > seems that the variable is nil in indirect buffers. Is it safe to leave > those references unchanged? You are correct. I

bug#58005: 13.1.4; Can't work with indirect buffers

2024-04-14 Thread Ikumi Keita
> Ikumi Keita writes: > . Why is the first argument always nil? The original function receives > the second argument as `extension'. Aren't there cases that we should ^^ > provide the same argument `extension' here? Sorry, I meant "first" here actually, rather than "second".

bug#58005: 13.1.4; Can't work with indirect buffers

2024-04-14 Thread Ikumi Keita
Hi Vangelis, > Vangelis Evangelou writes: > I am using indirect buffers with auctex and I am affected by this. My use > is to have an indirect buffer narrowed to the preamble of my file. > Typically, if I want to define a new command, I switch to the narrowed > buffer instead of jumping at

bug#58005: 13.1.4; Can't work with indirect buffers

2024-03-07 Thread Arash Esbati
Ikumi Keita writes: > Hi Philipp, please keep "Cc: 58...@debbugs.gnu.org" when you reply so > that the thread of the discussion remain in the bug tracker. > >> "Philipp G. Haselwarter" writes: >> Dear Keita, >> Thank you for looking into this issue. > >> I frequently use indirect buffers

bug#58005: 13.1.4; Can't work with indirect buffers

2022-12-09 Thread Ikumi Keita
Hi Philipp, please keep "Cc: 58...@debbugs.gnu.org" when you reply so that the thread of the discussion remain in the bug tracker. > "Philipp G. Haselwarter" writes: > Dear Keita, > Thank you for looking into this issue. > I frequently use indirect buffers when editing longer tex documents.

bug#58005: 13.1.4; Can't work with indirect buffers

2022-12-08 Thread Ikumi Keita
Hi Philipp, very sorry for such a long delay to reply. > "Philipp G. Haselwarter" writes: > Hi, > I often find myself jumping from latex to the current position in the > pdf via `pdf-sync-forward-search' from pdf-tools. This does not work > when the buffer I am editing is an indirect buffer,

bug#58005: 13.1.4; Can't work with indirect buffers

2022-09-22 Thread Philipp G. Haselwarter
Hi, I often find myself jumping from latex to the current position in the pdf via `pdf-sync-forward-search' from pdf-tools. This does not work when the buffer I am editing is an indirect buffer, like what you get from `C-x 4 c', i.e. `clone-indirect-buffer-other-window'. In particular,