On Wed, 10 Apr 2024 12:15:34 GMT, Joachim Kern wrote:
>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
>> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
>> clang by another name, and it uses the clang toolchain in the JDK build.
>> Thus
On Wed, 10 Apr 2024 13:46:11 GMT, Martin Doerr wrote:
>> In my humble opinion the inclusion of alloca.h was slightly cleaner, but I
>> guess it doesn't matter. Out of curiosity, why do you guys prefer not
>> including it?
>
> When only looking at AIX code, I think the inclusion of alloca.h was
On Wed, 10 Apr 2024 12:15:34 GMT, Joachim Kern wrote:
>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
>> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
>> clang by another name, and it uses the clang toolchain in the JDK build.
>> Thus
On Wed, 10 Apr 2024 13:35:39 GMT, Julian Waters wrote:
>> Yes I believe. I will remove the `#pragma alloca` everywhere, I will remove
>> the `#include ` everywhere and I will add
>> `-Dalloca=__builtin_alloca` to the compile commands. If it works I will
>> update the PR.
>
> In my humble
On Wed, 10 Apr 2024 10:13:37 GMT, Joachim Kern wrote:
>> Can `-Dalloca=__builtin_alloca` replace `#include `?
>
> Yes I believe. I will remove the `#pragma alloca` everywhere, I will remove
> the `#include ` everywhere and I will add
> `-Dalloca=__builtin_alloca` to the compile commands. If
On Wed, 10 Apr 2024 13:19:50 GMT, Martin Doerr wrote:
>> Currently XLC16 but looking to upgrade to XLC17 on the minimum supported
>> level for it (So it wouldn't be SP7 at present). Thanks for the ping - we
>> have no current plans to increase to SP7.
>
> Seems like we need to keep it. This is
On Tue, 9 Apr 2024 17:25:04 GMT, Stewart X Addison wrote:
>> Pinging @sxa - what build environment does temurin use for AIX?
>
> Currently XLC16 but looking to upgrade to XLC17 on the minimum supported
> level for it (So it wouldn't be SP7 at present). Thanks for the ping - we
> have no
> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
> clang by another name, and it uses the clang toolchain in the JDK build. Thus
> the old xlc toolchain was removed by
>
> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
> clang by another name, and it uses the clang toolchain in the JDK build. Thus
> the old xlc toolchain was removed by
>
> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
> clang by another name, and it uses the clang toolchain in the JDK build. Thus
> the old xlc toolchain was removed by
>
On Wed, 10 Apr 2024 10:07:02 GMT, Martin Doerr wrote:
>> Is the comment in front of
>> https://github.com/openjdk/jdk/blob/51ed69a586105b707ae616f9eba898449bf9fba7/src/hotspot/os/aix/os_aix.cpp#L28
>> still correct? Seems like it should get replaced. See
>>
On Wed, 10 Apr 2024 10:00:02 GMT, Martin Doerr wrote:
>> If I omit this #include
>> I get compiler errors of the following kind
>>
>> .../src/hotspot/share/runtime/javaThread.cpp::24: error: use of
>> undeclared identifier 'alloca'
>> char* p1 = (char*) alloca(1);
>>
On Wed, 10 Apr 2024 09:40:16 GMT, Joachim Kern wrote:
>> Do we even need to include ?
>>
>> From the Linux man page for alloca:
>>
>> By necessity, alloca() is a compiler built-in, also known as
>> __builtin_alloca(). By default, modern compilers automatically
>> translate all uses of
> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
> clang by another name, and it uses the clang toolchain in the JDK build. Thus
> the old xlc toolchain was removed by
>
On Wed, 10 Apr 2024 00:51:22 GMT, Kim Barrett wrote:
>> src/hotspot/share/utilities/globalDefinitions_gcc.hpp line 36:
>>
>>> 34: #if defined(_AIX)
>>> 35: #include
>>> 36: #endif
>>
>> I would much rather see this include added in the few places it was actually
>> needed, rather than being
On Tue, 9 Apr 2024 18:32:04 GMT, Kim Barrett wrote:
>> Joachim Kern has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> version check not needed anymore
>
> src/hotspot/share/utilities/byteswap.hpp line 2:
>
>> 1: /*
>> 2: * Copyright (c)
On Tue, 9 Apr 2024 17:00:56 GMT, Thomas Stuefe wrote:
>> Joachim Kern has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> version check not needed anymore
>
> src/hotspot/os_cpu/aix_ppc/os_aix_ppc.cpp line 440:
>
>> 438: st->print("pc ="
On Tue, 9 Apr 2024 16:59:39 GMT, Thomas Stuefe wrote:
>> Hi Thomas, `maxDisclaimSize` is of type `unsigned int`; therefore I get the
>> following warning:
>>
>> os/aix/os_aix.cpp:314:42: error: format specifies type 'unsigned long' but
>> the argument has type 'unsigned int'
On Tue, 9 Apr 2024 19:20:22 GMT, Kim Barrett wrote:
>> Joachim Kern has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> version check not needed anymore
>
> src/hotspot/share/utilities/globalDefinitions_gcc.hpp line 36:
>
>> 34: #if
On Tue, 2 Apr 2024 16:14:12 GMT, Joachim Kern wrote:
>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
>> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
>> clang by another name, and it uses the clang toolchain in the JDK build.
>> Thus
On Tue, 9 Apr 2024 17:01:59 GMT, Thomas Stuefe wrote:
>> @suchismith1993
>> Hi Suchi, can you please tell me when you will raise your build environment
>> from AIX 7.2 TL5 SP5 to SP7?
>> I' am asking you, because I want to get rid of this nasty workaround.
>
> Pinging @sxa - what build
On Tue, 2 Apr 2024 09:19:16 GMT, Joachim Kern wrote:
>> Hi Thomas,
>> I would like to get totally rid of this, because as I mentioned IBM already
>> modified the `stdlib.h` header not using `#define malloc vec_malloc` any
>> more (and all the other vec_... defines). We have to ask the adoptium
On Tue, 2 Apr 2024 16:14:12 GMT, Joachim Kern wrote:
>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
>> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
>> clang by another name, and it uses the clang toolchain in the JDK build.
>> Thus
On Tue, 2 Apr 2024 10:26:42 GMT, Joachim Kern wrote:
>> src/hotspot/os/aix/os_aix.cpp line 314:
>>
>>> 312: ErrnoPreserver ep;
>>> 313: log_trace(os, map)("disclaim failed: " RANGEFMT " errno=(%s)",
>>> 314: RANGEFMTARGS(p, (long)maxDisclaimSize),
>>
>>
On Tue, 2 Apr 2024 16:14:12 GMT, Joachim Kern wrote:
>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
>> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
>> clang by another name, and it uses the clang toolchain in the JDK build.
>> Thus
On Wed, 3 Apr 2024 02:28:08 GMT, Julian Waters wrote:
>> https://github.com/openjdk/jdk/pull/18586
>
> @kimbarrett I've been doing things to permit gcc/Windows, not clang. clang
> has too many different distributions on Windows for me to settle on one, and
> generalising all of them to be able
On Tue, 2 Apr 2024 20:10:12 GMT, Kim Barrett wrote:
>> I'm waiting for a bunch of tests to complete, so decided to just take that
>> issue.
>
> https://github.com/openjdk/jdk/pull/18586
@kimbarrett I've been doing things to permit gcc/Windows, not clang. clang has
too many different
On Tue, 2 Apr 2024 11:35:44 GMT, Joachim Kern wrote:
>> linux macos and now Aix use this file.
>
> Who is able to explain if
> `#if defined(LINUX) || defined(_ALLBSD_SOURCE) || defined(_AIX)`
> in this file is equivalent to
> `#if 1`
See my other comments and
On Tue, 2 Apr 2024 17:01:07 GMT, Kim Barrett wrote:
>> https://bugs.openjdk.org/browse/JDK-8329546 - I can take this if nobody else
>> grabs it soon.
>
> I'm waiting for a bunch of tests to complete, so decided to just take that
> issue.
https://github.com/openjdk/jdk/pull/18586
On Tue, 2 Apr 2024 16:52:04 GMT, Kim Barrett wrote:
>> There was at one time an attempt at a gcc/Solaris port, but I think it was
>> never completed, and most vestiges removed. More recently, @TheShermanTanker
>> has been doing stuff to permit clang/Windows, and clang-based builds use
>> this
On Tue, 2 Apr 2024 16:41:40 GMT, Kim Barrett wrote:
>> I cannot answer this question.
>> If this line is now obsolete it was also obsolete before including AIX,
>> because AIX didn't use this file beforehand.
>
> There was at one time an attempt at a gcc/Solaris port, but I think it was
> never
On Tue, 2 Apr 2024 11:20:49 GMT, Joachim Kern wrote:
>> src/hotspot/share/utilities/globalDefinitions_gcc.hpp line 62:
>>
>>> 60: #include
>>> 61:
>>> 62: #if defined(LINUX) || defined(_ALLBSD_SOURCE) || defined(_AIX)
>>
>> What else is left? Could we just remove this line altogether now?
>
> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
> clang by another name, and it uses the clang toolchain in the JDK build. Thus
> the old xlc toolchain was removed by
>
On Tue, 2 Apr 2024 14:48:49 GMT, Martin Doerr wrote:
>> My question is, do we need this block, because now already configure warns
>> about an outdated compiler, or is a warning to weak and we want to force
>> this error here?
>
> I think that building with xlc 16 is no longer possible because
On Tue, 2 Apr 2024 11:22:54 GMT, Joachim Kern wrote:
>> I'd prefer having less AIX specific parts in this file. Can this be moved
>> somewhere else? Or maybe combine it with the AIX code above?
>
> My question is, do we need this block, because now already configure warns
> about an outdated
> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
> clang by another name, and it uses the clang toolchain in the JDK build. Thus
> the old xlc toolchain was removed by
>
On Tue, 2 Apr 2024 11:28:30 GMT, Joachim Kern wrote:
>> src/hotspot/share/utilities/globalDefinitions_gcc.hpp line 103:
>>
>>> 101: #endif
>>> 102:
>>> 103: #if !defined(LINUX) && !defined(_ALLBSD_SOURCE) && !defined(_AIX)
>>
>> I believe this whole section can be removed now.
>>
>> At least
On Fri, 29 Mar 2024 08:06:01 GMT, Thomas Stuefe wrote:
>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
>> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
>> clang by another name, and it uses the clang toolchain in the JDK build.
>> Thus
On Thu, 28 Mar 2024 17:33:29 GMT, Martin Doerr wrote:
>> src/hotspot/share/utilities/globalDefinitions_gcc.hpp line 83:
>>
>>> 81: #error "xlc version not supported, macro __open_xl_version__ not
>>> found"
>>> 82: #endif
>>> 83: #endif // AIX
>>
>> This `#ifdef _AIX` might be obsolete,
On Fri, 29 Mar 2024 07:39:06 GMT, Thomas Stuefe wrote:
>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
>> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
>> clang by another name, and it uses the clang toolchain in the JDK build.
>> Thus
On Fri, 29 Mar 2024 07:25:30 GMT, Thomas Stuefe wrote:
>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
>> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
>> clang by another name, and it uses the clang toolchain in the JDK build.
>> Thus
On Fri, 29 Mar 2024 07:19:33 GMT, Thomas Stuefe wrote:
>> src/hotspot/os/aix/loadlib_aix.cpp line 120:
>>
>>> 118: (lm->is_in_vm ? '*' : ' '),
>>> 119: (uintptr_t)lm->text, (uintptr_t)lm->text + lm->text_len,
>>> 120: (uintptr_t)lm->data, (uintptr_t)lm->data + lm->data_len,
>>
On Fri, 29 Mar 2024 07:21:43 GMT, Thomas Stuefe wrote:
>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
>> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
>> clang by another name, and it uses the clang toolchain in the JDK build.
>> Thus
On Tue, 2 Apr 2024 09:14:10 GMT, Joachim Kern wrote:
>> Other than that, and kind of depending on your answer: How important is it
>> that we catch every use of the original malloc? Can be safely mix the
>> original malloc with vec_malloc if logging is not involved?
>>
>> I am asking, because
On Fri, 29 Mar 2024 07:59:05 GMT, Thomas Stuefe wrote:
>> While looking at this, I noticed that my question in
>> https://github.com/openjdk/jdk/pull/14146#discussion_r1207078176 and
>> followups had never been answered. Do you know the answers now?
>>
>> Quoting myself:
>>
>>> So, we do
On Fri, 29 Mar 2024 05:23:57 GMT, Julian Waters wrote:
> > The rest of the changes are needed because of using
> > utilities/compilerWarnings_xlc.hpp the compiler is much more nagging about
> > ill formatted printf
>
> Did you mean compilerWarnings_gcc.hpp?
Yes, you're right. I fixed it.
On Fri, 29 Mar 2024 07:56:10 GMT, Thomas Stuefe wrote:
>> src/hotspot/share/utilities/globalDefinitions_gcc.hpp line 50:
>>
>>> 48: #undef malloc
>>> 49: extern void *malloc(size_t) asm("vec_malloc");
>>> 50: #endif
>>
>> This `#if` is not needed if we are building on AIX 7.2 TL5 SP7 or
On Thu, 28 Mar 2024 16:57:00 GMT, Joachim Kern wrote:
>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
>> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
>> clang by another name, and it uses the clang toolchain in the JDK build.
>> Thus
On Fri, 29 Mar 2024 07:18:47 GMT, Thomas Stuefe wrote:
>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
>> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
>> clang by another name, and it uses the clang toolchain in the JDK build.
>> Thus
On Thu, 28 Mar 2024 16:50:20 GMT, Joachim Kern wrote:
> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
> clang by another name, and it uses the clang toolchain in the JDK build. Thus
> the
On Thu, 28 Mar 2024 16:50:20 GMT, Joachim Kern wrote:
> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
> clang by another name, and it uses the clang toolchain in the JDK build. Thus
> the
On Thu, 28 Mar 2024 16:53:39 GMT, Joachim Kern wrote:
>> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
>> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
>> clang by another name, and it uses the clang toolchain in the JDK build.
>> Thus
On Thu, 28 Mar 2024 16:50:20 GMT, Joachim Kern wrote:
> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
> clang by another name, and it uses the clang toolchain in the JDK build. Thus
> the
On Thu, 28 Mar 2024 16:50:20 GMT, Joachim Kern wrote:
> As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building
> the JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect
> clang by another name, and it uses the clang toolchain in the JDK build. Thus
> the
As of [JDK-8325880](https://bugs.openjdk.org/browse/JDK-8325880), building the
JDK requires version 17 of IBM Open XL C/C++ (xlc). This is in effect clang by
another name, and it uses the clang toolchain in the JDK build. Thus the old
xlc toolchain was removed by
55 matches
Mail list logo
