Re: [PATCH] udhcpc: add support for sending DHCPINFORM requests

2022-08-30 Thread Luca Boccassi
ot;)" > > //usage: IF_FEATURE_UDHCP_PORT( > > @@ -1172,6 +1186,7 @@ static void client_background(void) > > //usage: "\n -s PROG Run PROG at DHCP events > (default > > "CONFIG_UDHCPC_DEFAULT_SCRIPT")" > > //usage: "\n -p FILE Create pidfile" > > //usage: "\n -B Request broadcast replies" > > +//usage: "\n -I Request using inform" > > This barely explains anything. Updated in v2. > > +//usage: "\n -e IP Request this server IP > address" > > This is not correct. We do not "request server IPs". > We send requests to servers (sometimes by unicasting to their IPs, > but usually via broadcast). Updated in v2. > > + > > + if (opt & OPT_I) > > + use_inform = 1; > > Why do you need to have use_inform variable when (opt & OPT_I) > works just as well? Removed in v2. -- Kind regards, Luca Boccassi signature.asc Description: This is a digitally signed message part ___ busybox mailing list busybox@busybox.net http://lists.busybox.net/mailman/listinfo/busybox

Re: [PATCH v2] udhcpc: add support for sending DHCPINFORM packets

2022-09-22 Thread Luca Boccassi
On Tue, 2022-08-30 at 22:41 +0100, bl...@debian.org wrote: > From: Luca Boccassi > > It is useful for applications to be able to query DHCP options > without renewing IP address. Instead of a full DHCP handshake, > using -I will cause a single DHCPINFORM packet to be sent, a

Re: [PATCH v2] udhcpc: add support for sending DHCPINFORM packets

2022-11-02 Thread Luca Boccassi
On Thu, 22 Sept 2022 at 13:31, Luca Boccassi wrote: > > On Tue, 2022-08-30 at 22:41 +0100, bl...@debian.org wrote: > > From: Luca Boccassi > > > > It is useful for applications to be able to query DHCP options > > without renewing IP address. Instead of a ful

Re: [PATCH v2] udhcpc: add support for sending DHCPINFORM packets

2023-01-16 Thread Luca Boccassi
On Wed, 2 Nov 2022 at 12:05, Luca Boccassi wrote: > > On Thu, 22 Sept 2022 at 13:31, Luca Boccassi wrote: > > > > On Tue, 2022-08-30 at 22:41 +0100, bl...@debian.org wrote: > > > From: Luca Boccassi > > > > > > It is useful for applications t