[clang] [LTO] Fix Veclib flags correctly pass to LTO flags (PR #78749)

2024-01-22 Thread David Sherwood via cfe-commits
@@ -783,6 +783,28 @@ void tools::addLTOOptions(const ToolChain , const ArgList , "-generate-arange-section")); } + // Pass vector library arguments to LTO. + Arg *ArgVecLib = Args.getLastArg(options::OPT_fveclib); + if (ArgVecLib

[clang] [LTO] Fix Veclib flags correctly pass to LTO flags (PR #78749)

2024-01-22 Thread David Sherwood via cfe-commits
@@ -31,3 +31,31 @@ // RUN: %clang -fveclib=Accelerate %s -nodefaultlibs -target arm64-apple-ios8.0.0 -### 2>&1 | FileCheck --check-prefix=CHECK-LINK-NODEFAULTLIBS %s // CHECK-LINK-NODEFAULTLIBS-NOT: "-framework" "Accelerate" + + +/* Verify that the correct vector library is

[clang] Add option -fstdlib-hardening= (PR #78763)

2024-01-22 Thread Akira Hatanaka via cfe-commits
@@ -7730,6 +7730,14 @@ def source_date_epoch : Separate<["-"], "source-date-epoch">, } // let Visibility = [CC1Option] +def stdlib_hardening_EQ : Joined<["-"], "fstdlib-hardening=">, + Values<"none,fast,extensive,debug">, + NormalizedValues<["STDLIB_HARDENING_MODE_NONE",

[llvm] [clang] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread Hana Dusíková via cfe-commits
https://github.com/hanickadot updated https://github.com/llvm/llvm-project/pull/78033 From ae319fd34659c1373ce573346b93ffaa290a3312 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hana=20Dusi=CC=81kova=CC=81?= Date: Mon, 22 Jan 2024 00:00:43 +0100 Subject: [PATCH 1/9] [coverage] skipping code

[llvm] [clang] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread via cfe-commits
Hana =?utf-8?q?Dusi=CC=81kova=CC=81?= , Hana =?utf-8?q?Dusi=CC=81kova=CC=81?= , Hana =?utf-8?q?Dusi=CC=81kova=CC=81?= , Hana =?utf-8?q?Dusi=CC=81kova=CC=81?= , Hana =?utf-8?q?Dusi=CC=81kova=CC=81?= , Hana =?utf-8?q?Dusi=CC=81kova=CC=81?= , Hana =?utf-8?q?Dusi=CC=81kova=CC=81?= Message-ID:

[llvm] [clang] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -809,7 +809,7 @@ Bug Fixes in This

[clang] [SPIR-V] Prefer llvm-spirv- tool (PR #77897)

2024-01-22 Thread Henry Linjamäki via cfe-commits
linehill wrote: @AnastasiaStulova, @MaskRay, gentle ping. https://github.com/llvm/llvm-project/pull/77897 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SPIR-V] Prefer llvm-spirv- tool (PR #77897)

2024-01-22 Thread Henry Linjamäki via cfe-commits
https://github.com/linehill updated https://github.com/llvm/llvm-project/pull/77897 From 6165987ab890156a503d7afa38ad5c88510368b0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henry=20Linjam=C3=A4ki?= Date: Thu, 21 Dec 2023 08:43:16 +0200 Subject: [PATCH 1/2] [SPIR-V] Prefer llvm-spirv- tool

[clang] [llvm] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread Hana Dusíková via cfe-commits
@@ -1700,43 +1776,116 @@ struct CounterCoverageMappingBuilder Visit(S->getSubStmt()); } + void CoverIfConsteval(const IfStmt *S) { +assert(S->isConsteval()); + +const auto *Then = S->getThen(); +const auto *Else = S->getElse(); + +// I'm using

[llvm] [clang] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread Hana Dusíková via cfe-commits
https://github.com/hanickadot updated https://github.com/llvm/llvm-project/pull/78033 From ae319fd34659c1373ce573346b93ffaa290a3312 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hana=20Dusi=CC=81kova=CC=81?= Date: Mon, 22 Jan 2024 00:00:43 +0100 Subject: [PATCH 1/8] [coverage] skipping code

[llvm] [clang] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread Hana Dusíková via cfe-commits
https://github.com/hanickadot updated https://github.com/llvm/llvm-project/pull/78033 From ae319fd34659c1373ce573346b93ffaa290a3312 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hana=20Dusi=CC=81kova=CC=81?= Date: Mon, 22 Jan 2024 00:00:43 +0100 Subject: [PATCH 1/7] [coverage] skipping code

[clang] [LTO] Fix Veclib flags correctly pass to LTO flags (PR #78749)

2024-01-22 Thread Maciej Gabka via cfe-commits
@@ -31,3 +31,31 @@ // RUN: %clang -fveclib=Accelerate %s -nodefaultlibs -target arm64-apple-ios8.0.0 -### 2>&1 | FileCheck --check-prefix=CHECK-LINK-NODEFAULTLIBS %s // CHECK-LINK-NODEFAULTLIBS-NOT: "-framework" "Accelerate" + + +/* Verify that the correct vector library is

[compiler-rt] [mlir] [lldb] [lld] [llvm] [openmp] [clang-tools-extra] [libcxx] [libclc] [clang] [libc] Make llvm-strip not eat the .gnu_debuglink section (PR #78919)

2024-01-22 Thread Felix Kellenbenz via cfe-commits
felixkellenbenz wrote: Hey thanks for the review, I will add a test case in a moment. That's true, my change only impacts `--strip-all`. I tested `llvm-strip` with the `--strip-debug` flag and this didn't remove the `.gnu_debuglink` section. This is also seen when using `GNU strip`. Here

[compiler-rt] [lldb] [lld] [llvm] [flang] [clang-tools-extra] [libcxx] [clang] [libc] [clang] Fix assertion failure with deleted overloaded unary operators (PR #78316)

2024-01-22 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon closed https://github.com/llvm/llvm-project/pull/78316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (PR #69133)

2024-01-22 Thread David Spickett via cfe-commits
@@ -850,23 +850,38 @@ if (CLANG_ENABLE_BOOTSTRAP) endforeach() endif() -if (CLANG_BOLT_INSTRUMENT AND NOT LLVM_BUILD_INSTRUMENTED) +set(CLANG_BOLT "INSTRUMENT" CACHE STRING "Apply BOLT optimization to Clang. \ DavidSpickett wrote: Wild guess, this defaults

[clang] 11d1310 - [clang] Fix assertion failure with deleted overloaded unary operators (#78316)

2024-01-22 Thread via cfe-commits
Author: Mariya Podchishchaeva Date: 2024-01-22T10:06:26+01:00 New Revision: 11d1310b57a9f2defb4d65a35b90a69020c52e46 URL: https://github.com/llvm/llvm-project/commit/11d1310b57a9f2defb4d65a35b90a69020c52e46 DIFF:

[compiler-rt] [llvm] [clang-tools-extra] [libcxx] [clang] [libc] [mlir] [flang] [clang] Remove `CXXNewInitializationStyle::Implicit` (PR #78793)

2024-01-22 Thread via cfe-commits
https://github.com/tomasz-kaminski-sonarsource commented: LGTM. Thanks. https://github.com/llvm/llvm-project/pull/78793 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [lldb] [lld] [llvm] [flang] [clang-tools-extra] [libcxx] [clang] [libc] [clang] Fix assertion failure with deleted overloaded unary operators (PR #78316)

2024-01-22 Thread Mariya Podchishchaeva via cfe-commits
Fznamznon wrote: Driver failure seems unrelated. https://github.com/llvm/llvm-project/pull/78316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (PR #69133)

2024-01-22 Thread David Spickett via cfe-commits
DavidSpickett wrote: https://lab.llvm.org/buildbot/#/builders/245/builds/19468 ``` CMake Error at /home/tcwg-buildbot/worker/clang-armv8-quick/llvm/clang/utils/perf-training/CMakeLists.txt:105 (add_custom_target): Error evaluating generator expression: $ No target "merge-fdata" ```

[clang] 6c47419 - Revert "[Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (#69133)"

2024-01-22 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2024-01-22T08:58:17Z New Revision: 6c47419703acfcd7dcca9e30ab9dba6a7a42f977 URL: https://github.com/llvm/llvm-project/commit/6c47419703acfcd7dcca9e30ab9dba6a7a42f977 DIFF: https://github.com/llvm/llvm-project/commit/6c47419703acfcd7dcca9e30ab9dba6a7a42f977.diff

[clang] [clang][analyzer] Add function 'fscanf' to StreamChecker. (PR #78180)

2024-01-22 Thread Balázs Kéri via cfe-commits
https://github.com/balazske closed https://github.com/llvm/llvm-project/pull/78180 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0845514 - [clang][analyzer] Add function 'fscanf' to StreamChecker. (#78180)

2024-01-22 Thread via cfe-commits
Author: Balázs Kéri Date: 2024-01-22T09:58:09+01:00 New Revision: 0845514d1a78ca04ef90b775d8819a8a8f19a533 URL: https://github.com/llvm/llvm-project/commit/0845514d1a78ca04ef90b775d8819a8a8f19a533 DIFF: https://github.com/llvm/llvm-project/commit/0845514d1a78ca04ef90b775d8819a8a8f19a533.diff

[clang] [Clang][CMake] Support perf, LBR, and Instrument CLANG_BOLT options (PR #69133)

2024-01-22 Thread David Spickett via cfe-commits
DavidSpickett wrote: I think because bots don't always clean their cmake files, revert incoming. https://github.com/llvm/llvm-project/pull/69133 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-format] Do not update cursor pos if no includes replacement (PR #77456)

2024-01-22 Thread via cfe-commits
https://github.com/NorthBlue333 updated https://github.com/llvm/llvm-project/pull/77456 >From a3ddae11b909a319d73fccff409fa5c0648a234f Mon Sep 17 00:00:00 2001 From: NorthBlue333 Date: Tue, 9 Jan 2024 14:01:14 +0100 Subject: [PATCH] [clang-format] Do not update cursor pos if no includes

[mlir] [openmp] [libc] [libcxx] [libclc] [lld] [lldb] [clang-tools-extra] [compiler-rt] [clang] [llvm] Make llvm-strip not eat the .gnu_debuglink section (PR #78919)

2024-01-22 Thread James Henderson via cfe-commits
https://github.com/jh7370 requested changes to this pull request. Hi, thanks for the contribution. Please could you add a new lit test case to show that this behaviour works as intended. I note that this code as-is only impacts `--strip-all` behaviour. This means that if you use

[lldb] [libcxx] [libc] [compiler-rt] [flang] [llvm] [clang] [clang-tools-extra] [lld] [AMDGPU][GFX12] VOP encoding and codegen - add support for v_cvt fp8/… (PR #78414)

2024-01-22 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm commented: Why is so there so much special casing in the assembler/disassembler? https://github.com/llvm/llvm-project/pull/78414 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[mlir] [openmp] [libc] [libcxx] [libclc] [lld] [lldb] [clang-tools-extra] [compiler-rt] [clang] [llvm] Make llvm-strip not eat the .gnu_debuglink section (PR #78919)

2024-01-22 Thread Felix Kellenbenz via cfe-commits
https://github.com/felixkellenbenz updated https://github.com/llvm/llvm-project/pull/78919 >From bf376afe7bd69fd25a006890b2910f2fd32c191b Mon Sep 17 00:00:00 2001 From: Felix Kellenbenz Date: Mon, 22 Jan 2024 00:49:21 +0100 Subject: [PATCH] Make llvm-strip not eat the .gnu_debuglink section

[clang] [Clang][AST] fix crash in mangle lambda expression (PR #78896)

2024-01-22 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/78896 >From e4ac395028e651721677d85caf6c76e3a7f79308 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Wed, 17 Jan 2024 14:16:34 +0800 Subject: [PATCH 1/2] [Clang][Sema] fix outline member function template with default

[clang] [llvm] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -1700,43 +1776,116 @@ struct CounterCoverageMappingBuilder Visit(S->getSubStmt()); } +

[clang-tools-extra] [include-cleaner] Add --only-headers flag, opposite of --ignore-headers (PR #78714)

2024-01-22 Thread Haojian Wu via cfe-commits
https://github.com/hokein approved this pull request. https://github.com/llvm/llvm-project/pull/78714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Enable direct methods and fast alloc calls for libobjc2. (PR #78030)

2024-01-22 Thread David Chisnall via cfe-commits
https://github.com/davidchisnall closed https://github.com/llvm/llvm-project/pull/78030 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f36845d - Enable direct methods and fast alloc calls for libobjc2. (#78030)

2024-01-22 Thread via cfe-commits
Author: David Chisnall Date: 2024-01-22T08:38:41Z New Revision: f36845d0c696023ea97931a4201b43ddfababf9c URL: https://github.com/llvm/llvm-project/commit/f36845d0c696023ea97931a4201b43ddfababf9c DIFF: https://github.com/llvm/llvm-project/commit/f36845d0c696023ea97931a4201b43ddfababf9c.diff

[clang] [clang-format] Do not update cursor pos if no includes replacement (PR #77456)

2024-01-22 Thread via cfe-commits
NorthBlue333 wrote: `clang-check` builds in local. https://github.com/llvm/llvm-project/pull/77456 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread Jessica Paquette via cfe-commits
Hana =?utf-8?q?Dusi=CC=81kova=CC=81?= , Hana =?utf-8?q?Dusi=CC=81kova=CC=81?= , Hana =?utf-8?q?Dusi=CC=81kova=CC=81?= , Hana =?utf-8?q?Dusi=CC=81kova=CC=81?= , Hana =?utf-8?q?Dusi=CC=81kova=CC=81?= Message-ID: In-Reply-To: https://github.com/ornata approved this pull request. LGTM

[libclc] libclc: add missing AMD gfx symlinks (PR #78884)

2024-01-22 Thread Matt Arsenault via cfe-commits
=?utf-8?b?Wm9sdMOhbiBCw7ZzesO2cm3DqW55aQ=?=, =?utf-8?b?Wm9sdMOhbiBCw7ZzesO2cm3DqW55aQ=?Message-ID: In-Reply-To: https://github.com/arsenm closed https://github.com/llvm/llvm-project/pull/78884 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[libclc] 262735b - libclc: add missing AMD gfx symlinks (#78884)

2024-01-22 Thread via cfe-commits
Author: Zoltán Böszörményi Date: 2024-01-22T15:32:13+07:00 New Revision: 262735bbcc22f216a688b934ca9ff50b427c9dc1 URL: https://github.com/llvm/llvm-project/commit/262735bbcc22f216a688b934ca9ff50b427c9dc1 DIFF:

[clang] 8658d15 - Revert "[Clang][Sema] Diagnose function/variable templates that shadow their own template parameters (#78274)"

2024-01-22 Thread Corentin Jabot via cfe-commits
Author: Corentin Jabot Date: 2024-01-22T09:29:01+01:00 New Revision: 8658d157654832fe24b4f3d2a9a62784a4d6a162 URL: https://github.com/llvm/llvm-project/commit/8658d157654832fe24b4f3d2a9a62784a4d6a162 DIFF:

[llvm] [clang] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread Hana Dusíková via cfe-commits
https://github.com/hanickadot updated https://github.com/llvm/llvm-project/pull/78033 From ae319fd34659c1373ce573346b93ffaa290a3312 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hana=20Dusi=CC=81kova=CC=81?= Date: Mon, 22 Jan 2024 00:00:43 +0100 Subject: [PATCH 1/6] [coverage] skipping code

[flang] [clang] [flang]Add support for -moutline-atomics and -mno-outline-atomics (PR #78755)

2024-01-22 Thread Andrzej Warzyński via cfe-commits
@@ -354,6 +354,27 @@ void Flang::addTargetOptions(const ArgList , CmdArgs.push_back(Args.MakeArgString(CPU)); } + if (Arg *A = Args.getLastArg(options::OPT_moutline_atomics, + options::OPT_mno_outline_atomics)) { +// Option

[llvm] [clang] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread Hana Dusíková via cfe-commits
@@ -1251,6 +1264,69 @@ struct CounterCoverageMappingBuilder popRegions(Index); } + /// Find a valid range starting with \p StartingLoc and ending before \p + /// BeforeLoc. + std::optional findAreaStartingFromTo(SourceLocation StartingLoc, +

[llvm] [clang] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread Hana Dusíková via cfe-commits
https://github.com/hanickadot updated https://github.com/llvm/llvm-project/pull/78033 From ae319fd34659c1373ce573346b93ffaa290a3312 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hana=20Dusi=CC=81kova=CC=81?= Date: Mon, 22 Jan 2024 00:00:43 +0100 Subject: [PATCH 1/5] [coverage] skipping code

[clang] [clang][dataflow] Treat comma operator correctly in `getResultObjectLocation()`. (PR #78427)

2024-01-22 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/78427 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a2caa49 - [clang][dataflow] Treat comma operator correctly in `getResultObjectLocation()`. (#78427)

2024-01-22 Thread via cfe-commits
Author: martinboehme Date: 2024-01-22T09:23:06+01:00 New Revision: a2caa4929e8e8a24ee5f03ab37a9be7462a0 URL: https://github.com/llvm/llvm-project/commit/a2caa4929e8e8a24ee5f03ab37a9be7462a0 DIFF: https://github.com/llvm/llvm-project/commit/a2caa4929e8e8a24ee5f03ab37a9be7462a0.diff

[llvm] [clang] [RISCV] Add Zicfiss support to the shadow call stack implementation. (PR #68075)

2024-01-22 Thread Yeting Kuo via cfe-commits
yetingk wrote: Ping. https://github.com/llvm/llvm-project/pull/68075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Update documentation for `#pragma diagnostic` (PR #78095)

2024-01-22 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/78095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [clang] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread Hana Dusíková via cfe-commits
@@ -174,6 +179,10 @@ class SourceMappingRegion { void setGap(bool Gap) { GapRegion = Gap; } + bool isSkipped() const { return SkippedRegion; } hanickadot wrote: SkippedRegions are also created by preprocessor for comments and whitespaces, then they are

[clang] [clang] Update documentation for `#pragma diagnostic` (PR #78095)

2024-01-22 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/78095 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread Hana Dusíková via cfe-commits
@@ -1700,43 +1776,116 @@ struct CounterCoverageMappingBuilder Visit(S->getSubStmt()); } + void CoverIfConsteval(const IfStmt *S) { +assert(S->isConsteval()); + +const auto *Then = S->getThen(); +const auto *Else = S->getElse(); + +// I'm using

[clang] [llvm] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread Hana Dusíková via cfe-commits
https://github.com/hanickadot updated https://github.com/llvm/llvm-project/pull/78033 From ae319fd34659c1373ce573346b93ffaa290a3312 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hana=20Dusi=CC=81kova=CC=81?= Date: Mon, 22 Jan 2024 00:00:43 +0100 Subject: [PATCH 1/7] [coverage] skipping code

[clang] [clang-format] BreakAfterAttributes did not take into account gnu attributes (PR #78102)

2024-01-22 Thread Owen Pan via cfe-commits
owenca wrote: > You either have to use a new option, or adapt the documentation. Latter > clearly only refers to `C++11 attributes`, which `__attribute__(())` isn't. > > I don't think a new option is needed. > > When you are already at it, you may also consider handling `__declspec()`. +1.

[clang] [clang-format] Add MainIncludeChar option. (PR #78752)

2024-01-22 Thread via cfe-commits
https://github.com/j-jorge updated https://github.com/llvm/llvm-project/pull/78752 >From b6284b7498a283d28bfd5025897041dee23354c8 Mon Sep 17 00:00:00 2001 From: Julien Jorge Date: Fri, 19 Jan 2024 18:44:58 +0100 Subject: [PATCH] [clang-format] Add MainIncludeChar option. Resolves #27008,

[clang] [clang-format] Add MainIncludeChar option. (PR #78752)

2024-01-22 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata updated https://github.com/llvm/llvm-project/pull/78752 >From b6284b7498a283d28bfd5025897041dee23354c8 Mon Sep 17 00:00:00 2001 From: Julien Jorge Date: Fri, 19 Jan 2024 18:44:58 +0100 Subject: [PATCH] [clang-format] Add MainIncludeChar option. Resolves

[clang-tools-extra] a54463a - [clang-tidy] Use llvm::any_of (NFC)

2024-01-22 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2024-01-22T00:13:29-08:00 New Revision: a54463a4c6c32810b064e02b39e2c8f0de974006 URL: https://github.com/llvm/llvm-project/commit/a54463a4c6c32810b064e02b39e2c8f0de974006 DIFF: https://github.com/llvm/llvm-project/commit/a54463a4c6c32810b064e02b39e2c8f0de974006.diff

[clang] 234da20 - [Analysis] Use StringRef::ends_with_insensitive (NFC)

2024-01-22 Thread Kazu Hirata via cfe-commits
Author: Kazu Hirata Date: 2024-01-22T00:13:27-08:00 New Revision: 234da203779be31c83541d99ee28e01ee422c506 URL: https://github.com/llvm/llvm-project/commit/234da203779be31c83541d99ee28e01ee422c506 DIFF: https://github.com/llvm/llvm-project/commit/234da203779be31c83541d99ee28e01ee422c506.diff

[clang] [llvm] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread Jessica Paquette via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -174,6 +179,10 @@ class SourceMappingRegion { void setGap(bool Gap) { GapRegion = Gap; } +

[clang] [llvm] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread Hana Dusíková via cfe-commits
https://github.com/hanickadot updated https://github.com/llvm/llvm-project/pull/78033 From ae319fd34659c1373ce573346b93ffaa290a3312 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hana=20Dusi=CC=81kova=CC=81?= Date: Mon, 22 Jan 2024 00:00:43 +0100 Subject: [PATCH 1/6] [coverage] skipping code

[clang] [Serialization] Load Specializations Lazily (PR #76774)

2024-01-22 Thread Jonas Hahnfeld via cfe-commits
hahnjo wrote: > Would you like to give an reproducer so that I can debug? Not easily at the moment, unless you want to go through building the entirety of ROOT :-/ https://github.com/llvm/llvm-project/pull/76774 ___ cfe-commits mailing list

[clang] [llvm] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread Jessica Paquette via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -1251,6 +1264,69 @@ struct CounterCoverageMappingBuilder popRegions(Index); } + /// Find a valid range starting with \p

[clang] [llvm] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread Hana Dusíková via cfe-commits
https://github.com/hanickadot updated https://github.com/llvm/llvm-project/pull/78033 From ae319fd34659c1373ce573346b93ffaa290a3312 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Hana=20Dusi=CC=81kova=CC=81?= Date: Mon, 22 Jan 2024 00:00:43 +0100 Subject: [PATCH 1/5] [coverage] skipping code

[clang] [clang][dataflow] Treat comma operator correctly in `getResultObjectLocation()`. (PR #78427)

2024-01-22 Thread via cfe-commits
martinboehme wrote: > On the other hand, I am still wondering whether it is a good idea to expose > this publicly to the checks or we could do it automatically when necessary in > the engine code. That being said, I think the "publicness" of this API is not > that important to solve at this

[clang] Improved is simple type specifier (PR #78903)

2024-01-22 Thread Owen Pan via cfe-commits
owenca wrote: > Here's the sort of approach I"m looking at @owenca Can you restore the clang-format files for this pull request? I'll open another PR that depends on this one. https://github.com/llvm/llvm-project/pull/78903 ___ cfe-commits mailing

[clang] [llvm] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread Jessica Paquette via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -1700,43 +1776,116 @@ struct CounterCoverageMappingBuilder Visit(S->getSubStmt()); } + void CoverIfConsteval(const IfStmt *S) { +

[clang] [libclang/python] Expose Rewriter to the python binding (PR #77269)

2024-01-22 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: @linux4life798 Nice catch! I see that so far only `CompilationDatabase` and `CompletionChunk` expose functions in camelCase. It would be nice to change them, too, but those are decade-old APIs that _I think_ we promise stability for, so it might not be possible.

[clang] [llvm] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread Jessica Paquette via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -1700,43 +1776,116 @@ struct CounterCoverageMappingBuilder Visit(S->getSubStmt()); } + void CoverIfConsteval(const IfStmt *S) {

[clang] [llvm] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/78033 ___ cfe-commits mailing list

[clang] [llvm] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -1700,43 +1777,116 @@ struct CounterCoverageMappingBuilder Visit(S->getSubStmt()); } + void CoverIfConsteval(const IfStmt *S) { +

[clang] [llvm] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -1700,43 +1776,116 @@ struct CounterCoverageMappingBuilder Visit(S->getSubStmt()); } + void CoverIfConsteval(const IfStmt *S) { +

[clang] [llvm] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -1700,43 +1776,116 @@ struct CounterCoverageMappingBuilder Visit(S->getSubStmt()); } + void CoverIfConsteval(const IfStmt *S) { +

[llvm] [clang] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread via cfe-commits
Hana =?utf-8?q?Dusi=CC=81kova=CC=81?= , Hana =?utf-8?q?Dusi=CC=81kova=CC=81?= , Hana =?utf-8?q?Dusi=CC=81kova=CC=81?= Message-ID: In-Reply-To: https://github.com/cor3ntin commented: Looks great! I added a few comments This probably needs another edit of the release notes

[llvm] [clang] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -1700,43 +1776,116 @@ struct CounterCoverageMappingBuilder Visit(S->getSubStmt()); } + void CoverIfConsteval(const IfStmt *S) { +

[clang] [llvm] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -1700,43 +1776,116 @@ struct CounterCoverageMappingBuilder Visit(S->getSubStmt()); } + void CoverIfConsteval(const IfStmt *S) { +

[clang] [llvm] [coverage] skipping code coverage for 'if constexpr' and 'if consteval' (PR #78033)

2024-01-22 Thread via cfe-commits
Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= , Hana =?utf-8?q?Dusíková?= Message-ID: In-Reply-To: @@ -1700,43 +1776,116 @@ struct CounterCoverageMappingBuilder Visit(S->getSubStmt()); } + void CoverIfConsteval(const IfStmt *S) { +

[clang] [llvm] [AMDGPU] Enable OpenCL hostcall printf (WIP) (PR #72556)

2024-01-22 Thread Sameer Sahasrabuddhe via cfe-commits
@@ -198,15 +213,31 @@ RValue CodeGenFunction::EmitAMDGPUDevicePrintfCallExpr(const CallExpr *E) { } llvm::Value *Arg = A.getRValue(*this).getScalarVal(); +if (isString(A.getType().getTypePtr()) && CGM.getLangOpts().OpenCL) + Arg =

<    2   3   4   5   6   7