ayermolo wrote:
It's been 24 hours with no broken build bots. So I guess this one got it right.
:)
https://github.com/llvm/llvm-project/pull/83331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/ayermolo closed
https://github.com/llvm/llvm-project/pull/83331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dwblaikie approved this pull request.
Yeah, still not sure why something like `%clang -### -c -target x86_64 -g
-gsplit-dwarf %s` wouldn't change behavior on a darwin host and cause the check
for gnu-pubnames to fail there but if you say that works, guess that's OK &
if
ayermolo wrote:
@dwblaikie ping
https://github.com/llvm/llvm-project/pull/83331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/clayborg commented:
LGTM, but I will let the code owners here accept
https://github.com/llvm/llvm-project/pull/83331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11,7 +11,6 @@
// NOINLINE-NOT: "-fsplit-dwarf-inlining"
// SPLIT-NOT: "-dumpdir"
// SPLIT: "-debug-info-kind=constructor"
-// SPLIT-SAME: "-ggnu-pubnames"
ayermolo wrote:
At least on my mac it passed. With that check.
I double checked, and this is
@@ -11,7 +11,6 @@
// NOINLINE-NOT: "-fsplit-dwarf-inlining"
// SPLIT-NOT: "-dumpdir"
// SPLIT: "-debug-info-kind=constructor"
-// SPLIT-SAME: "-ggnu-pubnames"
dwblaikie wrote:
Nah, I think that's probably fine without an explicit `-ggdb` test - though
https://github.com/ayermolo edited
https://github.com/llvm/llvm-project/pull/83331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ayermolo edited
https://github.com/llvm/llvm-project/pull/83331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11,7 +11,6 @@
// NOINLINE-NOT: "-fsplit-dwarf-inlining"
// SPLIT-NOT: "-dumpdir"
// SPLIT: "-debug-info-kind=constructor"
-// SPLIT-SAME: "-ggnu-pubnames"
ayermolo wrote:
Oh I see!
Thanks for clarification.
That check should be there. I think it
https://github.com/ayermolo updated
https://github.com/llvm/llvm-project/pull/83331
>From 7d58760a887fc935e2af670f8aa721cdd5946391 Mon Sep 17 00:00:00 2001
From: Alexander Yermolovich
Date: Fri, 23 Feb 2024 14:52:04 -0800
Subject: [PATCH 1/2] [CLANG][DWARF] Do not emit -ggnu-pubnames for split
@@ -11,7 +11,6 @@
// NOINLINE-NOT: "-fsplit-dwarf-inlining"
// SPLIT-NOT: "-dumpdir"
// SPLIT: "-debug-info-kind=constructor"
-// SPLIT-SAME: "-ggnu-pubnames"
dwblaikie wrote:
> As discussed in original PR, #82840 , the idea is if -gsplit-dwarf with
>
https://github.com/ayermolo edited
https://github.com/llvm/llvm-project/pull/83331
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
13 matches
Mail list logo