[chromium-dev] Incorrect files under \src\third_party\python_24?

2009-03-09 Thread gutongsedeyo...@gmail.com
1) I am trying to compile Chromium with hammer/scons on Windows, with the latest source, and I am getting the following error message: scons: Reading SConscript files ... File D:\chromium\src\tools\grit\grit\scons.py, line 83 finally: ^ SyntaxError: invalid

[chromium-dev] focusRingColor() listening to system settings changes on Windows?

2009-03-09 Thread Jeremy Moskovich
(mailed to random people who I thought might know the answer). In platform/graphics/chromium/ColorChromium.cpp we currently hardcode the value of focusRingColor on OS X Windows. On OS X Safari listens on a notification to see if the user has changed the system focus color. Is there a similar

[chromium-dev] Re: focusRingColor() listening to system settings changes on Windows?

2009-03-09 Thread Dean McNamee
I would have to guess that if there was, it would be some window message (WM_THEMECHANGED ?) sent to our top level window, and the plumbing would be annoying for it. On Mon, Mar 9, 2009 at 10:21 AM, Jeremy Moskovich jer...@chromium.org wrote: (mailed to random people who I thought might know

[chromium-dev] Re: Incorrect files under \src\third_party\python_24?

2009-03-09 Thread Sam Kerner
Before python 2.5, a try block could not have both an except and finally block. (See http://docs.python.org/reference/compound_stmts.html#the-try-statement). In pre-2.5 python, you can get around this using two nested try blocks. try: try: blah() except: yada() finally:

[chromium-dev] Re: Changes to the waterfall.

2009-03-09 Thread Darin Fisher
On Sun, Mar 8, 2009 at 4:58 PM, Adam Langley a...@chromium.org wrote: On Sun, Mar 8, 2009 at 4:54 PM, Nicolas Sylvain nsylv...@chromium.org wrote: Hello, over the weekend I made some changes to the waterfall, and you might be interested. Firstly, thank you! This is great. Yes, thank

[chromium-dev] Re: Changes to the waterfall.

2009-03-09 Thread tony
On Mon, 9 Mar 2009, Nicolas Sylvain wrote: On Mon, Mar 9, 2009 at 9:10 AM, Darin Fisher da...@chromium.org wrote: On Sun, Mar 8, 2009 at 4:58 PM, Adam Langley a...@chromium.org wrote: On Sun, Mar 8, 2009 at 4:54 PM, Nicolas Sylvain nsylv...@chromium.org wrote: Hello, over the

[chromium-dev] Re: Changes to the waterfall.

2009-03-09 Thread Darin Fisher
On Mon, Mar 9, 2009 at 9:38 AM, t...@chromium.org wrote: On Mon, 9 Mar 2009, Nicolas Sylvain wrote: On Mon, Mar 9, 2009 at 9:10 AM, Darin Fisher da...@chromium.org wrote: On Sun, Mar 8, 2009 at 4:58 PM, Adam Langley a...@chromium.org wrote: On Sun, Mar 8, 2009 at 4:54 PM,

[chromium-dev] Re: Changes to the waterfall.

2009-03-09 Thread Nicolas Sylvain
On Mon, Mar 9, 2009 at 9:38 AM, t...@chromium.org wrote: On Mon, 9 Mar 2009, Nicolas Sylvain wrote: On Mon, Mar 9, 2009 at 9:10 AM, Darin Fisher da...@chromium.org wrote: On Sun, Mar 8, 2009 at 4:58 PM, Adam Langley a...@chromium.org wrote: On Sun, Mar 8, 2009 at 4:54 PM,

[chromium-dev] Re: Incorrect files under \src\third_party\python_24?

2009-03-09 Thread Evan Martin
On Sun, Mar 8, 2009 at 11:05 PM, gutongsedeyo...@gmail.com gutongsedeyo...@gmail.com wrote: 1) I am trying to compile Chromium with hammer/scons on Windows, with the latest source, and I am getting the following error message: This doesn't solve the below problem, but I believe the SCons

[chromium-dev] Re: Changes to the waterfall.

2009-03-09 Thread Nicolas Sylvain
On Mon, Mar 9, 2009 at 9:39 AM, Darin Fisher da...@chromium.org wrote: On Mon, Mar 9, 2009 at 9:38 AM, t...@chromium.org wrote: On Mon, 9 Mar 2009, Nicolas Sylvain wrote: On Mon, Mar 9, 2009 at 9:10 AM, Darin Fisher da...@chromium.org wrote: On Sun, Mar 8, 2009 at 4:58 PM, Adam

[chromium-dev] How do I fix the cookie DB problem?

2009-03-09 Thread Shaila
When i compile the chrome with KJS. I got the runtime error like this. [3840:3856:23286500:FATAL:cookie_monster_sqlite.cc(275)]Check failed:false.Unable to initialize cookie DB. How can i fix the error?? Help me. --~--~-~--~~~---~--~~ Chromium

[chromium-dev] Thoughts on copy/paste

2009-03-09 Thread Avi Drissman
Working through crbug.com/8384 (copy/paste), I've had a chance to look at Chromium's current copy/paste system. For those unfamiliar, the copy/paste menu items are always enabled, and send a message to TabContents. WebContents implements those methods by forwarding them to RenderViewHost, which

[chromium-dev] Re: focusRingColor() listening to system settings changes on Windows?

2009-03-09 Thread Evan Martin
Filed http://code.google.com/p/chromium/issues/detail?id=8540 http://code.google.com/p/chromium/issues/detail?id=8540 so someone else can triage 'em. On Mon, Mar 9, 2009 at 9:40 AM, Darin Fisher da...@chromium.org wrote: Right... there is a big TBD to get someone to implement proper

[chromium-dev] Re: focusRingColor() listening to system settings changes on Windows?

2009-03-09 Thread Evan Martin
Er, http://code.google.com/p/chromium/issues/detail?id=8541 was the second. On Mon, Mar 9, 2009 at 9:54 AM, Evan Martin e...@chromium.org wrote: Filed  http://code.google.com/p/chromium/issues/detail?id=8540  http://code.google.com/p/chromium/issues/detail?id=8540 so someone else can

[chromium-dev] Re: Changes to the waterfall.

2009-03-09 Thread Evan Martin
On Mon, Mar 9, 2009 at 9:38 AM, t...@chromium.org wrote: We could. Compiling chrome on linux in debug seems important enough though. Is this shared object something that is used only on the bot? The Modules Linux (dbg) builder covers this case. I agree that this should be moved to the FYI

[chromium-dev] Re: focusRingColor() listening to system settings changes on Windows?

2009-03-09 Thread Jonas Klink (Google)
Not knowing the extent of the capabilities here, but could this also be leveraged to respect High Contrast settings on Windows...? We have several bugs open on this (http://code.google.com/p/chromium/issues/detail?id=583, http://code.google.com/p/chromium/issues/detail?id=92), and demand for

[chromium-dev] Re: Changes to the waterfall.

2009-03-09 Thread Nicolas Sylvain
On Mon, Mar 9, 2009 at 10:59 AM, Darin Fisher da...@chromium.org wrote: On Mon, Mar 9, 2009 at 9:45 AM, Nicolas Sylvain nsylv...@chromium.orgwrote: On Mon, Mar 9, 2009 at 9:39 AM, Darin Fisher da...@chromium.org wrote: On Mon, Mar 9, 2009 at 9:38 AM, t...@chromium.org wrote: On Mon, 9

[chromium-dev] Re: Thoughts on copy/paste

2009-03-09 Thread Ojan Vafai
On Mon, Mar 9, 2009 at 10:12 AM, Avi Drissman a...@google.com wrote: On Mon, Mar 9, 2009 at 12:02 PM, Evan Martin e...@chromium.org wrote: Maybe a better option is to have the renderer send FYI, cut/copy/paste state is now x/y/z messages up to the UI whenever it changes? (I guess paste is

[chromium-dev] Re: Thoughts on copy/paste

2009-03-09 Thread Avi Drissman
Oh, that's curious. Where does the context menu come from? And how does it know? Avi On Mon, Mar 9, 2009 at 2:04 PM, Adam Barth aba...@google.com wrote: Thanks. I always use our context menu, which seems to be smarter about disabling cut/copy/paste. Adam On Mon, Mar 9, 2009 at 12:00 PM,

[chromium-dev] Re: Changes to the waterfall.

2009-03-09 Thread Pam Greene
On Mon, Mar 9, 2009 at 8:56 AM, Erik Kay erik...@chromium.org wrote: (repost) On Mon, Mar 9, 2009 at 9:45 AM, Nicolas Sylvain nsylv...@chromium.org wrote: I think purify ui tests is just waiting for a new version of purify maybe? After that it should be easy enough to turn it green.

[chromium-dev] Re: Thoughts on copy/paste

2009-03-09 Thread Avi Drissman
I'll have to look at that; thanks. In the meanwhile I've come to the unpleasant discovery that ViewHostMsg_ClipboardIsFormatAvailable requires that Clipboard::FormatType be IPC serializable. Time to hack at the Clipboard class. Avi On Mon, Mar 9, 2009 at 3:29 PM, Adam Barth aba...@chromium.org

[chromium-dev] Re: Thoughts on copy/paste

2009-03-09 Thread tony
1) the user right clicks on the page 2) the browser sends an IPC to the renderer with the click event 3) the renderer realizes that a context menu should show and sends an IPC back to the browser with information about which menu items should be enabled. In theory, this is the same as

[chromium-dev] Re: Thoughts on copy/paste

2009-03-09 Thread Adam Barth
Forgive my ignorance of Mac APIs, but why does the mouse click - display menu need to be synchronous? (In a way similar to how the right-click - context menu is async now.) Adam On Mon, Mar 9, 2009 at 2:39 PM, Avi Drissman a...@google.com wrote: An async menu might be an option for

[chromium-dev] Re: Thoughts on copy/paste

2009-03-09 Thread Amanda Walker
Because we don't see the mouse click for the main menu bar the same way we do for a context menu. Normally, we just get called back after a menu item has been selected. It's possible to update state while the menu is down, but that brings in the possibility of flashing/etc. as the menu changes

[chromium-dev] Re: Thoughts on copy/paste

2009-03-09 Thread Avi Drissman
Right. That involves some magic on the renderer side, probably polling WebCore for state after operations known to change it. Currently, WebCore isn't really set up for sending copy/paste state changes. Avi On Mon, Mar 9, 2009 at 4:55 PM, Amanda Walker ama...@chromium.org wrote: Because we

[chromium-dev] Download Page, modifications?

2009-03-09 Thread Mohamed Mansour
Hello, I just found out today that the new downloads page has been rolled out, great job on that glen! I have some questions, some of the top suggestions from the users in Google Help forums are the following: 1. Clear All Downloads 2. Delete All Downloads 3. Delete a specific download