Re: [chromium-dev] How to compile Google Chrome with Visual C++ 2008 Express Edition

2009-11-22 Thread PhistucK
It is probably that. I have not tried yet, but I will this afternoon. It must have been an obvious thing to do, but I am not dealing with Visual Studio almost at all and I am totally new to this, so, thank you for pointing that out. :) ☆PhistucK On Sat, Nov 21, 2009 at 17:12, Dominic Jodoin

Re: [chromium-dev] How to compile Google Chrome with Visual C++ 2008 Express Edition

2009-11-22 Thread PhistucK
It keeps not working... :( 6Linking... 6libcpmt.lib(locale0.obj) : error LNK2005: public: static unsigned int const std::ctypechar::table_size (?table_s...@?$ctype@d...@std@@2IB) already defined in chrome_dll_main.obj 6libcpmt.lib(locale.obj) : error LNK2005: public: __thiscall

[chromium-dev] How can I remove .o objects in linux

2009-11-22 Thread hap 497
Hi, I follow this instruction in building chromium on linux. http://code.google.com/p/chromium/wiki/LinuxBuildInstructions Can you please tell me how can I remove all .o after the build? I tried 'make clean', but it said there is no 'clean' target'. Thank you. -- Chromium Developers mailing

Re: [chromium-dev] How can I remove .o objects in linux

2009-11-22 Thread Adam Langley
On Sun, Nov 22, 2009 at 1:23 PM, hap 497 hap...@gmail.com wrote: Can you please tell me how can I remove all .o after the build? I tried 'make clean', but it said there is no 'clean' target'. % find out -type f -name *.o | xargs rm AGL -- Chromium Developers mailing list:

Re: [chromium-dev] How can I remove .o objects in linux

2009-11-22 Thread Antoine Labour
On Sun, Nov 22, 2009 at 1:35 PM, Adam Langley a...@chromium.org wrote: On Sun, Nov 22, 2009 at 1:23 PM, hap 497 hap...@gmail.com wrote: Can you please tell me how can I remove all .o after the build? I tried 'make clean', but it said there is no 'clean' target'. % find out -type f -name

Re: [chromium-dev] How can I remove .o objects in linux

2009-11-22 Thread Evan Martin
On Sun, Nov 22, 2009 at 1:43 PM, Antoine Labour pi...@google.com wrote: On Sun, Nov 22, 2009 at 1:35 PM, Adam Langley a...@chromium.org wrote: On Sun, Nov 22, 2009 at 1:23 PM, hap 497 hap...@gmail.com wrote: Can you please tell me how can I remove all .o after the build? I tried 'make

[chromium-dev] Re: Singleton shenanigans in base/time_win.cc causing problems (not the first time)

2009-11-22 Thread cpu
I hear you. The issue is to me endemic of singleton/lazyinstance AtExit dtor - Singleton A Object dtor -- Singleton B ctor - AtExit registration - bang Basically the dtors of singletons do too much or the whole scheme stinks. -- Chromium Developers mailing list: chromium-dev@googlegroups.com

Re: [chromium-dev] Singleton shenanigans in base/time_win.cc causing problems (not the first time)

2009-11-22 Thread Mike Belshe
I think we should have a list of low-level functionality which we just never cleanup. For the items you listed, I think you should leak them all. Trying to cleanup these items creates complicated code and ultimately won't run any better and possibly slower. Mike On Fri, Nov 20, 2009 at 1:44

Re: [chromium-dev] Singleton shenanigans in base/time_win.cc causing problems (not the first time)

2009-11-22 Thread Peter Kasting
On Sun, Nov 22, 2009 at 4:28 PM, Mike Belshe mbel...@google.com wrote: I think we should have a list of low-level functionality which we just never cleanup. For the items you listed, I think you should leak them all. Trying to cleanup these items creates complicated code and ultimately

Re: [chromium-dev] Singleton shenanigans in base/time_win.cc causing problems (not the first time)

2009-11-22 Thread Marc-Antoine Ruel
It's really about the unit tests, not in chromium. I guess we could probably leak the singleton in the unit tests too on each reset. Pawel, what do you think? Note to all the static local makers: you create an implicit atexit() each time... Use a leaky singleton instead. M-A On Sun, Nov 22,

Re: [chromium-dev] Singleton shenanigans in base/time_win.cc causing problems (not the first time)

2009-11-22 Thread Darin Fisher
We could define a function that must be called before you can use code in base/. You could add a call to this everywhere that we currently create the AtExitManager. Or, maybe we could combine those somehow. I don't think lazy initialization of stuff like this is all that valuable. It is

[chromium-dev] workflow for cross-platform development

2009-11-22 Thread Chris Bentzel
How do most people do cross-platform validation prior to submitting code? Do you mostly rely on the try-bots, or do you also patch the diffs to your different dev environments and build and test locally? If you do the patching, do you tend to do a gcl upload and grab the diffs from there, or do

Re: [chromium-dev] workflow for cross-platform development

2009-11-22 Thread Dirk Pranke
On Sat, Nov 21, 2009 at 10:52 AM, Chris Bentzel cbent...@google.com wrote: How do most people do cross-platform validation prior to submitting code? Do you mostly rely on the try-bots, or do you also patch the diffs to your different dev environments and build and test locally? I build on the

Re: [chromium-dev] workflow for cross-platform development

2009-11-22 Thread Robert Sesek
On Sat, Nov 21, 2009 at 1:52 PM, Chris Bentzel cbent...@google.com wrote: Do you mostly rely on the try-bots, or do you also patch the diffs to your different dev environments and build and test locally? If you do the patching, do you tend to do a gcl upload and grab the diffs from there, or

Re: [chromium-dev] Singleton shenanigans in base/time_win.cc causing problems (not the first time)

2009-11-22 Thread Paweł Hajdan Jr .
On Mon, Nov 23, 2009 at 02:22, Marc-Antoine Ruel mar...@google.com wrote: It's really about the unit tests, not in chromium. I guess we could probably leak the singleton in the unit tests too on each reset. Pawel, what do you think? Note to all the static local makers: you create an

Re: [chromium-dev] workflow for cross-platform development

2009-11-22 Thread Paweł Hajdan Jr .
On Sat, Nov 21, 2009 at 19:52, Chris Bentzel cbent...@google.com wrote: Have there been any thoughts about adding gcl patch and unpatch commands which will grab the file diffs as well as duplicate the CL metadata in src/.svn/gcl_info? It's not trivial to correctly apply a patch in svn (file

[chromium-dev] Re: heads up: Rietveld reply by email isn't working

2009-11-22 Thread John Abd-El-Malek
Note: this should be working again now. We decided to put the issue numbers in the subject line like Mondrian (but at the end, as to not conflict with bug numbers which are put at the front of Python bug mail). On Thu, Nov 19, 2009 at 11:40 AM, John Abd-El-Malek j...@chromium.orgwrote: There

[chromium-dev] Link error when compiling chromium on ubuntu 9.10

2009-11-22 Thread hap 497
Hi, I am tying to compile chromium on ubuntu 9.10. I think the compilation went fine. I just get an error in linking. $ make -j5 chrome LINK(target) out/Debug/chrome collect2: ld terminated with signal 9 [Killed] make: *** [out/Debug/chrome] Error 1 $ make out/Debug/chrome LINK(target)