Re: [chromium-dev] UI Jank Task Force Status Update

2009-12-08 Thread Paweł Hajdan Jr .
On Tue, Dec 8, 2009 at 00:19, Mark Mentovai m...@chromium.org wrote: Is this thought to be http://crbug.com/29240, or are there other problems with the signal handler? The change to fix that is out at http://codereview.chromium.org/460094. I'm not sure. The failures are not deterministic.

[chromium-dev] WebKit Sheriff swap: 12/26-29 ?

2009-12-08 Thread 鵜飼文敏
I am currently scheduled to be on WebKit Sheriff duty 12/26 and 12/29, but will be on vacation from 12/21. Anyone able to swap? Thanks, ukai -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe:

[chromium-dev] Layout Tests Task Force syncup meeting notes 12/07/2009

2009-12-08 Thread Jeff Chang
Layout Tests Task Force syncup meeting December 7, 2009 progress update - we are doing really well - 348 failing tests infrastructure - keeps getting better - dpranke's dashboard (very useful): http://chromiumlttf.appspot.com - increased accuracy in counting now - finders

Re: [chromium-dev] Re: WorkerTest in the linux/valgrind tests are silently failing due to mmap failure

2009-12-08 Thread Stuart Morgan
On Mon, Dec 7, 2009 at 11:21 AM, oshima osh...@chromium.org wrote: Oh, by the way, i found that the same thing is happening on mac side as well, but I'm not familiar with mac. Can someone take care of mac side? The process for disabling tests under valgrind is identical on the Mac, so you

Re: [chromium-dev] Splitting off some pieces of chrome.gyp...

2009-12-08 Thread Bradley Nelson
I had talked about this with mmentovai and some others. Concern was raised about the complexity this would introduce into gyp. I do have a gut feeling we'll eventually go there. What Greg is currently doing at least works with gyp as it now stands, but it isn't pretty. Mark, does what's happened

Re: [chromium-dev] Splitting off some pieces of chrome.gyp...

2009-12-08 Thread Mark Mentovai
I think that the stripped-down NaCl-specific 64-bit targets are the right thing to have happened to base, at least for now. Mark Brad Nelson wrote: I had talked about this with mmentovai and some others. Concern was raised about the complexity this would introduce into gyp. I do have a gut

Re: [chromium-dev] Splitting off some pieces of chrome.gyp...

2009-12-08 Thread Bradley Nelson
You mean as 'base' currently is, or duplicating the file lists? -BradN On Tue, Dec 8, 2009 at 11:19 AM, Mark Mentovai m...@chromium.org wrote: I think that the stripped-down NaCl-specific 64-bit targets are the right thing to have happened to base, at least for now. Mark Brad Nelson

[chromium-dev] Tryconsole

2009-12-08 Thread Bradley Nelson
Hi All, I've got a prototype summary view of the trybots up at http://tryconsole.appspot.com/ This will let you monitor/find your try jobs without digging through the waterfall. The text prompt lets you search (username / builder / change name). The two summary graphs show load for the day, load

Re: [chromium-dev] Splitting off some pieces of chrome.gyp...

2009-12-08 Thread Mark Mentovai
Bradley Nelson wrote: You mean as 'base' currently is, or duplicating the file lists? I mean I have no problem with base_nacl_win64 existing as a target, and with adding files that are needed in that target to that target. Mark -- Chromium Developers mailing list:

Re: [chromium-dev] Splitting off some pieces of chrome.gyp...

2009-12-08 Thread Bradley Nelson
Even if those files are largely a duplicate of those in base? -BradN On Tue, Dec 8, 2009 at 11:22 AM, Mark Mentovai m...@chromium.org wrote: Bradley Nelson wrote: You mean as 'base' currently is, or duplicating the file lists? I mean I have no problem with base_nacl_win64 existing as a

Re: [chromium-dev] Symbolized backtrace on Linux chromium?

2009-12-08 Thread 王重傑
addr2line is another possible option. addr2line -e sconsbuild/Debug/chrome 0x87d9bc This works even if -fvisbility=hidden. I think w/o address space layout randomization, it's...relatively deterministic (I think). So, given that, maybe it would be sensible to find a way to add a small

[chromium-dev] Chromium Tech Talks

2009-12-08 Thread Jeremy Orlow
Last Friday we recorded 4 tech talks based on the feedback we got on what topics would be interestingand here they are! http://www.youtube.com/watch?v=JFzC_Gx76E8 Darin Fisher talks about the recently upstreamed Chromium WebKit API. http://www.youtube.com/watch?v=bO3XEBuIDns Pam Greene talks

[chromium-dev] Re: Chromium Tech Talks

2009-12-08 Thread Jeremy Orlow
On Tue, Dec 8, 2009 at 11:25 AM, Jeremy Orlow jor...@chromium.org wrote: Last Friday we recorded 4 tech talks based on the feedback we got on what topics would be interestingand here they are! http://www.youtube.com/watch?v=JFzC_Gx76E8 Darin Fisher talks about the recently upstreamed

Re: [chromium-dev] Splitting off some pieces of chrome.gyp...

2009-12-08 Thread Mark Mentovai
Bradley Nelson wrote: Even if those files are largely a duplicate of those in base? If it gets to that point, we can maintain the sources list, or the shared sources list, in a variable. Then we could do explicit additions to the targets that need it, or explicit excludes if that winds up

Re: [chromium-dev] Splitting off some pieces of chrome.gyp...

2009-12-08 Thread Bradley Nelson
Greg, will this work for you? -BradN On Tue, Dec 8, 2009 at 11:28 AM, Mark Mentovai m...@chromium.org wrote: Bradley Nelson wrote: Even if those files are largely a duplicate of those in base? If it gets to that point, we can maintain the sources list, or the shared sources list, in a

[chromium-dev] WebKit roll status

2009-12-08 Thread Michael Nordman
Hi all, Just a note to let you know what's up with webkit rolls (or lack thereof) right now. We're at r51794 and have been for a while. Tip-of-tree webkit is at r51868. * All manner of svg tests are borked from some reason around r 51800, senorblanco is on that. * A couple of build breaks

[chromium-dev] Modifying .gyp files

2009-12-08 Thread Igor Gatis
When I change a .gyp, do I need to call gyp or the build process does that for me? If it does, how does it detect the .gyp file has been modified? -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe:

Re: [chromium-dev] Modifying .gyp files

2009-12-08 Thread Mark Mentovai
Igor Gatis wrote: When I change a .gyp, do I need to call gyp or the build process does that for me? If it does, how does it detect the .gyp file has been modified? When you change it yourself, in your own working copy, you run gclient runhooks to get new files generated. When a .gyp change is

Re: [chromium-dev] Re: Chromium Tech Talks

2009-12-08 Thread Mohamed Mansour
Awesome, nice work everyone! On Tue, Dec 8, 2009 at 2:26 PM, Jeremy Orlow jor...@chromium.org wrote: On Tue, Dec 8, 2009 at 11:25 AM, Jeremy Orlow jor...@chromium.org wrote: Last Friday we recorded 4 tech talks based on the feedback we got on what topics would be interestingand here they

Re: [chromium-dev] Modifying .gyp files

2009-12-08 Thread Igor Gatis
Got it, thanks. BTW, it might be worth mentioning that somewhere, perhaps here: http://www.chromium.org/developers/quick-reference On Tue, Dec 8, 2009 at 6:27 PM, Mark Mentovai mmento...@google.com wrote: Igor Gatis wrote: When I change a .gyp, do I need to call gyp or the build process does

Re: [chromium-dev] WebKit roll status

2009-12-08 Thread Stephen White
For the curious, as of WebKit 51800, SVG Filters are enabled by default. In theory (since this code is cross-platform), this should just require us turning them on in Chrome, and rebaselining the affected tests (about 24 on Windows). In practice, however, some of the code behind #if

Re: [chromium-dev] WebKit roll status

2009-12-08 Thread Dimitri Glazkov
I wonder if we should investigate and determine the cause of Linux failures before rolling. :DG On Tue, Dec 8, 2009 at 12:43 PM, Stephen White senorbla...@chromium.org wrote: For the curious, as of WebKit 51800, SVG Filters are enabled by default.  In theory (since this code is

Re: [chromium-dev] Re: Chromium Tech Talks

2009-12-08 Thread Pierre-Antoine LaFayette
Thanks for doing this! 2009/12/8 Jeremy Orlow jor...@chromium.org On Tue, Dec 8, 2009 at 11:25 AM, Jeremy Orlow jor...@chromium.org wrote: Last Friday we recorded 4 tech talks based on the feedback we got on what topics would be interestingand here they are!

Re: [chromium-dev] WebKit roll status

2009-12-08 Thread Michael Nordman
yikes 481 failures on linux... k... holding off rolling until we get a handle on the nature of the linux borkage On Tue, Dec 8, 2009 at 12:45 PM, Dimitri Glazkov dglaz...@google.comwrote: I wonder if we should investigate and determine the cause of Linux failures before rolling. :DG On

Re: [chromium-dev] WebKit roll status

2009-12-08 Thread Adam Langley
On Tue, Dec 8, 2009 at 12:55 PM, Michael Nordman micha...@chromium.org wrote: yikes 481 failures on linux... k... holding off rolling until we get a handle on the nature of the linux borkage This is probably the result of Markus's first WebKit patch. It was LGTMed and he asked that it be landed

Re: [chromium-dev] Re: WorkerTest in the linux/valgrind tests are silently failing due to mmap failure

2009-12-08 Thread oshima
(re-sending from chromium account) On Tue, Dec 8, 2009 at 9:06 AM, Stuart Morgan stuartmor...@chromium.orgwrote: On Mon, Dec 7, 2009 at 11:21 AM, oshima osh...@chromium.org wrote: Oh, by the way, i found that the same thing is happening on mac side as well, but I'm not familiar with mac.

Re: [chromium-dev] Plugin Manager UI Proposal

2009-12-08 Thread Evan Martin
On Mon, Dec 7, 2009 at 11:11 AM, Panayiotis panayio...@google.com wrote: A plugin is identified by its path in the filesystem. Different paths are considered different plugins. Can you discuss symlinks? We have to do some weird hacks in this area -- see webkit/glue/plugins/plugin_list_linux.cc

Re: [chromium-dev] WebKit roll status

2009-12-08 Thread Michael Nordman
Ah... thank you for the ptr. On Tue, Dec 8, 2009 at 1:00 PM, Adam Langley a...@chromium.org wrote: On Tue, Dec 8, 2009 at 12:55 PM, Michael Nordman micha...@chromium.org wrote: yikes 481 failures on linux... k... holding off rolling until we get a handle on the nature of the linux borkage

Re: [chromium-dev] Re: WorkerTest in the linux/valgrind tests are silently failing due to mmap failure

2009-12-08 Thread Stuart Morgan
On Tue, Dec 8, 2009 at 1:05 PM, oshima osh...@chromium.org wrote: Ok, so mac is using the same script, correct? Yep, same script. I can make a changelist, but I need a way to test it on mac. Can you or someone else help me on this? Sure, although testing the script change on the Mac isn't

Re: [chromium-dev] Tryconsole

2009-12-08 Thread Evan Martin
On Tue, Dec 8, 2009 at 11:21 AM, Bradley Nelson bradnel...@google.com wrote: I've got a prototype summary view of the trybots up at http://tryconsole.appspot.com/ This will let you monitor/find your try jobs without digging through the waterfall. The text prompt lets you search (username /

Re: [chromium-dev] Tryconsole

2009-12-08 Thread Adam Langley
On Tue, Dec 8, 2009 at 11:21 AM, Bradley Nelson bradnel...@google.com wrote: I've got a prototype summary view of the trybots up at http://tryconsole.appspot.com/ The icons are great :) AGL -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email

Re: [chromium-dev] Modifying .gyp files

2009-12-08 Thread Evan Martin
On Tue, Dec 8, 2009 at 12:23 PM, Igor Gatis igorga...@gmail.com wrote: When I change a .gyp, do I need to call gyp or the build process does that for me? If it does, how does it detect the .gyp file has been modified? On Linux, when you run make it will rerun gyp on your behalf if any gyp files

Re: [chromium-dev] Tryconsole

2009-12-08 Thread Marc-Antoine Ruel
On Tue, Dec 8, 2009 at 4:13 PM, Evan Martin e...@chromium.org wrote: On Tue, Dec 8, 2009 at 11:21 AM, Bradley Nelson bradnel...@google.com wrote: I've got a prototype summary view of the trybots up at http://tryconsole.appspot.com/ This will let you monitor/find your try jobs without digging

Re: [chromium-dev] WebKit roll status

2009-12-08 Thread Markus Gutschke
Oh, yes, that wouldn't be surprising :-/ There now is a new WebKit API for setting the scrollbar colors in Linux, and theWebKit change doesn't set the colors. That's waiting for the second half of the changelist which is pending in http://codereview.chromium.org/400027 Even after that pending

Re: [chromium-dev] WebKit roll status

2009-12-08 Thread Dimitri Glazkov
 - fix the problem with the black scrollbars in testshell. This is easy. The WebKit change currently sets all colors to zero, unless somebody explicitly sets them to something else. We can pick different default values that will at least make the scrollbars visible. This would still require

Re: [chromium-dev] WebKit roll status

2009-12-08 Thread Michael Nordman
Yes, It sounds like in all cases, there's going to be a big rebaseline-them-all-on-linux step at some point, the sooner the better. Given the nature of the problem (scrollbar drawing differences), lets roll and deal with the rebaselining seperately. But that should be done soonish, in the interim

Re: [chromium-dev] WebKit roll status

2009-12-08 Thread Markus Gutschke
http://codereview.chromium.org/400027/diff2/27001:30003/30013 On Tue, Dec 8, 2009 at 13:30, Adam Langley a...@google.com wrote: On Tue, Dec 8, 2009 at 1:27 PM, Dimitri Glazkov dglaz...@chromium.org wrote: Let's go with this. You'll have a chance all about the great rebaselining tool in the

Re: [chromium-dev] Re: Chromium Tech Talks

2009-12-08 Thread Paweł Hajdan Jr .
Thanks so much! It's nice to learn some things about webkit. Some ideas for the next round of talks: - how sandboxing works on Linux and Mac - ChromeFrame internals (how it interacts with IE, ExternalTab magic etc) - performance tests - Valgrind and ThreadSanitizer - plugins in the multi-process

Re: [chromium-dev] Re: WorkerTest in the linux/valgrind tests are silently failing due to mmap failure

2009-12-08 Thread oshima
On Tue, Dec 8, 2009 at 1:08 PM, Stuart Morgan stuartmor...@chromium.orgwrote: On Tue, Dec 8, 2009 at 1:05 PM, oshima osh...@chromium.org wrote: Ok, so mac is using the same script, correct? Yep, same script. I can make a changelist, but I need a way to test it on mac. Can you or someone

Re: [chromium-dev] Tryconsole

2009-12-08 Thread Marc-Antoine Ruel
I hotpatched the server to fix the exception but without the build steps, it's still not very useful. I'll try to get the build steps this week in. Sample: http://build.chromium.org/buildbot/try-server/json/builders/linux/builds/10906?as_text=1 Remove the ?as_text=1 to receive it as

[chromium-dev] buildbot cycle time dashboard?

2009-12-08 Thread Dan Kegel
Hey folks, I seem to recall we have a dashboard somewhere showing the cycle time of each of our build/test bots, but I can't find it. Can somebody point me to it? If it doesn't exist, maybe I'll scrape one together. Thanks... -- Chromium Developers mailing list: chromium-dev@googlegroups.com

Re: [chromium-dev] buildbot cycle time dashboard?

2009-12-08 Thread Eric Seidel
http://build.chromium.org/buildbot/waterfall/stats On Tue, Dec 8, 2009 at 2:51 PM, Dan Kegel d...@kegel.com wrote: Hey folks, I seem to recall we have a dashboard somewhere showing the cycle time of each of our build/test bots, but I can't find it.  Can somebody point me to it? If it

Re: [chromium-dev] buildbot cycle time dashboard?

2009-12-08 Thread James Hawkins
Thanks for the link Eric! Can someone explain what the Percentage of failures graph is representing? Thanks, James Hawkins On Tue, Dec 8, 2009 at 2:56 PM, Eric Seidel esei...@chromium.org wrote: http://build.chromium.org/buildbot/waterfall/stats On Tue, Dec 8, 2009 at 2:51 PM, Dan Kegel

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Tony Chang
http://code.google.com/p/chromium/issues/detail?id=18949 On Tue, Dec 8, 2009 at 3:18 PM, Evan Stade est...@chromium.org wrote: With the addition of bookmark sync and form autofill, this tab is getting rather tall (see attachment, ignore the blank space above synchronize bookmarks, which is a

Re: [chromium-dev] Re: WorkerTest in the linux/valgrind tests are silently failing due to mmap failure

2009-12-08 Thread oshima
On Tue, Dec 8, 2009 at 1:54 PM, oshima osh...@chromium.org wrote: On Tue, Dec 8, 2009 at 1:08 PM, Stuart Morgan stuartmor...@chromium.orgwrote: On Tue, Dec 8, 2009 at 1:05 PM, oshima osh...@chromium.org wrote: Ok, so mac is using the same script, correct? Yep, same script. I can

[chromium-dev] Re: Visualizing painting

2009-12-08 Thread MAD
I would love to try this... Let me know if somebody else is on it, otherwise, I will give it a shot... BYE MAD On Dec 7, 11:36 pm, Darin Fisher da...@chromium.org wrote: On Mon, Dec 7, 2009 at 8:31 PM, Peter Kasting pkast...@google.com wrote: On Mon, Dec 7, 2009 at 8:15 PM, Darin Fisher

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Evan Stade
On Tue, Dec 8, 2009 at 3:22 PM, Tony Chang t...@chromium.org wrote: http://code.google.com/p/chromium/issues/detail?id=18949 Yes, I suppose this problem is not new, but it has gotten worse. Has recent progress been made on that bug? It has been Started for months, seemingly. Also, does Matt M

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Ben Goodger (Google)
My opinion remains the same. Note that the dialog box as presented seems to have some layout issues that cause it to be taller than needed (see formatting in the sync section at the top). However, I suggest having the dialog box move (scroll) on screen as you move your mouse to the screen edge.

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Evan Stade
On Tue, Dec 8, 2009 at 3:37 PM, Ben Goodger (Google) b...@chromium.orgwrote: My opinion remains the same. Note that the dialog box as presented seems to have some layout issues that cause it to be taller than needed (see formatting in the sync section at the top). so, despite that it is

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Ben Goodger (Google)
On Tue, Dec 8, 2009 at 3:45 PM, Evan Stade est...@chromium.org wrote: On Tue, Dec 8, 2009 at 3:37 PM, Ben Goodger (Google) b...@chromium.org wrote: My opinion remains the same. Note that the dialog box as presented seems to have some layout issues that cause it to be taller than needed (see

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Ian Fette
Putting on my individual contributor hat here, I have to say that Ben's solution would seem very non-intuitive to me. I'm not aware of any app that works that way, and I would probably think that the dialog was just cut off (as is currently the case on my netbook), and would not expect to be able

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Peter Kasting
On Tue, Dec 8, 2009 at 4:03 PM, Ian Fette i...@chromium.org wrote: Putting on my individual contributor hat here, I have to say that Ben's solution would seem very non-intuitive to me. I'm not aware of any app that works that way, and I would probably think that the dialog was just cut off

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Evan Stade
On Tue, Dec 8, 2009 at 4:07 PM, Peter Kasting pkast...@google.com wrote: On Tue, Dec 8, 2009 at 4:03 PM, Ian Fette i...@chromium.org wrote: Putting on my individual contributor hat here, I have to say that Ben's solution would seem very non-intuitive to me. I'm not aware of any app that

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Lei Zhang
On Tue, Dec 8, 2009 at 4:11 PM, Evan Stade est...@chromium.org wrote: proposals on which of these options (again, see original attachment) to rip out are welcome and within the scope of this thread. The vbox? holding the bookmark sync status boxes is too narrow. If it used all the horizontal

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Evan Stade
On Tue, Dec 8, 2009 at 4:18 PM, Peter Kasting pkast...@google.com wrote: On Tue, Dec 8, 2009 at 4:11 PM, Evan Stade est...@chromium.org wrote: proposals on which of these options (again, see original attachment) to rip out are welcome and within the scope of this thread. Off the top of my

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Ben Goodger (Google)
BTW I am being a curmudgeon here for two reasons: - I have a deep aesthetic opposition to scrollbars in dialog boxes. Yes, I know Under the Hood has one, but that panel is sort of exempt because it's a) a sewer, and b) it has a white background that makes it look like a scrolling list. To me, a

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Tony Chang
I agree that this dialog should be shorter, but I think we still need an overflow solution. I can always make the display smaller or make the fonts larger. Alternately, we should pick a target minimum font size+display height and say we don't support user configurations less than that (kind of

Re: [chromium-dev] Re: Is there any good tool on Linux to browser and cross reference chromium source code?

2009-12-08 Thread Evan Martin
I got through my mail backlog far enough to at least file a bug on this http://code.google.com/p/chromium/issues/detail?id=29230 so you can star that for updates. On Thu, Sep 17, 2009 at 9:42 AM, --v1c1ous-- v1c1ous...@gmail.com wrote: I use a Search engine too:

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Peter Kasting
On Tue, Dec 8, 2009 at 4:25 PM, Evan Stade est...@chromium.org wrote: On Tue, Dec 8, 2009 at 4:18 PM, Peter Kasting pkast...@google.com wrote: * We have crazy word wrapping. The bookmark sync text could fit on one line. Why does it wrap? etc. elsewhere yes, we can save two lines in

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Ben Goodger (Google)
BTW I think the Use Gtk Theme button should be replaced by a special theme that triggers this mode, much like the default theme we have in the theme gallery. This would make the selection of this mode vs. others feel more natural wrt the others. -Ben -- Chromium Developers mailing list:

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Peter Kasting
On Tue, Dec 8, 2009 at 4:55 PM, Ben Goodger (Google) b...@chromium.orgwrote: BTW I think the Use Gtk Theme button should be replaced by a special theme that triggers this mode, much like the default theme we have in the theme gallery. This would make the selection of this mode vs. others feel

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Evan Stade
On Tue, Dec 8, 2009 at 4:51 PM, Peter Kasting pkast...@google.com wrote: On Tue, Dec 8, 2009 at 4:25 PM, Evan Stade est...@chromium.org wrote: On Tue, Dec 8, 2009 at 4:18 PM, Peter Kasting pkast...@google.comwrote: * We have crazy word wrapping. The bookmark sync text could fit on one

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Tony Chang
I think the real long term goal here is to make the GTK+ theme fast and make it the default theme. Users can still add the blue classic theme via the themes page. On Tue, Dec 8, 2009 at 4:55 PM, Ben Goodger (Google) b...@chromium.orgwrote: BTW I think the Use Gtk Theme button should be

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Ben Goodger (Google)
I like this idea too. -Ben On Tue, Dec 8, 2009 at 5:00 PM, Tony Chang t...@chromium.org wrote: I think the real long term goal here is to make the GTK+ theme fast and make it the default theme.  Users can still add the blue classic theme via the themes page. On Tue, Dec 8, 2009 at 4:55 PM,

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Peter Kasting
On Tue, Dec 8, 2009 at 4:59 PM, Evan Stade est...@chromium.org wrote: this makes the assumption that there is some best setting for each WM, which is false. What's best for me on metacity is not what's best for you on metacity. Unfortunately, if you really believe that, then for one of us

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Ben Goodger (Google)
Oops, I'll clarify and say I like the idea of getting the frame tint from the OS and making that be the default. I think you will probably still want to have the special theme to trigger the the Gtk icon mode. -Ben On Tue, Dec 8, 2009 at 5:04 PM, Ben Goodger (Google) b...@chromium.org wrote: I

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Evan Stade
On Tue, Dec 8, 2009 at 5:12 PM, Peter Kasting pkast...@google.com wrote: On Tue, Dec 8, 2009 at 4:59 PM, Evan Stade est...@chromium.org wrote: this makes the assumption that there is some best setting for each WM, which is false. What's best for me on metacity is not what's best for you on

Re: [chromium-dev] Height of Personal Stuff tab in Options window

2009-12-08 Thread Tony Chang
On Tue, Dec 8, 2009 at 5:20 PM, Elliot Glaysher e...@google.com wrote: On Tue, Dec 8, 2009 at 5:00 PM, Tony Chang t...@chromium.org wrote: I think the real long term goal here is to make the GTK+ theme fast and make it the default theme. Users can still add the blue classic theme via the

[chromium-dev] buildbot failure in Chromium on Linux Builder (ChromiumOS), revision 34134

2009-12-08 Thread buildbot
Automatically closing tree for update on Linux Builder (ChromiumOS) http://build.chromium.org/buildbot/waterfall/builders/Linux%20Builder%20%28ChromiumOS%29/builds/1177 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Linux%20Builder%20%28ChromiumOS%29 --= Automatically closing

[chromium-dev] google-breakpad compile failed on arm ubuntu

2009-12-08 Thread Richard Zhao
I seems breakpad don't support arm, right? struct _libc_fpstate not defined. Thanks Richard -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev

Re: [chromium-dev] google-breakpad compile failed on arm ubuntu

2009-12-08 Thread Adam Langley
On Tue, Dec 8, 2009 at 7:42 PM, Richard Zhao linux...@gmail.com wrote: I seems breakpad don't support arm, right? struct _libc_fpstate not defined. I never wrote ARM support for breakpad and I don't think anyone else did either: so no. However, breakpad is only used in Chrome branded builds,

Re: [chromium-dev] google-breakpad compile failed on arm ubuntu

2009-12-08 Thread Richard Zhao
On Wed, Dec 9, 2009 at 12:02 PM, Adam Langley a...@chromium.org wrote: On Tue, Dec 8, 2009 at 7:42 PM, Richard Zhao linux...@gmail.com wrote: I seems breakpad don't support arm, right? struct _libc_fpstate not defined. I never wrote ARM support for breakpad and I don't think anyone else did

[chromium-dev] buildbot failure in Chromium on Chromium XP, revision 34143

2009-12-08 Thread buildbot
Automatically closing tree for compile on Chromium XP http://build.chromium.org/buildbot/waterfall/builders/Chromium%20XP/builds/9092 http://build.chromium.org/buildbot/waterfall/waterfall?builder=Chromium%20XP --= Automatically closing tree for compile on Chromium XP =-- Revision: 34140,