Re: Review Request: multiple ip address per vm nic changes for isolated and vpc networks changes.

2013-03-01 Thread Jayapal Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9396/ --- (Updated March 1, 2013, 10:08 a.m.) Review request for cloudstack. Changes

Re: Review Request: multiple ip address per vm nic changes for isolated and vpc networks changes.

2013-03-01 Thread Jayapal Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9396/ --- (Updated March 1, 2013, 11:04 a.m.) Review request for cloudstack. Changes

Re: Review Request: multiple ip address per vm nic changes for isolated and vpc networks changes.

2013-02-28 Thread Abhinandan Prateek
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9396/#review17228 --- Remove white spaces and spellcheck and then it is ready for

Re: Review Request: multiple ip address per vm nic changes for isolated and vpc networks changes.

2013-02-27 Thread Jayapal Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9396/ --- (Updated Feb. 28, 2013, 5:24 a.m.) Review request for cloudstack. Changes

Re: Review Request: multiple ip address per vm nic changes for isolated and vpc networks changes.

2013-02-26 Thread Jayapal Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9396/ --- (Updated Feb. 26, 2013, 4:47 p.m.) Review request for cloudstack. Changes

Re: Review Request: multiple ip address per vm nic changes for isolated and vpc networks changes.

2013-02-26 Thread Jayapal Reddy
On Feb. 25, 2013, 8:18 a.m., Murali Reddy wrote: api/src/com/cloud/network/NetworkService.java, line 166 https://reviews.apache.org/r/9396/diff/2/?file=259809#file259809line166 can you add a comment what each of the service interface does Removed listSecondaryIps, using listnics to

Re: Review Request: multiple ip address per vm nic changes for isolated and vpc networks changes.

2013-02-25 Thread Murali Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9396/#review17030 --- Also, ensure your code does not have tabs, properly indented, has no

Re: Review Request: multiple ip address per vm nic changes for isolated and vpc networks changes.

2013-02-19 Thread Jayapal Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9396/ --- (Updated Feb. 19, 2013, 4:19 p.m.) Review request for cloudstack. Changes

Re: Review Request: multiple ip address per vm nic changes for isolated and vpc networks changes.

2013-02-11 Thread Chip Childers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9396/#review16419 --- Agree with David. There are several new class files, many of which

Review Request: multiple ip address per vm nic changes for isolated and vpc networks changes.

2013-02-10 Thread Jayapal Reddy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9396/ --- Review request for cloudstack. Description --- Using this feature we can

Re: Review Request: multiple ip address per vm nic changes for isolated and vpc networks changes.

2013-02-10 Thread David Nalley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9396/#review16397 --- I don't see any tests, and there are a number of new classes