Re: [CMake] Function for visibility definitions

2010-02-11 Thread Bill Hoffman
Hilton Medeiros wrote: Wow, now you got me. That is why I love discussions. Thanks for your insight, now I (my hard-as-rock head) can understand why this is not feasible. As a side note I think this should be in a list, maybe in the wiki, to advise others no to do this. A list of 'do not even

Re: [CMake] Function for visibility definitions

2010-02-11 Thread Hendrik Sattler
Zitat von Bill Hoffman bill.hoff...@kitware.com: That said, you could have CMake configure a .h file that had this stuff in it. It might be nice if the function did that automatically, as it is almost the same code for every project. Then once your project was built with CMake, you would

Re: [CMake] Function for visibility definitions

2010-02-11 Thread Michael Wild
On 11. Feb, 2010, at 15:40 , Hendrik Sattler wrote: Zitat von Bill Hoffman bill.hoff...@kitware.com: That said, you could have CMake configure a .h file that had this stuff in it. It might be nice if the function did that automatically, as it is almost the same code for every project. Then

Re: [CMake] Function for visibility definitions

2010-02-11 Thread Hendrik Sattler
Zitat von Michael Wild them...@gmail.com: On 11. Feb, 2010, at 15:40 , Hendrik Sattler wrote: Zitat von Bill Hoffman bill.hoff...@kitware.com: That said, you could have CMake configure a .h file that had this stuff in it. It might be nice if the function did that automatically, as it is

Re: [CMake] Function for visibility definitions

2010-02-11 Thread Clinton Stimpson
On 02/11/2010 07:40 AM, Hendrik Sattler wrote: Zitat von Bill Hoffman bill.hoff...@kitware.com: That said, you could have CMake configure a .h file that had this stuff in it. It might be nice if the function did that automatically, as it is almost the same code for every project. Then once

Re: [CMake] Function for visibility definitions

2010-02-11 Thread Andreas Pakulat
On 11.02.10 16:09:34, Hendrik Sattler wrote: Zitat von Michael Wild them...@gmail.com: On 11. Feb, 2010, at 15:40 , Hendrik Sattler wrote: Zitat von Bill Hoffman bill.hoff...@kitware.com: That said, you could have CMake configure a .h file that had this stuff in it. It might be nice if

Re: [CMake] Function for visibility definitions

2010-02-11 Thread Hendrik Sattler
Zitat von Clinton Stimpson clin...@elemtech.com: If your library is only ever built as shared, sure, you don't cmake to generate code. Otherwise, the code needs that bit of information from the build system. I'd rather have a configured header file with that info in it. cmake already does that

[CMake] Function for visibility definitions

2010-02-10 Thread Hilton Medeiros
Hello, I made a simple cmake module that defines a function to create the visibility definitions discussed in an earlier post about DEFINE_SYMBOL that some users (including me) get confused over. In case someone come here looking for it, I pushed it here:

Re: [CMake] Function for visibility definitions

2010-02-10 Thread Hendrik Sattler
Am Mittwoch 10 Februar 2010 19:46:57 schrieb Hilton Medeiros: macro (check_gcc_visibility) include (CheckCXXCompilerFlag) check_cxx_compiler_flag(-fvisibility=hidden GCC_SUPPORTS_VISIBILITY) endmacro() This macro does not check if gcc supports visibility but g++ instead. function

Re: [CMake] Function for visibility definitions

2010-02-10 Thread Christian Ehrlicher
Hilton Medeiros schrieb: Thanks for pointing that mistake, I fixed it. About g++: g++ is gcc with -lstdc++ What is wrong with a simple CMake file? I know what is good about it, if CMake had it built in neither me nor any CMake user would need to write neither a simple header file nor a

Re: [CMake] Function for visibility definitions

2010-02-10 Thread Hilton Medeiros
Hello Christian, thanks for the interest, let me explain: ## In your CMake file you could to do this: ... include (VisibilityDefinitions) add_visibility_definitions(PREFIX PROJECT) ... ## // In your project source, this: ... class PROJECT_EXPORTS ExampleClass {...}; ... // It is really simple,

Re: [CMake] Function for visibility definitions

2010-02-10 Thread Hilton Medeiros
Wow, now you got me. That is why I love discussions. Thanks for your insight, now I (my hard-as-rock head) can understand why this is not feasible. As a side note I think this should be in a list, maybe in the wiki, to advise others no to do this. A list of 'do not even think about this'. I'm