Re: [cmake-developers] [PATCH] Tests: Use a less strict regular expression to look for "SONAME".

On 09/01/2015 09:30 AM, Raphael Kubo da Costa wrote: > That's because that script is asserting that the regular expression does > _not_ match, which is always the case when GNU binutils is not used. Prior to the refactoring it also tested for existence. See below. How did that pass before?

Re: [cmake-developers] [PATCH] Tests: Use a less strict regular expression to look for "SONAME".

Brad King writes: > On 09/01/2015 09:30 AM, Raphael Kubo da Costa wrote: >> That's because that script is asserting that the regular expression does >> _not_ match, which is always the case when GNU binutils is not used. > > Prior to the refactoring it also tested for

Re: [cmake-developers] [PATCH] Tests: Use a less strict regular expression to look for "SONAME".

Brad King writes: > The same regex appears in > > Tests/Plugin/check_mod_soname.cmake > > and has for years. I think that one should be updated too, but I > wonder why this problem has not been revealed in that test before. That's because that script is asserting that

Re: [cmake-developers] [PATCH] Tests: Use a less strict regular expression to look for "SONAME".

On 09/01/2015 10:13 AM, Raphael Kubo da Costa wrote: > Interesting. I think it has always been "broken". > > From a FreeBSD perspective (now that I'm getting its nightly test > results back on track), what happened is that all FreeBSD releases so > far use GNU binutils by default, and the switch

[cmake-developers] [PATCH] Tests: Use a less strict regular expression to look for "SONAME".

Commit 899458ab ("Tests: Cover NO_SONAME property for SHARED libraries") introduced a few new ExportImport tests, and the check_lib_{no}soname.cmake scripts that parse readelf(1)'s output. Make the regular expression matching the SONAME line output by readelf less strict, as the output format