Re: [cmake-developers] Deprecating qt4_use_modules and qt4_automoc?

2013-07-12 Thread Stephen Kelly
clin...@elemtech.com wrote: What is the motivation for deprecating these? Can we just let them fade away on their own as the world moves from Qt4 to Qt5? This is entirely orthogonal to Qt 5. qt4_use_modules is new, but provides no benefit over tll(). We shouldn't encourage adoption of it

Re: [cmake-developers] Deprecating qt4_use_modules and qt4_automoc?

2013-07-11 Thread clinton
- Original Message - Stephen Kelly steveire@... writes: We could also probably add a runtime warning if enabled. You need to enable deprecation warnings with your compiler, so it would make sense to have to enable them with a cmake script too. CMAKE_ENABLE_DEPRECATION_WARNINGS

Re: [cmake-developers] Deprecating qt4_use_modules and qt4_automoc?

2013-07-10 Thread Stephen Kelly
Stephen Kelly steveire@... writes: We could also probably add a runtime warning if enabled. You need to enable deprecation warnings with your compiler, so it would make sense to have to enable them with a cmake script too. CMAKE_ENABLE_DEPRECATION_WARNINGS could be used to determine whether

Re: [cmake-developers] Deprecating qt4_use_modules and qt4_automoc?

2013-02-15 Thread Stephen Kelly
Marcus D. Hanwell wrote: But if you are advising just updating docs, then go for it. I entirely echo Dave's words here - I thought you meant more of an active warning against using it at runtime/producing errors. Well, actually I did mean runtime warnings. The documentation changes

Re: [cmake-developers] Deprecating qt4_use_modules and qt4_automoc?

2013-02-14 Thread Marcus D. Hanwell
On Wed, Feb 6, 2013 at 8:21 AM, David Cole dlrd...@aol.com wrote: -Original Message- From: Stephen Kelly steve...@gmail.com To: cmake-developers cmake-developers@cmake.org Sent: Wed, Feb 6, 2013 8:17 am Subject: Re: [cmake-developers] Deprecating qt4_use_modules and qt4_automoc

[cmake-developers] Deprecating qt4_use_modules and qt4_automoc?

2013-02-06 Thread Stephen Kelly
Hi there, The qt4_use_modules is now mostly obsoleted by tll in CMake 2.8.11. The main difference is that qt4_use_modules does not require the use of imported targets. I think we should deprecate it in favor of using tll() with imported targets (using the imported targets is independent of

Re: [cmake-developers] Deprecating qt4_use_modules and qt4_automoc?

2013-02-06 Thread Marcus D. Hanwell
On Wed, Feb 6, 2013 at 5:46 AM, Stephen Kelly steve...@gmail.com wrote: Hi there, The qt4_use_modules is now mostly obsoleted by tll in CMake 2.8.11. The main difference is that qt4_use_modules does not require the use of imported targets. I think we should deprecate it in favor of using

Re: [cmake-developers] Deprecating qt4_use_modules and qt4_automoc?

2013-02-06 Thread David Cole
-Original Message- From: Marcus D. Hanwell marcus.hanw...@kitware.com To: Stephen Kelly steve...@gmail.com Cc: cmake-developers cmake-developers@cmake.org Sent: Wed, Feb 6, 2013 7:55 am Subject: Re: [cmake-developers] Deprecating qt4_use_modules and qt4_automoc? On Wed, Feb 6

Re: [cmake-developers] Deprecating qt4_use_modules and qt4_automoc?

2013-02-06 Thread Stephen Kelly
David Cole wrote: I agree with Marcus. There's no reason to deprecate these (other than deprecating Qt4 entirely, but not yet) unless there's a significant code clarity advantage. I think in the case of the qt4_automoc macro at least, there's some technical issue with changes in

Re: [cmake-developers] Deprecating qt4_use_modules and qt4_automoc?

2013-02-06 Thread David Cole
-Original Message- From: Stephen Kelly steve...@gmail.com To: cmake-developers cmake-developers@cmake.org Sent: Wed, Feb 6, 2013 8:17 am Subject: Re: [cmake-developers] Deprecating qt4_use_modules and qt4_automoc? David Cole wrote: I agree with Marcus. There's no reason to deprecate