Re: [concordance-devel] libconcord Learn IR Updates

2008-06-23 Thread Andreas Schulz
OK, I plead guilty of lazyness and sloppy design in a few cases.. On Saturday 21 June 2008, Phil Dibowitz wrote: I have a request for future submissions of patches that have multiple parts (i.e. patchsets). I'd like to follow the general LKML standard here for this... A valid point - I will

Re: [concordance-devel] libIRremotes (Re: Patches for major update of IR code learning)

2008-06-23 Thread Phil Dibowitz
Andreas Schulz wrote: Accepted (and almost completed). Just not quite sure if this will also work with the python bindings. In addition, a single-shot application like concordance will IMHO not actually suffer too much from a small memory leak. I've seen other applictaions at work, running

Re: [concordance-devel] libconcord new full patch ( Re: Next try for the big IR learning patch ..)

2008-06-23 Thread Andreas Schulz
(I re-added some cuts by Phil to answer both posts in one) On Sunday 22 June 2008, Phil Dibowitz wrote: On Sunday 22 June 2008, Stephen Warren wrote: A pulse is usually a low-high-low transition, whereas these docs talk about pulses and spaces. There should be differentiation between

Re: [concordance-devel] libconcord new full patch (Re: Next try for the big IR learning patch..)

2008-06-23 Thread Phil Dibowitz
Andreas Schulz wrote: In the documentation for get_key_name, it may be worth mentioning that valid index values start at 1 anything wrong with index starting at 1 for '1'st entry? All arrays have their 1st entry at 0. That's how CS works. :) I would say, start at 0. I currently don't see

Re: [concordance-devel] libconcord new full patch (Re: Next try for the big IR learning patch..)

2008-06-23 Thread Stephen Warren
On Mon, June 23, 2008 3:11 pm, Andreas Schulz wrote: On Sunday 22 June 2008, Stephen Warren wrote: In the documentation for get_key_name, it may be worth mentioning that valid index values start at 1 anything wrong with index starting at 1 for '1'st entry? Probably not, but it's sufficiently

Re: [concordance-devel] libconcord new full patch (Re: Next try for the big IR learning patch..)

2008-06-23 Thread Stephen Warren
On Mon, June 23, 2008 3:28 pm, Phil Dibowitz wrote: Andreas Schulz wrote: Well, concordance could do that as well, so what about: char **get_keynames(uint8_t *data, uint32_t size); void destroy_keynames(char **names); and be done with the XML data in one call? I don't think we need the