Re: [concordance-devel] Patch: Add size parameters to *all* APIs

2008-03-29 Thread Phil Dibowitz
Stephen Warren wrote: Phil Dibowitz wrote: One comment on ** vs *. The code tends to use * in any non-public API, and ** only for public functions since C requires that. You converted various private APIs to **, and I prefer to leave them * to be consistent with the entire rest of the

Re: [concordance-devel] Patch: Add size parameters to *all* APIs

2008-03-29 Thread Stephen Warren
Phil Dibowitz wrote: Stephen Warren wrote: Phil Dibowitz wrote: One comment on ** vs *. The code tends to use * in any non-public API, and ** only for public functions since C requires that. You converted various private APIs to **, and I prefer to leave them * to be consistent with the

Re: [concordance-devel] Patch: Add size parameters to *all* APIs

2008-03-29 Thread Phil Dibowitz
Stephen Warren wrote: Phil Dibowitz wrote: Stephen Warren wrote: Phil Dibowitz wrote: One comment on ** vs *. The code tends to use * in any non-public API, and ** only for public functions since C requires that. You converted various private APIs to **, and I prefer to leave them * to be