Re: CONTINUUM-310 - customizable email templates

2007-10-02 Thread Rahul Thakur
I think this might be a good feature to have in continuum. Users can be allowed to create their own notification templates that can be stored in DB for a given build. In case of no email template, we use the default. Thoughts? Cheers, Rahul Tomislav Stojcevich wrote: This was marked

Re: CONTINUUM-310 - customizable email templates

2007-10-02 Thread Emmanuel Venisse
I think the best way would be to allow the user to chosse his own template, if a template isn't define, continuum will choose the default. About the issue, I closed it because the mail is customizable (subject, print or not the build output...) but if we can allow new templates, we'll can

Re: CONTINUUM-310 - customizable email templates

2007-10-02 Thread Tomislav Stojcevich
I think it should be re-opened since there still is no way to completely customize the template itself other than turning on and off the output and summary. In my case the turning on the summary wiith the build output turned off will give me what I want but it is still too much. I'd like to be

Re: CONTINUUM-310 - customizable email templates

2007-10-02 Thread Emmanuel Venisse
Tomislav Stojcevich a écrit : I think it should be re-opened since there still is no way to completely customize the template itself other than turning on and off the output and summary. In my case the turning on the summary wiith the build output turned off will give me what I want but it is

Re: CONTINUUM-310 - customizable email templates

2007-10-02 Thread Wendy Smoak
On 10/1/07, Tomislav Stojcevich [EMAIL PROTECTED] wrote: What does everybody think about adding a step to the continuum-webapp project that extracts the templates from the continuum-core.jar and puts a copy of them in the WEB-INF/classes directory. When the mail notifier loads the templates

Re: CONTINUUM-310 - customizable email templates

2007-10-02 Thread Rahul Thakur
I agree with Emmanuel; extracting templates from core jar is not a solution. So far from this thread it seems there are quite a few things we could do for the email template customization feature. IMO, We need to brainstorm what might make best sense. Do we allow custom email templates for:

Re: CONTINUUM-310 - customizable email templates

2007-10-02 Thread Jesse McConnell
I rather like the configuration of pebble where some of the configuration is just putting in classnames and the same could easily be done with the vm template resource location, source from some configuration and then if resource isn't found just use the default like emm was saying... jesse On

Re: CONTINUUM-310 - customizable email templates

2007-10-02 Thread Rahul Thakur
Wendy Smoak wrote: On 10/1/07, Tomislav Stojcevich [EMAIL PROTECTED] wrote: What does everybody think about adding a step to the continuum-webapp project that extracts the templates from the continuum-core.jar and puts a copy of them in the WEB-INF/classes directory. When the mail notifier

Re: CONTINUUM-310 - customizable email templates

2007-10-02 Thread Emmanuel Venisse
Wendy, All continuum conf will be externalized in 1.2 Emmanuel Wendy Smoak a écrit : On 10/1/07, Tomislav Stojcevich [EMAIL PROTECTED] wrote: What does everybody think about adding a step to the continuum-webapp project that extracts the templates from the continuum-core.jar and puts a copy

Re: CONTINUUM-310 - customizable email templates

2007-10-02 Thread Rahul Thakur
I haven't seen pebble config... I was thinking what if you move database between Continuum installs? Since your template resides outside the db, it won't be portable. Jesse McConnell wrote: I rather like the configuration of pebble where some of the configuration is just putting in

Re: CONTINUUM-310 - customizable email templates

2007-10-02 Thread Emmanuel Venisse
We can't move all in the db because schema updates can be a pain. In 1.2 all the conf, actually written in application.xml, will be move to an external file. This file will can be stored in ${user.home} so each installs will can use it like it is done in archiva-configuration. Emmanuel Rahul

Re: CONTINUUM-310 - customizable email templates

2007-10-02 Thread Tomislav Stojcevich
On 10/2/07, Rahul Thakur [EMAIL PROTECTED] wrote: I agree with Emmanuel; extracting templates from core jar is not a solution. yes, i do too but it was just a quick and dirty way to provide the functionality without any major coding, I guess those users that want it could still manually extract

Re: CONTINUUM-310 - customizable email templates

2007-10-02 Thread Wendy Smoak
On 10/2/07, Emmanuel Venisse [EMAIL PROTECTED] wrote: We can't move all in the db because schema updates can be a pain. In 1.2 all the conf, actually written in application.xml, will be move to an external file. This file will can be stored in ${user.home} so each installs will can use it

Re: CONTINUUM-310 - customizable email templates

2007-10-02 Thread Emmanuel Venisse
Wendy Smoak a écrit : On 10/2/07, Emmanuel Venisse [EMAIL PROTECTED] wrote: We can't move all in the db because schema updates can be a pain. In 1.2 all the conf, actually written in application.xml, will be move to an external file. This file will can be stored in ${user.home} so each

Re: CONTINUUM-310 - customizable email templates

2007-10-02 Thread olivier lamy
Hi, File in ${user.home} can cause trouble if you have two continuum instances started with the same user/id and if you need different configurations between instances. But we can think about something which merge between $CONTINUUM_HOME/conf and ${user.home) (I think plexus-registry can do this

Re: CONTINUUM-310 - customizable email templates

2007-10-02 Thread Tomislav Stojcevich
Can you write up a page on the wiki explaining where things are and how to do this? http://docs.codehaus.org/display/CONTINUUMUSER/Home I would if it actually worked. I just tried putting the templates in the WEB-INF/classes (using the same fully qualified path that they have in the

Re: CONTINUUM-310 - customizable email templates

2007-10-02 Thread olivier lamy
Are you using plexus-runtime or tomcat ? If it works with tomcat (adding the template in WEB-INF/classes/${templatepath}). It looks a classLoader issue with plexus-jetty because WEB-INF/classes must wins against WEB-INF/lib. -- Olivier 2007/10/2, Tomislav Stojcevich [EMAIL PROTECTED]: Can

Re: CONTINUUM-310 - customizable email templates

2007-10-02 Thread Tomislav Stojcevich
On 10/2/07, olivier lamy [EMAIL PROTECTED] wrote: Are you using plexus-runtime or tomcat ? If it works with tomcat (adding the template in WEB-INF/classes/${templatepath}). It looks a classLoader issue with plexus-jetty because WEB-INF/classes must wins against WEB-INF/lib. using plexus