Re: Code review: 7012540 (java.util.Objects.nonNull() incorrectly named)

2011-01-27 Thread Stephen Colebourne
As I said before, removing this method is the best option now. Get it right in v8. Stephen On 27 January 2011 05:05, mark.reinh...@oracle.com wrote: Executive summary: requireNonNull is the preferred name. Date: Tue, 25 Jan 2011 18:33:47 -0500 From: brian.go...@oracle.com

Re: Code review: 7012540 (java.util.Objects.nonNull() incorrectly named)

2011-01-27 Thread Rémi Forax
On 01/27/2011 09:38 AM, Stephen Colebourne wrote: As I said before, removing this method is the best option now. Get it right in v8. Stephen I think we can't. This method is already used at many place in the JDK. About the name, I propose: iUsedToUseGetClassHereButNodobyWasAbleToUnderstand()

Re: 6407460: provide Collections helper methods for new interfaces in JDK 1.6

2011-01-27 Thread Rémi Forax
Hi David, On 01/27/2011 06:27 PM, Brian Goetz wrote: Overall these look like good additions. I haven't reviewed the code in detail but a quick sanity check suggests that this is a good direction. There's definitely some more work needed on the testing (for example, testing that the contents

Re: Code review: 7012540 (java.util.Objects.nonNull() incorrectly named)

2011-01-27 Thread David Holmes
Rémi Forax said the following on 01/27/11 18:43: On 01/27/2011 09:38 AM, Stephen Colebourne wrote: As I said before, removing this method is the best option now. Get it right in v8. Stephen I think we can't. This method is already used at many place in the JDK. I think we can. Those usages

Re: BufferedWriter.write does not throw exception if it is already closed.

2011-01-27 Thread Jing LV
于 2011-1-26 0:19, Alan Bateman 写道: Jing LV wrote: Hello, I find a problem in java.io.BufferedWriter. It is stated in the java spec of its close() method: ... Once the stream has been closed, further write() or flush() invocations will cause an IOException to be thrown. However if a

Re: 6407460: provide Collections helper methods for new interfaces in JDK 1.6

2011-01-27 Thread David Schlosnagle
Thanks for the feedback Brian and Rémi. I'm assuming this would go into JDK 8 at the earliest, so there seems to be some time to build out the test cases and other related missing methods. Are JUnit tests acceptable (I see only a couple in jdk/test/java/dyn/) or would you prefer the standalone