Looks fine Joel; thanks,
-Joe
On 10/21/2013 04:12 AM, Joel Borggrén-Franck wrote:
Hi All,
http://cr.openjdk.java.net/~jfranck/8009411/webrev.03/
New webrev including the test originally contributed by Peter (I noticed the
commit doesn't include Peter in contributed by, I have fixed that in
Changeset: f003f09144ff
Author:jfranck
Date: 2013-10-22 10:08 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/f003f09144ff
8026857: AnnoConstruct.getAnnotationsByType does not search supertype for
inherited annotations if @SomeContainer({}) is present
Summary: An empty
On 22/10/2013 01:39, Stuart Marks wrote:
Looks fine, except one tiny issue.
In javax/rmi/CORBA/Stub.java, createDelegate() returns Object, and in
the static initializer it's cast to Object before being assigned to
Object stubDelegateInstance. It's sort-of in parallel with the other
cases
Changeset: 04ba97b7c2f9
Author:jfranck
Date: 2013-10-22 10:34 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/04ba97b7c2f9
8009411: (reflect) Class.getMethods should not include static methods from
interfaces
Summary: Update getMethods() and getMethod() to filter out
On 21/10/2013 20:50, Pisarev, Vitaliy wrote:
I appreciate the quick response.
I looked at the code of PassThroughFileSystem, and I must say it underlines my
point here. In case someone wants to interpose on the default provider, he has
to write all this boiler plate code.
And unless they are
Changeset: bb2fb6be8b2a
Author:ykantser
Date: 2013-10-22 10:57 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/bb2fb6be8b2a
8026962: Put java/lang/management/ClassLoadingMXBean/LoadCounts.java into
ProblemList.txt
Reviewed-by: sla, jbachorik
! test/ProblemList.txt
Hi Andreas,
A few nits:
Class.java:
import java.util.Collection;
+import java.util.Collections;
import java.util.HashSet;
unused import.
AnnotationSupport.java:
+/**
+ * Equivalent to calling {@code getDirectlyAndIndirectlyPresentAnnotations(
+ * annotations, annoClass,
On Tue 22 Oct 2013 12:21:36 PM CEST, Joel Borggrén-Franck wrote:
Hi Andreas,
A few nits:
Class.java:
import java.util.Collection;
+import java.util.Collections;
import java.util.HashSet;
unused import.
Right. Thanks.
AnnotationSupport.java:
+/**
+ * Equivalent to calling
Changeset: b07856d0de34
Author:alundblad
Date: 2013-10-22 12:35 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/b07856d0de34
8004912: Repeating annotations - getAnnotationsByType(ClassT) is not working
as expected for few inheritance scenarios
8019420: Repeatable
Changeset: 52ad44f9a3ec
Author:alanb
Date: 2013-10-22 11:40 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/corba/rev/52ad44f9a3ec
8021257: com.sun.corba.se.** should be on restricted package list
Reviewed-by: chegar, coffeys, smarks
Contributed-by: alan.bate...@oralce.com,
Hi, I would just like to ask for a pointer to some specification
document that describes inheritance of repeating annotations. I couldn't
find one on the net.
I have a feeling there's something wrong with the logic of
AnnotationsSuport.getAssociatedAnnotations. Why? Because it is based on
Hi Peter,
Spec is here: http://cr.openjdk.java.net/~abuckley/8misc.pdf
FYI I pushed this before I saw your mail but I do think the code is correct. An
extra pair of eyes would be great though!
FWIW I suspect we can be better with regards to allocation especially if we
optimize for the common
Changeset: f15ad52cffed
Author:alanb
Date: 2013-10-22 12:04 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/f15ad52cffed
8024833: (fc) FileChannel.map does not handle async close/interrupt correctly
Reviewed-by: alanb
Contributed-by: chris.w.den...@gmail.com
!
Hi,
Can I have a review for 8026772 [1] fix.
The webrev link: [2]
The timezone test is failed because of the changed TimeZone names
introduced in 8025255 [3].
This timezone names were changed according to updated translation
resource files introduced by 8025215 [4].
The fix changes the
Changeset: 6f9515a9519f
Author:alanb
Date: 2013-10-22 11:43 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6f9515a9519f
8021257: com.sun.corba.se.** should be on restricted package list
Reviewed-by: chegar, coffeys, smarks, mullan
Contributed-by: alan.bate...@oralce.com,
On 22/10/2013 03:07, Stuart Marks wrote:
Hi all,
Please review this small spec change to deprecate some obsolete RMI
APIs, along with a bit of associated cleanup. There are no functional
changes in this changeset.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8026427
Webrev:
Hi,
The spec says:
When the new get[Declared]AnnotationsByType(ClassT) methods are
called for a repeatable annotation type T, the question is how to extend
the policy
to handle multiple annotations of type T on the superclass and/or
subclass. Oracle
proposes the following policy for Java SE
Hi Stuart,
This looks good to me.
RMISecurityManager:
I see that there are a few places in the JDK where we still
instantiate an RMISecurityManager.
I assume we must unfortunately keep them for backward compatibility,
in case some application code would try to downcast
Changeset: 963c57175e40
Author:vromero
Date: 2013-10-22 13:54 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/963c57175e40
8025290: javac implicit versus explicit lambda compilation error
Reviewed-by: jjg, dlsmith
! src/share/classes/com/sun/tools/javac/comp/Attr.java
Changeset: 7cafbb397683
Author:chegar
Date: 2013-10-22 14:00 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/7cafbb397683
8017779: java/net/Authenticator/B4769350.java fails
Reviewed-by: chegar
Contributed-by: Tristan Yan tristan@oracle.com, Kurchi Subhra Hazra
Changeset: 5f4aecd73caa
Author:mullan
Date: 2013-10-22 08:03 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/5f4aecd73caa
8021191: Add isAuthorized check to limited doPrivileged methods
Reviewed-by: weijun, xuelei
! src/share/classes/java/security/AccessControlContext.java
!
I think the problem could be solved in two ways:
- by explicitly scanning the inheritance chain for the 1st class that
has the annotations of type T present directly or indirectly (by
containment).
- by canonicalizing the representation of the repeating annotations in
the class file
Thanks for the reviews.
Mikael
On 2013-10-18 13:09, Peter Allwin wrote:
+1
Thanks,
/peter
On Oct 18, 2013, at 12:56 PM, Staffan Larsen staffan.lar...@oracle.com wrote:
Looks good!
Thanks,
/Staffan
On 16 okt 2013, at 14:04, Mikael Auno mikael.a...@oracle.com wrote:
This bug got a bit
Changeset: 54869853c06c
Author:alanb
Date: 2013-10-22 14:13 +0100
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/54869853c06c
7074436: (sc) SocketChannel can do short gathering writes when channel
configured blocking (win)
Reviewed-by: chegar
!
+1
Map/ConcurrentMap.putIfAbsent/remove/replace: missing a close '}' in the doc
code snippets.
That's a good test. Needs updating to include the bug id in the meta-data.
Paul.
On Oct 18, 2013, at 9:34 PM, Mike Duigou mike.dui...@oracle.com wrote:
On Oct 17 2013, at 07:36 , Paul Sandoz
Hi,
In the spec. document:
http://cr.openjdk.java.net/~abuckley/8misc.pdf
http://cr.openjdk.java.net/%7Eabuckley/8misc.pdf
on page 11, chapter 1.2 the following:
When the new get[Declared]AnnotationsByType(ClassT) methods are
called for a repeatable annotation type T, the question is how
Kumar,
thanks for suggestion, dt.jar seems to be a fine test subject.
Fixed @test field and the .jar used in the test.
New webrev is here: http://cr.openjdk.java.net/~kizune/8020802/webrev.03
/Alex
On 10/22/13 24:33, Kumar Srinivasan wrote:
Alex,
The @test should be just TestNormal not
Hello Lennart,
Sorry for the little belated reply.
The behaviour you see is due to a fix for JDK-7131459 and is the
expected one.
While working on the DecimalFormat optimization which you noticed in the
code, we discovered a long-standing bug in the DigitList.java class
(see bug 7131459
Changeset: d8d5b7919c57
Author:sundar
Date: 2013-10-22 14:27 +0530
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/d8d5b7919c57
8027016: Array.prototype.indexOf should return -1 when array is of length zero
Reviewed-by: lagergren, attila
!
Hi,
Please review to address issues in the serialization source files [1]
- The OffsetTime and OffsetDateTime classes have inconsistent
serialization.
- Order of modifiers
Webrev:
http://cr.openjdk.java.net/~rriggs/webrev-serial-cleanup-8024686/
[1]
On 10/21/2013 2:11 PM, Daniel Fuchs wrote:
Hi,
Please find below a fix for
8026863: regression in anonymous Logger.setParent method
This is a regression I introduced in JDK 8 with one of my recent
logging fixes:
8023168: Cleanup LogManager class initialization
and
Fine by me (not an official reviewer)
Stephen
On 22 October 2013 15:34, roger riggs roger.ri...@oracle.com wrote:
Hi,
Please review to address issues in the serialization source files [1]
- The OffsetTime and OffsetDateTime classes have inconsistent
serialization.
- Order of modifiers
Hi Peter,
On my way to dinner I realized we have a problem for inherited annotations
there are inherited over two (or more) declarations. I believe this is
essentially the issue you highlighted though I will look into this tomorrow.
On 22 okt 2013, at 21:20, Peter Levart peter.lev...@gmail.com
looks good.
On 10/22/13 7:34 AM, roger riggs wrote:
Hi,
Please review to address issues in the serialization source files [1]
- The OffsetTime and OffsetDateTime classes have inconsistent
serialization.
- Order of modifiers
Webrev:
Hi Alex,
thanks for suggestion, dt.jar seems to be a fine test subject.
Fixed @test field and the .jar used in the test.
I am sorry! I misled you yesterday, it should simply be @test
New webrev is here: http://cr.openjdk.java.net/~kizune/8020802/webrev.03
Here are some nits, mostly
Changeset: 6a1989dc302d
Author:igerasim
Date: 2013-10-15 18:41 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/6a1989dc302d
8023390: Test java/net/NetworkInterface/MemLeakTest.java failed with the latest
jdk8 build
Summary: Removing the test as it is unreliable and fails
Kumar,
new version of webrev where i have fixed all the coding style
glitches i've found is here:
http://cr.openjdk.java.net/~kizune/8020802/webrev.04
/Alex
On 10/22/13 19:32, Kumar Srinivasan wrote:
Hi Alex,
thanks for suggestion, dt.jar seems to be a fine test subject.
Fixed @test
Approved.
Kumar
On 10/22/2013 9:08 AM, Alexander Zuev wrote:
Kumar,
new version of webrev where i have fixed all the coding style
glitches i've found is here:
http://cr.openjdk.java.net/~kizune/8020802/webrev.04
/Alex
On 10/22/13 19:32, Kumar Srinivasan wrote:
Hi Alex,
thanks for
Hi,
This is a new implementation property that is consistent with recent
additions as in JAXP 1.5 in that the scope and order are the same, refer
to http://docs.oracle.com/javase/tutorial/jaxp/properties/scope.html. By
default, feature enableExtensionFunctions is true. When
Changeset: 0ecbc0188b64
Author:attila
Date: 2013-10-22 16:43 +0200
URL: http://hg.openjdk.java.net/jdk8/tl/nashorn/rev/0ecbc0188b64
8027031: complete merging of loads and converts
Reviewed-by: jlaskey, lagergren
! src/jdk/nashorn/api/scripting/ScriptObjectMirror.java
!
Hi,
Please review the updated revision at
http://cr.openjdk.java.net/~henryjen/ccc/8025909/1/webrev
- Rewording {Iterable|Map}::forEach from ordering constraint so that
implementation class is allowed to process in parallel ignoring the order.
- fixed typo in Collector as Paul pointed out
Changeset: 9758edb6976f
Author:bpb
Date: 2013-10-22 10:44 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9758edb6976f
8026806: Incomplete test of getaddrinfo() return value could lead to incorrect
exception for Windows Inet 6
Summary: Check getaddrinfo return value before
Changeset: 23b124cbf242
Author:drchase
Date: 2013-10-22 12:57 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/23b124cbf242
8026818: Defmeth failures with -mode invoke
Summary: Added test for IllegalAccessException - IllegalAccessError path to
check if root cause was
Changeset: 72c0f289a8cb
Author:kizune
Date: 2013-10-22 22:18 +0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/72c0f289a8cb
8026873: tools/launcher/VersionCheck.java fails in jprt because of jmc.ini
Reviewed-by: ksrini
! test/tools/launcher/VersionCheck.java
Hello,
Please review some warnings cleanups to
src/share/classes/java/lang/ClassLoader.java
src/share/classes/java/lang/ClassValue.java
src/share/classes/java/lang/SecurityManager.java
Thanks,
-Joe
diff -r 54869853c06c src/share/classes/java/lang/ClassLoader.java
---
Changeset: 2be08cdd1ced
Author:bpb
Date: 2013-10-22 11:25 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/2be08cdd1ced
7179567: JCK8 tests: api/java_net/URLClassLoader/index.html#Ctor3 failed with
NPE
6445180: URLClassLoader does not describe the behavior of several methods
On 10/22/2013 08:20 PM, Joe Darcy wrote:
Hello,
Please review some warnings cleanups to
src/share/classes/java/lang/ClassLoader.java
src/share/classes/java/lang/ClassValue.java
src/share/classes/java/lang/SecurityManager.java
Thanks,
looks good.
-Joe
Rémi
diff -r 54869853c06c
Looks ok to me Joe.
-Chris.
On 10/22/2013 07:20 PM, Joe Darcy wrote:
Hello,
Please review some warnings cleanups to
src/share/classes/java/lang/ClassLoader.java
src/share/classes/java/lang/ClassValue.java
src/share/classes/java/lang/SecurityManager.java
Thanks,
-Joe
diff -r
On 22/10/2013 19:20, Joe Darcy wrote:
Hello,
Please review some warnings cleanups to
src/share/classes/java/lang/ClassLoader.java
src/share/classes/java/lang/ClassValue.java
src/share/classes/java/lang/SecurityManager.java
Thanks,
-Joe
Looks okay.
-Alan
Please review more javadoc cleanup to satisfy javadoc -Xlint.
The changes remove p markup where it is invalid or unnecessary
in packages java. io, lang, net, nio, rmi, security, text, and util.
(this is a relatively low priority cleanup).
Webrev:
On 18/10/2013 17:00, Ivan Gerasimov wrote:
Thank you Martin for the references.
I've implemented passing the limitation to the application in a
similar manner.
The timeout value is passed to the test through the CloseRaceTimeout
system property.
If the property wasn't set, the default value
Changeset: 9a32af82bd1e
Author:darcy
Date: 2013-10-22 12:04 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9a32af82bd1e
8027062: Fix lint and doclint issues in java.lang.{ClassLoader, ClassValue,
SecurityManager}
Reviewed-by: chegar, forax, alanb, mduigou
!
Overall, I think is this good.
I think in MessageDigest
--- old/src/share/classes/java/security/MessageDigest.java 2013-10-21
17:31:32.734881244 -0400
+++ new/src/share/classes/java/security/MessageDigest.java 2013-10-21
17:31:32.558891607 -0400
@@ -54,21 +54,21 @@
*
*
The text you quoted (When the new...) is a high-level explanation - a
policy - of how Core Reflection should work. The text then proceeds to
give definitions suitable for the API spec: This policy for Java SE 8
is reified in the following definitions:
Alex
On 10/22/2013 7:06 AM, Peter
Wow, that's a lot of nits!
Reviewed via patch:
- blockquotepre{@code is redundant. You could remove the blockquote
- This change should be reverted I think:
- * bra name=ResourceBundleMapping/When mapping resource bundle names to
+ * br id=ResourceBundleMappingWhen mapping resource bundle
Hi Lance,
ok, I will add {@code}... since that's the current style. (Not used
everywhere yet).
Roger
On 10/22/2013 3:11 PM, Lance Andersen - Oracle wrote:
Overall, I think is this good.
I think in MessageDigest
--- old/src/share/classes/java/security/MessageDigest.java 2013-10-21
Happy to vounteer for sponsorship duties. Been following this from the
sidelines.
-Rob
On 22/10/13 20:01, Alan Bateman wrote:
On 18/10/2013 17:00, Ivan Gerasimov wrote:
Thank you Martin for the references.
I've implemented passing the limitation to the application in a
similar manner.
Hi, Rob.
jtreg supports identification of manual tests with the /manual option on
various actions (see [1] and [2]). I don't know how frequently this option is
used within the JDK regression test suite.
Thanks,
iris
[1]: http://openjdk.java.net/jtreg/runtests.html
[2]:
Hi Mike,
On 10/22/2013 3:13 PM, Mike Duigou wrote:
Wow, that's a lot of nits!
Reviewed via patch:
- blockquotepre{@code is redundant. You could remove the blockquote
will do.
- This change should be reverted I think:
- * bra name=ResourceBundleMapping/When mapping resource bundle names to
Changeset: c956a5d0618f
Author:juh
Date: 2013-10-22 11:57 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/c956a5d0618f
8025287: NPE in
api/java_security/cert/PKIXRevocationChecker/GeneralTests_GeneralTests
Reviewed-by: mullan
!
Changeset: e2b814e68956
Author:rriggs
Date: 2013-10-22 15:03 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e2b814e68956
8024686: Cleanup of java.time serialization source
Summary: optimize serialized form of OffsetTime, OffsetDateTime; correct order
of modifiers
This corba fix was fixed many moons ago in JDK5. Bad records meant it
didn't get forward ported to JDK6 and later families. We need to fix
that now. I'm looking to push this to jdk8-tl and backport to jdk7u-dev
shortly afterwards.
bug ID : https://bugs.openjdk.java.net/browse/JDK-5036554
On 10/22/13 5:18 AM, Alan Bateman wrote:
On 22/10/2013 03:07, Stuart Marks wrote:
Hi all,
Please review this small spec change to deprecate some obsolete RMI APIs,
along with a bit of associated cleanup. There are no functional changes in
this changeset.
Bug:
On 22/10/2013 17:08, Alexander Zuev wrote:
Kumar,
new version of webrev where i have fixed all the coding style
glitches i've found is here:
http://cr.openjdk.java.net/~kizune/8020802/webrev.04
I looked at the latest webrev and it looks much cleaner than the
original patch (thanks).
One
Hi Daniel,
Yes, this round is just deprecation, not removal, so anything that uses
RMISecurityManager can continue to do so for the near future.
Ideally we should remove all references to RMISecurityManager from the JDK, but
this can be done later. The only cost is some deprecation warnings.
Thanks for the comments, updated with Webrev with the suggestions.
http://cr.openjdk.java.net/~rriggs/webrev-javadoc-8026982/
Roger
On 10/22/2013 2:53 PM, roger riggs wrote:
Please review more javadoc cleanup to satisfy javadoc -Xlint.
The changes remove p markup where it is invalid or
The changes in the security area look fine to me.
--Sean
On 10/22/2013 04:31 PM, roger riggs wrote:
Thanks for the comments, updated with Webrev with the suggestions.
http://cr.openjdk.java.net/~rriggs/webrev-javadoc-8026982/
Roger
On 10/22/2013 2:53 PM, roger riggs wrote:
Please
Looks good.
The id=xxx form is equivalent way to tag a paragraph with a target link.
TIL that it's time to stop using a name=... :-) (Since HTML 4.01)
Mike
On Oct 22 2013, at 13:31 , roger riggs roger.ri...@oracle.com wrote:
Thanks for the comments, updated with Webrev with the
The pprecode./code/prep
is updated to pre{@code ...}/pre that should simply be:
{@code ...}
I notice that there are few ending p not removed in this
updated patch. One example:
- * pprecode
- * (byte)(0xff amp; (v gt;gt; 8))
- * (byte)(0xff amp; v)
- * /code/prep
+ *
Hi Mandy,
On 10/22/2013 5:01 PM, Mandy Chung wrote:
The pprecode./code/prep
is updated to pre{@code ...}/pre that should simply be:
{@code ...}
the {@code ...} does not imply preformatted. So for a multi-line or
separate line example the pre is still needed.
I notice that there
On 10/22/13 2:06 PM, roger riggs wrote:
Hi Mandy,
On 10/22/2013 5:01 PM, Mandy Chung wrote:
The pprecode./code/prep
is updated to pre{@code ...}/pre that should simply be:
{@code ...}
the {@code ...} does not imply preformatted. So for a multi-line or
separate line example the pre
Changeset: e84413f066e0
Author:mfang
Date: 2013-10-22 14:26 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/e84413f066e0
8026109: [ja] overtranslation of jarsigner in command line output
Reviewed-by: naoto
! src/share/classes/sun/security/tools/jarsigner/Resources_ja.java
Changeset: 4bb758a77fd7
Author:rriggs
Date: 2013-10-22 17:02 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/4bb758a77fd7
8026982: javadoc errors in core libs
Summary: Cleanup of javadoc -Xlint errors
Reviewed-by: lancea, mduigou, darcy, mullan, mchung
!
Thanks, will fix them for the commit.
Cheers,
Henry
On Oct 22, 2013, at 1:45 PM, Mike Duigou mike.dui...@oracle.com wrote:
Looks fine. Two non-blocking nits:
LambdaMetaFactory:
(-0) : period at the end of @param
(-0) : FLAG_SERIALIZABLE should be in {@code}
On Oct 22 2013, at
Changeset: 9fbf35589211
Author:smarks
Date: 2013-10-22 14:51 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/9fbf35589211
8026427: deprecate obsolete APIs from java.rmi
Reviewed-by: alanb, dfuchs
! src/share/classes/java/rmi/RMISecurityManager.java
!
Changeset: 0913c3bab168
Author:henryjen
Date: 2013-10-22 15:12 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/0913c3bab168
8025909: Lambda Library Spec Updates
8024179: Document limitations and performance characteristics of stream sources
and operations
8024138: (Spec
Alan,
i guess you're right, i have updated code to use the same method with
fallback for creation .pack temporary file.
New webrev can be found at
http://cr.openjdk.java.net/~kizune/8020802/webrev.05
/Alex
On 10/22/13 23:55, Alan Bateman wrote:
On 22/10/2013 17:08, Alexander Zuev wrote:
Changeset: fc7a6fa3589a
Author:ascarpino
Date: 2013-10-22 19:37 -0400
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/fc7a6fa3589a
8025763: Provider does not override new Hashtable methods
Reviewed-by: mullan
! src/share/classes/java/security/Provider.java
Changeset: b065de1700d3
Changeset: 6cd16d8ed2b9
Author:rfield
Date: 2013-10-22 16:53 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/6cd16d8ed2b9
8023668: Desugar serializable lambda bodies using more robust naming scheme
Summary: lambda / bridged method-reference naming overhaul
Reviewed-by:
Changeset: d545d67e2f68
Author:weijun
Date: 2013-10-23 08:32 +0800
URL: http://hg.openjdk.java.net/jdk8/tl/jdk/rev/d545d67e2f68
8027026: Change keytool -genkeypair to use -keyalg RSA
Reviewed-by: alanb, chegar, mullan
! test/ProblemList.txt
!
Changeset: 351d6808c1a5
Author:jjg
Date: 2013-10-22 17:42 -0700
URL: http://hg.openjdk.java.net/jdk8/tl/langtools/rev/351d6808c1a5
8027119: Cleanup javadoc comments for taglet API
Reviewed-by: mduigou
! src/share/classes/com/sun/javadoc/Tag.java
Changeset: 41d3ffca22ff
Author:
Hi Mike,
On 19/10/2013 5:34 AM, Mike Duigou wrote:
Updated webrev:
http://cr.openjdk.java.net/~mduigou/JDK-8024688/3/webrev/
I see there is a version 4 now :)
ConcurrentMap:
In replaceAll:
261 * pThis implementation assumes that the ConcurrentMap
cannot contain null ...
is this
Thank you for the feedback. Responses inline.
On Oct 22 2013, at 18:45 , David Holmes david.hol...@oracle.com wrote:
Hi Mike,
On 19/10/2013 5:34 AM, Mike Duigou wrote:
Updated webrev:
http://cr.openjdk.java.net/~mduigou/JDK-8024688/3/webrev/
I see there is a version 4 now :)
Yep, I
Hi Michael,
27 *@summary Test case for tzdata2005m support for 9 locales
What's the purpose of this test? Do we really need to keep this one?
Thanks,
Masayoshi
On 10/22/2013 8:13 PM, Aleksej Efimov wrote:
Hi,
Can I have a review for 8026772 [1] fix.
The webrev link: [2]
The timezone test
Seems like a sensible fix.
(Note: your webrev appears to be on an internal server, not visible to the
public, but nothing there is confidential to my eye.)
It's unfortunate that the test involves creating another shell script test, but
the alternative is probably a lot of work to develop a
85 matches
Mail list logo
