[PATCH] improve is_text_file() to not treat valid Unicode as bad_chars

2013-03-25 Thread Denys Vlasenko
In valid Unicode, first non-ASCII byte is always 11xx and the following bytes are always 10xx. Random binary data is likely to violate this rule *a lot*. This patch makes bad_chars++ decision only if it sees a non-ASCII byte which violates the rule described above. Also, it makes

[PATCH 1/2] reporter-rhtsupport: upload file to BigFileURL if it is large

2013-03-25 Thread Denys Vlasenko
This patch adds BigFileURL and BigSizeMB parameters. If uploaded DIR is bigger than BigSizeMB, then it is not attached to the case, but uploaded to BigFileURL, then a comment is added to the case with the URL of uploaded file. Version 2: run-tested against actual server. Signed-off-by: Denys

[PATCH 2/2] reporter-rhtsupport: improve logging

2013-03-25 Thread Denys Vlasenko
While testing previous patch, I got error messages which were not very helpful. Lets add URL to them. Signed-off-by: Denys Vlasenko dvlas...@redhat.com --- src/plugins/abrt_rh_support.c | 53 ++- 1 file changed, 32 insertions(+), 21 deletions(-) diff

Re: [PATCH] improve is_text_file() to not treat valid Unicode as bad_chars

2013-03-25 Thread Jakub Filak
Works fine. Pushed. Thank you. Note: I didn't try it but I think the following content will be wrongly considered as text but it is better than considering a text file as a binary file: 0x110x 0x10xx 0x10xx 0x10xx 0x10xx 0x10xx - bad chars == 0 but invalid UTF-8 or:

Re: [PATCH] Remove all smolt-related files and code bits

2013-03-25 Thread Jakub Filak
We have to use a separate commit for changes spec file [1]. Please, split this patch. 1: http://abrt.etherpad.corp.redhat.com/develguide On Monday, March 25, 2013 12:41:46 PM Denys Vlasenko wrote: Smolts.org is being retired by Fedora Infrastructure. Signed-off-by: Denys Vlasenko

[ABRT PATCH 1/2] Remove smolt-related parts of specfile

2013-03-25 Thread Denys Vlasenko
Smolts.org is being retired by Fedora Infrastructure. Signed-off-by: Denys Vlasenko dvlas...@redhat.com --- abrt.spec.in | 2 -- 1 file changed, 2 deletions(-) diff --git a/abrt.spec.in b/abrt.spec.in index 359b15c..dc408fa 100644 --- a/abrt.spec.in +++ b/abrt.spec.in @@ -501,7 +501,6 @@

[ABRT PATCH 2/2] spec: remove the abrt-gui related: #629

2013-03-25 Thread Jiri Moskovcak
--- abrt.spec.in | 1 - 1 file changed, 1 deletion(-) diff --git a/abrt.spec.in b/abrt.spec.in index 359b15c..ac85c7f 100644 --- a/abrt.spec.in +++ b/abrt.spec.in @@ -536,7 +536,6 @@ gtk-update-icon-cache %{_datadir}/icons/hicolor /dev/null || : %files gui %defattr(-,root,root,-)

[ABRT PATCH 1/2] remove the abrt-gui closes #629

2013-03-25 Thread Jiri Moskovcak
Signed-off-by: Jiri Moskovcak jmosk...@redhat.com --- configure.ac|1 - po/POTFILES.in |1 - src/Makefile.am |2 +- src/gui-gtk/Makefile.am | 38 -- src/gui-gtk/main.c | 1422 --- 5 files changed, 1

Re: [LIBREPORT PATCH] Add test for is_text_file

2013-03-25 Thread Jakub Filak
Pushed. Thanks On Monday, March 25, 2013 01:40:18 PM Denys Vlasenko wrote: Signed-off-by: Denys Vlasenko dvlas...@redhat.com --- tests/Makefile.am | 1 + tests/is_text_file.at | 49 + tests/testsuite.at| 1 + 3 files changed, 51

Re: [ABRT PATCH 2/2] Remove all smolt-related files and code bits

2013-03-25 Thread Jakub Filak
Pushed both. Thanks On Monday, March 25, 2013 01:34:18 PM Denys Vlasenko wrote: Smolts.org is being retired by Fedora Infrastructure. Signed-off-by: Denys Vlasenko dvlas...@redhat.com --- doc/project/abrt.tex | 1 - po/POTFILES.in

[GNOME-ABRT PATCH 3/6] Recover from DBus errors while sending command line

2013-03-25 Thread Jakub Filak
- closes rhbz#926011 Signed-off-by: Jakub Filak jfi...@redhat.com --- src/gnome-abrt | 22 ++ test/fake_app_dbus_service | 46 ++ 2 files changed, 60 insertions(+), 8 deletions(-) create mode 100755

[GNOME-ABRT PATCH 4/6] Remove left-over RELEASE varible from configure.ac

2013-03-25 Thread Jakub Filak
Signed-off-by: Jakub Filak jfi...@redhat.com --- configure.ac | 2 -- 1 file changed, 2 deletions(-) diff --git a/configure.ac b/configure.ac index 03cfdf5..d3fd063 100644 --- a/configure.ac +++ b/configure.ac @@ -71,11 +71,9 @@ dnl ** END

[GNOME-ABRT PATCH 5/6] Replace GNU style make pattern rules by implicit rules

2013-03-25 Thread Jakub Filak
Signed-off-by: Jakub Filak jfi...@redhat.com --- doc/Makefile.am | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/doc/Makefile.am b/doc/Makefile.am index ba4e667..39e82a5 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -5,10 +5,12 @@ MAN6_TXT = gnome-abrt.txt #

[GNOME-ABRT PATCH 6/6] Use IOChannel approach in order to make signal handling synchronous

2013-03-25 Thread Jakub Filak
- closes #17 Signed-off-by: Jakub Filak jfi...@redhat.com --- src/gnome-abrt | 4 ++- src/gnome_abrt/Makefile.am | 1 + src/gnome_abrt/controller.py.in | 19 +++- src/gnome_abrt/signals.py | 66 + 4 files changed, 74

Re: [GNOME-ABRT PATCH 6/6] Use IOChannel approach in order to make signal handling synchronous

2013-03-25 Thread Michal Toman
1-5 OK, pushed. On 25.03.2013 16:26, Jakub Filak wrote: +def handle_signal(signum, frame): +while True: +try: +os.wait3(os.WNOHANG) +except OSError as ex: +logging.debug(ex.message) +break It is not obvious

[GNOME-ABRT PATCH 1/2] Use IOChannel approach in order to make signal handling synchronous

2013-03-25 Thread Jakub Filak
- closes #17 Signed-off-by: Jakub Filak jfi...@redhat.com --- src/gnome-abrt | 4 ++- src/gnome_abrt/Makefile.am | 1 + src/gnome_abrt/controller.py.in | 19 +++ src/gnome_abrt/signals.py | 71 + 4 files changed, 79

[GNOME-ABRT PATCH 2/2] Add all python Requires to BuildRequires because of pylint

2013-03-25 Thread Jakub Filak
Signed-off-by: Jakub Filak jfi...@redhat.com --- gnome-abrt.spec.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gnome-abrt.spec.in b/gnome-abrt.spec.in index 7d6d4da..2c8e94a 100644 --- a/gnome-abrt.spec.in +++ b/gnome-abrt.spec.in @@ -25,6 +25,9 @@ BuildRequires: pygobject3-devel

Re: [GNOME-ABRT PATCH 2/2] Add all python Requires to BuildRequires because of pylint

2013-03-25 Thread Jakub Filak
This one is already pushed. It was a trivial change required for test build. On Monday, March 25, 2013 05:20:18 PM Jakub Filak wrote: Signed-off-by: Jakub Filak jfi...@redhat.com --- gnome-abrt.spec.in | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gnome-abrt.spec.in

Re: [ABRT PATCH] Integration with satyr

2013-03-25 Thread Jakub Filak
Thank you. The patch looks good to me. Please, split it to tow separate patches. The first for the spec file and the second for the rest. Then I will test it and push it. On Thursday, March 07, 2013 04:47:06 PM Martin Milata wrote: diff --git a/abrt.spec.in b/abrt.spec.in index

[SATYR PATCH] python: duplicate code refactorization, part 1

2013-03-25 Thread Martin Milata
Hi, this is an attempt to get rid of duplicate code in satyr python bindings. I tried to reuse the code for a function that is currently repeated several times. This is accomplished by treating all pointers that can have different types as void* and accessing structure members through pointer